Regression in 6.8 from "ACPI: OSL: Use a threaded interrupt handler for SCI"
Hi all,
any kernels after 6.7 break my trusty old Toughbook CF-51 by rendering many PCI devices unusable.
I did first notice that i915 did no longer work and filed
https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11437, there I was pointed to commit
commit 7a36b901a6eb0e9945341db71ed3c45c7721cfa9
Author: Rafael J. Wysocki <[email protected]> Date: Mon Nov 27 20:57:43 2023 +0100
ACPI: OSL: Use a threaded interrupt handler for SCI
which I verified with a week-long bisecting from 6.7 to 6.8 (just for fun :-)
Just reverting this commit top of 6.10-rc5 (sorry, this machine is not very powerful so I did not try the latest git master) makes everything work fine again.
I get these messages in dmesg when running the broken kernels:
[ T308] genirq: Flags mismatch irq 9. 00000080 (yenta) vs. 00002080 (acpi) [ T305] genirq: Flags mismatch irq 9. 00000080 (uhci_hcd:usb1) vs. 00002080 (acpi) [ T305] genirq: Flags mismatch irq 9. 00000080 (uhci_hcd:usb1) vs. 00002080 (acpi) [ T46] genirq: Flags mismatch irq 9. 00000080 (ehci_hcd:usb1) vs. 00002080 (acpi) [ T312] genirq: Flags mismatch irq 9. 00000080 (firewire_ohci) vs. 00002080 (acpi) [ T305] genirq: Flags mismatch irq 9. 00000080 (uhci_hcd:usb1) vs. 00002080 (acpi) [ T308] genirq: Flags mismatch irq 9. 00000080 (yenta) vs. 00002080 (acpi) [ T592] genirq: Flags mismatch irq 9. 00000080 (snd_intel8x0) vs. 00002080 (acpi) [ T581] genirq: Flags mismatch irq 9. 00000080 (i915) vs. 00002080 (acpi) [ T874] genirq: Flags mismatch irq 9. 00000080 (enp2s1) vs. 00002080 (acpi)
These are not present with that commit reverted.
The machine has an old Pentium M (Dothan):
toughbook:~ # cat /proc/cpuinfo
processor : 0vendor_id : GenuineIntel
cpu family : 6
model : 13
model name : Intel(R) Pentium(R) M processor 1.60GHz
stepping : 6
microcode : 0x18
cpu MHz : 1600.000
cache size : 2048 KBfdiv_bug : nof00f_bug : nocoma_bug : no
fpu : yesfpu_exception : yes
cpuid level : 2
wp : yes
flags : fpu vme de pse tsc msr mce cx8 sep mtrr pge mca cmov clflush dts acpi mmx fxsr sse sse2 ss tm pbe bts cpuid est tm2
bugs : cpu_meltdown spectre_v1 spectre_v2 spec_store_bypass l1tf mds swapgs itlb_multihit mmio_unknown
bogomips : 3193.05
clflush size : 32cache_alignment : 32
address sizes : 36 bits physical, 32 bits virtual
power management:
and is running an i686 pae kernel:
toughbook:~ # uname -a
Linux toughbook 6.10.0-rc5-pae-seife+ #17 PREEMPT_DYNAMIC Sat Jul 6 07:36:41 CEST 2024 i686 i686 i386 GNU/Linux
I can provide more information on request
Best regards
Signature · 4 lines
Stefan Seyfried "For a successful technology, reality must take precedence over public relations, for nature cannot be fooled." -- Richard Feynman
Hi,
Quoted 7 lines · Stefan Seyfried
Hi all,
any kernels after 6.7 break my trusty old Toughbook CF-51 by rendering many PCI devices unusable.
I did first notice that i915 did no longer work and filed
https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11437, there I was pointed to commit
Quoted 8 lines
commit
7a36b901a6eb0e9945341db71ed3c45c7721cfa9
Author: Rafael J. Wysocki <[email protected]> Date: Mon Nov 27 20:57:43 2023 +0100ACPI: OSL: Use a threaded interrupt handler for SCI
which I verified with a week-long bisecting from 6.7 to 6.8 (just for fun :-)
Thanks for reporting this, although it would be nice to put linux-acpi on the CC.
Quoted 15 lines
Just reverting this commit top of 6.10-rc5 (sorry, this machine is not very powerful so I did not try the latest git master) makes everything work fine again.
I get these messages in dmesg when running the broken kernels:
[ T308] genirq: Flags mismatch irq 9. 00000080 (yenta) vs. 00002080 (acpi) [ T305] genirq: Flags mismatch irq 9. 00000080 (uhci_hcd:usb1) vs. 00002080 (acpi) [ T305] genirq: Flags mismatch irq 9. 00000080 (uhci_hcd:usb1) vs. 00002080 (acpi) [ T46] genirq: Flags mismatch irq 9. 00000080 (ehci_hcd:usb1) vs. 00002080 (acpi) [ T312] genirq: Flags mismatch irq 9. 00000080 (
firewire_ohci) vs. 00002080 (acpi) [ T305] genirq: Flags mismatch irq 9. 00000080 (uhci_hcd:usb1) vs. 00002080 (acpi) [ T308] genirq: Flags mismatch irq 9. 00000080 (yenta) vs. 00002080 (acpi) [ T592] genirq: Flags mismatch irq 9. 00000080 (snd_intel8x0) vs. 00002080 (acpi) [ T581] genirq: Flags mismatch irq 9. 00000080 (i915) vs. 00002080 (acpi) [ T874] genirq: Flags mismatch irq 9. 00000080 (enp2s1) vs. 00002080 (acpi)
Quoted 2 lines
These are not present with that commit reverted.
So all of the drivers above attempt to share the IRQ with the SCI and they don't use IRQF_ONESHOT and because they all are threaded, there is a flags conflict.
They all need to be made pass IRQF_COND_ONESHOT when requesting interrupts and it will all work again.
I'll send you a patch for this (hopefully later today), but I guess it will take a while until it gets absorbed.
Thanks!
Rafael J. Wysocki
maintainerQuoted 59 lines · Rafael J
Hi,
Quoted 9 lines · Stefan Seyfried
Hi all,
any kernels after 6.7 break my trusty old Toughbook CF-51 by rendering many PCI devices unusable.
I did first notice that i915 did no longer work and filed
https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11437, there I was pointed to commitQuoted 9 lines
commit
7a36b901a6eb0e9945341db71ed3c45c7721cfa9Author: Rafael J. Wysocki <[email protected]> Date: Mon Nov 27 20:57:43 2023 +0100ACPI: OSL: Use a threaded interrupt handler for SCI
which I verified with a week-long bisecting from 6.7 to 6.8 (just for fun :-)
Thanks for reporting this, although it would be nice to put linux-acpi on the CC.
Quoted 27 lines
Just reverting this commit top of 6.10-rc5 (sorry, this machine is not very powerful so I did not try the latest git master) makes everything work fine again.
I get these messages in dmesg when running the broken kernels:
[ T308] genirq: Flags mismatch irq 9. 00000080 (yenta) vs. 00002080 (acpi)
[ T305] genirq: Flags mismatch irq 9. 00000080 (uhci_hcd:usb1) vs. 00002080 (acpi)
[ T305] genirq: Flags mismatch irq 9. 00000080 (uhci_hcd:usb1) vs. 00002080 (acpi)
[ T46] genirq: Flags mismatch irq 9. 00000080 (ehci_hcd:usb1) vs.
00002080 (acpi)
[ T312] genirq: Flags mismatch irq 9. 00000080 (firewire_ohci) vs. 00002080 (acpi)
[ T305] genirq: Flags mismatch irq 9. 00000080 (uhci_hcd:usb1) vs. 00002080 (acpi)
[ T308] genirq: Flags mismatch irq 9. 00000080 (yenta) vs. 00002080 (acpi)
[ T592] genirq: Flags mismatch irq 9. 00000080 (snd_intel8x0) vs. 00002080 (acpi)
[ T581] genirq: Flags mismatch irq 9. 00000080 (i915) vs. 00002080 (acpi)
[ T874] genirq: Flags mismatch irq 9. 00000080 (enp2s1) vs. 00002080 (acpi)Quoted 2 lines
These are not present with that commit reverted.
So all of the drivers above attempt to share the IRQ with the SCI and they don't use
IRQF_ONESHOTand because they all are threaded, there is a flags conflict.
Quoted 7 lines
They all need to be made pass
IRQF_COND_ONESHOTwhen requesting interrupts and it will all work again.I'll send you a patch for this (hopefully later today), but I guess it will take a while until it gets absorbed.
Thanks!
So can you please check if the attached patch helps?
--- include/linux/interrupt.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
include/linux/interrupt.h +2 -1
@@ -168,7 +168,8 @@ static inline int __must_check request_irq(unsigned int irq, irq_handler_t handler, unsigned long flags, const char *name, void *dev) { - return request_threaded_irq(irq, handler, NULL, flags, name, dev); + return request_threaded_irq(irq, handler, NULL, + flags | IRQF_COND_ONESHOT, name, dev); } extern int __must_check
Hi Rafael,
Am 10.07.24 um 15:13 schrieb Rafael J. Wysocki:
Quoted 5 lines
Quoted 1 line · Rafael J
So can you please check if the attached patch helps?
Yes, everything works perfectly fine with that applied.
Thanks and best regards,
Stefan
Signature · 4 lines
Stefan Seyfried "For a successful technology, reality must take precedence over public relations, for nature cannot be fooled." -- Richard Feynman
Rafael J. Wysocki
maintainerHi Stefan,
Quoted 8 lines · Stefan Seyfried
Hi Rafael,
Am 10.07.24 um 15:13 schrieb Rafael J. Wysocki:
Quoted 4 lines
Quoted 1 line · Rafael J
Quoted 6 lines
Quoted 1 line
So can you please check if the attached patch helps?
Yes, everything works perfectly fine with that applied.
Thanks and best regards,
Thanks for testing!
Patch submitted, let's see what Thomas has to say about it.
Cheers, Rafael