Skip to contentSkip to conversation

drivers/net: ks8842 Fix crash on received packet when in PIO mode.

PATCH In review Dennis Aberilla 2 participants 3 messages May 18, 2011 Network drivers

lore
Share & tools
lore

Dennis Aberilla

author
#0 lore raw

PATCH 1/1 drivers/net: ks8842 Fix crash on received packet when in PIO mode.

This patch fixes a kernel crash during packet reception due to not enough allocated bytes for the skb. This applies to the driver when running in PIO mode in an ISA bus setup.

Signed-off-by Dennis Aberilla <[email protected]>

---

drivers/net/ks8842.c +1 -1
index f0d8346..9069aee 100644
@@ -662,7 +662,7 @@ static void ks8842_rx_frame(struct net_device *netdev,
 
   /* check the status */
   if ((status & RXSR_VALID) && !(status & RXSR_ERROR)) {
-     struct sk_buff *skb = netdev_alloc_skb_ip_align(netdev, len);
+     struct sk_buff *skb = netdev_alloc_skb_ip_align(netdev, len + 2);
 
      if (skb) {

--

|Dennis

maintainer
#1 lore raw

From: Dennis Aberilla <[email protected]>
Date: Wed, 18 May 2011 14:51:14 -0700 (PDT)

drivers/net/ks8842.c static void ks8842_rx_frame(struct net_device *netdev, · line 665

Quoted 10 lines
drivers/net/ks8842.c +1 -1
index f0d8346..9069aee 100644
@@ -662,7 +662,7 @@ static void ks8842_rx_frame(struct net_device *netdev,
 
   /* check the status */
   if ((status & RXSR_VALID) && !(status & RXSR_ERROR)) {
-     struct sk_buff *skb = netdev_alloc_skb_ip_align(netdev, len);
+     struct sk_buff *skb = netdev_alloc_skb_ip_align(netdev, len + 2);

Your patch has been corrupted by your email client, it has turned TAB characters into spaces, amongst other things. This makes your patch unusable.

Please read Documentation/email-clients.txt, and use that information to fix your email client, and then send the patch as a test email to yourself and make sure that you can extract the patch and apply it cleanly before you resend it here.

Thanks.