Skip to contentSkip to conversation

ARM: EXYNOS: exynos4-dt: Set .smp field of machine descriptor

PATCH New Tomasz Figa 4 participants 5 messages Oct 12, 2012 – Oct 22, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: EXYNOS: exynos4-dt: Set .smp field of machine descriptor

This patch adds missing initializer of .smp field of machine descriptor of Exynos 4 DT machine.

---
 arch/arm/mach-exynos/mach-exynos4-dt.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-exynos/mach-exynos4-dt.c +1 -0
index 7222e3c..d6bdcfb 100644
@@ -119,6 +119,7 @@ static char const *exynos4_dt_compat[] __initdata = {
 
 DT_MACHINE_START(EXYNOS4210_DT, "Samsung Exynos4 (Flattened Device Tree)")
 	/* Maintainer: Thomas Abraham <[email protected]> */
+	.smp		= smp_ops(exynos_smp_ops),
 	.init_irq	= exynos4_init_irq,
 	.map_io		= exynos4_dt_map_io,
 	.handle_irq	= gic_handle_irq,
Signature · 1 line
1.7.12
#1 lore raw

PATCH 1/1 ARM: EXYNOS: exynos4-dt: Set .smp field of machine descriptor

Quoted 17 lines · On Friday 12 of October 2012 11:49:38 Tomasz Figa wrote:

This patch adds missing initializer of .smp field of machine descriptor of Exynos 4 DT machine.

---
 arch/arm/mach-exynos/mach-exynos4-dt.c | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/arch/arm/mach-exynos/mach-exynos4-dt.c index 7222e3c..d6bdcfb 100644

arch/arm/mach-exynos/mach-exynos4-dt.c +0 -0
@@ -119,6 +119,7 @@ static char const *exynos4_dt_compat[] __initdata =
 {
 
 DT_MACHINE_START(EXYNOS4210_DT, "Samsung Exynos4 (Flattened Device

Tree)") /* Maintainer: Thomas Abraham <[email protected]> */

arch/arm/mach-exynos/mach-exynos4-dt.c static char const *exynos4_dt_compat[] __initdata = { · line 125

Quoted 4 lines
arch/arm/mach-exynos/mach-exynos4-dt.c +1 -0
+	.smp		= smp_ops(exynos_smp_ops),
 	.init_irq	= exynos4_init_irq,
 	.map_io		= exynos4_dt_map_io,
 	.handle_irq	= gic_handle_irq,

Ping. I think this should be considered a fix.

Best regards,
Tomasz Figa

#2 lore raw

PATCH 1/1 ARM: EXYNOS: exynos4-dt: Set .smp field of machine descriptor

+ Arnd, Olof,

Tomasz,
I think it's better to add arm-soc maintainers at CC when send the patches. Samsung patches doesn't handled or merged with proper time.

Thank you,
Kyungmin Park

Quoted 34 lines · Tomasz Figa
Quoted 17 lines · On Friday 12 of October 2012 11:49:38 Tomasz Figa wrote:

This patch adds missing initializer of .smp field of machine descriptor of Exynos 4 DT machine.

---
 arch/arm/mach-exynos/mach-exynos4-dt.c | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/arch/arm/mach-exynos/mach-exynos4-dt.c index 7222e3c..d6bdcfb 100644

arch/arm/mach-exynos/mach-exynos4-dt.c +0 -0
@@ -119,6 +119,7 @@ static char const *exynos4_dt_compat[] __initdata =
 {
 
 DT_MACHINE_START(EXYNOS4210_DT, "Samsung Exynos4 (Flattened Device

Tree)") /* Maintainer: Thomas Abraham <[email protected]> */

arch/arm/mach-exynos/mach-exynos4-dt.c static char const *exynos4_dt_compat[] __initdata = { · line 125

Quoted 4 lines
arch/arm/mach-exynos/mach-exynos4-dt.c +1 -0
+	.smp		= smp_ops(exynos_smp_ops),
 	.init_irq	= exynos4_init_irq,
 	.map_io		= exynos4_dt_map_io,
 	.handle_irq	= gic_handle_irq,

Ping. I think this should be considered a fix.

Best regards,
Tomasz Figa

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw

PATCH 1/1 ARM: EXYNOS: exynos4-dt: Set .smp field of machine descriptor

Quoted 5 lines · Kyungmin Park

+ Arnd, Olof,

Tomasz,
I think it's better to add arm-soc maintainers at CC when send the

patches.

Quoted 2 lines

Samsung patches doesn't handled or merged with proper time.

I did just now. Sorry for late.

[...]

Quoted 2 lines
Quoted 2 lines

Ping. I think this should be considered a fix.

Tomasz, yes I applied this in my -fix. Note this will be sent to upstream with other Samsung fixes during 3.7-rc, probably in a couple of days.

Thanks for your reminder.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

#4 lore raw

PATCH 1/1 ARM: EXYNOS: exynos4-dt: Set .smp field of machine descriptor

In reply to Tomasz Figa
Quoted 15 lines · Tomasz Figa

This patch adds missing initializer of .smp field of machine descriptor of Exynos 4 DT machine.

---
 arch/arm/mach-exynos/mach-exynos4-dt.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach- renamed from arch/arm/mach-exynos/mach-exynos4-dt.c +0 -0

exynos/mach-exynos4-dt.c
index 7222e3c..d6bdcfb 100644

arch/arm/mach-exynos/mach-exynos4-dt.c static char const *exynos4_dt_compat[] __initdata = { · line 120

Quoted 2 lines
arch/arm/mach-exynos/mach-exynos4-dt.c +0 -0
@@ -119,6 +119,7 @@ static char const *exynos4_dt_compat[] __initdata = {
 
 DT_MACHINE_START(EXYNOS4210_DT, "Samsung Exynos4 (Flattened Device

Tree)")

Quoted 7 lines
arch/arm/mach-exynos/mach-exynos4-dt.c +1 -1
 	/* Maintainer: Thomas Abraham <[email protected]> */
+	.smp		= smp_ops(exynos_smp_ops),
 	.init_irq	= exynos4_init_irq,
 	.map_io		= exynos4_dt_map_io,
 	.handle_irq	= gic_handle_irq,
--

1.7.12

Yes, right. Applied.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.