package/opengl: ensure consistency between the various providers
PATCH 1/1 package/opengl: ensure consistency between the various providers
Some GL providers will provide libegl and libgles, but not libgl, while other will provide libgl but not libegl not libgles. This can be the case with:
- mesa3d -> libgl
- rpi-userland -> libegl and libgles
Since we can not protect against this situation in the Config.in files (especially because providers may be out-of-tree), we can only check for the validity after the fact.
Fixes:
http://autobuild.buildroot.org/results/6f1/6f197c643972e92f0b27b3afac7da7b4b1115f7e/ http://autobuild.buildroot.org/results/6c6/6c6e0a236bde7b892a69119a49422119f3efaa97/ http://autobuild.buildroot.org/results/5a2/5a2a1503b7d19c0ca5b0e9093aa24ed9c020e812/ ...
--- package/opengl/opengl.mk | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
package/opengl/opengl.mk +29 -0
@@ -1 +1,30 @@ include $(sort $(wildcard package/opengl/*/*.mk)) + +# Ensure consistency betwenn the various GL providers: + +# If we have a libgl provider, then the libegl provider must be the same +ifeq ($(BR2_PACKAGE_HAS_LIBGL)$(BR2_PACKAGE_HAS_LIBEGL),yy) +# No need to qstrip, both are quoted +ifneq ($(BR2_PACKAGE_PROVIDES_LIBGL),$(BR2_PACKAGE_PROVIDES_LIBEGL)) +$(error Provider for libgl ($(BR2_PACKAGE_PROVIDES_LIBGL)) is not the same \ + as for libegl ($(BR2_PACKAGE_PROVIDES_LIBEGL))) +endif +endif + +# If we have a libgl provider, then the libgles provider must be the same +ifeq ($(BR2_PACKAGE_HAS_LIBGL)$(BR2_PACKAGE_HAS_LIBGLES),yy) +# No need to qstrip, both are quoted +ifneq ($(BR2_PACKAGE_PROVIDES_LIBGL),$(BR2_PACKAGE_PROVIDES_LIBGLES)) +$(error Provider for libgl ($(BR2_PACKAGE_PROVIDES_LIBGL)) is not the same \ + as for libgles ($(BR2_PACKAGE_PROVIDES_LIBGLES))) +endif +endif + +# If we have a libegl provider, then the libgles provider must be the same +ifeq ($(BR2_PACKAGE_HAS_LIBEGL)$(BR2_PACKAGE_HAS_LIBGLES),yy) +# No need to qstrip, both are quoted +ifneq ($(BR2_PACKAGE_PROVIDES_LIBEGL),$(BR2_PACKAGE_PROVIDES_LIBGLES)) +$(error Provider for libegl ($(BR2_PACKAGE_PROVIDES_LIBEGL)) is not the same \ + as for libgles ($(BR2_PACKAGE_PROVIDES_LIBGLES))) +endif +endif
Signature · 1 line
2.7.4
PATCH 1/1 package/opengl: ensure consistency between the various providers
Quoted 5 lines · Yann E. MORIN
Some GL providers will provide libegl and libgles, but not libgl, while other will provide libgl but not libegl not libgles. This can be the case with:
- mesa3d -> libgl
- rpi-userland -> libegl and libgles
The commit message is missing an explanation of why this is bad... Something
like "Such a situation leads to conflicting headers and libraries when building a package that uses both libgl and libegl."
Quoted 4 lines
Since we can not protect against this situation in the Config.in files (especially because providers may be out-of-tree), we can only check for the validity after the fact.
Perhaps it would be possible to create a new opengl virtual package, and that
the libgl* providers provide opengl instead of the specific libgl. So libgl etc. would no longer be virtual packages by themselves, but just suboptions of opengl. The libgl* consumers would depend on BR2_PACKAGE_HAS_LIBGL but add opengl to their dependencies instead of libgl.
Clearly this alternative is too invasive for 2017.02, so your patch is still valid.
Quoted 5 lines
Fixes:
http://autobuild.buildroot.org/results/6f1/6f197c643972e92f0b27b3afac7da7b4b1115f7e/ http://autobuild.buildroot.org/results/6c6/6c6e0a236bde7b892a69119a49422119f3efaa97/ http://autobuild.buildroot.org/results/5a2/5a2a1503b7d19c0ca5b0e9093aa24ed9c020e812/
Does the autobuilder script filter out errors like these? If not, the
autobuilder errors will not be fixed, they'll just move...
Quoted 15 lines
...Signed-off-by "Yann E. MORIN" <[email protected]>Cc Thomas Petazzoni <[email protected]>--- package/opengl/opengl.mk | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)package/opengl/opengl.mk +1
-0@@ -1 +1,30 @@ include $(sort $(wildcard package/opengl/*/*.mk)) +
package/opengl/opengl.mk line 12
Quoted 10 lines
package/opengl/opengl.mk +10
-0+# Ensure consistency betwenn the various GL providers: + +# If we have a libgl provider, then the libegl provider must be the same +ifeq ($(BR2_PACKAGE_HAS_LIBGL)$(BR2_PACKAGE_HAS_LIBEGL),yy) +# No need to qstrip, both are quoted +ifneq ($(BR2_PACKAGE_PROVIDES_LIBGL),$(BR2_PACKAGE_PROVIDES_LIBEGL)) +$(error Provider for libgl ($(BR2_PACKAGE_PROVIDES_LIBGL)) is not the same \ + as for libegl ($(BR2_PACKAGE_PROVIDES_LIBEGL))) +endif +endif
Shouldn't all this be protected by BR_BUILDING?
Regards,
Arnout
Quoted 19 lines
package/opengl/opengl.mk +18
-0+ +# If we have a libgl provider, then the libgles provider must be the same +ifeq ($(BR2_PACKAGE_HAS_LIBGL)$(BR2_PACKAGE_HAS_LIBGLES),yy) +# No need to qstrip, both are quoted +ifneq ($(BR2_PACKAGE_PROVIDES_LIBGL),$(BR2_PACKAGE_PROVIDES_LIBGLES)) +$(error Provider for libgl ($(BR2_PACKAGE_PROVIDES_LIBGL)) is not the same \ + as for libgles ($(BR2_PACKAGE_PROVIDES_LIBGLES))) +endif +endif + +# If we have a libegl provider, then the libgles provider must be the same +ifeq ($(BR2_PACKAGE_HAS_LIBEGL)$(BR2_PACKAGE_HAS_LIBGLES),yy) +# No need to qstrip, both are quoted +ifneq ($(BR2_PACKAGE_PROVIDES_LIBEGL),$(BR2_PACKAGE_PROVIDES_LIBGLES)) +$(error Provider for libegl ($(BR2_PACKAGE_PROVIDES_LIBEGL)) is not the same \ + as for libgles ($(BR2_PACKAGE_PROVIDES_LIBGLES))) +endif +endif
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH 1/1 package/opengl: ensure consistency between the various providers
Arnout, All,
On 2017-02-16 18:46 +0100, Arnout Vandecappelle spake thusly:
Quoted 10 lines · Yann E. MORIN
Quoted 5 lines
Some GL providers will provide libegl and libgles, but not libgl, while other will provide libgl but not libegl not libgles. This can be the case with:
- mesa3d -> libgl
- rpi-userland -> libegl and libglesThe commit message is missing an explanation of why this is bad... Something
like "Such a situation leads to conflicting headers and libraries when building a package that uses both libgl and libegl."
OK, I can fix that.
Quoted 9 lines
Quoted 3 lines
Since we can not protect against this situation in the Config.in files (especially because providers may be out-of-tree), we can only check for the validity after the fact.
Perhaps it would be possible to create a new opengl virtual package, and that
the libgl* providers provide opengl instead of the specific libgl. So libgl etc. would no longer be virtual packages by themselves, but just suboptions of opengl. The libgl* consumers would depend onBR2_PACKAGE_HAS_LIBGLbut add opengl to their dependencies instead of libgl.
I don't like it, because it means that it is no longer possible to have out-of-tree providers (e.g. in a br2-external tree).
(If I understood correctly what you are proposing.)
Quoted 10 lines
Clearly this alternative is too invasive for 2017.02, so your patch is still valid.
Quoted 5 lines
Fixes:
http://autobuild.buildroot.org/results/6f1/6f197c643972e92f0b27b3afac7da7b4b1115f7e/ http://autobuild.buildroot.org/results/6c6/6c6e0a236bde7b892a69119a49422119f3efaa97/ http://autobuild.buildroot.org/results/5a2/5a2a1503b7d19c0ca5b0e9093aa24ed9c020e812/Does the autobuilder script filter out errors like these? If not, the
autobuilder errors will not be fixed, they'll just move...
Clearly, the autobuilder scripts will have to learn to catch this, as they are currently catching the multiple-providers case.
Quoted 17 lines
Quoted 17 lines
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Thomas Petazzoni <[email protected]>--- package/opengl/opengl.mk | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)package/opengl/opengl.mk +5
-0@@ -1 +1,30 @@ include $(sort $(wildcard package/opengl/*/*.mk)) + +# Ensure consistency betwenn the various GL providers: + +# If we have a libgl provider, then the libegl provider must be the same +ifeq ($(BR2_PACKAGE_HAS_LIBGL)$(BR2_PACKAGE_HAS_LIBEGL),yy)
Quoted 8 lines
package/opengl/opengl.mk line 12
Quoted 6 lines
package/opengl/opengl.mk +6
-0+# No need to qstrip, both are quoted +ifneq ($(BR2_PACKAGE_PROVIDES_LIBGL),$(BR2_PACKAGE_PROVIDES_LIBEGL)) +$(error Provider for libgl ($(BR2_PACKAGE_PROVIDES_LIBGL)) is not the same \ + as for libegl ($(BR2_PACKAGE_PROVIDES_LIBEGL))) +endif +endifShouldn't all this be protected by
BR_BUILDING?
I was wondering if we should have it, so that we could re-enter the menuconfig in case of error, but it seems that it was not needed.
And we do not want to allow 'make source' either, sonce the configuration is invalid.
What are you trying to protect against (here) with BR_BUILDING?
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 package/opengl: ensure consistency between the various providers
Quoted 4 lines · Yann E. MORIN
Arnout, All,
On 2017-02-16 18:46 +0100, Arnout Vandecappelle spake thusly:
Quoted 1 line · Yann E. MORIN
[snip]
Quoted 10 lines
Quoted 9 lines
Quoted 3 lines
Since we can not protect against this situation in the Config.in files (especially because providers may be out-of-tree), we can only check for the validity after the fact.
Perhaps it would be possible to create a new opengl virtual package, and that
the libgl* providers provide opengl instead of the specific libgl. So libgl etc. would no longer be virtual packages by themselves, but just suboptions of opengl. The libgl* consumers would depend onBR2_PACKAGE_HAS_LIBGLbut add opengl to their dependencies instead of libgl.
Quoted 4 lines
I don't like it, because it means that it is no longer possible to have out-of-tree providers (e.g. in a br2-external tree).
(If I understood correctly what you are proposing.)
Probably not :-) My proposal would break current out-of-tree providers (and
consumers), but new providers would still be possible.
The idea is that libgl, libgles and libegl would no longer be virtual packages.
Instead, opengl would be a virtual package, with three suboptions BR2_PACKAGE_HAS_LIBGL, BR2_PACKAGE_HAS_LIBGLES and BR2_PACKAGE_HAS_LIBEGL, each of which would select BR2_PACKAGE_HAS_OPENGL. A provider would select one of the suboptions (which implicitly selects HAS_OPENGL), and would set only BR2_PACKAGE_PROVIDES_OPENGL to itself. A consumer would depend on one of the suboptions in the Config.in file, and add opengl to its DEPENDENCIES in the .mk file. BR2_PACKAGE_HAS_OPENGL itself would not be used except by the virtual-package infra.
Basically, it boils down to reusing the existing infra for detecting
conflicting providers of virtual packages.
Quoted 40 lines
Quoted 10 lines
Clearly this alternative is too invasive for 2017.02, so your patch is still valid.
Quoted 5 lines
Fixes:
http://autobuild.buildroot.org/results/6f1/6f197c643972e92f0b27b3afac7da7b4b1115f7e/ http://autobuild.buildroot.org/results/6c6/6c6e0a236bde7b892a69119a49422119f3efaa97/ http://autobuild.buildroot.org/results/5a2/5a2a1503b7d19c0ca5b0e9093aa24ed9c020e812/Does the autobuilder script filter out errors like these? If not, the
autobuilder errors will not be fixed, they'll just move...Clearly, the autobuilder scripts will have to learn to catch this, as they are currently catching the multiple-providers case.
Quoted 17 lines
Quoted 17 lines
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Thomas Petazzoni <[email protected]>--- package/opengl/opengl.mk | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)package/opengl/opengl.mk +5
-0@@ -1 +1,30 @@ include $(sort $(wildcard package/opengl/*/*.mk)) + +# Ensure consistency betwenn the various GL providers: + +# If we have a libgl provider, then the libegl provider must be the same +ifeq ($(BR2_PACKAGE_HAS_LIBGL)$(BR2_PACKAGE_HAS_LIBEGL),yy)Quoted 8 lines
package/opengl/opengl.mk line 12
Quoted 6 lines
package/opengl/opengl.mk +6
-0+# No need to qstrip, both are quoted +ifneq ($(BR2_PACKAGE_PROVIDES_LIBGL),$(BR2_PACKAGE_PROVIDES_LIBEGL)) +$(error Provider for libgl ($(BR2_PACKAGE_PROVIDES_LIBGL)) is not the same \ + as for libegl ($(BR2_PACKAGE_PROVIDES_LIBEGL))) +endif +endifShouldn't all this be protected by
BR_BUILDING?
Quoted 7 lines
I was wondering if we should have it, so that we could re-enter the menuconfig in case of error, but it seems that it was not needed.
And we do not want to allow 'make source' either, sonce the configuration is invalid.
What are you trying to protect against (here) with
BR_BUILDING?
I didn't thing really hard about it, that's why it was a question :-) It's just
that most of this kind of stuff is protected by BR_BUILDING. But indeed, the check in virtual-package isn't, and that's what we try to emulate here, so it's OK.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH 1/1 package/opengl: ensure consistency between the various providers
Arnout, All,
On 2017-02-17 08:56 +0100, Arnout Vandecappelle spake thusly:
Quoted 16 lines · Yann E. MORIN
Quoted 4 lines
Arnout, All,
On 2017-02-16 18:46 +0100, Arnout Vandecappelle spake thusly:
Quoted 1 line · Yann E. MORIN
[snip]
Quoted 10 lines
Quoted 9 lines
Quoted 3 lines
Since we can not protect against this situation in the Config.in files (especially because providers may be out-of-tree), we can only check for the validity after the fact.
Perhaps it would be possible to create a new opengl virtual package, and that
the libgl* providers provide opengl instead of the specific libgl. So libgl etc. would no longer be virtual packages by themselves, but just suboptions of opengl. The libgl* consumers would depend onBR2_PACKAGE_HAS_LIBGLbut add opengl to their dependencies instead of libgl.
Quoted 6 lines
Quoted 4 lines
I don't like it, because it means that it is no longer possible to have out-of-tree providers (e.g. in a br2-external tree).
(If I understood correctly what you are proposing.)
Probably not :-)
Damn... ;-)
Quoted 13 lines
My proposal would break current out-of-tree providers (and consumers), but new providers would still be possible.
The idea is that libgl, libgles and libegl would no longer be virtual packages.
Instead, opengl would be a virtual package, with three suboptionsBR2_PACKAGE_HAS_LIBGL,BR2_PACKAGE_HAS_LIBGLESandBR2_PACKAGE_HAS_LIBEGL, each of which would selectBR2_PACKAGE_HAS_OPENGL. A provider would select one of the suboptions (which implicitly selectsHAS_OPENGL), and would set onlyBR2_PACKAGE_PROVIDES_OPENGLto itself. A consumer would depend on one of the suboptions in the Config.in file, and add opengl to its DEPENDENCIES in the .mk file.BR2_PACKAGE_HAS_OPENGLitself would not be used except by the virtual-package infra.
Quoted 2 lines
Basically, it boils down to reusing the existing infra for detecting
conflicting providers of virtual packages.
Ah, I see. Yes, this is clever. Yes, I would think this would be acceptable.
But clearly this would not be not for 2017.02.
[--SNIP--]
Quoted 5 lines
Quoted 5 lines
Quoted 1 line
Shouldn't all this be protected by
BR_BUILDING?I was wondering if we should have it, so that we could re-enter the menuconfig in case of error, but it seems that it was not needed.
Quoted 8 lines
Quoted 4 lines
And we do not want to allow 'make source' either, sonce the configuration is invalid.
What are you trying to protect against (here) with
BR_BUILDING?I didn't thing really hard about it, that's why it was a question :-) It's just
that most of this kind of stuff is protected byBR_BUILDING. But indeed, the check in virtual-package isn't, and that's what we try to emulate here, so it's OK.
I will double-check.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 package/opengl: ensure consistency between the various providers
In reply to Arnout VandecappelleHello Yann,
Quoted 7 lines · On Thursday 16 February 2017 18:46:10 CET Arnout Vandecappelle wrote:
Quoted 5 lines · Yann E. MORIN
Some GL providers will provide libegl and libgles, but not libgl, while other will provide libgl but not libegl not libgles. This can be the case with:
- mesa3d -> libgl
- rpi-userland -> libegl and libgles
Unfortunately, as far as I remember, this kind of configuration is necessary to build xdriver_xf86-video-imx-viv. Mesa is necessary to build GLX support but, EGL/GLes have to be provided by imx-gpu-viv.
However, maybe your idea is correct and xdriver_xf86-video-imx-viv should be reworked (but it is not a trivial work).
Quoted 3 lines
The commit message is missing an explanation of why this is bad... Something
like "Such a situation leads to conflicting headers and libraries when building a package that uses both libgl and libegl."
Signature · 3 lines
J?r?me Pouiller, Sysmic Embedded Linux specialist http://www.sysmic.fr
PATCH 1/1 package/opengl: ensure consistency between the various providers
Hello,
Quoted 9 lines · J?r?me Pouiller
Quoted 7 lines · On Thursday 16 February 2017 18:46:10 CET Arnout Vandecappelle wrote:
Quoted 5 lines · Yann E. MORIN
Some GL providers will provide libegl and libgles, but not libgl, while other will provide libgl but not libegl not libgles. This can be the case with:
- mesa3d -> libgl
- rpi-userland -> libegl and libgles
Quoted 3 lines
Unfortunately, as far as I remember, this kind of configuration is necessary to build xdriver_xf86-video-imx-viv. Mesa is necessary to build GLX support but, EGL/GLes have to be provided by imx-gpu-viv.
Nope, it's not actually needed. Even with xdriver_xf86-video-imx-viv, the OpenGL provider is imx-gpu-viv, as it's ultimately the one that provides libGL.so.
However, it is true that imx-gpu-viv is a special case as it provides a libGL.so that itself uses libraries provided by Mesa.
So the hack I've done so far is:
- select BR2_PACKAGE_HAS_LIBGL if BR2_PACKAGE_XORG7
+ select BR2_PACKAGE_HAS_LIBGL if BR2_PACKAGE_XORG7 && !BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_X11
and:
- default "mesa3d" if BR2_PACKAGE_XORG7
+ default "mesa3d" if BR2_PACKAGE_XORG7 && !BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_X11
This is a quick hack, but it allows mesa3d to *NOT* be seen as an OpenGL provider if imx-gpu-viv X11 support is enabled.
So I still think the rule should be: we support only one OpenGL provider. And the rest should be solved by exposing mesa3d as an OpenGL provider or not depending on Config.in options.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 package/opengl: ensure consistency between the various providers
Quoted 13 lines · On Friday 17 February 2017 11:04:36 CET Thomas Petazzoni wrote:
Hello,
Quoted 9 lines · J?r?me Pouiller
Quoted 7 lines · On Thursday 16 February 2017 18:46:10 CET Arnout Vandecappelle wrote:
Quoted 5 lines · Yann E. MORIN
Some GL providers will provide libegl and libgles, but not libgl, while other will provide libgl but not libegl not libgles. This can be the case with:
- mesa3d -> libgl
- rpi-userland -> libegl and libgles
Quoted 7 lines
Quoted 3 lines
Unfortunately, as far as I remember, this kind of configuration is necessary to build xdriver_xf86-video-imx-viv. Mesa is necessary to build GLX support but, EGL/GLes have to be provided by imx-gpu-viv.
Nope, it's not actually needed. Even with xdriver_xf86-video-imx-viv, the OpenGL provider is imx-gpu-viv, as it's ultimately the one that provides libGL.so.
Yes, replace "necessary" by "currently used" in my sentence.
Quoted 13 lines
However, it is true that imx-gpu-viv is a special case as it provides a libGL.so that itself uses libraries provided by Mesa.
So the hack I've done so far is:
(quoted diff) +1
-1- select BR2_PACKAGE_HAS_LIBGL if BR2_PACKAGE_XORG7 + select BR2_PACKAGE_HAS_LIBGL if BR2_PACKAGE_XORG7 && !BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_X11and:
(quoted diff) +1
-1- default "mesa3d" if BR2_PACKAGE_XORG7 + default "mesa3d" if BR2_PACKAGE_XORG7 && !BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_X11
Quoted 6 lines
This is a quick hack, but it allows mesa3d to *NOT* be seen as an OpenGL provider if imx-gpu-viv X11 support is enabled.
So I still think the rule should be: we support only one OpenGL provider. And the rest should be solved by exposing mesa3d as an OpenGL provider or not depending on Config.in options.
I agree. Give me a few days to prepare a patch that do that.
Signature · 3 lines
J?r?me Pouiller, Sysmic Embedded Linux specialist http://www.sysmic.fr
PATCH 1/1 package/opengl: ensure consistency between the various providers
In reply to Yann E. MORINHello,
Quoted 16 lines · Yann E. MORIN
Some GL providers will provide libegl and libgles, but not libgl, while other will provide libgl but not libegl not libgles. This can be the case with:
- mesa3d -> libgl
- rpi-userland -> libegl and libglesSince we can not protect against this situation in the Config.in files (especially because providers may be out-of-tree), we can only check for the validity after the fact.
Fixes:
http://autobuild.buildroot.org/results/6f1/6f197c643972e92f0b27b3afac7da7b4b1115f7e/ http://autobuild.buildroot.org/results/6c6/6c6e0a236bde7b892a69119a49422119f3efaa97/ http://autobuild.buildroot.org/results/5a2/5a2a1503b7d19c0ca5b0e9093aa24ed9c020e812/ ...
Quoted 5 lines
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Thomas Petazzoni <[email protected]>--- package/opengl/opengl.mk | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
This patch has received numerous comments, so I'll mark it as Changes Requested in patchwork.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com