simplify copy_mm()
Subsystems (4)
PATCH 1/1 simplify copy_mm()
All this can happen without a single goto.
Signed-off-by Rolf Eike Beer <[email protected]>
--- kernel/fork.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-)
kernel/fork.c +4 -11
@@ -1382,7 +1382,6 @@ static struct mm_struct *dup_mm(struct task_struct *tsk,static int copy_mm (unsigned long clone_flags,struct task_struct *tsk) {struct mm_struct *mm, *oldmm; -int retval; tsk->min_flt = tsk->maj_flt =0 ; tsk->nvcsw = tsk->nivcsw =0 ;
@@ -1409,21 +1408,15 @@ static int copy_mm(unsigned long clone_flags, struct task_struct *tsk)if (clone_flags &CLONE_VM ) {mmget (oldmm); mm = oldmm; - goto good_mm; + }else { + mm =dup_mm (tsk, current->mm); +if (!mm) +return -ENOMEM ; } - retval = -ENOMEM ; - mm =dup_mm (tsk, current->mm); -if (!mm) - goto fail_nomem; - -good_mm: tsk->mm = mm; tsk->active_mm = mm;return 0 ; - -fail_nomem: -return retval; }static int copy_fs (unsigned long clone_flags,struct task_struct *tsk)
Signature · 11 lines
2.30.0 -- Rolf Eike Beer, emlix GmbH, http://www.emlix.com Fon +49 551 30664-0, Fax +49 551 30664-11 Gothaer Platz 3, 37083 Göttingen, Germany Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160 Geschäftsführung: Heike Jordan, Dr. Uwe Kracke – Ust-IdNr.: DE 205 198 055 emlix - smart embedded open source