Input: atkbd - correct MSC_SCAN events for force_release keys
Subsystems (2)
PATCH 1/1 Input: atkbd - correct MSC_SCAN events for force_release keys
Without the change either no scancode would be reported on release of force_release keys, or - if the key is marked as force_release erroneously - the release event and the scancode would be reported in separate reports to the input layer.
--- drivers/input/keyboard/atkbd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/input/keyboard/atkbd.c +4 -2
@@ -456,8 +456,9 @@ static irqreturn_t atkbd_interrupt(struct serio *serio, unsigned char data, keycode = atkbd->keycode[code]; -if (keycode !=ATKBD_KEY_NULL ) -input_event (dev,EV_MSC ,MSC_SCAN , code); +if (!(atkbd->release &&test_bit (code, atkbd->force_release_mask))) +if (keycode !=ATKBD_KEY_NULL ) +input_event (dev,EV_MSC ,MSC_SCAN , code);switch (keycode) {case ATKBD_KEY_NULL :
@@ -511,6 +512,7 @@ static irqreturn_t atkbd_interrupt(struct serio *serio, unsigned char data,input_sync (dev);if (value &&test_bit (code, atkbd->force_release_mask)) { +input_event (dev,EV_MSC ,MSC_SCAN , code);input_report_key (dev, keycode,0 );input_sync (dev); }
Signature · 11 lines
1.8.4.5 -- Stefan Brüns / Bergstraße 21 / 52062 Aachen home: +49 241 53809034 mobile: +49 151 50412019 work: +49 2405 49936-424 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 28 lines · you
Without the change either no scancode would be reported on release of
force_releasekeys, or - if the key is marked asforce_releaseerroneously - the release event and the scancode would be reported in separate reports to the input layer.Signed-off-by Stefan Brüns <[email protected]>--- drivers/input/keyboard/atkbd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/input/keyboard/atkbd.c +3
-2@@ -456,8 +456,9 @@ static irqreturn_t atkbd_interrupt(struct serio *serio, unsigned char data, keycode = atkbd->keycode[code]; -if (keycode !=ATKBD_KEY_NULL ) -input_event (dev,EV_MSC ,MSC_SCAN , code); +if (!(atkbd->release &&test_bit (code, atkbd->force_release_mask))) +if (keycode !=ATKBD_KEY_NULL ) +input_event (dev,EV_MSC ,MSC_SCAN , code);switch (keycode) {case ATKBD_KEY_NULL :
drivers/input/keyboard/atkbd.c static irqreturn_t atkbd_interrupt(struct serio *serio, unsigned char data, · line 518
Quoted 7 lines
drivers/input/keyboard/atkbd.c +1
-0@@ -511,6 +512,7 @@ static irqreturn_t atkbd_interrupt(struct serio *serio, unsigned char data,input_sync (dev);if (value &&test_bit (code, atkbd->force_release_mask)) { +input_event (dev,EV_MSC ,MSC_SCAN , code);input_report_key (dev, keycode,0 );input_sync (dev); }
Ping!
Kind regards,
Stefan
Signature · 7 lines
Stefan Brüns / Bergstraße 21 / 52062 Aachen home: +49 241 53809034 mobile: +49 151 50412019 work: +49 2405 49936-424 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Dmitry Torokhov
maintainerQuoted 39 lines · Stefan Brüns
Quoted 28 lines · you
Without the change either no scancode would be reported on release of
force_releasekeys, or - if the key is marked asforce_releaseerroneously - the release event and the scancode would be reported in separate reports to the input layer.Signed-off-by Stefan Brüns <[email protected]>--- drivers/input/keyboard/atkbd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/input/keyboard/atkbd.c +3
-2@@ -456,8 +456,9 @@ static irqreturn_t atkbd_interrupt(struct serio *serio, unsigned char data, keycode = atkbd->keycode[code]; -if (keycode !=ATKBD_KEY_NULL ) -input_event (dev,EV_MSC ,MSC_SCAN , code); +if (!(atkbd->release &&test_bit (code, atkbd->force_release_mask))) +if (keycode !=ATKBD_KEY_NULL ) +input_event (dev,EV_MSC ,MSC_SCAN , code);switch (keycode) {case ATKBD_KEY_NULL :drivers/input/keyboard/atkbd.c static irqreturn_t atkbd_interrupt(struct serio *serio, unsigned char data, · line 518
Quoted 7 lines
drivers/input/keyboard/atkbd.c +1
-0@@ -511,6 +512,7 @@ static irqreturn_t atkbd_interrupt(struct serio *serio, unsigned char data,input_sync (dev);if (value &&test_bit (code, atkbd->force_release_mask)) { +input_event (dev,EV_MSC ,MSC_SCAN , code);input_report_key (dev, keycode,0 );input_sync (dev); }Ping!
Quoted 1 line
Kind regards,
I do not see the original patch mail, could you please resend (and CC me)?
Thanks.
Signature · 5 lines
Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html