Skip to contentSkip to conversation

add nss for LSB library check

PATCH Superseded Hongxu Jia 5 participants 20 messages Jul 10, 2013 – Jul 12, 2013

lore
Share & tools
lore

Hongxu Jia

author
#0 lore raw

v2 cover add nss for LSB library check

Change from V1:
1) Rename the title of patch 1/5
2) Use ${libdir} rather than ${base_libdir} as the lib location which references the nss in meta-browser.

//Hongxu

The following changes since commit dc86293f0444384e8ae5131fdd10b6cb077164b0:

bitbake: HOB:Proper handle of SIGINT (2013-07-05 15:52:48 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib hongxu/fix-nss
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-nss

Hongxu Jia (5):
nspr: add native version
packagegroup-core-lsb: add nss for LSB library check
nss: add version 3.15.1
nss: create checksum files for the nss libraries
nss: fix incorrect shebang line of perl script

 .../packagegroups/packagegroup-core-lsb.bb         |   1 +
 meta/recipes-support/nspr/nspr_4.10.bb             |   2 +
 .../files/nss-fix-incorrect-shebang-of-perl.patch  | 110 ++++++++++++
 .../files/nss-fix-support-cross-compiling.patch    |  71 ++++++++
 .../files/nss-no-rpath-for-cross-compiling.patch   |  26 +++
 meta/recipes-support/nss/files/nss.pc.in           |  11 ++
 meta/recipes-support/nss/files/signlibs.sh         |  20 +++
 meta/recipes-support/nss/nss.inc                   | 187 +++++++++++++++++++++
 meta/recipes-support/nss/nss_3.15.1.bb             |   9 +
 9 files changed, 437 insertions(+)
 create mode 100644 meta/recipes-support/nss/files/nss-fix-incorrect-shebang-of-perl.patch
 create mode 100644 meta/recipes-support/nss/files/nss-fix-support-cross-compiling.patch
 create mode 100644 meta/recipes-support/nss/files/nss-no-rpath-for-cross-compiling.patch
 create mode 100644 meta/recipes-support/nss/files/nss.pc.in
 create mode 100644 meta/recipes-support/nss/files/signlibs.sh
 create mode 100644 meta/recipes-support/nss/nss.inc
 create mode 100644 meta/recipes-support/nss/nss_3.15.1.bb
Signature · 1 line
1.8.1.2
author
#1 lore raw

PATCH v2 1/5 nspr: add native version

It is required by nss-native.

[YOCTO #4096]

---
 meta/recipes-support/nspr/nspr_4.10.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-support/nspr/nspr_4.10.bb +2 -0
index 3936d67..fcecb95 100644
@@ -173,3 +173,5 @@ FILES_${PN} = "${libdir}/lib*.so"
 FILES_${PN}-dev = "${bindir}/* ${libdir}/nspr/tests/* ${libdir}/pkgconfig \
                 ${includedir}/* ${datadir}/aclocal/* "
 FILES_${PN}-dbg += "${libdir}/nspr/tests/.debug/*"
+
+BBCLASSEXTEND = "native"
Signature · 1 line
1.8.1.2
author
#2 lore raw

PATCH v2 2/5 packagegroup-core-lsb: add nss for LSB library check

In reply to Hongxu Jia

Add nss for LSB library check.
...
Unable to find library libnss3.so
Unable to find library libssl3.so
...

[YOCTO 4096]

---
 meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb +1 -0
index d71db26..4d79592 100644
@@ -167,6 +167,7 @@ RDEPENDS_packagegroup-core-lsb-core = "\
     zlib \
     nspr \
     libpng12 \
+    nss \
 "
 
 SUMMARY_packagegroup-core-lsb-perl = "LSB Runtime Languages (Perl)"
Signature · 1 line
1.8.1.2
author
#3 lore raw

PATCH v2 3/5 nss: add version 3.15.1

In reply to Hongxu Jia

Network Security Services (NSS) is a set of libraries designed to support cross-platform development of security-enabled client and server applications. Applications built with NSS can support SSL v2 and v3, TLS, PKCS 5, PKCS 7, PKCS 11, PKCS 12, S/MIME, X.509 v3 certificates, and other security standards.

[YOCTO #4096]

---
 .../files/nss-fix-support-cross-compiling.patch    |  71 +++++++++
 .../files/nss-no-rpath-for-cross-compiling.patch   |  26 ++++
 meta/recipes-support/nss/files/nss.pc.in           |  11 ++
 meta/recipes-support/nss/nss.inc                   | 170 +++++++++++++++++++++
 meta/recipes-support/nss/nss_3.15.1.bb             |   9 ++
 5 files changed, 287 insertions(+)
 create mode 100644 meta/recipes-support/nss/files/nss-fix-support-cross-compiling.patch
 create mode 100644 meta/recipes-support/nss/files/nss-no-rpath-for-cross-compiling.patch
 create mode 100644 meta/recipes-support/nss/files/nss.pc.in
 create mode 100644 meta/recipes-support/nss/nss.inc
 create mode 100644 meta/recipes-support/nss/nss_3.15.1.bb
meta/recipes-support/nss/files/nss-fix-support-cross-compiling.patch new file +71 -0
new file mode 100644
index 0000000..f0b3550
@@ -0,0 +1,71 @@
+nss: fix support cross compiling
+
+Let some make variables be assigned from outside makefile.
+
+Signed-off-by: Hongxu Jia <[email protected]>
+Upstream-Status: Inappropriate [configuration]
+---
+ nss/coreconf/Linux.mk   | 12 +++++++++++-
+ nss/coreconf/arch.mk    |  2 +-
+ nss/lib/freebl/Makefile |  6 ++++++
+ 3 files changed, 18 insertions(+), 2 deletions(-)
+
+diff --git a/nss/coreconf/Linux.mk b/nss/coreconf/Linux.mk
+--- a/nss/coreconf/Linux.mk
++++ b/nss/coreconf/Linux.mk
+@@ -16,11 +16,21 @@ ifeq ($(USE_PTHREADS),1)
+ 	IMPL_STRATEGY = _PTH
+ endif
+ 
++ifndef CC
+ CC			= gcc
++endif
++
++ifdef CXX
++CCC			= $(CXX)
++else
+ CCC			= g++
++endif
++
++ifndef RANLIB
+ RANLIB			= ranlib
++endif
+ 
+-DEFAULT_COMPILER = gcc
++DEFAULT_COMPILER = $(CC)
+ 
+ ifeq ($(OS_TARGET),Android)
+ ifndef ANDROID_NDK
+diff --git a/nss/coreconf/arch.mk b/nss/coreconf/arch.mk
+index 6557348..b722412 100644
+--- a/nss/coreconf/arch.mk
++++ b/nss/coreconf/arch.mk
+@@ -37,7 +37,7 @@ OS_TEST := $(shell uname -m)
+ ifeq ($(OS_TEST),i86pc)
+     OS_RELEASE := $(shell uname -r)_$(OS_TEST)
+ else
+-    OS_RELEASE := $(shell uname -r)
++    OS_RELEASE ?= $(shell uname -r)
+ endif
+ 
+ #
+diff --git a/nss/lib/freebl/Makefile b/nss/lib/freebl/Makefile
+index 0d293f1..678f506 100644
+--- a/nss/lib/freebl/Makefile
++++ b/nss/lib/freebl/Makefile
+@@ -36,6 +36,12 @@ ifdef USE_64
+ 	DEFINES += -DNSS_USE_64
+ endif
+ 
++ifeq ($(OS_TEST),mips)
++ifndef USE_64
++	DEFINES += -DNS_PTR_LE_32
++endif
++endif
++
+ ifdef USE_ABI32_FPU
+ 	DEFINES += -DNSS_USE_ABI32_FPU
+ endif
+-- 
+1.8.1.2
+
meta/recipes-support/nss/files/nss-no-rpath-for-cross-compiling.patch new file +26 -0
new file mode 100644
index 0000000..7661dc9
@@ -0,0 +1,26 @@
+nss:no rpath for cross compiling
+
+Signed-off-by: Hongxu Jia <[email protected]>
+Upstream-Status: Inappropriate [configuration]
+---
+ nss/cmd/platlibs.mk | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/nss/cmd/platlibs.mk b/nss/cmd/platlibs.mk
+--- a/nss/cmd/platlibs.mk
++++ b/nss/cmd/platlibs.mk
+@@ -18,9 +18,9 @@ endif
+ 
+ ifeq ($(OS_ARCH), Linux)
+ ifeq ($(USE_64), 1)
+-EXTRA_SHARED_LIBS += -Wl,-rpath,'$$ORIGIN/../lib64:/opt/sun/private/lib64:$$ORIGIN/../lib'
++#EXTRA_SHARED_LIBS += -Wl,-rpath,'$$ORIGIN/../lib64:/opt/sun/private/lib64:$$ORIGIN/../lib'
+ else
+-EXTRA_SHARED_LIBS += -Wl,-rpath,'$$ORIGIN/../lib:/opt/sun/private/lib'
++#EXTRA_SHARED_LIBS += -Wl,-rpath,'$$ORIGIN/../lib:/opt/sun/private/lib'
+ endif
+ endif
+ 
+-- 
+1.8.1.2
+
meta/recipes-support/nss/files/nss.pc.in new file +11 -0
new file mode 100644
index 0000000..200f635
@@ -0,0 +1,11 @@
+prefix=OEPREFIX
+exec_prefix=OEEXECPREFIX
+libdir=OELIBDIR
+includedir=OEINCDIR
+
+Name: NSS
+Description: Network Security Services
+Version: %NSS_VERSION%
+Requires: nspr >= %NSPR_VERSION%
+Libs: -lssl3 -lsmime3 -lnss3 -lsoftokn3 -lnssutil3
+Cflags: -IOEINCDIR
meta/recipes-support/nss/nss.inc new file +170 -0

170 lines not on this page · raw message

meta/recipes-support/nss/nss_3.15.1.bb new file +9 -0
new file mode 100644
index 0000000..7b06f00
@@ -0,0 +1,9 @@
+require nss.inc
+
+SRC_URI += "\
+    http://ftp.mozilla.org/pub/mozilla.org/security/nss/releases/NSS_3_15_1_RTM/src/${BPN}-${PV}.tar.gz \
+"
+
+SRC_URI[md5sum] = "fb68f4d210ac9397dd0d3c39c4f938eb"
+SRC_URI[sha256sum] = "f994106a33d1f3210f4151bbb3419a1c28fd1cb545caa7dc9afdebd6da626284"
+
Signature · 1 line
1.8.1.2
#4 lore raw

Re: [PATCH 3/5] nss: add version 3.15.1

Quoted 4 lines · Hongxu Jia

Network Security Services (NSS) is a set of libraries designed to support cross-platform development of security-enabled client and server applications. Applications built with NSS can support SSL v2 and v3, TLS, PKCS 5, PKCS 7, PKCS 11, PKCS 12, S/MIME, X.509 v3 certificates, and other security standards.

What's the rationale for putting this into oe-core instead of updating the recipe in meta-browser?

Ross

#5 lore raw

Re: [PATCH 3/5] nss: add version 3.15.1

Quoted 8 lines · Ross
Quoted 4 lines · Hongxu Jia

Network Security Services (NSS) is a set of libraries designed to support cross-platform development of security-enabled client and server applications. Applications built with NSS can support SSL v2 and v3, TLS, PKCS 5, PKCS 7, PKCS 11, PKCS 12, S/MIME, X.509 v3 certificates, and other security standards.

What's the rationale for putting this into oe-core instead of updating the recipe in meta-browser?

Of course if I actually read the other mails I'd see it was for LSB.

Ross

#6 lore raw

Re: [PATCH 3/5] nss: add version 3.15.1

Quoted 11 lines · Ross
Quoted 8 lines · Ross
Quoted 4 lines · Hongxu Jia

Network Security Services (NSS) is a set of libraries designed to support cross-platform development of security-enabled client and server applications. Applications built with NSS can support SSL v2 and v3, TLS, PKCS 5, PKCS 7, PKCS 11, PKCS 12, S/MIME, X.509 v3 certificates, and other security standards.

What's the rationale for putting this into oe-core instead of updating the recipe in meta-browser?

Of course if I actually read the other mails I'd see it was for LSB.

I think you could still legitimately question whether having recipes in oe-core that are "just for LSB" is sensible and/or desirable, not least because dangling libraries that don't have any users are hard to test.

p.

#7 lore raw

Re: [PATCH 3/5] nss: add version 3.15.1

Quoted 3 lines · Phil Blundell

I think you could still legitimately question whether having recipes in oe-core that are "just for LSB" is sensible and/or desirable, not least because dangling libraries that don't have any users are hard to test.

I was just pondering the idea of a "meta-lsb"...

Ross

author
#8 lore raw

Re: [PATCH 3/5] nss: add version 3.15.1

Quoted 5 lines · Ross
Quoted 3 lines · Phil Blundell

I think you could still legitimately question whether having recipes in oe-core that are "just for LSB" is sensible and/or desirable, not least because dangling libraries that don't have any users are hard to test.

I was just pondering the idea of a "meta-lsb"...

The reason why I choose to put nss into oe-core is I found nspr in oe-core. They both used for lsb-test and come from mozilla.

Anyone has a better idea about where to put?

https://developer.mozilla.org/en-US/docs/NSS
https://developer.mozilla.org/en-US/docs/NSPR

//Hongxu

Quoted 2 lines

Ross

#9 lore raw

Re: [PATCH 3/5] nss: add version 3.15.1

In reply to Burton, Ross
Quoted 6 lines · Ross
Quoted 3 lines · Phil Blundell

I think you could still legitimately question whether having recipes in oe-core that are "just for LSB" is sensible and/or desirable, not least because dangling libraries that don't have any users are hard to test.

I was just pondering the idea of a "meta-lsb"...

Yeah, I was thinking about that too. The obvious downside of this plan is that this layer would end up containing a random-looking grab-bag of recipes with nothing in common other than that they're needed for LSB conformance and not in oe-core.

In practice that's probably going to mean that the majority of them would duplicate recipes from other layers (e.g. meta-browser in the nss case) which doesn't seem like a very satisfactory state of affairs.

p.

#10 lore raw

Re: [PATCH 3/5] nss: add version 3.15.1

Quoted 10 lines · Phil Blundell
Quoted 1 line

I was just pondering the idea of a "meta-lsb"...

Yeah, I was thinking about that too. The obvious downside of this plan is that this layer would end up containing a random-looking grab-bag of recipes with nothing in common other than that they're needed for LSB conformance and not in oe-core.

In practice that's probably going to mean that the majority of them would duplicate recipes from other layers (e.g. meta-browser in the nss case) which doesn't seem like a very satisfactory state of affairs.

That's pretty much exactly my thoughts. Two less than ideal
situations, one less worse than the other (LSB in oe-core being less worse, in my opinion).

Ross

author
#11 lore raw

PATCH v2 4/5 nss: create checksum files for the nss libraries

In reply to Hongxu Jia

Add checksum files required for the NSS softoken to operate in FIPS 140 mode. The shlibsign is invoked to sign the libraries, and it is built for the target architecture and doesn't support cross-compiling so far.

Invoke shlibsign at target's first boot time to generate checksum files.

https://developer.mozilla.org/en-US/docs/NSS/NSS_Tech_Notes/nss_tech_note6
http://en.wikipedia.org/wiki/FIPS_140
https://bugzilla.mozilla.org/show_bug.cgi?id=681624

---
 meta/recipes-support/nss/files/signlibs.sh | 20 ++++++++++++++++++++
 meta/recipes-support/nss/nss.inc           | 16 ++++++++++++++++
 2 files changed, 36 insertions(+)
 create mode 100644 meta/recipes-support/nss/files/signlibs.sh
meta/recipes-support/nss/files/signlibs.sh new file +20 -0
new file mode 100644
index 0000000..1ec79f4
@@ -0,0 +1,20 @@
+#!/bin/sh
+
+# signlibs.sh
+#
+# (c)2010 Wind River Systems, Inc.
+#
+# regenerates the .chk files for the NSS libraries that require it
+# since the ones that are built have incorrect checksums that were
+# calculated on the host where they really need to be done on the
+# target
+
+CHK_FILES=`find /lib* /usr/lib* -name "*.chk"`
+SIGN_BINARY=`which shlibsign`
+for I in $CHK_FILES
+do
+       DN=`dirname $I`
+       BN=`basename $I .chk`
+       FN=$DN/$BN.so
+       $SIGN_BINARY -i $FN
+done
meta/recipes-support/nss/nss.inc +16 -0
index 87cba38..4270743 100644
@@ -18,6 +18,7 @@ SRC_URI = "\
 "
 SRC_URI_append_class-target += "\
     file://nss.pc.in \
+    file://signlibs.sh \
 "
 inherit siteinfo
 PR = "r0"
@@ -136,6 +137,14 @@ do_install() {
 }
 
 do_install_append_class-target() {
+    # Create empty .chk files for the NSS libraries at build time. They could
+    # be regenerated at target's boot time.
+    for file in libsoftokn3.chk libfreebl3.chk libnssdbm3.chk; do
+        touch ${D}/${libdir}/$file
+        chmod 755 ${D}/${libdir}/$file
+    done
+    install -D -m 755 ${WORKDIR}/signlibs.sh ${D}/${bindir}/signlibs.sh
+
     install -d ${D}${libdir}/pkgconfig/
     sed 's/%NSS_VERSION%/${PV}/' ${WORKDIR}/nss.pc.in | sed 's/%NSPR_VERSION%/4.9.2/' > ${D}${libdir}/pkgconfig/nss.pc
     sed -i s:OEPREFIX:${prefix}:g ${D}${libdir}/pkgconfig/nss.pc
@@ -151,6 +160,13 @@ do_install_append_class-target() {
     rm ./empty_password
 }
 
+pkg_postinst_${PN} () {
+    if [ -n "$D" ]; then
+        exit 1
+    fi
+    signlibs.sh
+}
+
 FILES_${PN} = "\
     ${sysconfdir} \
     ${bindir} \
Signature · 1 line
1.8.1.2
#12 lore raw

Re: [PATCH 4/5] nss: create checksum files for the nss libraries

Quoted 5 lines · Hongxu Jia

Add checksum files required for the NSS softoken to operate in FIPS 140 mode. The shlibsign is invoked to sign the libraries, and it is built for the target architecture and doesn't support cross-compiling so far.

Invoke shlibsign at target's first boot time to generate checksum files.

As NSS depends on nss-native, can't you use that? The bug you link to implies that's what someone else has done when building NSS for iOS.

Ross

author
#13 lore raw

Re: [PATCH 4/5] nss: create checksum files for the nss libraries

Quoted 8 lines · Ross
Quoted 5 lines · Hongxu Jia

Add checksum files required for the NSS softoken to operate in FIPS 140 mode. The shlibsign is invoked to sign the libraries, and it is built for the target architecture and doesn't support cross-compiling so far.

Invoke shlibsign at target's first boot time to generate checksum files.

As NSS depends on nss-native, can't you use that? The bug you link to implies that's what someone else has done when building NSS for iOS.

Yes, invoke 'certutil' to create a blank certificate at build time.

//Hongxu

Quoted 2 lines

Ross

author
#14 lore raw

PATCH v2 5/5 nss: fix incorrect shebang line of perl script

In reply to Hongxu Jia

Replace incorrect shebang line with `#!/usr/bin/perl'.

---
 .../files/nss-fix-incorrect-shebang-of-perl.patch  | 110 +++++++++++++++++++++
 meta/recipes-support/nss/nss.inc                   |   1 +
 2 files changed, 111 insertions(+)
 create mode 100644 meta/recipes-support/nss/files/nss-fix-incorrect-shebang-of-perl.patch
meta/recipes-support/nss/files/nss-fix-incorrect-shebang-of-perl.patch new file +110 -0
new file mode 100644
index 0000000..ae2a6e5
@@ -0,0 +1,110 @@
+nss: fix incorrect shebang of perl
+
+Replace incorrect shebang of perl with `#!/usr/bin/perl'.
+
+Signed-off-by: Hongxu Jia <[email protected]>
+Upstream-Status: Pending
+---
+ nss/cmd/smimetools/smime  | 2 +-
+ nss/coreconf/cpdist.pl    | 2 +-
+ nss/coreconf/import.pl    | 2 +-
+ nss/coreconf/jniregen.pl  | 2 +-
+ nss/coreconf/outofdate.pl | 2 +-
+ nss/coreconf/release.pl   | 2 +-
+ nss/coreconf/version.pl   | 2 +-
+ nss/tests/clean_tbx       | 2 +-
+ nss/tests/path_uniq       | 2 +-
+ 9 files changed, 9 insertions(+), 9 deletions(-)
+
+diff --git a/nss/cmd/smimetools/smime b/nss/cmd/smimetools/smime
+--- a/nss/cmd/smimetools/smime
++++ b/nss/cmd/smimetools/smime
+@@ -1,4 +1,4 @@
+-#!/usr/local/bin/perl
++#!/usr/bin/perl
+ 
+ # This Source Code Form is subject to the terms of the Mozilla Public
+ # License, v. 2.0. If a copy of the MPL was not distributed with this
+diff --git a/nss/coreconf/cpdist.pl b/nss/coreconf/cpdist.pl
+index 800edfb..652187f 100755
+--- a/nss/coreconf/cpdist.pl
++++ b/nss/coreconf/cpdist.pl
+@@ -1,4 +1,4 @@
+-#! /usr/local/bin/perl
++#!/usr/bin/perl
+ #
+ # This Source Code Form is subject to the terms of the Mozilla Public
+ # License, v. 2.0. If a copy of the MPL was not distributed with this
+diff --git a/nss/coreconf/import.pl b/nss/coreconf/import.pl
+index dd2d177..428eaa5 100755
+--- a/nss/coreconf/import.pl
++++ b/nss/coreconf/import.pl
+@@ -1,4 +1,4 @@
+-#! /usr/local/bin/perl
++#!/usr/bin/perl
+ #
+ # This Source Code Form is subject to the terms of the Mozilla Public
+ # License, v. 2.0. If a copy of the MPL was not distributed with this
+diff --git a/nss/coreconf/jniregen.pl b/nss/coreconf/jniregen.pl
+index 2039180..5f4f69c 100755
+--- a/nss/coreconf/jniregen.pl
++++ b/nss/coreconf/jniregen.pl
+@@ -1,4 +1,4 @@
+-#!/usr/local/bin/perl
++#!/usr/bin/perl
+ #
+ # This Source Code Form is subject to the terms of the Mozilla Public
+ # License, v. 2.0. If a copy of the MPL was not distributed with this
+diff --git a/nss/coreconf/outofdate.pl b/nss/coreconf/outofdate.pl
+index 33d80bb..01fc097 100755
+--- a/nss/coreconf/outofdate.pl
++++ b/nss/coreconf/outofdate.pl
+@@ -1,4 +1,4 @@
+-#!/usr/local/bin/perl
++#!/usr/bin/perl
+ #
+ # This Source Code Form is subject to the terms of the Mozilla Public
+ # License, v. 2.0. If a copy of the MPL was not distributed with this
+diff --git a/nss/coreconf/release.pl b/nss/coreconf/release.pl
+index 7cde19d..b5df2f6 100755
+--- a/nss/coreconf/release.pl
++++ b/nss/coreconf/release.pl
+@@ -1,4 +1,4 @@
+-#! /usr/local/bin/perl
++#!/usr/bin/perl
+ #
+ # This Source Code Form is subject to the terms of the Mozilla Public
+ # License, v. 2.0. If a copy of the MPL was not distributed with this
+diff --git a/nss/coreconf/version.pl b/nss/coreconf/version.pl
+index d2a4942..79359fe 100644
+--- a/nss/coreconf/version.pl
++++ b/nss/coreconf/version.pl
+@@ -1,4 +1,4 @@
+-#!/usr/sbin/perl
++#!/usr/bin/perl
+ #
+ # This Source Code Form is subject to the terms of the Mozilla Public
+ # License, v. 2.0. If a copy of the MPL was not distributed with this
+diff --git a/nss/tests/clean_tbx b/nss/tests/clean_tbx
+index 4de9555..a7def9f 100755
+--- a/nss/tests/clean_tbx
++++ b/nss/tests/clean_tbx
+@@ -1,4 +1,4 @@
+-#! /bin/perl
++#!/usr/bin/perl
+ 
+ #######################################################################
+ #
+diff --git a/nss/tests/path_uniq b/nss/tests/path_uniq
+index f29f60a..08fbffa 100755
+--- a/nss/tests/path_uniq
++++ b/nss/tests/path_uniq
+@@ -1,4 +1,4 @@
+-#! /bin/perl
++#!/usr/bin/perl
+ 
+ ########################################################################
+ #
+-- 
+1.8.1.2
+
meta/recipes-support/nss/nss.inc +1 -0
index 4270743..e2f3891 100644
@@ -15,6 +15,7 @@ LIC_FILES_CHKSUM = "file://nss/lib/freebl/mpi/doc/LICENSE;md5=491f158d09d948466a
 SRC_URI = "\
     file://nss-fix-support-cross-compiling.patch \
     file://nss-no-rpath-for-cross-compiling.patch \
+    file://nss-fix-incorrect-shebang-of-perl.patch \
 "
 SRC_URI_append_class-target += "\
     file://nss.pc.in \
Signature · 1 line
1.8.1.2
#15 lore raw

Re: [PATCH 5/5] nss: fix incorrect shebang line of perl script

Quoted 1 line · Hongxu Jia

Replace incorrect shebang line with `#!/usr/bin/perl'.

I thought using 'env' was the preferred method?

author
#16 lore raw

Re: [PATCH 5/5] nss: fix incorrect shebang line of perl script

Quoted 4 lines · Trevor Woerner
Quoted 1 line · Hongxu Jia

Replace incorrect shebang line with `#!/usr/bin/perl'.

I thought using 'env' was the preferred method?

If use 'env', should we add 'coreutils' on nss's DEPENDS? The coreutils provides env.

//Hongxu

#17 lore raw

Re: [PATCH 5/5] nss: fix incorrect shebang line of perl script

Quoted 8 lines · On Thursday 11 July 2013 16:58:15 Hongxu Jia wrote:
Quoted 4 lines · Trevor Woerner
Quoted 1 line · Hongxu Jia

Replace incorrect shebang line with `#!/usr/bin/perl'.

I thought using 'env' was the preferred method?

If use 'env', should we add 'coreutils' on nss's DEPENDS? The coreutils provides env.

Our busybox configuration enables its version of env as well. I think it's pretty safe to assume this is available without the need for additional dependencies.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
author
#18 lore raw

Re: [PATCH 5/5] nss: fix incorrect shebang line of perl script

Quoted 10 lines · Paul Eggleton
Quoted 6 lines · On Thursday 11 July 2013 16:58:15 Hongxu Jia wrote:
Quoted 3 lines · Trevor Woerner
Quoted 1 line · Hongxu Jia

Replace incorrect shebang line with `#!/usr/bin/perl'.

I thought using 'env' was the preferred method?

If use 'env', should we add 'coreutils' on nss's DEPENDS? The coreutils provides env.

Our busybox configuration enables its version of env as well. I think it's pretty safe to assume this is available without the need for additional dependencies.

Got it, use 'env' and without additional dependencies, I will fix this.

Thanks
Hongxu

Quoted 3 lines

Cheers,
Paul

author
#19 lore raw

v3 cover add nss for LSB library check (cover letter only)

In reply to Hongxu Jia

Change in V3:
1) Replace incorrect shebang line with `#!/usr/bin/env perl'.

Change in V2:
1) Rename the title of patch 1/5
2) Use ${libdir} rather than ${base_libdir} as the lib location which references the nss in meta-browser.

The following changes since commit dc86293f0444384e8ae5131fdd10b6cb077164b0:

bitbake: HOB:Proper handle of SIGINT (2013-07-05 15:52:48 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib hongxu/fix-nss
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-nss

Hongxu Jia (5):
nspr: add native version
packagegroup-core-lsb: add nss for LSB library check
nss: add version 3.15.1
nss: create checksum files for the nss libraries
nss: fix incorrect shebang line of perl script

 .../packagegroups/packagegroup-core-lsb.bb         |   1 +
 meta/recipes-support/nspr/nspr_4.10.bb             |   2 +
 .../files/nss-fix-incorrect-shebang-of-perl.patch  | 110 ++++++++++++
 .../files/nss-fix-support-cross-compiling.patch    |  71 ++++++++
 .../files/nss-no-rpath-for-cross-compiling.patch   |  26 +++
 meta/recipes-support/nss/files/nss.pc.in           |  11 ++
 meta/recipes-support/nss/files/signlibs.sh         |  20 +++
 meta/recipes-support/nss/nss.inc                   | 187 +++++++++++++++++++++
 meta/recipes-support/nss/nss_3.15.1.bb             |   9 +
 9 files changed, 437 insertions(+)
 create mode 100644 meta/recipes-support/nss/files/nss-fix-incorrect-shebang-of-perl.patch
 create mode 100644 meta/recipes-support/nss/files/nss-fix-support-cross-compiling.patch
 create mode 100644 meta/recipes-support/nss/files/nss-no-rpath-for-cross-compiling.patch
 create mode 100644 meta/recipes-support/nss/files/nss.pc.in
 create mode 100644 meta/recipes-support/nss/files/signlibs.sh
 create mode 100644 meta/recipes-support/nss/nss.inc
 create mode 100644 meta/recipes-support/nss/nss_3.15.1.bb

-- 1.8.1.2