Skip to contentSkip to conversation

2.6.16-rc1-mm4

DISCUSSION Chuck Ebbert 3 participants 3 messages Feb 1, 2006 – Feb 2, 2006

lore
Share & tools
lore
#0 lore raw

In-Reply-To: <[email protected]>

 $ perl scripts/reference_init.pl | grep smp_locks
 Error: ./arch/i386/kernel/alternative.o .smp_locks refers to 00000008 R_386_32          .init.text
 Error: ./arch/i386/kernel/apic.o .smp_locks refers to 00000000 R_386_32          .init.text
 Error: ./arch/i386/kernel/apic.o .smp_locks refers to 00000010 R_386_32          .init.text
 Error: ./arch/i386/kernel/apic.o .smp_locks refers to 00000014 R_386_32          .init.text
 Error: ./arch/i386/kernel/cpu/amd.o .smp_locks refers to 00000000 R_386_32          .init.text
 Error: ./arch/i386/kernel/cpu/amd.o .smp_locks refers to 00000004 R_386_32          .init.text
 Error: ./arch/i386/kernel/cpu/amd.o .smp_locks refers to 00000008 R_386_32          .init.text
 Error: ./arch/i386/kernel/cpu/amd.o .smp_locks refers to 0000000c R_386_32          .init.text
 Error: ./arch/i386/kernel/cpu/amd.o .smp_locks refers to 00000010 R_386_32          .init.text
 Error: ./arch/i386/kernel/cpu/amd.o .smp_locks refers to 00000014 R_386_32          .init.text
 Error: ./arch/i386/kernel/cpu/amd.o .smp_locks refers to 00000018 R_386_32          .init.text
 Error: ./arch/i386/kernel/cpu/centaur.o .smp_locks refers to 00000000 R_386_32          .init.text
 Error: ./arch/i386/kernel/cpu/centaur.o .smp_locks refers to 00000004 R_386_32          .init.text
 ...

Caused by x86_smp_alternatives.patch

Does this mean that the SMP lock-switching could write all over discarded __init code?

Signature · 1 line
Chuck
#1 lore raw
Quoted 10 lines · Chuck Ebbert (on Tue, 31 Jan 2006 21:44:20 -0500) wrote:

In-Reply-To: <[email protected]>

$ perl scripts/reference_init.pl | grep smp_locks
Error: ./arch/i386/kernel/alternative.o .smp_locks refers to 00000008 R_386_32          .init.text
...

Caused by x86_smp_alternatives.patch

Does this mean that the SMP lock-switching could write all over discarded __init code?

Looking at the patch, it builds tables that can refer to .init.text but then it excludes table entries that do not fall between _text and _etext. Which makes the reference from .smp_locks to .init.text a false positive. Gerd, is that the way that smp_alternatives is meant to work? If so, I will update reference_*.pl.

+ alternatives_smp_module_add(NULL, "core kernel",
+ __smp_locks, __smp_locks_end,
+ _text, _etext);

#2 lore raw
Quoted 6 lines · Keith Owens
Quoted 1 line · Chuck Ebbert (on Tue, 31 Jan 2006 21:44:20 -0500) wrote:

Error: ./arch/i386/kernel/alternative.o .smp_locks refers to 00000008 R_386_32 .init.text

Looking at the patch, it builds tables that can refer to .init.text but then it excludes table entries that do not fall between _text and _etext.

Yep. The same goes for modules where the patch also keeps track of the .text section ranges to avoid accessing __init regions which might have been released meanwhile.

cheers,

Gerd

Signature · 3 lines
Gerd 'just married' Hoffmann <[email protected]>
I'm the hacker formerly known as Gerd Knorr.
http://www.suse.de/~kraxel/just-married.jpeg