soc: versatile: Add terminating entry for realview_soc_of_match
PATCH 1/1 soc: versatile: Add terminating entry for realview_soc_of_match
The of_device_id table is supposed to be zero-terminated.
--- drivers/soc/versatile/soc-realview.c | 1 + 1 file changed, 1 insertion(+)
drivers/soc/versatile/soc-realview.c +1 -0
@@ -26,6 +26,7 @@ static const struct of_device_id realview_soc_of_match[] = { { .compatible = "arm,realview-pb11mp-soc", }, { .compatible = "arm,realview-pba8-soc", }, { .compatible = "arm,realview-pbx-soc", }, + { } }; static u32 realview_coreid;
Signature · 1 line
1.9.1
Quoted 3 lines · Axel Lin
The
of_device_idtable is supposed to be zero-terminated.Signed-off-by Axel Lin <[email protected]>
Arnd are you merging this directly into ARM SoC?
Yours,
Linus Walleij
Arnd Bergmann
AppliedQuoted 10 lines · On Monday 20 October 2014 14:37:04 Linus Walleij wrote:
Quoted 3 lines · Axel Lin
The
of_device_idtable is supposed to be zero-terminated.Signed-off-by Axel Lin <[email protected]>Acked-by Linus Walleij <[email protected]>Arnd are you merging this directly into ARM SoC?
Applied to the fixes branch.
Please remember to add [email protected] when you want us to pick up the patches.
Arnd
Quoted 5 lines
Quoted 3 lines
Arnd are you merging this directly into ARM SoC?
Applied to the fixes branch.
Thanks.
Quoted 3 lines
Please remember to add [email protected] when you want us to pick up the patches.
scripts/get_maintainer.pl does not suggest [email protected] for this patch.
$ scripts/get_maintainer.pl 0001-soc-versatile-Add-terminating-entry-for-realview_soc.patch Linus Walleij <[email protected]> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:144/144=100%) Arnd Bergmann <[email protected]> (commit_signer:1/1=100%) [email protected] (open list)
Maybe it needs update the maintainer entry?
Axel
Quoted 11 lines · On Wednesday 29 October 2014 08:48:11 Axel Lin wrote:
Quoted 5 lines
Quoted 3 lines
Arnd are you merging this directly into ARM SoC?
Applied to the fixes branch.
Thanks.
Quoted 3 lines
Please remember to add [email protected] when you want us to pick up the patches.
scripts/get_maintainer.pldoes not suggest [email protected] for this patch.
Quoted 8 lines
$ scripts/get_maintainer.pl 0001-soc-versatile-Add-terminating-entry-for-realview_soc.patch Linus Walleij <[email protected]> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:144/144=100%) Arnd Bergmann <[email protected]> (commit_signer:1/1=100%) [email protected] (open list)Maybe it needs update the maintainer entry?
We generally don't want developers other than subarch maintainers to send us stuff directly and we certainly don't want to be Cc'd on (literally, if you count every version in review) thousands of patches per kernel release.
My comment was directed at Linus, who has sent us the updates for vexpress recently and who was (rightfully) asking for the patch to be picked up.
Arnd