amd64_edac: add DRAM error injection logic using sysfs
I believe I failed to reply to ALL and replied only to the sender
doug t
Quoted 34 lines · Ingo Molnar
From: Ingo Molnar <[email protected]>
Subject: Re: [PATCH 20/21]amd64_edac: add DRAM error injection logic using sysfs
To: "Borislav Petkov" <[email protected]>
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Date: Wednesday, April 29, 2009, 12:17 PMQuoted 6 lines · Borislav Petkov
From: Doug Thompson <[email protected]>
Signed-off-by Doug Thompson <[email protected]>Signed-off-by Borislav Petkov <[email protected]>---
drivers/edac/amd64_edac.c| 287+++++++++++++++++++++++++++++++++++++++++++++
Quoted 1 line
1 files changed, 287 insertions(+), 0deletions(-)
Review
Quoted 2 lines
(quoted diff) +0
-0
b/drivers/edac/amd64_edac.cdrivers/edac/amd64_edac.c static ssize_t
Quoted 4 lines
index b1a7e8c..4d1076f 100644
drivers/edac/amd64_edac.c +0
-0@@ -4621,3 +4621,290 @@ static ssize_t
amd64_hole_show(struct mem_ctl_info *mci, char *data)Quoted 4 lines
#endif /* DEBUG */
+#ifdefCONFIG_EDAC_AMD64_OPTERON_ERROR_INJECTIONthis should be in a separate .c file under
drivers/edac/amd64/.
Quoted 7 lines
Introducing large #ifdef sections like that is not very clean. The
amd64_edac.cfile is _way_ too large at more than 5000 lines of
code.Ingo
If we broke this into a separate files, then there would be TWO (2) files: 1 for the source code of the routines and a 1 for the table entries which reference those routines. Is that then acceptable as well?
Same pattern applies to the DEBUG functions Info refers to in another thread: 2 separate files would be required as well.
2 files for Error Injection code
2 files for DEBUG controls
1 files for text mapping
and I assume all these would be included via an #include statement at their appropriate locations
thx
doug t
Quoted 57 lines · Doug Thompson
I believe I failed to reply to ALL and replied only to the sender
doug t
Quoted 34 lines · Ingo Molnar
From: Ingo Molnar <[email protected]>
Subject: Re: [PATCH 20/21]amd64_edac: add DRAM error injection logic using sysfs
To: "Borislav Petkov" <[email protected]>
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Date: Wednesday, April 29, 2009, 12:17 PMQuoted 6 lines · Borislav Petkov
From: Doug Thompson <[email protected]>
Signed-off-by Doug Thompson <[email protected]>Signed-off-by Borislav Petkov <[email protected]>---
drivers/edac/amd64_edac.c| 287+++++++++++++++++++++++++++++++++++++++++++++
Quoted 1 line
1 files changed, 287 insertions(+), 0deletions(-)
Review
Quoted 2 lines
(quoted diff) +0
-0
b/drivers/edac/amd64_edac.cdrivers/edac/amd64_edac.c static ssize_t
Quoted 4 lines
index b1a7e8c..4d1076f 100644
drivers/edac/amd64_edac.c +0
-0@@ -4621,3 +4621,290 @@ static ssize_t
amd64_hole_show(struct mem_ctl_info *mci, char *data)Quoted 4 lines
#endif /* DEBUG */
+#ifdefCONFIG_EDAC_AMD64_OPTERON_ERROR_INJECTIONthis should be in a separate .c file under
drivers/edac/amd64/.Quoted 7 lines
Introducing large #ifdef sections like that is not very clean. The
amd64_edac.cfile is _way_ too large at more than 5000 lines of
code.Ingo
If we broke this into a separate files, then there would be TWO
(2) files: 1 for the source code of the routines and a 1 for the table entries which reference those routines. Is that then acceptable as well?Same pattern applies to the DEBUG functions Info refers to in another thread: 2 separate files would be required as well.
Quoted 6 lines
2 files for Error Injection code
2 files for DEBUG controls
1 files for text mappingand I assume all these would be included via an #include statement at their appropriate locations
A Makefile might be more natural i think - that way the #ifdef turns into a makefile rule?
Ingo