Skip to contentSkip to conversation

Detect NVMe controller in recent MacBooks

PATCH New Daniel Roschka 3 participants 4 messages Feb 17, 2017 – Feb 21, 2017 NVMe

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Detect NVMe controller in recent MacBooks

Adds support for detection of the NVMe controller found in the following recent MacBooks:
- Retina MacBook 2016 (MacBook9,1)
- 13" MacBook Pro 2016 without Touch Bar (MacBook13,1)
- 13" MacBook Pro 2016 with Touch Bar (MacBook13,2)

Signed-off-by Daniel Roschka <danielroschka at phoenitydawn.de>
---
 drivers/nvme/host/pci.c | 1 +
 1 file changed, 1 insertion(+)
drivers/nvme/host/pci.c +1 -0
index 3faefabf339c..22401aeae96e 100644
@@ -2110,6 +2110,7 @@ static const struct pci_device_id nvme_id_table[] = {
                .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
        { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
        { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
+       { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
        { 0, }
 };
 MODULE_DEVICE_TABLE(pci, nvme_id_table);
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 Detect NVMe controller in recent MacBooks

Quoted 5 lines · Daniel Roschka

Adds support for detection of the NVMe controller found in the following recent MacBooks:
- Retina MacBook 2016 (MacBook9,1)
- 13" MacBook Pro 2016 without Touch Bar (MacBook13,1)
- 13" MacBook Pro 2016 with Touch Bar (MacBook13,2)

This looks fine to me:

Reviewed-by Christoph Hellwig <hch at lst.de>

Just curious: what class code do the Apple controllers display?

#2 lore raw

PATCH 1/1 Detect NVMe controller in recent MacBooks

Quoted 1 line · On Sunday, 19. February 2017, 17:12:08 CET you wrote:

Just curious: what class code do the Apple controllers display?

They use 0x018002. My guess is that that's just a typo and they meant 0x010802 instead.