TODO list for staging/r8188eu
Dear Larry, Philip,
From what I understand how the development process works, drivers in staging should have a to-do list in the TODO file. Please read https://www.kernel.org/
doc/html/latest/process/2.Process.html?highlight=todo#staging-trees.
Could you (as the maintainers of the r8188eu driver) please compile and provide the above mentioned list?
Thanks,
Fabio
Greg Kroah-Hartman
maintainerQuoted 8 lines · Fabio M. De Francesco
Dear Larry, Philip,
Quoted 1 line
From what I understand how the development process works, drivers in staging
should have a to-do list in the TODO file. Please read https://www.kernel.org/
doc/html/latest/process/2.Process.html?highlight=todo#staging-trees.Could you (as the maintainers of the r8188eu driver) please compile and provide the above mentioned list?
Why don't you provide an initial list for people to work off of if you feel it is needed here?
thanks,
greg k-h
Quoted 4 lines · CEST Greg Kroah-Hartman
Quoted 3 lines · Fabio M. De Francesco
Dear Larry, Philip,
Quoted 1 line
From what I understand how the development process works, drivers in
staging
Quoted 2 lines
Quoted 2 lines
should have a to-do list in the TODO file. Please read https://
www.kernel.org/
Quoted 11 lines
Quoted 4 lines
doc/html/latest/process/2.Process.html?highlight=todo#staging-trees.
Could you (as the maintainers of the r8188eu driver) please compile and provide the above mentioned list?
Why don't you provide an initial list for people to work off of if you feel it is needed here?
thanks,
greg k-h
Unfortunately I'm not able to tell what is needed to do to have a driver improved so that it can be moved off staging. This work should be better addressed by someone who is much more experienced.
For example, I read from other drivers TODO lists that cfg80211 and lib80211 are required but I don't know what they are.
Regards,
Fabio
Greg Kroah-Hartman
maintainerQuoted 19 lines · Fabio M. De Francesco
Quoted 4 lines · CEST Greg Kroah-Hartman
Quoted 3 lines · Fabio M. De Francesco
Dear Larry, Philip,
Quoted 1 line
From what I understand how the development process works, drivers in
staging
Quoted 2 lines
Quoted 2 lines
should have a to-do list in the TODO file. Please read https://
www.kernel.org/
Quoted 10 lines
Quoted 4 lines
doc/html/latest/process/2.Process.html?highlight=todo#staging-trees.
Could you (as the maintainers of the r8188eu driver) please compile and provide the above mentioned list?
Why don't you provide an initial list for people to work off of if you feel it is needed here?
thanks,
Quoted 8 lines
Quoted 1 line
greg k-h
Unfortunately I'm not able to tell what is needed to do to have a driver improved so that it can be moved off staging. This work should be better addressed by someone who is much more experienced.
For example, I read from other drivers TODO lists that cfg80211 and lib80211 are required but I don't know what they are.
Those are two things that are also required here as well, like all in-kernel wifi drivers.
Quoted 26 lines · Fabio M. De Francesco
Quoted 4 lines · CEST Greg Kroah-Hartman
Quoted 3 lines · Fabio M. De Francesco
Dear Larry, Philip,
Quoted 1 line
From what I understand how the development process works, drivers in
staging
Quoted 2 lines
Quoted 2 lines
should have a to-do list in the TODO file. Please read https://
www.kernel.org/
Quoted 11 lines
Quoted 4 lines
doc/html/latest/process/2.Process.html?highlight=todo#staging-trees.
Could you (as the maintainers of the r8188eu driver) please compile and provide the above mentioned list?
Why don't you provide an initial list for people to work off of if you feel it is needed here?
thanks,
greg k-h
Unfortunately I'm not able to tell what is needed to do to have a driver improved so that it can be moved off staging. This work should be better addressed by someone who is much more experienced.
Quoted 9 lines
For example, I read from other drivers TODO lists that cfg80211 and lib80211 are required but I don't know what they are.
Regards,
Fabio
Dear Fabio,
I believe Larry is working on hooking up CFG80211 again (he mentioned going quite for a few days to work on it). As for other stuff that needs doing, a few things come to mind:
* Removal of dead code (whether or not this includes the debugging/printing macros is a matter of opinion, I would say yes personally) such as unusued functions, struct fields, etc.
* Correction of code styling in the kernel (e.g. there is a lot of camel case).
* Use of in-kernel functionality and removal of unnecessary wrappers where possible.
* Removal of the HAL layer and migration of its functionality into the driver as a whole - this is an important one I would argue.
There is likely to be lots of other items not on that list, but that would seem to be the basis of a TODO list if we need one?
Regards,
Phil
Quoted 50 lines · CEST Phillip Potter
Quoted 26 lines · Fabio M. De Francesco
Quoted 4 lines · CEST Greg Kroah-Hartman
Quoted 3 lines · Fabio M. De Francesco
Dear Larry, Philip,
Quoted 1 line
From what I understand how the development process works, drivers in
staging
Quoted 2 lines
Quoted 2 lines
should have a to-do list in the TODO file. Please read https://
www.kernel.org/
Quoted 11 lines
Quoted 4 lines
doc/html/latest/process/2.Process.html?highlight=todo#staging-trees.
Could you (as the maintainers of the r8188eu driver) please compile and provide the above mentioned list?
Why don't you provide an initial list for people to work off of if you feel it is needed here?
thanks,
greg k-h
Unfortunately I'm not able to tell what is needed to do to have a driver improved so that it can be moved off staging. This work should be better addressed by someone who is much more experienced.
Quoted 6 lines
For example, I read from other drivers TODO lists that cfg80211 and lib80211 are required but I don't know what they are.
Regards,
Fabio
Dear Fabio,
I believe Larry is working on hooking up CFG80211 again (he mentioned going quite for a few days to work on it). As for other stuff that needs doing, a few things come to mind:
* Removal of dead code (whether or not this includes the debugging/printing macros is a matter of opinion, I would say yes personally) such as unused functions, struct fields, etc.
* Correction of code styling in the kernel (e.g. there is a lot of camel case).
* Use of in-kernel functionality and removal of unnecessary wrappers where possible.
* Removal of the HAL layer and migration of its functionality into the driver as a whole - this is an important one I would argue.
Quoted 5 lines
There is likely to be lots of other items not on that list, but that would seem to be the basis of a TODO list if we need one?
Regards,
Phil
Dear Philip,
Thanks for this initial list. I suppose that every driver in staging should have it. If you like I could send a patch with the list you prepared, unless you prefer to make it yourself (since you wrote it). Please let me know what you prefer.
We shouldn't forget that from time to time new people decide to enter kernel hacking through staging. I think that a list could help all future newcomers.
Thanks,
Fabio
Quoted 64 lines · Fabio M. De Francesco
Quoted 50 lines · CEST Phillip Potter
Quoted 26 lines · Fabio M. De Francesco
Quoted 4 lines · CEST Greg Kroah-Hartman
Quoted 3 lines · Fabio M. De Francesco
Dear Larry, Philip,
Quoted 1 line
From what I understand how the development process works, drivers in
staging
Quoted 2 lines
Quoted 2 lines
should have a to-do list in the TODO file. Please read https://
www.kernel.org/
Quoted 11 lines
Quoted 4 lines
doc/html/latest/process/2.Process.html?highlight=todo#staging-trees.
Could you (as the maintainers of the r8188eu driver) please compile and provide the above mentioned list?
Why don't you provide an initial list for people to work off of if you feel it is needed here?
thanks,
greg k-h
Unfortunately I'm not able to tell what is needed to do to have a driver improved so that it can be moved off staging. This work should be better addressed by someone who is much more experienced.
Quoted 6 lines
For example, I read from other drivers TODO lists that cfg80211 and lib80211 are required but I don't know what they are.
Regards,
Fabio
Dear Fabio,
I believe Larry is working on hooking up CFG80211 again (he mentioned going quite for a few days to work on it). As for other stuff that needs doing, a few things come to mind:
* Removal of dead code (whether or not this includes the debugging/printing macros is a matter of opinion, I would say yes personally) such as unused functions, struct fields, etc.
* Correction of code styling in the kernel (e.g. there is a lot of camel case).
* Use of in-kernel functionality and removal of unnecessary wrappers where possible.
* Removal of the HAL layer and migration of its functionality into the driver as a whole - this is an important one I would argue.Quoted 5 lines
There is likely to be lots of other items not on that list, but that would seem to be the basis of a TODO list if we need one?
Regards,
PhilDear Philip,
Thanks for this initial list. I suppose that every driver in staging should have it. If you like I could send a patch with the list you prepared, unless you prefer to make it yourself (since you wrote it). Please let me know what you prefer.
Quoted 13 lines
We shouldn't forget that from time to time new people decide to enter kernel hacking through staging. I think that a list could help all future newcomers.
Thanks,
Fabio
Dear Fabio,
By all means feel free to submit this - there will be other stuff people will probably want to add to it also, that is just what I thought of so far. Many thanks.
Regards,
Phil