Skip to contentSkip to conversation

ath: Remove unneeded variable

PATCH In review Kalle Valo 3 participants 4 messages Jun 13, 2023 – Jun 14, 2023 2 messages not in the archive Qualcomm Atheros ATH9K wireless driver

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

Kalle Valo

author
#2 lore raw
Quoted 5 lines · [email protected] writes:

Fix the following coccicheck warning:

drivers/net/wireless/ath/ath9k/gpio.c:501:5-8: Unneeded variable: "len".

No HTML emails, our lists drop those automatically. Please use 'git send-email', more info in the wiki below.

This is not the first time I'm commenting about this for a patch from 208suo.com:

https://lore.kernel.org/linux-wireless/[email protected]/

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#3 lore raw

PATCH 1/1 ath: Remove unneeded variable

In reply to a message not in the archive

Fix the following coccicheck warning:

drivers/net/wireless/ath/ath9k/gpio.c:501:5-8: Unneeded variable: "len".

---
 drivers/net/wireless/ath/ath9k/gpio.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/wireless/ath/ath9k/gpio.c +1 -2
index b457e52dd365..f3d1bc02e633 100644
@@ -498,14 +498,13 @@ static int ath9k_dump_legacy_btcoex(struct ath_softc *sc, u8 *buf, u32 size)
 {
 
     struct ath_btcoex *btcoex = &sc->btcoex;
-    u32 len = 0;
 
     ATH_DUMP_BTCOEX("Stomp Type", btcoex->bt_stomp_type);
     ATH_DUMP_BTCOEX("BTCoex Period (msec)", btcoex->btcoex_period);
     ATH_DUMP_BTCOEX("Duty Cycle", btcoex->duty_cycle);
     ATH_DUMP_BTCOEX("BT Wait time", btcoex->bt_wait_time);
 
-    return len;
+    return 0;
 }
 
 int ath9k_dump_btcoex(struct ath_softc *sc, u8 *buf, u32 size)
author
#4 lore raw
Quoted 8 lines · [email protected] writes:

Fix the following coccicheck warning:

drivers/net/wireless/ath/ath9k/gpio.c:501:5-8: Unneeded variable: "len".

---
 drivers/net/wireless/ath/ath9k/gpio.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

The "wifi: ath9k:" prefix is missing from the title. And also try to make titles unique so something like this:

"wifi: ath9k: remove unneeded variable from ath9k_dump_legacy_btcoex()"

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#5 lore raw
In reply to [email protected]

Hi Mingtong,

Quoted 4 lines · On Wed, Jun 14, 2023 at 1:23 PM <[email protected]> wrote:

Fix the following coccicheck warning:

drivers/net/wireless/ath/ath9k/gpio.c:501:5-8: Unneeded variable: "len".

Coccinelle / Coccicheck is unable to accurately detect unused variables as it can only analyse the code as it is written and doesn't, for example, expand macros. This produces false positives like the one you're trying to fix in this patch.

Quoted 11 lines
---
  drivers/net/wireless/ath/ath9k/gpio.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/wireless/ath/ath9k/gpio.c +0 -0
index b457e52dd365..f3d1bc02e633 100644

drivers/net/wireless/ath/ath9k/gpio.c static int ath9k_dump_legacy_btcoex(struct · line 503

Quoted 7 lines
drivers/net/wireless/ath/ath9k/gpio.c +0 -1
@@ -498,14 +498,13 @@ static int ath9k_dump_legacy_btcoex(struct
 ath_softc *sc, u8 *buf, u32 size)
  {
 
      struct ath_btcoex *btcoex = &sc->btcoex;
-    u32 len = 0;
 
      ATH_DUMP_BTCOEX("Stomp Type", btcoex->bt_stomp_type);

ATH_DUMP_BTCOEX() is a macro that relies on a bunch of local variables being defined, one of which is "len". If you'd compiled this code, you would have spotted this problem immediately.

A "correct" solution to the "problem" here might be to add the local variables to the macro parameters or move the definition of the macro closer to where it's used so it's more obvious that some "magic" is going on here.

As others have said, you need to fully understand what code is doing before producing these sorts of cleanups, otherwise you'll produce incorrect patches like this one.

Thanks,

Signature · 4 lines
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/