xen: unexport __init-annotated xen_xlate_map_ballooned_pages()
PATCH 1/1 xen: unexport __init-annotated xen_xlate_map_ballooned_pages()
EXPORT_SYMBOL and __init is a bad combination because the .init.text section is freed up after the initialization. Hence, modules cannot use symbols annotated __init. The access to a freed symbol may end up with kernel panic.
modpost used to detect it, but it has been broken for a decade.
Recently, I fixed modpost so it started to warn it again, then this showed up in linux-next builds.
There are two ways to fix it:
- Remove __init
- Remove EXPORT_SYMBOL
I chose the latter for this case because none of the in-tree call-sites (arch/arm/xen/enlighten.c, arch/x86/xen/grant-table.c) is compiled as modular.
---
drivers/xen/xlate_mmu.c | 1 - 1 file changed, 1 deletion(-)
drivers/xen/xlate_mmu.c +0 -1
@@ -261,7 +261,6 @@ int __init xen_xlate_map_ballooned_pages(xen_pfn_t **gfns, void **virt,return 0 ; } -EXPORT_SYMBOL_GPL (xen_xlate_map_ballooned_pages);struct remap_pfn {struct mm_struct *mm;
Signature · 1 line
2.32.0
On 06.06.22 07:59, Masahiro Yamada wrote:
Hello
Quoted 10 lines
EXPORT_SYMBOLand__initis a bad combination because the .init.text section is freed up after the initialization. Hence, modules cannot use symbols annotated__init. The access to a freed symbol may end up with kernel panic.modpost used to detect it, but it has been broken for a decade.
Recently, I fixed modpost so it started to warn it again, then this showed up in linux-next builds.
Quoted 8 lines
There are two ways to fix it:
- Remove
__init
- RemoveEXPORT_SYMBOLI chose the latter for this case because none of the in-tree call-sites (
arch/arm/xen/enlighten.c,arch/x86/xen/grant-table.c) is compiled as modular.
Good description.
Quoted 4 lines
Fixes 243848fc018c ("xen/grant-table: Move xlated_setup_gnttab_pages to common place")Reported-by Stephen Rothwell <[email protected]>Signed-off-by Masahiro Yamada <[email protected]>
I think the patch is correct.
Quoted 17 lines
---
drivers/xen/xlate_mmu.c | 1 - 1 file changed, 1 deletion(-)drivers/xen/xlate_mmu.c +0
-1@@ -261,7 +261,6 @@ int __init xen_xlate_map_ballooned_pages(xen_pfn_t **gfns, void **virt,return 0 ; } -EXPORT_SYMBOL_GPL (xen_xlate_map_ballooned_pages);struct remap_pfn {struct mm_struct *mm;
Signature · 3 lines
Regards, Oleksandr Tyshchenko
Quoted 27 lines · Oleksandr
On 06.06.22 07:59, Masahiro Yamada wrote:
Hello
Quoted 10 lines
EXPORT_SYMBOLand__initis a bad combination because the .init.text section is freed up after the initialization. Hence, modules cannot use symbols annotated__init. The access to a freed symbol may end up with kernel panic.modpost used to detect it, but it has been broken for a decade.
Recently, I fixed modpost so it started to warn it again, then this showed up in linux-next builds.
Quoted 8 lines
There are two ways to fix it:
- Remove
__init
- RemoveEXPORT_SYMBOLI chose the latter for this case because none of the in-tree call-sites (
arch/arm/xen/enlighten.c,arch/x86/xen/grant-table.c) is compiled as modular.Good description.
Quoted 1 line
Quoted 8 lines
Quoted 4 lines
Fixes 243848fc018c ("xen/grant-table: Move xlated_setup_gnttab_pages tocommon place")
Reported-by Stephen Rothwell <[email protected]>Signed-off-by Masahiro Yamada <[email protected]>I think the patch is correct.
Reviewed-by Oleksandr Tyshchenko <[email protected]>
Quoted 22 lines
Quoted 16 lines
---
drivers/xen/xlate_mmu.c | 1 - 1 file changed, 1 deletion(-)drivers/xen/xlate_mmu.c +0
-1@@ -261,7 +261,6 @@ int __init xen_xlate_map_ballooned_pages(xen_pfn_t **gfns, void **virt, return 0; } -EXPORT_SYMBOL_GPL (xen_xlate_map_ballooned_pages);struct remap_pfn {struct mm_struct *mm;Signature · 3 lines
Regards, Oleksandr Tyshchenko
Quoted 15 lines · Masahiro Yamada
EXPORT_SYMBOLand__initis a bad combination because the .init.text section is freed up after the initialization. Hence, modules cannot use symbols annotated__init. The access to a freed symbol may end up with kernel panic.modpost used to detect it, but it has been broken for a decade.
Recently, I fixed modpost so it started to warn it again, then this showed up in linux-next builds.
There are two ways to fix it:
- Remove
__init
- RemoveEXPORT_SYMBOL
Quoted 7 lines
I chose the latter for this case because none of the in-tree call-sites (
arch/arm/xen/enlighten.c,arch/x86/xen/grant-table.c) is compiled as modular.Fixes 243848fc018c ("xen/grant-table: Move xlated_setup_gnttab_pages to common place")Reported-by Stephen Rothwell <[email protected]>Signed-off-by Masahiro Yamada <[email protected]>
Pushed to xen/tip.git for-linus-5.19a
Juergen