Skip to contentSkip to conversation

dt-bindings: edac: Add Altera SOCFPGA SDRAM EDAC binding

PATCH In review Alessandro Zanni 2 participants 4 messages Aug 1, 2024 – Aug 4, 2024 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 dt-bindings: edac: Add Altera SOCFPGA SDRAM EDAC binding

Convert the device tree bindings for the Altera PCIe MSI controller

---

Notes:
v3: moved yaml file from arm/altera to the edac folder, removed items keys, added general node names

 .../arm/altera/socfpga-sdram-edac.txt         | 15 -------
 .../bindings/edac/altr,sdram-edac.yaml        | 44 +++++++++++++++++++
 2 files changed, 44 insertions(+), 15 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.txt
 create mode 100644 Documentation/devicetree/bindings/edac/altr,sdram-edac.yaml
Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.txt deleted +0 -15
deleted file mode 100644
index f5ad0ff69fae..000000000000
@@ -1,15 +0,0 @@
-Altera SOCFPGA SDRAM Error Detection & Correction [EDAC]
-The EDAC accesses a range of registers in the SDRAM controller.
-
-Required properties:
-- compatible : should contain "altr,sdram-edac" or "altr,sdram-edac-a10"
-- altr,sdr-syscon : phandle of the sdr module
-- interrupts : Should contain the SDRAM ECC IRQ in the
-	appropriate format for the IRQ controller.
-
-Example:
-	sdramedac {
-		compatible = "altr,sdram-edac";
-		altr,sdr-syscon = <&sdr>;
-		interrupts = <0 39 4>;
-	};
Documentation/devicetree/bindings/edac/altr,sdram-edac.yaml new file +44 -0

44 lines not on this page · raw message

Signature · 1 line
2.43.0
#1 lore raw
Quoted 5 lines · Alessandro Zanni

Convert the device tree bindings for the Altera PCIe MSI controller

---

Subject: you did not add binding in this patch. Binding was already there. You converted one to DT schema.

Quoted 3 lines

Notes:
v3: moved yaml file from arm/altera to the edac folder, removed items keys, added general node names

...

Documentation/devicetree/bindings/edac/altr,sdram-edac.yaml line 41

Quoted 7 lines
Documentation/devicetree/bindings/edac/altr,sdram-edac.yaml new file +7 -0
+
+examples:
+  - |
+    memory-controller {
+      compatible = "altr,sdram-edac";
+      altr,sdr-syscon = <&sdr>;
+      interrupts = <0 39 4>;

No improvements here.

<form letter>
This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them.

Thank you.
</form letter>

Best regards,
Krzysztof

#2 lore raw

Thank you for the review.

This patch aims to be a conversion from txt file "bindings/arm/altera/socfpga-sdram-edac.txt" to this "bindings/edac/altr,sdram-edac.yaml" file. That's why I also deleted the txt file in the patch.

Maybe I should have put a different title to make it clearer.

This is the original example in the txt file:

sdramedac {
    compatible = "altr,sdram-edac";
    altr,sdr-syscon = <&sdr>;
    interrupts = <0 39 4>;

and this is my conversion:

Documentation/devicetree/bindings/edac/altr,sdram-edac.yaml line 41

Quoted 5 lines
Documentation/devicetree/bindings/edac/altr,sdram-edac.yaml new file +5 -0
+  - |
+    memory-controller {
+      compatible = "altr,sdram-edac";
+      altr,sdr-syscon = <&sdr>;
+      interrupts = <0 39 4>;

Sorry for that but, to me, it's not clear what I should convert in this example to complete the yaml file.

Best regards,
Alessandro

Il giorno ven 2 ago 2024 alle ore 08:54 Krzysztof Kozlowski <[email protected]> ha scritto:

Quoted 43 lines · Alessandro Zanni
Quoted 5 lines

Convert the device tree bindings for the Altera PCIe MSI controller

---

Subject: you did not add binding in this patch. Binding was already there. You converted one to DT schema.

Quoted 3 lines

Notes:
v3: moved yaml file from arm/altera to the edac folder, removed items keys, added general node names

...

Documentation/devicetree/bindings/edac/altr,sdram-edac.yaml line 41

Quoted 7 lines
Documentation/devicetree/bindings/edac/altr,sdram-edac.yaml new file +7 -0
+
+examples:
+  - |
+    memory-controller {
+      compatible = "altr,sdram-edac";
+      altr,sdr-syscon = <&sdr>;
+      interrupts = <0 39 4>;

No improvements here.

<form letter>
This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them.

Thank you.
</form letter>

Best regards,
Krzysztof

#3 lore raw
Quoted 16 lines · Alessandro Zanni

Thank you for the review.

This patch aims to be a conversion from txt file "bindings/arm/altera/socfpga-sdram-edac.txt" to this "bindings/edac/altr,sdram-edac.yaml" file. That's why I also deleted the txt file in the patch.

Maybe I should have put a different title to make it clearer.

This is the original example in the txt file:

sdramedac {
    compatible = "altr,sdram-edac";
    altr,sdr-syscon = <&sdr>;
    interrupts = <0 39 4>;

and this is my conversion:

Quoted 9 lines

Documentation/devicetree/bindings/edac/altr,sdram-edac.yaml line 41

Quoted 5 lines
Documentation/devicetree/bindings/edac/altr,sdram-edac.yaml new file +5 -0
+  - |
+    memory-controller {
+      compatible = "altr,sdram-edac";
+      altr,sdr-syscon = <&sdr>;
+      interrupts = <0 39 4>;

Sorry for that but, to me, it's not clear what I should convert in this example to complete the yaml file.

Don't top-post. I have no clue what you are referring to.

Best regards,
Krzysztof