drm/amdgpu: fix PSP autoload twice in FLR
Subsystems (2)
PATCH 1/1 drm/amdgpu: fix PSP autoload twice in FLR
the block->status.hw = false assignment will overwrite PSP's previous hw status, which will cause PSP execute resume operation after hw init.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +4 -1
@@ -2574,6 +2574,10 @@ static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev) AMD_IP_BLOCK_TYPE_IH, }; +for (i =0 ; i < adev->num_ip_blocks; i++) { + adev->ip_blocks[i].status.hw = false; + } +for (i =0 ; i <ARRAY_SIZE (ip_order); i++) {int j;struct amdgpu_ip_block *block;
@@ -2581,7 +2585,6 @@ static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev)for (j =0 ; j < adev->num_ip_blocks; j++) { block = &adev->ip_blocks[j]; - block->status.hw = false;if (block->version->type != ip_order[i] || !block->status.valid)continue ;
Signature · 6 lines
2.25.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 13 lines · Liu ChengZhe
the
block->status.hw= false assignment will overwrite PSP's previous hw status, which will cause PSP execute resume operation after hw init.Signed-off-by Liu ChengZhe <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev) · line 2580
Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +4
-0@@ -2574,6 +2574,10 @@ static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev) AMD_IP_BLOCK_TYPE_IH, }; +for (i =0 ; i < adev->num_ip_blocks; i++) { + adev->ip_blocks[i].status.hw = false; + } +
Braces surrounding a single statement block are unnecessary and "checkpatch" complains about it. Just remote the braces around a single statement block in loops.
Regards,
Luben
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev) · line 2590
Quoted 12 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0
-1for (i =0 ; i <ARRAY_SIZE (ip_order); i++) {int j;struct amdgpu_ip_block *block;@@ -2581,7 +2585,6 @@ static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev)for (j =0 ; j < adev->num_ip_blocks; j++) { block = &adev->ip_blocks[j]; - block->status.hw = false;if (block->version->type != ip_order[i] || !block->status.valid)continue ;
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx