net: Add missing __raw_write_seqcount_end() and seqcount_release()
PATCH 1/1 net: Add missing __raw_write_seqcount_end() and seqcount_release()
Hi Sebastian,
This patch fixes a problem [1] I saw when backporting 'net: Properly annotate the try-lock for the seqlock" from 5.4 to 4.19 which also looks like it should apply to -devel.
Thanks,
Tom
---
The patch ('net: Properly annotate the try-lock for the seqlock") adds __raw_write_seqcount_begin() in qdisc_run_begin() but omits the corresponding __raw_write_seqcount_end() and seqcount_release() in qdisc_run_end().
Add it unconditionally, since qdisc_run_end() is never called unless qdisc_run_begin() succeeds, and if it succeeds, __raw_write_seqcount_begin() seqcount_acquire() will have been called.
Signed-off-by Tom Zanussi <[email protected]>
--- include/net/sch_generic.h | 4 ++++ 1 file changed, 4 insertions(+)
include/net/sch_generic.h +4 -0
@@ -192,7 +192,11 @@ static inline bool qdisc_run_begin(struct Qdisc *qdisc)static inline void qdisc_run_end (struct Qdisc *qdisc) {#ifdef CONFIG_PREEMPT_RT +seqcount_t *s = &qdisc->running.seqcount; +write_sequnlock (&qdisc->running); +__raw_write_seqcount_end (s); +seqcount_release (&s->dep_map,1 , _RET_IP_);#else write_seqcount_end (&qdisc->running);#endif
Signature · 1 line
2.17.1