Skip to contentSkip to conversation

ipu3-cio2: Build bridge only if ACPI is enabled

PATCH In review Sakari Ailus 3 participants 5 messages Feb 2, 2021

Subsystems (3)
lore
Share & tools
lore

Sakari Ailus

author maintainer
#0 lore raw

PATCH 1/1 ipu3-cio2: Build bridge only if ACPI is enabled

ipu3-cio2-bridge uses several features of the ACPI framework that have no meaningful replacement when ACPI is disabled. Instead of adding #ifdefs to the affected places, only build the bridge code if CONFIG_ACPI is enabled.

Fixes 803abec64ef9 ("media: ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver")

---
Hi Randy,

Thanks for reporting this.

This patch should address the problem.

 drivers/media/pci/intel/ipu3/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/pci/intel/ipu3/Kconfig +1 -1
index 24f4e79fe0cb..dce8274c81e6 100644
@@ -20,7 +20,7 @@ config VIDEO_IPU3_CIO2
 
 config CIO2_BRIDGE
 	bool "IPU3 CIO2 Sensors Bridge"
-	depends on VIDEO_IPU3_CIO2
+	depends on VIDEO_IPU3_CIO2 && ACPI
 	help
 	  This extension provides an API for the ipu3-cio2 driver to create
 	  connections to cameras that are hidden in the SSDB buffer in ACPI.
Signature · 1 line
2.29.2
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Sakari Ailus

ipu3-cio2-bridge uses several features of the ACPI framework that have no meaningful replacement when ACPI is disabled. Instead of adding #ifdefs to the affected places, only build the bridge code if CONFIG_ACPI is enabled.

Fixes 803abec64ef9 ("media: ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver")

Thanks.

Quoted 24 lines

---
Hi Randy,

Thanks for reporting this.

This patch should address the problem.

 drivers/media/pci/intel/ipu3/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/pci/intel/ipu3/Kconfig +1 -1
index 24f4e79fe0cb..dce8274c81e6 100644
@@ -20,7 +20,7 @@ config VIDEO_IPU3_CIO2
 
 config CIO2_BRIDGE
 	bool "IPU3 CIO2 Sensors Bridge"
-	depends on VIDEO_IPU3_CIO2
+	depends on VIDEO_IPU3_CIO2 && ACPI
 	help
 	  This extension provides an API for the ipu3-cio2 driver to create
 	  connections to cameras that are hidden in the SSDB buffer in ACPI.
Signature · 1 line
~Randy
author maintainer
#2 lore raw
Quoted 10 lines · Randy Dunlap
Quoted 6 lines · Sakari Ailus

ipu3-cio2-bridge uses several features of the ACPI framework that have no meaningful replacement when ACPI is disabled. Instead of adding #ifdefs to the affected places, only build the bridge code if CONFIG_ACPI is enabled.

Fixes 803abec64ef9 ("media: ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver")

Thanks! I'll include this in a pull request to Mauro shortly.

Signature · 1 line
Sakari Ailus
#3 lore raw
Quoted 6 lines · Sakari Ailus
Quoted 5 lines · Randy Dunlap
Quoted 4 lines · Sakari Ailus

ipu3-cio2-bridge uses several features of the ACPI framework that have no meaningful replacement when ACPI is disabled. Instead of adding #ifdefs to the affected places, only build the bridge code if CONFIG_ACPI is enabled.

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Fixes 803abec64ef9 ("media: ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver")

Thanks! I'll include this in a pull request to Mauro shortly.

Ah - thank you both; sorry to have missed that.

author maintainer
#4 lore raw
Quoted 7 lines · Daniel Scally
Quoted 6 lines · Sakari Ailus
Quoted 5 lines · Randy Dunlap
Quoted 4 lines · Sakari Ailus

ipu3-cio2-bridge uses several features of the ACPI framework that have no meaningful replacement when ACPI is disabled. Instead of adding #ifdefs to the affected places, only build the bridge code if CONFIG_ACPI is enabled.

Quoted 7 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Fixes 803abec64ef9 ("media: ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver")

Thanks! I'll include this in a pull request to Mauro shortly.

Ah - thank you both; sorry to have missed that.

No worries; this was missed in review, too. There are just combinations you don't always end up testing before merging the patches.

Signature · 3 lines
Regards,

Sakari Ailus