bug in bonding driver
Subsystems (2)
Hi,
One of our guys pointed out what appears to be a bug in bond_ab_arp_inspect(). There's a chunk of code that looks like this:
/* * Give slaves 2*delta after being enslaved or made * active. This avoids bouncing, as the last receive * times need a full ARP monitor cycle to be updated. */ if (!time_after_eq(jiffies, slave->jiffies + 2 * delta_in_ticks)) continue;
The catch here is that slave->jiffies may not ever get updated after being set initially, and on long-running systems jiffies will overflow.
That could cause this check to be true for a substantial amount of time
rather than for just a short period.
One way to fix it would be a boolean which tracks whether or not we've gone past the time, and if we have then we don't bother actually checking the time anymore.
Chris
Quoted 12 lines · Chris Friesen
One of our guys pointed out what appears to be a bug in
bond_ab_arp_inspect(). There's a chunk of code that looks like this:/* * Give slaves 2*delta after being enslaved or made * active. This avoids bouncing, as the last receive * times need a full ARP monitor cycle to be updated. */ if (!time_after_eq(jiffies, slave->jiffies + 2 * delta_in_ticks)) continue;
Quoted 4 lines
The catch here is that
slave->jiffiesmay not ever get updated after being set initially, and on long-running systems jiffies will overflow. That could cause this check to be true for a substantial amount of time rather than for just a short period.
The definition for time_after in include/linux/jiffies.h claims
to handle timer wrapping, but even so, there presumably has to be a cutoff at which "after" becomes "before" again.
Some quick fooling around suggests that if, for example,slave->jiffies is near the top of the range (ULONG_MAX - a few hundred), when jiffies gets up to around ULONG_MAX / 2 time_after_eq will flip from "after" to "before."
I don't think this is a particularly farfetched example, since
jiffies is intentionally started near the top of the range, so slave->jiffies is likely to be high in the range after bonding is configured at boot.
Quoted 3 lines
One way to fix it would be a boolean which tracks whether or not we've gone past the time, and if we have then we don't bother actually checking the time anymore.
It might be clearer to make the slave->jiffies some kind of
countdown instead, perhaps reusing the slave->delay used for updelay/downdelay and eliminating slave->jiffies entirely.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [email protected]
Quoted 12 lines · Jay Vosburgh
Quoted 4 lines · Chris Friesen
The catch here is that
slave->jiffiesmay not ever get updated after being set initially, and on long-running systems jiffies will overflow. That could cause this check to be true for a substantial amount of time rather than for just a short period.Some quick fooling around suggests that if, for example,
slave->jiffiesis near the top of the range (ULONG_MAX- a few hundred), when jiffies gets up to aroundULONG_MAX/ 2time_after_eqwill flip from "after" to "before."
Quoted 4 lines
I don't think this is a particularly farfetched example, since
jiffies is intentionally started near the top of the range, soslave->jiffiesis likely to be high in the range after bonding is configured at boot.
Agreed. If I understand it right the result of time_after_eq is only valid if the result of the subtraction is less than LONG_MAX.
Quoted 7 lines
Quoted 3 lines
One way to fix it would be a boolean which tracks whether or not we've gone past the time, and if we have then we don't bother actually checking the time anymore.
It might be clearer to make the slave->jiffies some kind ofcountdown instead, perhaps reusing the
slave->delayused for updelay/downdelay and eliminatingslave->jiffiesentirely.
Yes, that seems reasonable as well.
Chris