mmc: sdhci-pci: Switch to use acpi_evaluate_dsm_typed()
PATCH 1/1 mmc: sdhci-pci: Switch to use acpi_evaluate_dsm_typed()
The acpi_evaluate_dsm_typed() provides a way to check the type of the object evaluated by _DSM call. Use it instead of open coded variant.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/mmc/host/sdhci-pci-core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/mmc/host/sdhci-pci-core.c +3 -2
@@ -483,11 +483,12 @@ static int __intel_dsm(struct intel_host *intel_host, struct device *dev,int err =0 ;size_t len; - obj =acpi_evaluate_dsm (ACPI_HANDLE (dev), &intel_dsm_guid,0 , fn,NULL ); + obj =acpi_evaluate_dsm_typed (ACPI_HANDLE (dev), &intel_dsm_guid,0 , fn,NULL , +ACPI_TYPE_BUFFER );if (!obj)return -EOPNOTSUPP ; -if (obj->type !=ACPI_TYPE_BUFFER || obj->buffer.length <1 ) { +if (obj->buffer.length <1 ) { err = -EINVAL ; goto out; }
Signature · 1 line
2.40.0.1.gaa8946217a0b
Quoted 4 lines · Andy Shevchenko
The
acpi_evaluate_dsm_typed()provides a way to check the type of the object evaluated by_DSMcall. Use it instead of open coded variant.Signed-off-by Andy Shevchenko <[email protected]>
Acked-by Adrian Hunter <[email protected]>
Quoted 23 lines
--- drivers/mmc/host/sdhci-pci-core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/mmc/host/sdhci-pci-core.c +3
-2@@ -483,11 +483,12 @@ static int __intel_dsm(struct intel_host *intel_host, struct device *dev,int err =0 ;size_t len; - obj =acpi_evaluate_dsm (ACPI_HANDLE (dev), &intel_dsm_guid,0 , fn,NULL ); + obj =acpi_evaluate_dsm_typed (ACPI_HANDLE (dev), &intel_dsm_guid,0 , fn,NULL , +ACPI_TYPE_BUFFER );if (!obj)return -EOPNOTSUPP ; -if (obj->type !=ACPI_TYPE_BUFFER || obj->buffer.length <1 ) { +if (obj->buffer.length <1 ) { err = -EINVAL ; goto out; }
Quoted 5 lines · Andy Shevchenko
The
acpi_evaluate_dsm_typed()provides a way to check the type of the object evaluated by_DSMcall. Use it instead of open coded variant.Signed-off-by Andy Shevchenko <[email protected]>
Applied for next, thanks!
Kind regards
Uffe
Quoted 26 lines
--- drivers/mmc/host/sdhci-pci-core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/mmc/host/sdhci-pci-core.c +3
-3@@ -483,11 +483,12 @@ static int __intel_dsm(struct intel_host *intel_host, struct device *dev,int err =0 ;size_t len; - obj =acpi_evaluate_dsm (ACPI_HANDLE (dev), &intel_dsm_guid,0 , fn,NULL ); + obj =acpi_evaluate_dsm_typed (ACPI_HANDLE (dev), &intel_dsm_guid,0 , fn,NULL , +ACPI_TYPE_BUFFER );if (!obj)return -EOPNOTSUPP ; -if (obj->type !=ACPI_TYPE_BUFFER || obj->buffer.length <1 ) { +if (obj->buffer.length <1 ) { err = -EINVAL ; goto out; } --2.40.0.1.gaa8946217a0b