Skip to contentSkip to conversation

buildtools/cmdline: fix meson error when used as a subproject

PATCH Applied Robin Jarry 3 participants 3 messages Aug 1, 2024 – Oct 11, 2024 Arm/Amlogic Meson SoC support

lore
Share & tools
lore

Robin Jarry

author
#0 lore raw

PATCH 1/1 buildtools/cmdline: fix meson error when used as a subproject

Fix the following error when using dpdk as a subproject:

subprojects/dpdk/buildtools/subproject/meson.build:28:56:
ERROR: Unknown function "file".

This was obviously never tested in its submitted form.

Cc [email protected]
Fixes 7d8c608faa7f ("buildtools/cmdline: allow using script in subproject")
Signed-off-by Robin Jarry <[email protected]>
---
 buildtools/subproject/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
buildtools/subproject/meson.build +1 -1
index 9ba94671bd0e..8ae081e1698a 100644
@@ -25,4 +25,4 @@ endif
 
 libdpdk_dep = dpdk_dep
 
-meson.override_find_program('dpdk-cmdline-gen.py', file('../dpdk-cmdline-gen.py'))
+meson.override_find_program('dpdk-cmdline-gen.py', files('../dpdk-cmdline-gen.py'))
Signature · 1 line
2.45.2
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Robin Jarry

Fix the following error when using dpdk as a subproject:

subprojects/dpdk/buildtools/subproject/meson.build:28:56:
ERROR: Unknown function "file".

Quoted 7 lines

This was obviously never tested in its submitted form.

Cc [email protected]
Fixes 7d8c608faa7f ("buildtools/cmdline: allow using script in subproject")
Signed-off-by Robin Jarry <[email protected]>

---

Good catch, and easy fix, thanks.

Interestingly, even without testing the build, vscode meson extension flags this issue in the "problems" tab of vscode: "Unknown function file"

Acked-by Bruce Richardson <[email protected]>
Applied
#2 lore raw

07/08/2024 15:43, Bruce Richardson:

Quoted 14 lines · Robin Jarry
Quoted 5 lines

Fix the following error when using dpdk as a subproject:

subprojects/dpdk/buildtools/subproject/meson.build:28:56:
ERROR: Unknown function "file".

Quoted 7 lines

This was obviously never tested in its submitted form.

Cc [email protected]
Fixes 7d8c608faa7f ("buildtools/cmdline: allow using script in subproject")
Signed-off-by Robin Jarry <[email protected]>

---

Quoted 6 lines

Good catch, and easy fix, thanks.

Interestingly, even without testing the build, vscode meson extension flags this issue in the "problems" tab of vscode: "Unknown function file"

Acked-by Bruce Richardson <[email protected]>

Applied, thanks.