Skip to contentSkip to conversation

docs/ja_JP/SubmittingPatches: Trace changes in English docs, take 1

PATCH In review Akira Yokosawa 4 participants 9 messages May 3, 2022 – May 9, 2022

Subsystems (2)
lore
Share & tools
lore

Akira Yokosawa

author reviewer
#0 lore raw

cover docs/ja_JP/SubmittingPatches: Trace changes in English docs, take 1

Hi,

This is the first batch of updates attempting to modernize Japanese SubmittingPatches. Conversion to ReST will be done later when the corresponding commit doing the conversion is reached. Pending list of commits is quite long (about 90) and this effort is expected to produce dozens of series.

List of commits for English (then) SubmittingPatches:

- f5039935ac68 ("Documentation: update GregKH links")
- e52d2e1f25f0 ("Documentation/SubmittingPatches: suggested the use of scripts/get_maintainer.pl")
- 755727b7fb1e ("Randy has moved")
- 8543ae1296f6 ("checkpatch: add Suggested-by as a standard signature")
- 0af5270324cc ("Documentation/SubmittingPatches: Request summaries for commit references")

Note: Commit db12fb833a88 ("Documentation: fix spelling error in SubmittingPatches") does not affect Japanese translation.

Thanks, Akira
--
Akira Yokosawa (5):
docs/ja_JP/SubmittingPatches: Update GregKH links docs/ja_JP/SubmittingPatches: Suggest the use of
scripts/get_maintainer.pl
docs/ja_JP/SubmittingPatches: Randy has moved docs/ja_JP/SubmittingPatches: Add Suggested-by as a standard signature docs/ja_JP/SubmittingPatches: Request summaries for commit references

 .../translations/ja_JP/SubmittingPatches      | 36 ++++++++++++++-----
 1 file changed, 27 insertions(+), 9 deletions(-)

base-commit: 81c653659d34ec253fba7f5d0f430813fe0f643d

Signature · 1 line
2.25.1
author reviewer
#1 lore raw

PATCH 1/5 docs/ja_JP/SubmittingPatches: Update GregKH links

Reflect changes made in commit f5039935ac68 ("Documentation: update GregKH links").

---
 Documentation/translations/ja_JP/SubmittingPatches | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
Documentation/translations/ja_JP/SubmittingPatches +5 -4
index 0d308edef781..c986d925de51 100644
@@ -681,10 +681,11 @@ Jeff Garzik, "Linux kernel patch submission format".
   <https://web.archive.org/web/20180829112450/http://linux.yyz.us/patch-format.html>
 
 Greg Kroah-Hartman, "How to piss off a kernel subsystem maintainer".
-  <http://www.kroah.com/log/2005/03/31/>
-  <http://www.kroah.com/log/2005/07/08/>
-  <http://www.kroah.com/log/2005/10/19/>
-  <http://www.kroah.com/log/2006/01/11/>
+  <http://www.kroah.com/log/linux/maintainer.html>
+  <http://www.kroah.com/log/linux/maintainer-02.html>
+  <http://www.kroah.com/log/linux/maintainer-03.html>
+  <http://www.kroah.com/log/linux/maintainer-04.html>
+  <http://www.kroah.com/log/linux/maintainer-05.html>
 
 NO!!!! No more huge patch bombs to [email protected] people!
   <https://lore.kernel.org/r/[email protected]>
Signature · 1 line
2.25.1
author reviewer
#2 lore raw

PATCH 2/5 docs/ja_JP/SubmittingPatches: Suggest the use of scripts/get_maintainer.pl

In reply to Akira Yokosawa

Reflect changes made in commit e52d2e1f25f0 ("Documentation/SubmittingPatches: suggested the use of scripts/get_maintainer.pl").

---
 Documentation/translations/ja_JP/SubmittingPatches | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/translations/ja_JP/SubmittingPatches +2 -1
index c986d925de51..230e62401c78 100644
@@ -162,7 +162,8 @@ http://savannah.nongnu.org/projects/quilt
 
 MAINTAINERS ファイルとソースコードに目を通してください。そして、その変
 更がメンテナのいる特定のサブシステムに加えられるものであることが分か
-れば、その人に電子メールを送ってください。
+れば、その人に電子メールを送ってください。その際
+./scripts/get_maintainers.pl のスクリプトが有用です。
 
 もし、メンテナが載っていなかったり、メンテナからの応答がないなら、
 LKML ( [email protected] )へパッチを送ってください。ほとんど
Signature · 1 line
2.25.1
author reviewer
#3 lore raw

PATCH 3/5 docs/ja_JP/SubmittingPatches: Randy has moved

In reply to Akira Yokosawa

Reflect changes made in commit 755727b7fb1e ("Randy has moved").

---
 Documentation/translations/ja_JP/SubmittingPatches | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
Documentation/translations/ja_JP/SubmittingPatches +1 -3
index 230e62401c78..d3b16bd7fcc6 100644
@@ -81,9 +81,7 @@ Linux カーネルに対する全ての変更は diff(1) コマンドによる
 dontdiff ファイルには Linux カーネルのビルドプロセスの過程で生成された
 ファイルの一覧がのっています。そして、それらはパッチを生成する diff(1)
 コマンドで無視されるべきです。dontdiff ファイルは 2.6.12 以後のバージョ
-ンの Linux カーネルソースツリーに含まれています。それより前のバージョン
-の Linux カーネルソースツリーに対する dontdiff ファイルは、
-<http://www.xenotime.net/linux/doc/dontdiff>から取得することができます。
+ンの Linux カーネルソースツリーに含まれています。
 
 投稿するパッチの中に関係のない余分なファイルが含まれていないことを確
 認してください。diff(1) コマンドで生成したパッチがあなたの意図したとお
Signature · 1 line
2.25.1
author reviewer
#4 lore raw

PATCH 4/5 docs/ja_JP/SubmittingPatches: Add Suggested-by as a standard signature

In reply to Akira Yokosawa

Reflect changes made in commit 8543ae1296f6 ("checkpatch: add Suggested-by as a standard signature").

---
 Documentation/translations/ja_JP/SubmittingPatches | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Documentation/translations/ja_JP/SubmittingPatches +8 -1
index d3b16bd7fcc6..805886a695c8 100644
@@ -399,7 +399,7 @@ Acked-by: が必ずしもパッチ全体の承認を示しているわけでは
 このタグはパッチに関心があると思われる人達がそのパッチの議論に含まれていたこと
 を明文化します。
 
-14) Reported-by と Tested-by: と Reviewed-by: の利用
+14) Reported-by:, Tested-by:, Reviewed-by: および Suggested-by: の利用
 
 他の誰かによって報告された問題を修正するパッチであれば、問題報告者という寄与を
 クレジットするために、Reported-by: タグを追加することを検討してください。
@@ -448,6 +448,13 @@ Reviewd-by タグはそのパッチがカーネルに対して適切な修正で
 レビューを実施したレビューアによって提供される時、Reviewed-by: タグがあなたの
 パッチをカーネルにマージする可能性を高めるでしょう。
 
+Suggested-by: タグは、パッチのアイデアがその人からの提案に基づくものである
+ことを示し、アイデアの提供をクレジットするものです。提案者の明示的な許可が
+ない場合、特にそのアイデアが公開のフォーラムで示されていない場合には、この
+タグをつけないように注意してください。とはいえ、アイデアの提供者をこつこつ
+クレジットしていけば、望むらくはその人たちが将来別の機会に再度力を貸す気に
+なってくれるかもしれません。
+
 15) 標準的なパッチのフォーマット
 
 標準的なパッチのサブジェクトは以下のとおりです。
Signature · 1 line
2.25.1
author reviewer
#5 lore raw

PATCH 5/5 docs/ja_JP/SubmittingPatches: Request summaries for commit references

In reply to Akira Yokosawa

Reflect changes made in commit 0af5270324cc ("Documentation/SubmittingPatches: Request summaries for commit references").

Note: Translated paragraph uses a slightly different structure and omit a redundant phrase so that they are easier to follow.

---
 Documentation/translations/ja_JP/SubmittingPatches | 11 +++++++++++
 1 file changed, 11 insertions(+)
Documentation/translations/ja_JP/SubmittingPatches +11 -0
index 805886a695c8..66ce0d8b0526 100644
@@ -123,6 +123,17 @@ http://savannah.nongnu.org/projects/quilt
 登録済みのバグエントリを修正するパッチであれば、そのバグエントリを示すバグ ID
 や URL を明記してください。
 
+特定のコミットを参照したい場合は、その SHA-1 ID だけでなく、一行サマリ
+も含めてください。それにより、それが何に関するコミットなのかがレビューする
+人にわかりやすくなります。
+例 (英文のママ):
+
+       Commit e21d2170f36602ae2708 ("video: remove unnecessary
+       platform_set_drvdata()") removed the unnecessary
+       platform_set_drvdata(), but left the variable "dev" unused,
+       delete it.
+
+
 3) パッチの分割
 
 意味のあるひとまとまりごとに変更を個々のパッチファイルに分けてください。
Signature · 1 line
2.25.1
Reviewed-by on the v1 series
#6 lore raw
In reply to Akira Yokosawa
Quoted 33 lines · Akira Yokosawa

Hi,

This is the first batch of updates attempting to modernize Japanese SubmittingPatches. Conversion to ReST will be done later when the corresponding commit doing the conversion is reached. Pending list of commits is quite long (about 90) and this effort is expected to produce dozens of series.

List of commits for English (then) SubmittingPatches:

- f5039935ac68 ("Documentation: update GregKH links")
- e52d2e1f25f0 ("Documentation/SubmittingPatches: suggested the use of scripts/get_maintainer.pl")
- 755727b7fb1e ("Randy has moved")
- 8543ae1296f6 ("checkpatch: add Suggested-by as a standard signature")
- 0af5270324cc ("Documentation/SubmittingPatches: Request summaries for commit references")

Note: Commit db12fb833a88 ("Documentation: fix spelling error in SubmittingPatches") does not affect Japanese translation.

Thanks, Akira
--
Akira Yokosawa (5):
docs/ja_JP/SubmittingPatches: Update GregKH links docs/ja_JP/SubmittingPatches: Suggest the use of
scripts/get_maintainer.pl
docs/ja_JP/SubmittingPatches: Randy has moved docs/ja_JP/SubmittingPatches: Add Suggested-by as a standard signature docs/ja_JP/SubmittingPatches: Request summaries for commit references

Quoted 8 lines

.../translations/ja_JP/SubmittingPatches | 36 ++++++++++++++-----

1 file changed, 27 insertions(+), 9 deletions(-)

base-commit: 81c653659d34ec253fba7f5d0f430813fe0f643d

Signature · 1 line
2.25.1

Resending the response to this patch due to misconfiguration of my email client.

For the series,

Best regards,
Kosuke

#7 lore raw
Quoted 43 lines · Kosuke Fujimoto
Quoted 34 lines · Akira Yokosawa

Hi,

This is the first batch of updates attempting to modernize Japanese SubmittingPatches. Conversion to ReST will be done later when the corresponding commit doing the conversion is reached. Pending list of commits is quite long (about 90) and this effort is expected to produce dozens of series.

List of commits for English (then) SubmittingPatches:

- f5039935ac68 ("Documentation: update GregKH links")
- e52d2e1f25f0 ("Documentation/SubmittingPatches: suggested the use of scripts/get_maintainer.pl")
- 755727b7fb1e ("Randy has moved")
- 8543ae1296f6 ("checkpatch: add Suggested-by as a standard signature")
- 0af5270324cc ("Documentation/SubmittingPatches: Request summaries for commit references")

Note: Commit db12fb833a88 ("Documentation: fix spelling error in SubmittingPatches") does not affect Japanese translation.

Thanks, Akira
--
Akira Yokosawa (5):
docs/ja_JP/SubmittingPatches: Update GregKH links docs/ja_JP/SubmittingPatches: Suggest the use of
scripts/get_maintainer.pl
docs/ja_JP/SubmittingPatches: Randy has moved docs/ja_JP/SubmittingPatches: Add Suggested-by as a standard signature docs/ja_JP/SubmittingPatches: Request summaries for commit references

Quoted 8 lines

.../translations/ja_JP/SubmittingPatches | 36 ++++++++++++++-----

1 file changed, 27 insertions(+), 9 deletions(-)

base-commit: 81c653659d34ec253fba7f5d0f430813fe0f643d --
2.25.1

Quoted 8 lines

Resending the response to this patch due to misconfiguration of my email client.

For the series,

Best regards,
Kosuke

Plan of doing follow up chagens at first and then conversion to ReST sounds good.
I'll continue to review your changes.

Thank you for your patches.
Tsugikazu Shibata

maintainer
#8 lore raw
In reply to Akira Yokosawa
Quoted 10 lines · Akira Yokosawa

Hi,

This is the first batch of updates attempting to modernize Japanese SubmittingPatches. Conversion to ReST will be done later when the corresponding commit doing the conversion is reached. Pending list of commits is quite long (about 90) and this effort is expected to produce dozens of series.

List of commits for English (then) SubmittingPatches:

Quoted 8 lines

- f5039935ac68 ("Documentation: update GregKH links")
- e52d2e1f25f0 ("Documentation/SubmittingPatches: suggested the use of scripts/get_maintainer.pl")
- 755727b7fb1e ("Randy has moved")
- 8543ae1296f6 ("checkpatch: add Suggested-by as a standard signature")
- 0af5270324cc ("Documentation/SubmittingPatches: Request summaries for commit references")

Note: Commit db12fb833a88 ("Documentation: fix spelling error in SubmittingPatches") does not affect Japanese translation.

Series applied, thanks.

jon