Skip to contentSkip to conversation

'select' on deleted KEYS_DEBUG_PROC_KEYS option

PATCH New Andreas Ziegler 3 participants 4 messages Jan 26, 2016 – Feb 3, 2016

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi Dmitry,

your commit f4dc37785e9b ("integrity: define '.evm' as a builtin 'trusted' keyring") introduces the INTEGRITY_TRUSTED_KEYRING Kconfig option, which has a 'select' to KEYS_DEBUG_PROC_KEYS.

This option, however, has been removed over a year ago by commit dabd39cc2fb1 ("KEYS: Make /proc/keys unconditional if CONFIG_KEYS=y") and -- besides the 'select' mentioned above -- only occurs inside (outdated) defconfigs.

Should I prepare a simple patch removing the select?

Best regards,

Andreas

#1 lore raw

Hi,

Yes, please make a patch.

Thanks for noticing,

Dmitry
________________________________________
From: Andreas Ziegler [[email protected]]
Sent: Tuesday, January 26, 2016 5:39 PM
To: Dmitry Kasatkin
Cc: David Howells; James Morris; Serge E. Hallyn; [email protected]
Subject: 'select' on deleted KEYS_DEBUG_PROC_KEYS option

Hi Dmitry,

your commit f4dc37785e9b ("integrity: define '.evm' as a builtin 'trusted' keyring") introduces the INTEGRITY_TRUSTED_KEYRING Kconfig option, which has a 'select' to KEYS_DEBUG_PROC_KEYS.

This option, however, has been removed over a year ago by commit dabd39cc2fb1 ("KEYS: Make /proc/keys unconditional if CONFIG_KEYS=y") and -- besides the 'select' mentioned above -- only occurs inside (outdated) defconfigs.

Should I prepare a simple patch removing the select?

Best regards,

Andreas

#2 lore raw

PATCH 1/1 security: Remove select to deleted KEYS_DEBUG_PROC_KEYS option

Commit f4dc37785e9b ("integrity: define '.evm' as a builtin 'trusted' keyring") introduces the INTEGRITY_TRUSTED_KEYRING Kconfig option.

This option 'select's KEYS_DEBUG_PROC_KEYS which has been removed earlier by commit dabd39cc2fb1 ("KEYS: Make /proc/keys unconditional if CONFIG_KEYS=y"). This patch removes the inoperative select.

---
 security/integrity/Kconfig | 1 -
 1 file changed, 1 deletion(-)
security/integrity/Kconfig +0 -1
index 21d7568..7543398 100644
@@ -45,7 +45,6 @@ config INTEGRITY_TRUSTED_KEYRING
 	bool "Require all keys on the integrity keyrings be signed"
 	depends on SYSTEM_TRUSTED_KEYRING
 	depends on INTEGRITY_ASYMMETRIC_KEYS
-	select KEYS_DEBUG_PROC_KEYS
 	default y
 	help
 	   This option requires that all keys added to the .ima and
Signature · 1 line
1.9.1