Remove busybox bbappend
cover Remove busybox bbappend
Note: this patch needs to be applied right after the patch that does the merge of the bbappend in OE-Core (just sent to the OE-Core list).
The following changes since commit d4571b3d94d999ad54d8965f0d049dcfd34da504:
quagga: two fixes (2013-08-16 11:00:19 -0400)
are available in the git repository at:
git://git.openembedded.org/meta-openembedded-contrib paule/busybox
http://cgit.openembedded.org/cgit.cgi/meta-openembedded-contrib/log/?h=paule/busybox
Paul Eggleton (1):
busybox: remove bbappend
meta-oe/recipes-core/busybox/busybox/busybox-syslog.default | 1 - meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend | 11 ----------- 2 files changed, 12 deletions(-) delete mode 100644 meta-oe/recipes-core/busybox/busybox/busybox-syslog.default delete mode 100644 meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend
Signature · 1 line
1.8.1.2
PATCH 1/1 busybox: remove bbappend
This bbappend has effectively been merged into OE-Core, although the log buffer size is the busybox default rather than 64K - layers may change this either by providing their own /etc/default/busybox-syslog file (when using systemd) or modifying the CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE option in busybox's build time config.
--- meta-oe/recipes-core/busybox/busybox/busybox-syslog.default | 1 - meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend | 11 ----------- 2 files changed, 12 deletions(-) delete mode 100644 meta-oe/recipes-core/busybox/busybox/busybox-syslog.default delete mode 100644 meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend
meta-oe/recipes-core/busybox/busybox/busybox-syslog.default deleted +0 -1
@@ -1 +0,0 @@ -OPTIONS="-C64"
meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend deleted +0 -11
@@ -1,11 +0,0 @@ -# look for files in the layer first -FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" - -SRC_URI += "file://busybox-syslog.default" - -do_install_append() { - install -d ${D}${sysconfdir}/default - install -m 0644 ${WORKDIR}/busybox-syslog.default ${D}${sysconfdir}/default/busybox-syslog -} - -FILES_${PN}-syslog += "${sysconfdir}/default/busybox-syslog"
Signature · 1 line
1.8.1.2
Re: [meta-oe][PATCH 1/1] busybox: remove bbappend
Quoted 6 lines · Paul Eggleton
This bbappend has effectively been merged into OE-Core, although the log buffer size is the busybox default rather than 64K - layers may change this either by providing their own
/etc/default/busybox-syslogfile (when using systemd) or modifying theCONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZEoption in busybox's build time config
I think it would be better if we added this option via a kconfig fragment in OE-Core if DISTRO_FEATURES contained systemd and then remove this from here. I say this because otherwise size of circular buffer goes back to 16k from 64k and may not be enough to hold valuable info. On modern systems I think we can afford 64k. I would even argue to make it default in busybox. having said that, busybox-syslogd may be redundant when using systemd since we have journald with systemd but there might still be lot of use cases of busybox-syslogd. Either of these above approaches are fine with me.
Quoted 40 lines
Signed-off-by Paul Eggleton <[email protected]>---
meta-oe/recipes-core/busybox/busybox/busybox-syslog.default | 1 -
meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend | 11 -----------2 files changed, 12 deletions(-)delete mode 100644 meta-oe/recipes-core/busybox/busybox/busybox-syslog.default delete mode 100644 meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend
meta-oe/recipes-core/busybox/busybox/busybox-syslog.default deleted +0
-1@@ -1 +0,0 @@ -OPTIONS="-C64"meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend deleted +0
-11@@ -1,11 +0,0 @@ -# look for files in the layer first -FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" - -SRC_URI += "file://busybox-syslog.default" - -do_install_append() { - install -d ${D}${sysconfdir}/default - install -m 0644 ${WORKDIR}/busybox-syslog.default ${D}${sysconfdir}/default/busybox-syslog -} - -FILES_${PN}-syslog += "${sysconfdir}/default/busybox-syslog"Signature · 6 lines
1.8.1.2 _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [meta-oe][PATCH 1/1] busybox: remove bbappend
Quoted 9 lines · On Friday 23 August 2013 10:36:15 Khem Raj wrote:
Quoted 6 lines · Paul Eggleton
This bbappend has effectively been merged into OE-Core, although the log buffer size is the busybox default rather than 64K - layers may change this either by providing their own
/etc/default/busybox-syslogfile (when using systemd) or modifying theCONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZEoption in busybox's build time config
Quoted 4 lines
I think it would be better if we added this option via a kconfig fragment in OE-Core if
DISTRO_FEATUREScontained systemd and then remove this from here. I say this because otherwise size of circular buffer goes back to 16k from 64k and may not be enough to hold valuable info.
Why is this specific to systemd?
Cheers,
Paul
Signature · 2 lines
Paul Eggleton Intel Open Source Technology Centre
Re: [meta-oe][PATCH 1/1] busybox: remove bbappend
Quoted 10 lines · Paul Eggleton
Quoted 9 lines · On Friday 23 August 2013 10:36:15 Khem Raj wrote:
Quoted 6 lines · Paul Eggleton
This bbappend has effectively been merged into OE-Core, although the log buffer size is the busybox default rather than 64K - layers may change this either by providing their own
/etc/default/busybox-syslogfile (when using systemd) or modifying theCONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZEoption in busybox's build time config
Quoted 6 lines
Quoted 4 lines
I think it would be better if we added this option via a kconfig fragment in OE-Core if
DISTRO_FEATUREScontained systemd and then remove this from here. I say this because otherwise size of circular buffer goes back to 16k from 64k and may not be enough to hold valuable info.Why is this specific to systemd?
It probably is not. Otavio added it, so I am CCing him however this is default used in many distros, just to keep enough messages around while you can affort 64K buffer which is not a huge ask these days.
Quoted 8 lines
Cheers,
PaulSignature · 2 lines
Paul Eggleton Intel Open Source Technology Centre
Re: [meta-oe][PATCH 1/1] busybox: remove bbappend
Quoted 17 lines · On Monday 26 August 2013 14:39:10 Khem Raj wrote:
Quoted 15 lines · Paul Eggleton
Quoted 13 lines · On Friday 23 August 2013 10:36:15 Khem Raj wrote:
Quoted 6 lines · Paul Eggleton
This bbappend has effectively been merged into OE-Core, although the log buffer size is the busybox default rather than 64K - layers may change this either by providing their own
/etc/default/busybox-syslogfile (when using systemd) or modifying theCONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZEoption in busybox's build time configI think it would be better if we added this option via a kconfig fragment in OE-Core if
DISTRO_FEATUREScontained systemd and then remove this from here. I say this because otherwise size of circular buffer goes back to 16k from 64k and may not be enough to hold valuable info.
Quoted 6 lines
Quoted 1 line
Why is this specific to systemd?
It probably is not. Otavio added it, so I am CCing him however this is default used in many distros, just to keep enough messages around while you can affort 64K buffer which is not a huge ask these days.
If it's generally useful and not specific to systemd (and it seems it isn't the latter) I'd have to say I agree, let's set the default in our busybox defconfig.
Cheers,
Paul
Signature · 2 lines
Paul Eggleton Intel Open Source Technology Centre
Re: [meta-oe][PATCH 1/1] busybox: remove bbappend
Quoted 20 lines · Paul Eggleton
Quoted 19 lines · On Monday 26 August 2013 14:39:10 Khem Raj wrote:
Quoted 16 lines · Paul Eggleton
Quoted 9 lines · On Friday 23 August 2013 10:36:15 Khem Raj wrote:
Quoted 6 lines · Paul Eggleton
This bbappend has effectively been merged into OE-Core, although the log buffer size is the busybox default rather than 64K - layers may change this either by providing their own
/etc/default/busybox-syslogfile (when using systemd) or modifying theCONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZEoption in busybox's build time configQuoted 4 lines
I think it would be better if we added this option via a kconfig fragment in OE-Core if
DISTRO_FEATUREScontained systemd and then remove this from here. I say this because otherwise size of circular buffer goes back to 16k from 64k and may not be enough to hold valuable info.Why is this specific to systemd?
Quoted 9 lines
Quoted 4 lines
It probably is not. Otavio added it, so I am CCing him however this is default used in many distros, just to keep enough messages around while you can affort 64K buffer which is not a huge ask these days.
If it's generally useful and not specific to systemd (and it seems it isn't the latter) I'd have to say I agree, let's set the default in our busybox defconfig.
I have no issues with changed the defconfig.
Quoted 7 lines
Cheers,
PaulSignature · 2 lines
Paul Eggleton Intel Open Source Technology Centre
Re: [meta-oe][PATCH 1/1] busybox: remove bbappend
In reply to Paul EggletonQuoted 20 lines · Paul Eggleton
Quoted 19 lines · On Monday 26 August 2013 14:39:10 Khem Raj wrote:
Quoted 16 lines · Paul Eggleton
Quoted 9 lines · On Friday 23 August 2013 10:36:15 Khem Raj wrote:
Quoted 6 lines · Paul Eggleton
This bbappend has effectively been merged into OE-Core, although the log buffer size is the busybox default rather than 64K - layers may change this either by providing their own
/etc/default/busybox-syslogfile (when using systemd) or modifying theCONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZEoption in busybox's build time configQuoted 4 lines
I think it would be better if we added this option via a kconfig fragment in OE-Core if
DISTRO_FEATUREScontained systemd and then remove this from here. I say this because otherwise size of circular buffer goes back to 16k from 64k and may not be enough to hold valuable info.Why is this specific to systemd?
Quoted 8 lines
Quoted 4 lines
It probably is not. Otavio added it, so I am CCing him however this is default used in many distros, just to keep enough messages around while you can affort 64K buffer which is not a huge ask these days.
If it's generally useful and not specific to systemd (and it seems it isn't the latter) I'd have to say I agree, let's set the default in our busybox defconfig.
+1
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Martin Jansa
AppliedRe: [meta-oe][PATCH 1/1] busybox: remove bbappend
In reply to Paul EggletonQuoted 6 lines · Paul Eggleton
This bbappend has effectively been merged into OE-Core, although the log buffer size is the busybox default rather than 64K - layers may change this either by providing their own
/etc/default/busybox-syslogfile (when using systemd) or modifying theCONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZEoption in busybox's build time config.
Applied, thanks!
Quoted 40 lines
Signed-off-by Paul Eggleton <[email protected]>--- meta-oe/recipes-core/busybox/busybox/busybox-syslog.default | 1 - meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend | 11 ----------- 2 files changed, 12 deletions(-) delete mode 100644 meta-oe/recipes-core/busybox/busybox/busybox-syslog.default delete mode 100644 meta-oe/recipes-core/busybox/busybox_1.21.1.bbappendmeta-oe/recipes-core/busybox/busybox/busybox-syslog.default deleted +0
-1@@ -1 +0,0 @@ -OPTIONS="-C64"meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend deleted +0
-11@@ -1,11 +0,0 @@ -# look for files in the layer first -FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" - -SRC_URI += "file://busybox-syslog.default" - -do_install_append() { - install -d ${D}${sysconfdir}/default - install -m 0644 ${WORKDIR}/busybox-syslog.default ${D}${sysconfdir}/default/busybox-syslog -} - -FILES_${PN}-syslog += "${sysconfdir}/default/busybox-syslog"Signature · 6 lines
1.8.1.2 _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]