Skip to contentSkip to conversation

config: change ABI versioning for global

PATCH In review Marcin Baran 11 participants 131 messages Sep 30, 2019 – Nov 22, 2019 Page 3 of 4

Subsystems (9)
lore
Share & tools
lore
#75 lore raw

PATCH v6 5/10 lpm: remove deprecated code

In reply to Anatoly Burakov

From: Marcin Baran <[email protected]>

Remove code for old ABI versions ahead of ABI version bump.

---

Notes:
v2:
- Moved this to before ABI version bump to avoid compile breakage

 lib/librte_lpm/rte_lpm.c  | 996 ++------------------------------------
 lib/librte_lpm/rte_lpm.h  |  88 ----
 lib/librte_lpm/rte_lpm6.c | 132 +----
 lib/librte_lpm/rte_lpm6.h |  25 -
 4 files changed, 48 insertions(+), 1193 deletions(-)
lib/librte_lpm/rte_lpm.c +34 -962
index c96395e269..b78c487447 100644
@@ -90,34 +90,8 @@ depth_to_range(uint8_t depth)
 /*
  * Find an existing lpm table and return a pointer to it.
  */
-struct rte_lpm_v20 *
-rte_lpm_find_existing_v20(const char *name)
-{
-	struct rte_lpm_v20 *l = NULL;
-	struct rte_tailq_entry *te;
-	struct rte_lpm_list *lpm_list;
-
-	lpm_list = RTE_TAILQ_CAST(rte_lpm_tailq.head, rte_lpm_list);
-
-	rte_mcfg_tailq_read_lock();
-	TAILQ_FOREACH(te, lpm_list, next) {
-		l = te->data;
-		if (strncmp(name, l->name, RTE_LPM_NAMESIZE) == 0)
-			break;
-	}
-	rte_mcfg_tailq_read_unlock();
-
-	if (te == NULL) {
-		rte_errno = ENOENT;
-		return NULL;
-	}
-
-	return l;
-}
-VERSION_SYMBOL(rte_lpm_find_existing, _v20, 2.0);
-
 struct rte_lpm *
-rte_lpm_find_existing_v1604(const char *name)
+rte_lpm_find_existing(const char *name)
 {
 	struct rte_lpm *l = NULL;
 	struct rte_tailq_entry *te;
@@ -140,88 +114,12 @@ rte_lpm_find_existing_v1604(const char *name)
 
 	return l;
 }
-BIND_DEFAULT_SYMBOL(rte_lpm_find_existing, _v1604, 16.04);
-MAP_STATIC_SYMBOL(struct rte_lpm *rte_lpm_find_existing(const char *name),
-		rte_lpm_find_existing_v1604);
 
 /*
  * Allocates memory for LPM object
  */
-struct rte_lpm_v20 *
-rte_lpm_create_v20(const char *name, int socket_id, int max_rules,
-		__rte_unused int flags)
-{
-	char mem_name[RTE_LPM_NAMESIZE];
-	struct rte_lpm_v20 *lpm = NULL;
-	struct rte_tailq_entry *te;
-	uint32_t mem_size;
-	struct rte_lpm_list *lpm_list;
-
-	lpm_list = RTE_TAILQ_CAST(rte_lpm_tailq.head, rte_lpm_list);
-
-	RTE_BUILD_BUG_ON(sizeof(struct rte_lpm_tbl_entry_v20) != 2);
-
-	/* Check user arguments. */
-	if ((name == NULL) || (socket_id < -1) || (max_rules == 0)) {
-		rte_errno = EINVAL;
-		return NULL;
-	}
-
-	snprintf(mem_name, sizeof(mem_name), "LPM_%s", name);
-
-	/* Determine the amount of memory to allocate. */
-	mem_size = sizeof(*lpm) + (sizeof(lpm->rules_tbl[0]) * max_rules);
-
-	rte_mcfg_tailq_write_lock();
-
-	/* guarantee there's no existing */
-	TAILQ_FOREACH(te, lpm_list, next) {
-		lpm = te->data;
-		if (strncmp(name, lpm->name, RTE_LPM_NAMESIZE) == 0)
-			break;
-	}
-
-	if (te != NULL) {
-		lpm = NULL;
-		rte_errno = EEXIST;
-		goto exit;
-	}
-
-	/* allocate tailq entry */
-	te = rte_zmalloc("LPM_TAILQ_ENTRY", sizeof(*te), 0);
-	if (te == NULL) {
-		RTE_LOG(ERR, LPM, "Failed to allocate tailq entry\n");
-		rte_errno = ENOMEM;
-		goto exit;
-	}
-
-	/* Allocate memory to store the LPM data structures. */
-	lpm = rte_zmalloc_socket(mem_name, mem_size,
-			RTE_CACHE_LINE_SIZE, socket_id);
-	if (lpm == NULL) {
-		RTE_LOG(ERR, LPM, "LPM memory allocation failed\n");
-		rte_free(te);
-		rte_errno = ENOMEM;
-		goto exit;
-	}
-
-	/* Save user arguments. */
-	lpm->max_rules = max_rules;
-	strlcpy(lpm->name, name, sizeof(lpm->name));
-
-	te->data = lpm;
-
-	TAILQ_INSERT_TAIL(lpm_list, te, next);
-
-exit:
-	rte_mcfg_tailq_write_unlock();
-
-	return lpm;
-}
-VERSION_SYMBOL(rte_lpm_create, _v20, 2.0);
-
 struct rte_lpm *
-rte_lpm_create_v1604(const char *name, int socket_id,
+rte_lpm_create(const char *name, int socket_id,
 		const struct rte_lpm_config *config)
 {
 	char mem_name[RTE_LPM_NAMESIZE];
@@ -321,45 +219,12 @@ rte_lpm_create_v1604(const char *name, int socket_id,
 
 	return lpm;
 }
-BIND_DEFAULT_SYMBOL(rte_lpm_create, _v1604, 16.04);
-MAP_STATIC_SYMBOL(
-	struct rte_lpm *rte_lpm_create(const char *name, int socket_id,
-			const struct rte_lpm_config *config), rte_lpm_create_v1604);
 
 /*
  * Deallocates memory for given LPM table.
  */
 void
-rte_lpm_free_v20(struct rte_lpm_v20 *lpm)
-{
-	struct rte_lpm_list *lpm_list;
-	struct rte_tailq_entry *te;
-
-	/* Check user arguments. */
-	if (lpm == NULL)
-		return;
-
-	lpm_list = RTE_TAILQ_CAST(rte_lpm_tailq.head, rte_lpm_list);
-
-	rte_mcfg_tailq_write_lock();
-
-	/* find our tailq entry */
-	TAILQ_FOREACH(te, lpm_list, next) {
-		if (te->data == (void *) lpm)
-			break;
-	}
-	if (te != NULL)
-		TAILQ_REMOVE(lpm_list, te, next);
-
-	rte_mcfg_tailq_write_unlock();
-
-	rte_free(lpm);
-	rte_free(te);
-}
-VERSION_SYMBOL(rte_lpm_free, _v20, 2.0);
-
-void
-rte_lpm_free_v1604(struct rte_lpm *lpm)
+rte_lpm_free(struct rte_lpm *lpm)
 {
 	struct rte_lpm_list *lpm_list;
 	struct rte_tailq_entry *te;
@@ -387,9 +252,6 @@ rte_lpm_free_v1604(struct rte_lpm *lpm)
 	rte_free(lpm);
 	rte_free(te);
 }
-BIND_DEFAULT_SYMBOL(rte_lpm_free, _v1604, 16.04);
-MAP_STATIC_SYMBOL(void rte_lpm_free(struct rte_lpm *lpm),
-		rte_lpm_free_v1604);
 
 /*
  * Adds a rule to the rule table.
@@ -402,79 +264,7 @@ MAP_STATIC_SYMBOL(void rte_lpm_free(struct rte_lpm *lpm),
  * NOTE: Valid range for depth parameter is 1 .. 32 inclusive.
  */
 static int32_t
-rule_add_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked, uint8_t depth,
-	uint8_t next_hop)
-{
-	uint32_t rule_gindex, rule_index, last_rule;
-	int i;
-
-	VERIFY_DEPTH(depth);
-
-	/* Scan through rule group to see if rule already exists. */
-	if (lpm->rule_info[depth - 1].used_rules > 0) {
-
-		/* rule_gindex stands for rule group index. */
-		rule_gindex = lpm->rule_info[depth - 1].first_rule;
-		/* Initialise rule_index to point to start of rule group. */
-		rule_index = rule_gindex;
-		/* Last rule = Last used rule in this rule group. */
-		last_rule = rule_gindex + lpm->rule_info[depth - 1].used_rules;
-
-		for (; rule_index < last_rule; rule_index++) {
-
-			/* If rule already exists update its next_hop and return. */
-			if (lpm->rules_tbl[rule_index].ip == ip_masked) {
-				lpm->rules_tbl[rule_index].next_hop = next_hop;
-
-				return rule_index;
-			}
-		}
-
-		if (rule_index == lpm->max_rules)
-			return -ENOSPC;
-	} else {
-		/* Calculate the position in which the rule will be stored. */
-		rule_index = 0;
-
-		for (i = depth - 1; i > 0; i--) {
-			if (lpm->rule_info[i - 1].used_rules > 0) {
-				rule_index = lpm->rule_info[i - 1].first_rule
-						+ lpm->rule_info[i - 1].used_rules;
-				break;
-			}
-		}
-		if (rule_index == lpm->max_rules)
-			return -ENOSPC;
-
-		lpm->rule_info[depth - 1].first_rule = rule_index;
-	}
-
-	/* Make room for the new rule in the array. */
-	for (i = RTE_LPM_MAX_DEPTH; i > depth; i--) {
-		if (lpm->rule_info[i - 1].first_rule
-				+ lpm->rule_info[i - 1].used_rules == lpm->max_rules)
-			return -ENOSPC;
-
-		if (lpm->rule_info[i - 1].used_rules > 0) {
-			lpm->rules_tbl[lpm->rule_info[i - 1].first_rule
-				+ lpm->rule_info[i - 1].used_rules]
-					= lpm->rules_tbl[lpm->rule_info[i - 1].first_rule];
-			lpm->rule_info[i - 1].first_rule++;
-		}
-	}
-
-	/* Add the new rule. */
-	lpm->rules_tbl[rule_index].ip = ip_masked;
-	lpm->rules_tbl[rule_index].next_hop = next_hop;
-
-	/* Increment the used rules counter for this rule group. */
-	lpm->rule_info[depth - 1].used_rules++;
-
-	return rule_index;
-}
-
-static int32_t
-rule_add_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
+rule_add(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
 	uint32_t next_hop)
 {
 	uint32_t rule_gindex, rule_index, last_rule;
@@ -550,30 +340,7 @@ rule_add_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
  * NOTE: Valid range for depth parameter is 1 .. 32 inclusive.
  */
 static void
-rule_delete_v20(struct rte_lpm_v20 *lpm, int32_t rule_index, uint8_t depth)
-{
-	int i;
-
-	VERIFY_DEPTH(depth);
-
-	lpm->rules_tbl[rule_index] =
-			lpm->rules_tbl[lpm->rule_info[depth - 1].first_rule
-				+ lpm->rule_info[depth - 1].used_rules - 1];
-
-	for (i = depth; i < RTE_LPM_MAX_DEPTH; i++) {
-		if (lpm->rule_info[i].used_rules > 0) {
-			lpm->rules_tbl[lpm->rule_info[i].first_rule - 1] =
-				lpm->rules_tbl[lpm->rule_info[i].first_rule
-					+ lpm->rule_info[i].used_rules - 1];
-			lpm->rule_info[i].first_rule--;
-		}
-	}
-
-	lpm->rule_info[depth - 1].used_rules--;
-}
-
-static void
-rule_delete_v1604(struct rte_lpm *lpm, int32_t rule_index, uint8_t depth)
+rule_delete(struct rte_lpm *lpm, int32_t rule_index, uint8_t depth)
 {
 	int i;
 
@@ -600,28 +367,7 @@ rule_delete_v1604(struct rte_lpm *lpm, int32_t rule_index, uint8_t depth)
  * NOTE: Valid range for depth parameter is 1 .. 32 inclusive.
  */
 static int32_t
-rule_find_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked, uint8_t depth)
-{
-	uint32_t rule_gindex, last_rule, rule_index;
-
-	VERIFY_DEPTH(depth);
-
-	rule_gindex = lpm->rule_info[depth - 1].first_rule;
-	last_rule = rule_gindex + lpm->rule_info[depth - 1].used_rules;
-
-	/* Scan used rules at given depth to find rule. */
-	for (rule_index = rule_gindex; rule_index < last_rule; rule_index++) {
-		/* If rule is found return the rule index. */
-		if (lpm->rules_tbl[rule_index].ip == ip_masked)
-			return rule_index;
-	}
-
-	/* If rule is not found return -EINVAL. */
-	return -EINVAL;
-}
-
-static int32_t
-rule_find_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth)
+rule_find(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth)
 {
 	uint32_t rule_gindex, last_rule, rule_index;
 
@@ -645,42 +391,7 @@ rule_find_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth)
  * Find, clean and allocate a tbl8.
  */
 static int32_t
-tbl8_alloc_v20(struct rte_lpm_tbl_entry_v20 *tbl8)
-{
-	uint32_t group_idx; /* tbl8 group index. */
-	struct rte_lpm_tbl_entry_v20 *tbl8_entry;
-
-	/* Scan through tbl8 to find a free (i.e. INVALID) tbl8 group. */
-	for (group_idx = 0; group_idx < RTE_LPM_TBL8_NUM_GROUPS;
-			group_idx++) {
-		tbl8_entry = &tbl8[group_idx * RTE_LPM_TBL8_GROUP_NUM_ENTRIES];
-		/* If a free tbl8 group is found clean it and set as VALID. */
-		if (!tbl8_entry->valid_group) {
-			struct rte_lpm_tbl_entry_v20 new_tbl8_entry = {
-				.valid = INVALID,
-				.depth = 0,
-				.valid_group = VALID,
-			};
-			new_tbl8_entry.next_hop = 0;
-
-			memset(&tbl8_entry[0], 0,
-					RTE_LPM_TBL8_GROUP_NUM_ENTRIES *
-					sizeof(tbl8_entry[0]));
-
-			__atomic_store(tbl8_entry, &new_tbl8_entry,
-					__ATOMIC_RELAXED);
-
-			/* Return group index for allocated tbl8 group. */
-			return group_idx;
-		}
-	}
-
-	/* If there are no tbl8 groups free then return error. */
-	return -ENOSPC;
-}
-
-static int32_t
-tbl8_alloc_v1604(struct rte_lpm_tbl_entry *tbl8, uint32_t number_tbl8s)
+tbl8_alloc(struct rte_lpm_tbl_entry *tbl8, uint32_t number_tbl8s)
 {
 	uint32_t group_idx; /* tbl8 group index. */
 	struct rte_lpm_tbl_entry *tbl8_entry;
@@ -714,22 +425,7 @@ tbl8_alloc_v1604(struct rte_lpm_tbl_entry *tbl8, uint32_t number_tbl8s)
 }
 
 static void
-tbl8_free_v20(struct rte_lpm_tbl_entry_v20 *tbl8, uint32_t tbl8_group_start)
-{
-	/* Set tbl8 group invalid*/
-	struct rte_lpm_tbl_entry_v20 zero_tbl8_entry = {
-		.valid = INVALID,
-		.depth = 0,
-		.valid_group = INVALID,
-	};
-	zero_tbl8_entry.next_hop = 0;
-
-	__atomic_store(&tbl8[tbl8_group_start], &zero_tbl8_entry,
-			__ATOMIC_RELAXED);
-}
-
-static void
-tbl8_free_v1604(struct rte_lpm_tbl_entry *tbl8, uint32_t tbl8_group_start)
+tbl8_free(struct rte_lpm_tbl_entry *tbl8, uint32_t tbl8_group_start)
 {
 	/* Set tbl8 group invalid*/
 	struct rte_lpm_tbl_entry zero_tbl8_entry = {0};
@@ -739,78 +435,7 @@ tbl8_free_v1604(struct rte_lpm_tbl_entry *tbl8, uint32_t tbl8_group_start)
 }
 
 static __rte_noinline int32_t
-add_depth_small_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth,
-		uint8_t next_hop)
-{
-	uint32_t tbl24_index, tbl24_range, tbl8_index, tbl8_group_end, i, j;
-
-	/* Calculate the index into Table24. */
-	tbl24_index = ip >> 8;
-	tbl24_range = depth_to_range(depth);
-
-	for (i = tbl24_index; i < (tbl24_index + tbl24_range); i++) {
-		/*
-		 * For invalid OR valid and non-extended tbl 24 entries set
-		 * entry.
-		 */
-		if (!lpm->tbl24[i].valid || (lpm->tbl24[i].valid_group == 0 &&
-				lpm->tbl24[i].depth <= depth)) {
-
-			struct rte_lpm_tbl_entry_v20 new_tbl24_entry = {
-				.valid = VALID,
-				.valid_group = 0,
-				.depth = depth,
-			};
-			new_tbl24_entry.next_hop = next_hop;
-
-			/* Setting tbl24 entry in one go to avoid race
-			 * conditions
-			 */
-			__atomic_store(&lpm->tbl24[i], &new_tbl24_entry,
-					__ATOMIC_RELEASE);
-
-			continue;
-		}
-
-		if (lpm->tbl24[i].valid_group == 1) {
-			/* If tbl24 entry is valid and extended calculate the
-			 *  index into tbl8.
-			 */
-			tbl8_index = lpm->tbl24[i].group_idx *
-					RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-			tbl8_group_end = tbl8_index +
-					RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-
-			for (j = tbl8_index; j < tbl8_group_end; j++) {
-				if (!lpm->tbl8[j].valid ||
-						lpm->tbl8[j].depth <= depth) {
-					struct rte_lpm_tbl_entry_v20
-						new_tbl8_entry = {
-						.valid = VALID,
-						.valid_group = VALID,
-						.depth = depth,
-					};
-					new_tbl8_entry.next_hop = next_hop;
-
-					/*
-					 * Setting tbl8 entry in one go to avoid
-					 * race conditions
-					 */
-					__atomic_store(&lpm->tbl8[j],
-						&new_tbl8_entry,
-						__ATOMIC_RELAXED);
-
-					continue;
-				}
-			}
-		}
-	}
-
-	return 0;
-}
-
-static __rte_noinline int32_t
-add_depth_small_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
+add_depth_small(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
 		uint32_t next_hop)
 {
 #define group_idx next_hop
@@ -882,150 +507,7 @@ add_depth_small_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
 }
 
 static __rte_noinline int32_t
-add_depth_big_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked, uint8_t depth,
-		uint8_t next_hop)
-{
-	uint32_t tbl24_index;
-	int32_t tbl8_group_index, tbl8_group_start, tbl8_group_end, tbl8_index,
-		tbl8_range, i;
-
-	tbl24_index = (ip_masked >> 8);
-	tbl8_range = depth_to_range(depth);
-
-	if (!lpm->tbl24[tbl24_index].valid) {
-		/* Search for a free tbl8 group. */
-		tbl8_group_index = tbl8_alloc_v20(lpm->tbl8);
-
-		/* Check tbl8 allocation was successful. */
-		if (tbl8_group_index < 0) {
-			return tbl8_group_index;
-		}
-
-		/* Find index into tbl8 and range. */
-		tbl8_index = (tbl8_group_index *
-				RTE_LPM_TBL8_GROUP_NUM_ENTRIES) +
-				(ip_masked & 0xFF);
-
-		/* Set tbl8 entry. */
-		for (i = tbl8_index; i < (tbl8_index + tbl8_range); i++) {
-			struct rte_lpm_tbl_entry_v20 new_tbl8_entry = {
-				.valid = VALID,
-				.depth = depth,
-				.valid_group = lpm->tbl8[i].valid_group,
-			};
-			new_tbl8_entry.next_hop = next_hop;
-			__atomic_store(&lpm->tbl8[i], &new_tbl8_entry,
-					__ATOMIC_RELAXED);
-		}
-
-		/*
-		 * Update tbl24 entry to point to new tbl8 entry. Note: The
-		 * ext_flag and tbl8_index need to be updated simultaneously,
-		 * so assign whole structure in one go
-		 */
-
-		struct rte_lpm_tbl_entry_v20 new_tbl24_entry = {
-			.group_idx = (uint8_t)tbl8_group_index,
-			.valid = VALID,
-			.valid_group = 1,
-			.depth = 0,
-		};
-
-		__atomic_store(&lpm->tbl24[tbl24_index], &new_tbl24_entry,
-				__ATOMIC_RELEASE);
-
-	} /* If valid entry but not extended calculate the index into Table8. */
-	else if (lpm->tbl24[tbl24_index].valid_group == 0) {
-		/* Search for free tbl8 group. */
-		tbl8_group_index = tbl8_alloc_v20(lpm->tbl8);
-
-		if (tbl8_group_index < 0) {
-			return tbl8_group_index;
-		}
-
-		tbl8_group_start = tbl8_group_index *
-				RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-		tbl8_group_end = tbl8_group_start +
-				RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-
-		/* Populate new tbl8 with tbl24 value. */
-		for (i = tbl8_group_start; i < tbl8_group_end; i++) {
-			struct rte_lpm_tbl_entry_v20 new_tbl8_entry = {
-				.valid = VALID,
-				.depth = lpm->tbl24[tbl24_index].depth,
-				.valid_group = lpm->tbl8[i].valid_group,
-			};
-			new_tbl8_entry.next_hop =
-				lpm->tbl24[tbl24_index].next_hop;
-			__atomic_store(&lpm->tbl8[i], &new_tbl8_entry,
-					__ATOMIC_RELAXED);
-		}
-
-		tbl8_index = tbl8_group_start + (ip_masked & 0xFF);
-
-		/* Insert new rule into the tbl8 entry. */
-		for (i = tbl8_index; i < tbl8_index + tbl8_range; i++) {
-			struct rte_lpm_tbl_entry_v20 new_tbl8_entry = {
-				.valid = VALID,
-				.depth = depth,
-				.valid_group = lpm->tbl8[i].valid_group,
-			};
-			new_tbl8_entry.next_hop = next_hop;
-			__atomic_store(&lpm->tbl8[i], &new_tbl8_entry,
-					__ATOMIC_RELAXED);
-		}
-
-		/*
-		 * Update tbl24 entry to point to new tbl8 entry. Note: The
-		 * ext_flag and tbl8_index need to be updated simultaneously,
-		 * so assign whole structure in one go.
-		 */
-
-		struct rte_lpm_tbl_entry_v20 new_tbl24_entry = {
-				.group_idx = (uint8_t)tbl8_group_index,
-				.valid = VALID,
-				.valid_group = 1,
-				.depth = 0,
-		};
-
-		__atomic_store(&lpm->tbl24[tbl24_index], &new_tbl24_entry,
-				__ATOMIC_RELEASE);
-
-	} else { /*
-		* If it is valid, extended entry calculate the index into tbl8.
-		*/
-		tbl8_group_index = lpm->tbl24[tbl24_index].group_idx;
-		tbl8_group_start = tbl8_group_index *
-				RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-		tbl8_index = tbl8_group_start + (ip_masked & 0xFF);
-
-		for (i = tbl8_index; i < (tbl8_index + tbl8_range); i++) {
-
-			if (!lpm->tbl8[i].valid ||
-					lpm->tbl8[i].depth <= depth) {
-				struct rte_lpm_tbl_entry_v20 new_tbl8_entry = {
-					.valid = VALID,
-					.depth = depth,
-					.valid_group = lpm->tbl8[i].valid_group,
-				};
-				new_tbl8_entry.next_hop = next_hop;
-				/*
-				 * Setting tbl8 entry in one go to avoid race
-				 * condition
-				 */
-				__atomic_store(&lpm->tbl8[i], &new_tbl8_entry,
-						__ATOMIC_RELAXED);
-
-				continue;
-			}
-		}
-	}
-
-	return 0;
-}
-
-static __rte_noinline int32_t
-add_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
+add_depth_big(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
 		uint32_t next_hop)
 {
 #define group_idx next_hop
@@ -1038,7 +520,7 @@ add_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
 
 	if (!lpm->tbl24[tbl24_index].valid) {
 		/* Search for a free tbl8 group. */
-		tbl8_group_index = tbl8_alloc_v1604(lpm->tbl8, lpm->number_tbl8s);
+		tbl8_group_index = tbl8_alloc(lpm->tbl8, lpm->number_tbl8s);
 
 		/* Check tbl8 allocation was successful. */
 		if (tbl8_group_index < 0) {
@@ -1084,7 +566,7 @@ add_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
 	} /* If valid entry but not extended calculate the index into Table8. */
 	else if (lpm->tbl24[tbl24_index].valid_group == 0) {
 		/* Search for free tbl8 group. */
-		tbl8_group_index = tbl8_alloc_v1604(lpm->tbl8, lpm->number_tbl8s);
+		tbl8_group_index = tbl8_alloc(lpm->tbl8, lpm->number_tbl8s);
 
 		if (tbl8_group_index < 0) {
 			return tbl8_group_index;
@@ -1178,48 +660,7 @@ add_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
  * Add a route
  */
 int
-rte_lpm_add_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth,
-		uint8_t next_hop)
-{
-	int32_t rule_index, status = 0;
-	uint32_t ip_masked;
-
-	/* Check user arguments. */
-	if ((lpm == NULL) || (depth < 1) || (depth > RTE_LPM_MAX_DEPTH))
-		return -EINVAL;
-
-	ip_masked = ip & depth_to_mask(depth);
-
-	/* Add the rule to the rule table. */
-	rule_index = rule_add_v20(lpm, ip_masked, depth, next_hop);
-
-	/* If the is no space available for new rule return error. */
-	if (rule_index < 0) {
-		return rule_index;
-	}
-
-	if (depth <= MAX_DEPTH_TBL24) {
-		status = add_depth_small_v20(lpm, ip_masked, depth, next_hop);
-	} else { /* If depth > RTE_LPM_MAX_DEPTH_TBL24 */
-		status = add_depth_big_v20(lpm, ip_masked, depth, next_hop);
-
-		/*
-		 * If add fails due to exhaustion of tbl8 extensions delete
-		 * rule that was added to rule table.
-		 */
-		if (status < 0) {
-			rule_delete_v20(lpm, rule_index, depth);
-
-			return status;
-		}
-	}
-
-	return 0;
-}
-VERSION_SYMBOL(rte_lpm_add, _v20, 2.0);
-
-int
-rte_lpm_add_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
+rte_lpm_add(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
 		uint32_t next_hop)
 {
 	int32_t rule_index, status = 0;
@@ -1232,7 +673,7 @@ rte_lpm_add_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
 	ip_masked = ip & depth_to_mask(depth);
 
 	/* Add the rule to the rule table. */
-	rule_index = rule_add_v1604(lpm, ip_masked, depth, next_hop);
+	rule_index = rule_add(lpm, ip_masked, depth, next_hop);
 
 	/* If the is no space available for new rule return error. */
 	if (rule_index < 0) {
@@ -1240,16 +681,16 @@ rte_lpm_add_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
 	}
 
 	if (depth <= MAX_DEPTH_TBL24) {
-		status = add_depth_small_v1604(lpm, ip_masked, depth, next_hop);
+		status = add_depth_small(lpm, ip_masked, depth, next_hop);
 	} else { /* If depth > RTE_LPM_MAX_DEPTH_TBL24 */
-		status = add_depth_big_v1604(lpm, ip_masked, depth, next_hop);
+		status = add_depth_big(lpm, ip_masked, depth, next_hop);
 
 		/*
 		 * If add fails due to exhaustion of tbl8 extensions delete
 		 * rule that was added to rule table.
 		 */
 		if (status < 0) {
-			rule_delete_v1604(lpm, rule_index, depth);
+			rule_delete(lpm, rule_index, depth);
 
 			return status;
 		}
@@ -1257,42 +698,12 @@ rte_lpm_add_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
 
 	return 0;
 }
-BIND_DEFAULT_SYMBOL(rte_lpm_add, _v1604, 16.04);
-MAP_STATIC_SYMBOL(int rte_lpm_add(struct rte_lpm *lpm, uint32_t ip,
-		uint8_t depth, uint32_t next_hop), rte_lpm_add_v1604);
 
 /*
  * Look for a rule in the high-level rules table
  */
 int
-rte_lpm_is_rule_present_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth,
-uint8_t *next_hop)
-{
-	uint32_t ip_masked;
-	int32_t rule_index;
-
-	/* Check user arguments. */
-	if ((lpm == NULL) ||
-		(next_hop == NULL) ||
-		(depth < 1) || (depth > RTE_LPM_MAX_DEPTH))
-		return -EINVAL;
-
-	/* Look for the rule using rule_find. */
-	ip_masked = ip & depth_to_mask(depth);
-	rule_index = rule_find_v20(lpm, ip_masked, depth);
-
-	if (rule_index >= 0) {
-		*next_hop = lpm->rules_tbl[rule_index].next_hop;
-		return 1;
-	}
-
-	/* If rule is not found return 0. */
-	return 0;
-}
-VERSION_SYMBOL(rte_lpm_is_rule_present, _v20, 2.0);
-
-int
-rte_lpm_is_rule_present_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
+rte_lpm_is_rule_present(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
 uint32_t *next_hop)
 {
 	uint32_t ip_masked;
@@ -1306,7 +717,7 @@ uint32_t *next_hop)
 
 	/* Look for the rule using rule_find. */
 	ip_masked = ip & depth_to_mask(depth);
-	rule_index = rule_find_v1604(lpm, ip_masked, depth);
+	rule_index = rule_find(lpm, ip_masked, depth);
 
 	if (rule_index >= 0) {
 		*next_hop = lpm->rules_tbl[rule_index].next_hop;
@@ -1316,12 +727,9 @@ uint32_t *next_hop)
 	/* If rule is not found return 0. */
 	return 0;
 }
-BIND_DEFAULT_SYMBOL(rte_lpm_is_rule_present, _v1604, 16.04);
-MAP_STATIC_SYMBOL(int rte_lpm_is_rule_present(struct rte_lpm *lpm, uint32_t ip,
-		uint8_t depth, uint32_t *next_hop), rte_lpm_is_rule_present_v1604);
 
 static int32_t
-find_previous_rule_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth,
+find_previous_rule(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
 		uint8_t *sub_rule_depth)
 {
 	int32_t rule_index;
@@ -1331,7 +739,7 @@ find_previous_rule_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth,
 	for (prev_depth = (uint8_t)(depth - 1); prev_depth > 0; prev_depth--) {
 		ip_masked = ip & depth_to_mask(prev_depth);
 
-		rule_index = rule_find_v20(lpm, ip_masked, prev_depth);
+		rule_index = rule_find(lpm, ip_masked, prev_depth);
 
 		if (rule_index >= 0) {
 			*sub_rule_depth = prev_depth;
@@ -1343,133 +751,7 @@ find_previous_rule_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth,
 }
 
 static int32_t
-find_previous_rule_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
-		uint8_t *sub_rule_depth)
-{
-	int32_t rule_index;
-	uint32_t ip_masked;
-	uint8_t prev_depth;
-
-	for (prev_depth = (uint8_t)(depth - 1); prev_depth > 0; prev_depth--) {
-		ip_masked = ip & depth_to_mask(prev_depth);
-
-		rule_index = rule_find_v1604(lpm, ip_masked, prev_depth);
-
-		if (rule_index >= 0) {
-			*sub_rule_depth = prev_depth;
-			return rule_index;
-		}
-	}
-
-	return -1;
-}
-
-static int32_t
-delete_depth_small_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked,
-	uint8_t depth, int32_t sub_rule_index, uint8_t sub_rule_depth)
-{
-	uint32_t tbl24_range, tbl24_index, tbl8_group_index, tbl8_index, i, j;
-
-	/* Calculate the range and index into Table24. */
-	tbl24_range = depth_to_range(depth);
-	tbl24_index = (ip_masked >> 8);
-
-	/*
-	 * Firstly check the sub_rule_index. A -1 indicates no replacement rule
-	 * and a positive number indicates a sub_rule_index.
-	 */
-	if (sub_rule_index < 0) {
-		/*
-		 * If no replacement rule exists then invalidate entries
-		 * associated with this rule.
-		 */
-		for (i = tbl24_index; i < (tbl24_index + tbl24_range); i++) {
-
-			if (lpm->tbl24[i].valid_group == 0 &&
-					lpm->tbl24[i].depth <= depth) {
-				struct rte_lpm_tbl_entry_v20
-					zero_tbl24_entry = {
-						.valid = INVALID,
-						.depth = 0,
-						.valid_group = 0,
-					};
-					zero_tbl24_entry.next_hop = 0;
-				__atomic_store(&lpm->tbl24[i],
-					&zero_tbl24_entry, __ATOMIC_RELEASE);
-			} else if (lpm->tbl24[i].valid_group == 1) {
-				/*
-				 * If TBL24 entry is extended, then there has
-				 * to be a rule with depth >= 25 in the
-				 * associated TBL8 group.
-				 */
-
-				tbl8_group_index = lpm->tbl24[i].group_idx;
-				tbl8_index = tbl8_group_index *
-						RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-
-				for (j = tbl8_index; j < (tbl8_index +
-					RTE_LPM_TBL8_GROUP_NUM_ENTRIES); j++) {
-
-					if (lpm->tbl8[j].depth <= depth)
-						lpm->tbl8[j].valid = INVALID;
-				}
-			}
-		}
-	} else {
-		/*
-		 * If a replacement rule exists then modify entries
-		 * associated with this rule.
-		 */
-
-		struct rte_lpm_tbl_entry_v20 new_tbl24_entry = {
-			.next_hop = lpm->rules_tbl[sub_rule_index].next_hop,
-			.valid = VALID,
-			.valid_group = 0,
-			.depth = sub_rule_depth,
-		};
-
-		struct rte_lpm_tbl_entry_v20 new_tbl8_entry = {
-			.valid = VALID,
-			.valid_group = VALID,
-			.depth = sub_rule_depth,
-		};
-		new_tbl8_entry.next_hop =
-				lpm->rules_tbl[sub_rule_index].next_hop;
-
-		for (i = tbl24_index; i < (tbl24_index + tbl24_range); i++) {
-
-			if (lpm->tbl24[i].valid_group == 0 &&
-					lpm->tbl24[i].depth <= depth) {
-				__atomic_store(&lpm->tbl24[i], &new_tbl24_entry,
-						__ATOMIC_RELEASE);
-			} else  if (lpm->tbl24[i].valid_group == 1) {
-				/*
-				 * If TBL24 entry is extended, then there has
-				 * to be a rule with depth >= 25 in the
-				 * associated TBL8 group.
-				 */
-
-				tbl8_group_index = lpm->tbl24[i].group_idx;
-				tbl8_index = tbl8_group_index *
-						RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-
-				for (j = tbl8_index; j < (tbl8_index +
-					RTE_LPM_TBL8_GROUP_NUM_ENTRIES); j++) {
-
-					if (lpm->tbl8[j].depth <= depth)
-						__atomic_store(&lpm->tbl8[j],
-							&new_tbl8_entry,
-							__ATOMIC_RELAXED);
-				}
-			}
-		}
-	}
-
-	return 0;
-}
-
-static int32_t
-delete_depth_small_v1604(struct rte_lpm *lpm, uint32_t ip_masked,
+delete_depth_small(struct rte_lpm *lpm, uint32_t ip_masked,
 	uint8_t depth, int32_t sub_rule_index, uint8_t sub_rule_depth)
 {
 #define group_idx next_hop
@@ -1576,7 +858,7 @@ delete_depth_small_v1604(struct rte_lpm *lpm, uint32_t ip_masked,
  * thus can be recycled
  */
 static int32_t
-tbl8_recycle_check_v20(struct rte_lpm_tbl_entry_v20 *tbl8,
+tbl8_recycle_check(struct rte_lpm_tbl_entry *tbl8,
 		uint32_t tbl8_group_start)
 {
 	uint32_t tbl8_group_end, i;
@@ -1623,140 +905,7 @@ tbl8_recycle_check_v20(struct rte_lpm_tbl_entry_v20 *tbl8,
 }
 
 static int32_t
-tbl8_recycle_check_v1604(struct rte_lpm_tbl_entry *tbl8,
-		uint32_t tbl8_group_start)
-{
-	uint32_t tbl8_group_end, i;
-	tbl8_group_end = tbl8_group_start + RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-
-	/*
-	 * Check the first entry of the given tbl8. If it is invalid we know
-	 * this tbl8 does not contain any rule with a depth < RTE_LPM_MAX_DEPTH
-	 *  (As they would affect all entries in a tbl8) and thus this table
-	 *  can not be recycled.
-	 */
-	if (tbl8[tbl8_group_start].valid) {
-		/*
-		 * If first entry is valid check if the depth is less than 24
-		 * and if so check the rest of the entries to verify that they
-		 * are all of this depth.
-		 */
-		if (tbl8[tbl8_group_start].depth <= MAX_DEPTH_TBL24) {
-			for (i = (tbl8_group_start + 1); i < tbl8_group_end;
-					i++) {
-
-				if (tbl8[i].depth !=
-						tbl8[tbl8_group_start].depth) {
-
-					return -EEXIST;
-				}
-			}
-			/* If all entries are the same return the tb8 index */
-			return tbl8_group_start;
-		}
-
-		return -EEXIST;
-	}
-	/*
-	 * If the first entry is invalid check if the rest of the entries in
-	 * the tbl8 are invalid.
-	 */
-	for (i = (tbl8_group_start + 1); i < tbl8_group_end; i++) {
-		if (tbl8[i].valid)
-			return -EEXIST;
-	}
-	/* If no valid entries are found then return -EINVAL. */
-	return -EINVAL;
-}
-
-static int32_t
-delete_depth_big_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked,
-	uint8_t depth, int32_t sub_rule_index, uint8_t sub_rule_depth)
-{
-	uint32_t tbl24_index, tbl8_group_index, tbl8_group_start, tbl8_index,
-			tbl8_range, i;
-	int32_t tbl8_recycle_index;
-
-	/*
-	 * Calculate the index into tbl24 and range. Note: All depths larger
-	 * than MAX_DEPTH_TBL24 are associated with only one tbl24 entry.
-	 */
-	tbl24_index = ip_masked >> 8;
-
-	/* Calculate the index into tbl8 and range. */
-	tbl8_group_index = lpm->tbl24[tbl24_index].group_idx;
-	tbl8_group_start = tbl8_group_index * RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-	tbl8_index = tbl8_group_start + (ip_masked & 0xFF);
-	tbl8_range = depth_to_range(depth);
-
-	if (sub_rule_index < 0) {
-		/*
-		 * Loop through the range of entries on tbl8 for which the
-		 * rule_to_delete must be removed or modified.
-		 */
-		for (i = tbl8_index; i < (tbl8_index + tbl8_range); i++) {
-			if (lpm->tbl8[i].depth <= depth)
-				lpm->tbl8[i].valid = INVALID;
-		}
-	} else {
-		/* Set new tbl8 entry. */
-		struct rte_lpm_tbl_entry_v20 new_tbl8_entry = {
-			.valid = VALID,
-			.depth = sub_rule_depth,
-			.valid_group = lpm->tbl8[tbl8_group_start].valid_group,
-		};
-
-		new_tbl8_entry.next_hop =
-				lpm->rules_tbl[sub_rule_index].next_hop;
-		/*
-		 * Loop through the range of entries on tbl8 for which the
-		 * rule_to_delete must be modified.
-		 */
-		for (i = tbl8_index; i < (tbl8_index + tbl8_range); i++) {
-			if (lpm->tbl8[i].depth <= depth)
-				__atomic_store(&lpm->tbl8[i], &new_tbl8_entry,
-						__ATOMIC_RELAXED);
-		}
-	}
-
-	/*
-	 * Check if there are any valid entries in this tbl8 group. If all
-	 * tbl8 entries are invalid we can free the tbl8 and invalidate the
-	 * associated tbl24 entry.
-	 */
-
-	tbl8_recycle_index = tbl8_recycle_check_v20(lpm->tbl8, tbl8_group_start);
-
-	if (tbl8_recycle_index == -EINVAL) {
-		/* Set tbl24 before freeing tbl8 to avoid race condition.
-		 * Prevent the free of the tbl8 group from hoisting.
-		 */
-		lpm->tbl24[tbl24_index].valid = 0;
-		__atomic_thread_fence(__ATOMIC_RELEASE);
-		tbl8_free_v20(lpm->tbl8, tbl8_group_start);
-	} else if (tbl8_recycle_index > -1) {
-		/* Update tbl24 entry. */
-		struct rte_lpm_tbl_entry_v20 new_tbl24_entry = {
-			.next_hop = lpm->tbl8[tbl8_recycle_index].next_hop,
-			.valid = VALID,
-			.valid_group = 0,
-			.depth = lpm->tbl8[tbl8_recycle_index].depth,
-		};
-
-		/* Set tbl24 before freeing tbl8 to avoid race condition.
-		 * Prevent the free of the tbl8 group from hoisting.
-		 */
-		__atomic_store(&lpm->tbl24[tbl24_index], &new_tbl24_entry,
-				__ATOMIC_RELAXED);
-		__atomic_thread_fence(__ATOMIC_RELEASE);
-		tbl8_free_v20(lpm->tbl8, tbl8_group_start);
-	}
-
-	return 0;
-}
-
-static int32_t
-delete_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked,
+delete_depth_big(struct rte_lpm *lpm, uint32_t ip_masked,
 	uint8_t depth, int32_t sub_rule_index, uint8_t sub_rule_depth)
 {
 #define group_idx next_hop
@@ -1811,7 +960,7 @@ delete_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked,
 	 * associated tbl24 entry.
 	 */
 
-	tbl8_recycle_index = tbl8_recycle_check_v1604(lpm->tbl8, tbl8_group_start);
+	tbl8_recycle_index = tbl8_recycle_check(lpm->tbl8, tbl8_group_start);
 
 	if (tbl8_recycle_index == -EINVAL) {
 		/* Set tbl24 before freeing tbl8 to avoid race condition.
@@ -1819,7 +968,7 @@ delete_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked,
 		 */
 		lpm->tbl24[tbl24_index].valid = 0;
 		__atomic_thread_fence(__ATOMIC_RELEASE);
-		tbl8_free_v1604(lpm->tbl8, tbl8_group_start);
+		tbl8_free(lpm->tbl8, tbl8_group_start);
 	} else if (tbl8_recycle_index > -1) {
 		/* Update tbl24 entry. */
 		struct rte_lpm_tbl_entry new_tbl24_entry = {
@@ -1835,7 +984,7 @@ delete_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked,
 		__atomic_store(&lpm->tbl24[tbl24_index], &new_tbl24_entry,
 				__ATOMIC_RELAXED);
 		__atomic_thread_fence(__ATOMIC_RELEASE);
-		tbl8_free_v1604(lpm->tbl8, tbl8_group_start);
+		tbl8_free(lpm->tbl8, tbl8_group_start);
 	}
 #undef group_idx
 	return 0;
@@ -1845,7 +994,7 @@ delete_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked,
  * Deletes a rule
  */
 int
-rte_lpm_delete_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth)
+rte_lpm_delete(struct rte_lpm *lpm, uint32_t ip, uint8_t depth)
 {
 	int32_t rule_to_delete_index, sub_rule_index;
 	uint32_t ip_masked;
@@ -1864,7 +1013,7 @@ rte_lpm_delete_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth)
 	 * Find the index of the input rule, that needs to be deleted, in the
 	 * rule table.
 	 */
-	rule_to_delete_index = rule_find_v20(lpm, ip_masked, depth);
+	rule_to_delete_index = rule_find(lpm, ip_masked, depth);
 
 	/*
 	 * Check if rule_to_delete_index was found. If no rule was found the
@@ -1874,7 +1023,7 @@ rte_lpm_delete_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth)
 		return -EINVAL;
 
 	/* Delete the rule from the rule table. */
-	rule_delete_v20(lpm, rule_to_delete_index, depth);
+	rule_delete(lpm, rule_to_delete_index, depth);
 
 	/*
 	 * Find rule to replace the rule_to_delete. If there is no rule to
@@ -1882,100 +1031,26 @@ rte_lpm_delete_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth)
 	 * entries associated with this rule.
 	 */
 	sub_rule_depth = 0;
-	sub_rule_index = find_previous_rule_v20(lpm, ip, depth, &sub_rule_depth);
+	sub_rule_index = find_previous_rule(lpm, ip, depth, &sub_rule_depth);
 
 	/*
 	 * If the input depth value is less than 25 use function
 	 * delete_depth_small otherwise use delete_depth_big.
 	 */
 	if (depth <= MAX_DEPTH_TBL24) {
-		return delete_depth_small_v20(lpm, ip_masked, depth,
+		return delete_depth_small(lpm, ip_masked, depth,
 				sub_rule_index, sub_rule_depth);
 	} else { /* If depth > MAX_DEPTH_TBL24 */
-		return delete_depth_big_v20(lpm, ip_masked, depth, sub_rule_index,
+		return delete_depth_big(lpm, ip_masked, depth, sub_rule_index,
 				sub_rule_depth);
 	}
 }
-VERSION_SYMBOL(rte_lpm_delete, _v20, 2.0);
-
-int
-rte_lpm_delete_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth)
-{
-	int32_t rule_to_delete_index, sub_rule_index;
-	uint32_t ip_masked;
-	uint8_t sub_rule_depth;
-	/*
-	 * Check input arguments. Note: IP must be a positive integer of 32
-	 * bits in length therefore it need not be checked.
-	 */
-	if ((lpm == NULL) || (depth < 1) || (depth > RTE_LPM_MAX_DEPTH)) {
-		return -EINVAL;
-	}
-
-	ip_masked = ip & depth_to_mask(depth);
-
-	/*
-	 * Find the index of the input rule, that needs to be deleted, in the
-	 * rule table.
-	 */
-	rule_to_delete_index = rule_find_v1604(lpm, ip_masked, depth);
-
-	/*
-	 * Check if rule_to_delete_index was found. If no rule was found the
-	 * function rule_find returns -EINVAL.
-	 */
-	if (rule_to_delete_index < 0)
-		return -EINVAL;
-
-	/* Delete the rule from the rule table. */
-	rule_delete_v1604(lpm, rule_to_delete_index, depth);
-
-	/*
-	 * Find rule to replace the rule_to_delete. If there is no rule to
-	 * replace the rule_to_delete we return -1 and invalidate the table
-	 * entries associated with this rule.
-	 */
-	sub_rule_depth = 0;
-	sub_rule_index = find_previous_rule_v1604(lpm, ip, depth, &sub_rule_depth);
-
-	/*
-	 * If the input depth value is less than 25 use function
-	 * delete_depth_small otherwise use delete_depth_big.
-	 */
-	if (depth <= MAX_DEPTH_TBL24) {
-		return delete_depth_small_v1604(lpm, ip_masked, depth,
-				sub_rule_index, sub_rule_depth);
-	} else { /* If depth > MAX_DEPTH_TBL24 */
-		return delete_depth_big_v1604(lpm, ip_masked, depth, sub_rule_index,
-				sub_rule_depth);
-	}
-}
-BIND_DEFAULT_SYMBOL(rte_lpm_delete, _v1604, 16.04);
-MAP_STATIC_SYMBOL(int rte_lpm_delete(struct rte_lpm *lpm, uint32_t ip,
-		uint8_t depth), rte_lpm_delete_v1604);
 
 /*
  * Delete all rules from the LPM table.
  */
 void
-rte_lpm_delete_all_v20(struct rte_lpm_v20 *lpm)
-{
-	/* Zero rule information. */
-	memset(lpm->rule_info, 0, sizeof(lpm->rule_info));
-
-	/* Zero tbl24. */
-	memset(lpm->tbl24, 0, sizeof(lpm->tbl24));
-
-	/* Zero tbl8. */
-	memset(lpm->tbl8, 0, sizeof(lpm->tbl8));
-
-	/* Delete all rules form the rules table. */
-	memset(lpm->rules_tbl, 0, sizeof(lpm->rules_tbl[0]) * lpm->max_rules);
-}
-VERSION_SYMBOL(rte_lpm_delete_all, _v20, 2.0);
-
-void
-rte_lpm_delete_all_v1604(struct rte_lpm *lpm)
+rte_lpm_delete_all(struct rte_lpm *lpm)
 {
 	/* Zero rule information. */
 	memset(lpm->rule_info, 0, sizeof(lpm->rule_info));
@@ -1990,6 +1065,3 @@ rte_lpm_delete_all_v1604(struct rte_lpm *lpm)
 	/* Delete all rules form the rules table. */
 	memset(lpm->rules_tbl, 0, sizeof(lpm->rules_tbl[0]) * lpm->max_rules);
 }
-BIND_DEFAULT_SYMBOL(rte_lpm_delete_all, _v1604, 16.04);
-MAP_STATIC_SYMBOL(void rte_lpm_delete_all(struct rte_lpm *lpm),
-		rte_lpm_delete_all_v1604);
lib/librte_lpm/rte_lpm.h +0 -88

154 lines not on this page · raw message

lib/librte_lpm/rte_lpm6.c +14 -118

208 lines not on this page · raw message

lib/librte_lpm/rte_lpm6.h +0 -25
index 5d59ccb1fe..37dfb20249 100644
@@ -96,12 +96,6 @@ rte_lpm6_free(struct rte_lpm6 *lpm);
 int
 rte_lpm6_add(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth,
 		uint32_t next_hop);
-int
-rte_lpm6_add_v20(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth,
-		uint8_t next_hop);
-int
-rte_lpm6_add_v1705(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth,
-		uint32_t next_hop);
 
 /**
  * Check if a rule is present in the LPM table,
@@ -121,12 +115,6 @@ rte_lpm6_add_v1705(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth,
 int
 rte_lpm6_is_rule_present(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth,
 		uint32_t *next_hop);
-int
-rte_lpm6_is_rule_present_v20(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth,
-		uint8_t *next_hop);
-int
-rte_lpm6_is_rule_present_v1705(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth,
-		uint32_t *next_hop);
 
 /**
  * Delete a rule from the LPM table.
@@ -184,11 +172,6 @@ rte_lpm6_delete_all(struct rte_lpm6 *lpm);
  */
 int
 rte_lpm6_lookup(const struct rte_lpm6 *lpm, uint8_t *ip, uint32_t *next_hop);
-int
-rte_lpm6_lookup_v20(const struct rte_lpm6 *lpm, uint8_t *ip, uint8_t *next_hop);
-int
-rte_lpm6_lookup_v1705(const struct rte_lpm6 *lpm, uint8_t *ip,
-		uint32_t *next_hop);
 
 /**
  * Lookup multiple IP addresses in an LPM table.
@@ -210,14 +193,6 @@ int
 rte_lpm6_lookup_bulk_func(const struct rte_lpm6 *lpm,
 		uint8_t ips[][RTE_LPM6_IPV6_ADDR_SIZE],
 		int32_t *next_hops, unsigned int n);
-int
-rte_lpm6_lookup_bulk_func_v20(const struct rte_lpm6 *lpm,
-		uint8_t ips[][RTE_LPM6_IPV6_ADDR_SIZE],
-		int16_t *next_hops, unsigned int n);
-int
-rte_lpm6_lookup_bulk_func_v1705(const struct rte_lpm6 *lpm,
-		uint8_t ips[][RTE_LPM6_IPV6_ADDR_SIZE],
-		int32_t *next_hops, unsigned int n);
 
 #ifdef __cplusplus
 }
Signature · 1 line
2.17.1
#76 lore raw

PATCH v6 6/10 distributor: remove deprecated code

In reply to Anatoly Burakov

From: Marcin Baran <[email protected]>

Remove code for old ABI versions ahead of ABI version bump.

---

Notes:
v5:
- Fixed shared library linking error due to versioning still enabled

v2:
- Moved this to before ABI version bump to avoid compile breakage

v2:
- Moved this to before ABI version bump to avoid compile breakage

 lib/librte_distributor/rte_distributor.c      | 56 +++--------------
 .../rte_distributor_v1705.h                   | 61 -------------------
 lib/librte_distributor/rte_distributor_v20.c  |  9 ---
 3 files changed, 9 insertions(+), 117 deletions(-)
 delete mode 100644 lib/librte_distributor/rte_distributor_v1705.h
lib/librte_distributor/rte_distributor.c +9 -47
index 7df97df92d..a4c8ff6a96 100644
@@ -18,7 +18,6 @@
 
 #include "rte_distributor.h"
 #include "rte_distributor_v20.h"
-#include "rte_distributor_v1705.h"
 #include "distributor_private.h"
 
 TAILQ_HEAD(rte_dist_burst_list, rte_distributor);
@@ -33,7 +32,7 @@ EAL_REGISTER_TAILQ(rte_dist_burst_tailq)
 /**** Burst Packet APIs called by workers ****/
 
 void
-rte_distributor_request_pkt_v1705(struct rte_distributor *d,
+rte_distributor_request_pkt(struct rte_distributor *d,
 		unsigned int worker_id, struct rte_mbuf **oldpkt,
 		unsigned int count)
 {
@@ -83,14 +82,9 @@ rte_distributor_request_pkt_v1705(struct rte_distributor *d,
 	__atomic_store_n(retptr64, *retptr64 | RTE_DISTRIB_GET_BUF,
 			__ATOMIC_RELEASE);
 }
-BIND_DEFAULT_SYMBOL(rte_distributor_request_pkt, _v1705, 17.05);
-MAP_STATIC_SYMBOL(void rte_distributor_request_pkt(struct rte_distributor *d,
-		unsigned int worker_id, struct rte_mbuf **oldpkt,
-		unsigned int count),
-		rte_distributor_request_pkt_v1705);
 
 int
-rte_distributor_poll_pkt_v1705(struct rte_distributor *d,
+rte_distributor_poll_pkt(struct rte_distributor *d,
 		unsigned int worker_id, struct rte_mbuf **pkts)
 {
 	struct rte_distributor_buffer *buf = &d->bufs[worker_id];
@@ -129,13 +123,9 @@ rte_distributor_poll_pkt_v1705(struct rte_distributor *d,
 
 	return count;
 }
-BIND_DEFAULT_SYMBOL(rte_distributor_poll_pkt, _v1705, 17.05);
-MAP_STATIC_SYMBOL(int rte_distributor_poll_pkt(struct rte_distributor *d,
-		unsigned int worker_id, struct rte_mbuf **pkts),
-		rte_distributor_poll_pkt_v1705);
 
 int
-rte_distributor_get_pkt_v1705(struct rte_distributor *d,
+rte_distributor_get_pkt(struct rte_distributor *d,
 		unsigned int worker_id, struct rte_mbuf **pkts,
 		struct rte_mbuf **oldpkt, unsigned int return_count)
 {
@@ -163,14 +153,9 @@ rte_distributor_get_pkt_v1705(struct rte_distributor *d,
 	}
 	return count;
 }
-BIND_DEFAULT_SYMBOL(rte_distributor_get_pkt, _v1705, 17.05);
-MAP_STATIC_SYMBOL(int rte_distributor_get_pkt(struct rte_distributor *d,
-		unsigned int worker_id, struct rte_mbuf **pkts,
-		struct rte_mbuf **oldpkt, unsigned int return_count),
-		rte_distributor_get_pkt_v1705);
 
 int
-rte_distributor_return_pkt_v1705(struct rte_distributor *d,
+rte_distributor_return_pkt(struct rte_distributor *d,
 		unsigned int worker_id, struct rte_mbuf **oldpkt, int num)
 {
 	struct rte_distributor_buffer *buf = &d->bufs[worker_id];
@@ -202,10 +187,6 @@ rte_distributor_return_pkt_v1705(struct rte_distributor *d,
 
 	return 0;
 }
-BIND_DEFAULT_SYMBOL(rte_distributor_return_pkt, _v1705, 17.05);
-MAP_STATIC_SYMBOL(int rte_distributor_return_pkt(struct rte_distributor *d,
-		unsigned int worker_id, struct rte_mbuf **oldpkt, int num),
-		rte_distributor_return_pkt_v1705);
 
 /**** APIs called on distributor core ***/
 
@@ -360,7 +341,7 @@ release(struct rte_distributor *d, unsigned int wkr)
 
 /* process a set of packets to distribute them to workers */
 int
-rte_distributor_process_v1705(struct rte_distributor *d,
+rte_distributor_process(struct rte_distributor *d,
 		struct rte_mbuf **mbufs, unsigned int num_mbufs)
 {
 	unsigned int next_idx = 0;
@@ -500,14 +481,10 @@ rte_distributor_process_v1705(struct rte_distributor *d,
 
 	return num_mbufs;
 }
-BIND_DEFAULT_SYMBOL(rte_distributor_process, _v1705, 17.05);
-MAP_STATIC_SYMBOL(int rte_distributor_process(struct rte_distributor *d,
-		struct rte_mbuf **mbufs, unsigned int num_mbufs),
-		rte_distributor_process_v1705);
 
 /* return to the caller, packets returned from workers */
 int
-rte_distributor_returned_pkts_v1705(struct rte_distributor *d,
+rte_distributor_returned_pkts(struct rte_distributor *d,
 		struct rte_mbuf **mbufs, unsigned int max_mbufs)
 {
 	struct rte_distributor_returned_pkts *returns = &d->returns;
@@ -532,10 +509,6 @@ rte_distributor_returned_pkts_v1705(struct rte_distributor *d,
 
 	return retval;
 }
-BIND_DEFAULT_SYMBOL(rte_distributor_returned_pkts, _v1705, 17.05);
-MAP_STATIC_SYMBOL(int rte_distributor_returned_pkts(struct rte_distributor *d,
-		struct rte_mbuf **mbufs, unsigned int max_mbufs),
-		rte_distributor_returned_pkts_v1705);
 
 /*
  * Return the number of packets in-flight in a distributor, i.e. packets
@@ -557,7 +530,7 @@ total_outstanding(const struct rte_distributor *d)
  * queued up.
  */
 int
-rte_distributor_flush_v1705(struct rte_distributor *d)
+rte_distributor_flush(struct rte_distributor *d)
 {
 	unsigned int flushed;
 	unsigned int wkr;
@@ -586,13 +559,10 @@ rte_distributor_flush_v1705(struct rte_distributor *d)
 
 	return flushed;
 }
-BIND_DEFAULT_SYMBOL(rte_distributor_flush, _v1705, 17.05);
-MAP_STATIC_SYMBOL(int rte_distributor_flush(struct rte_distributor *d),
-		rte_distributor_flush_v1705);
 
 /* clears the internal returns array in the distributor */
 void
-rte_distributor_clear_returns_v1705(struct rte_distributor *d)
+rte_distributor_clear_returns(struct rte_distributor *d)
 {
 	unsigned int wkr;
 
@@ -608,13 +578,10 @@ rte_distributor_clear_returns_v1705(struct rte_distributor *d)
 		__atomic_store_n(&(d->bufs[wkr].retptr64[0]), 0,
 				__ATOMIC_RELEASE);
 }
-BIND_DEFAULT_SYMBOL(rte_distributor_clear_returns, _v1705, 17.05);
-MAP_STATIC_SYMBOL(void rte_distributor_clear_returns(struct rte_distributor *d),
-		rte_distributor_clear_returns_v1705);
 
 /* creates a distributor instance */
 struct rte_distributor *
-rte_distributor_create_v1705(const char *name,
+rte_distributor_create(const char *name,
 		unsigned int socket_id,
 		unsigned int num_workers,
 		unsigned int alg_type)
@@ -688,8 +655,3 @@ rte_distributor_create_v1705(const char *name,
 
 	return d;
 }
-BIND_DEFAULT_SYMBOL(rte_distributor_create, _v1705, 17.05);
-MAP_STATIC_SYMBOL(struct rte_distributor *rte_distributor_create(
-		const char *name, unsigned int socket_id,
-		unsigned int num_workers, unsigned int alg_type),
-		rte_distributor_create_v1705);
lib/librte_distributor/rte_distributor_v1705.h deleted +0 -61

61 lines not on this page · raw message

lib/librte_distributor/rte_distributor_v20.c +0 -9
index db6c49258a..53fa16d27d 100644
@@ -41,7 +41,6 @@ rte_distributor_request_pkt_v20(struct rte_distributor_v20 *d,
 	/* Sync with distributor on GET_BUF flag. */
 	__atomic_store_n(&(buf->bufptr64), req, __ATOMIC_RELEASE);
 }
-VERSION_SYMBOL(rte_distributor_request_pkt, _v20, 2.0);
 
 struct rte_mbuf *
 rte_distributor_poll_pkt_v20(struct rte_distributor_v20 *d,
@@ -57,7 +56,6 @@ rte_distributor_poll_pkt_v20(struct rte_distributor_v20 *d,
 	int64_t ret = buf->bufptr64 >> RTE_DISTRIB_FLAG_BITS;
 	return (struct rte_mbuf *)((uintptr_t)ret);
 }
-VERSION_SYMBOL(rte_distributor_poll_pkt, _v20, 2.0);
 
 struct rte_mbuf *
 rte_distributor_get_pkt_v20(struct rte_distributor_v20 *d,
@@ -69,7 +67,6 @@ rte_distributor_get_pkt_v20(struct rte_distributor_v20 *d,
 		rte_pause();
 	return ret;
 }
-VERSION_SYMBOL(rte_distributor_get_pkt, _v20, 2.0);
 
 int
 rte_distributor_return_pkt_v20(struct rte_distributor_v20 *d,
@@ -82,7 +79,6 @@ rte_distributor_return_pkt_v20(struct rte_distributor_v20 *d,
 	__atomic_store_n(&(buf->bufptr64), req, __ATOMIC_RELEASE);
 	return 0;
 }
-VERSION_SYMBOL(rte_distributor_return_pkt, _v20, 2.0);
 
 /**** APIs called on distributor core ***/
 
@@ -318,7 +314,6 @@ rte_distributor_process_v20(struct rte_distributor_v20 *d,
 	d->returns.count = ret_count;
 	return num_mbufs;
 }
-VERSION_SYMBOL(rte_distributor_process, _v20, 2.0);
 
 /* return to the caller, packets returned from workers */
 int
@@ -339,7 +334,6 @@ rte_distributor_returned_pkts_v20(struct rte_distributor_v20 *d,
 
 	return retval;
 }
-VERSION_SYMBOL(rte_distributor_returned_pkts, _v20, 2.0);
 
 /* return the number of packets in-flight in a distributor, i.e. packets
  * being worked on or queued up in a backlog.
@@ -369,7 +363,6 @@ rte_distributor_flush_v20(struct rte_distributor_v20 *d)
 
 	return flushed;
 }
-VERSION_SYMBOL(rte_distributor_flush, _v20, 2.0);
 
 /* clears the internal returns array in the distributor */
 void
@@ -380,7 +373,6 @@ rte_distributor_clear_returns_v20(struct rte_distributor_v20 *d)
 	memset(d->returns.mbufs, 0, sizeof(d->returns.mbufs));
 #endif
 }
-VERSION_SYMBOL(rte_distributor_clear_returns, _v20, 2.0);
 
 /* creates a distributor instance */
 struct rte_distributor_v20 *
@@ -424,4 +416,3 @@ rte_distributor_create_v20(const char *name,
 
 	return d;
 }
-VERSION_SYMBOL(rte_distributor_create, _v20, 2.0);
Signature · 1 line
2.17.1
#77 lore raw

PATCH v6 7/10 distributor: rename v2.0 ABI to _single suffix

In reply to Anatoly Burakov

From: Marcin Baran <[email protected]>

The original ABI versioning was slightly misleading in that the DPDK 2.0 ABI was really a single mode for the distributor, and is used as such throughout the distributor code.

Fix this by renaming all _v20 API's to _single API's, and remove symbol versioning.

---

Notes:
v4:
- Changed it back to how it was with v2
- Removed remaining v2.0 symbols

v3:
- Removed single mode from distributor as per Dave's comments

v2:
- Moved this to before ABI version bump to avoid compile breakage

 lib/librte_distributor/Makefile               |  2 +-
 lib/librte_distributor/distributor_private.h  | 10 ++--
 lib/librte_distributor/meson.build            |  2 +-
 lib/librte_distributor/rte_distributor.c      | 24 +++++-----
 ...ributor_v20.c => rte_distributor_single.c} | 48 +++++++++----------
 ...ributor_v20.h => rte_distributor_single.h} | 26 +++++-----
 .../rte_distributor_version.map               | 18 +------
 7 files changed, 58 insertions(+), 72 deletions(-)
 rename lib/librte_distributor/{rte_distributor_v20.c => rte_distributor_single.c} (88%)
 rename lib/librte_distributor/{rte_distributor_v20.h => rte_distributor_single.h} (89%)
lib/librte_distributor/Makefile +1 -1
index 0ef80dcff4..d9d0089166 100644
@@ -15,7 +15,7 @@ EXPORT_MAP := rte_distributor_version.map
 LIBABIVER := 1
 
 # all source are stored in SRCS-y
-SRCS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) := rte_distributor_v20.c
+SRCS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) := rte_distributor_single.c
 SRCS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) += rte_distributor.c
 ifeq ($(CONFIG_RTE_ARCH_X86),y)
 SRCS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) += rte_distributor_match_sse.c
lib/librte_distributor/distributor_private.h +5 -5
index c89371123e..489aef2acb 100644
@@ -55,7 +55,7 @@ extern "C" {
  * the next cache line to worker 0, we pad this out to three cache lines.
  * Only 64-bits of the memory is actually used though.
  */
-union rte_distributor_buffer_v20 {
+union rte_distributor_buffer_single {
 	volatile int64_t bufptr64;
 	char pad[RTE_CACHE_LINE_SIZE*3];
 } __rte_cache_aligned;
@@ -80,8 +80,8 @@ struct rte_distributor_returned_pkts {
 	struct rte_mbuf *mbufs[RTE_DISTRIB_MAX_RETURNS];
 };
 
-struct rte_distributor_v20 {
-	TAILQ_ENTRY(rte_distributor_v20) next;    /**< Next in list. */
+struct rte_distributor_single {
+	TAILQ_ENTRY(rte_distributor_single) next;    /**< Next in list. */
 
 	char name[RTE_DISTRIBUTOR_NAMESIZE];  /**< Name of the ring. */
 	unsigned int num_workers;             /**< Number of workers polling */
@@ -96,7 +96,7 @@ struct rte_distributor_v20 {
 
 	struct rte_distributor_backlog backlog[RTE_DISTRIB_MAX_WORKERS];
 
-	union rte_distributor_buffer_v20 bufs[RTE_DISTRIB_MAX_WORKERS];
+	union rte_distributor_buffer_single bufs[RTE_DISTRIB_MAX_WORKERS];
 
 	struct rte_distributor_returned_pkts returns;
 };
@@ -154,7 +154,7 @@ struct rte_distributor {
 
 	enum rte_distributor_match_function dist_match_fn;
 
-	struct rte_distributor_v20 *d_v20;
+	struct rte_distributor_single *d_single;
 };
 
 void
lib/librte_distributor/meson.build +1 -1
index c9617d7b14..50b91887b5 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-sources = files('rte_distributor.c', 'rte_distributor_v20.c')
+sources = files('rte_distributor.c', 'rte_distributor_single.c')
 if arch_subdir == 'x86'
 	sources += files('rte_distributor_match_sse.c')
 else
lib/librte_distributor/rte_distributor.c +13 -11
index a4c8ff6a96..6c5b0c86e8 100644
@@ -17,7 +17,7 @@
 #include <rte_tailq.h>
 
 #include "rte_distributor.h"
-#include "rte_distributor_v20.h"
+#include "rte_distributor_single.h"
 #include "distributor_private.h"
 
 TAILQ_HEAD(rte_dist_burst_list, rte_distributor);
@@ -42,7 +42,7 @@ rte_distributor_request_pkt(struct rte_distributor *d,
 	volatile int64_t *retptr64;
 
 	if (unlikely(d->alg_type == RTE_DIST_ALG_SINGLE)) {
-		rte_distributor_request_pkt_v20(d->d_v20,
+		rte_distributor_request_pkt_single(d->d_single,
 			worker_id, oldpkt[0]);
 		return;
 	}
@@ -93,7 +93,8 @@ rte_distributor_poll_pkt(struct rte_distributor *d,
 	unsigned int i;
 
 	if (unlikely(d->alg_type == RTE_DIST_ALG_SINGLE)) {
-		pkts[0] = rte_distributor_poll_pkt_v20(d->d_v20, worker_id);
+		pkts[0] = rte_distributor_poll_pkt_single(d->d_single,
+			worker_id);
 		return (pkts[0]) ? 1 : 0;
 	}
 
@@ -133,7 +134,7 @@ rte_distributor_get_pkt(struct rte_distributor *d,
 
 	if (unlikely(d->alg_type == RTE_DIST_ALG_SINGLE)) {
 		if (return_count <= 1) {
-			pkts[0] = rte_distributor_get_pkt_v20(d->d_v20,
+			pkts[0] = rte_distributor_get_pkt_single(d->d_single,
 				worker_id, oldpkt[0]);
 			return (pkts[0]) ? 1 : 0;
 		} else
@@ -163,7 +164,7 @@ rte_distributor_return_pkt(struct rte_distributor *d,
 
 	if (unlikely(d->alg_type == RTE_DIST_ALG_SINGLE)) {
 		if (num == 1)
-			return rte_distributor_return_pkt_v20(d->d_v20,
+			return rte_distributor_return_pkt_single(d->d_single,
 				worker_id, oldpkt[0]);
 		else
 			return -EINVAL;
@@ -354,7 +355,8 @@ rte_distributor_process(struct rte_distributor *d,
 
 	if (d->alg_type == RTE_DIST_ALG_SINGLE) {
 		/* Call the old API */
-		return rte_distributor_process_v20(d->d_v20, mbufs, num_mbufs);
+		return rte_distributor_process_single(d->d_single,
+			mbufs, num_mbufs);
 	}
 
 	if (unlikely(num_mbufs == 0)) {
@@ -494,7 +496,7 @@ rte_distributor_returned_pkts(struct rte_distributor *d,
 
 	if (d->alg_type == RTE_DIST_ALG_SINGLE) {
 		/* Call the old API */
-		return rte_distributor_returned_pkts_v20(d->d_v20,
+		return rte_distributor_returned_pkts_single(d->d_single,
 				mbufs, max_mbufs);
 	}
 
@@ -537,7 +539,7 @@ rte_distributor_flush(struct rte_distributor *d)
 
 	if (d->alg_type == RTE_DIST_ALG_SINGLE) {
 		/* Call the old API */
-		return rte_distributor_flush_v20(d->d_v20);
+		return rte_distributor_flush_single(d->d_single);
 	}
 
 	flushed = total_outstanding(d);
@@ -568,7 +570,7 @@ rte_distributor_clear_returns(struct rte_distributor *d)
 
 	if (d->alg_type == RTE_DIST_ALG_SINGLE) {
 		/* Call the old API */
-		rte_distributor_clear_returns_v20(d->d_v20);
+		rte_distributor_clear_returns_single(d->d_single);
 		return;
 	}
 
@@ -610,9 +612,9 @@ rte_distributor_create(const char *name,
 			rte_errno = ENOMEM;
 			return NULL;
 		}
-		d->d_v20 = rte_distributor_create_v20(name,
+		d->d_single = rte_distributor_create_single(name,
 				socket_id, num_workers);
-		if (d->d_v20 == NULL) {
+		if (d->d_single == NULL) {
 			free(d);
 			/* rte_errno will have been set */
 			return NULL;
lib/librte_distributor/rte_distributor_single.c renamed from lib/librte_distributor/rte_distributor_v20.c +24 -24

155 lines not on this page · raw message

lib/librte_distributor/rte_distributor_single.h renamed from lib/librte_distributor/rte_distributor_v20.h +13 -13
similarity index 89%
rename from lib/librte_distributor/rte_distributor_v20.h
rename to lib/librte_distributor/rte_distributor_single.h
index 12865658ba..2f80aa43d1 100644
@@ -2,8 +2,8 @@
  * Copyright(c) 2010-2014 Intel Corporation
  */
 
-#ifndef _RTE_DISTRIB_V20_H_
-#define _RTE_DISTRIB_V20_H_
+#ifndef _RTE_DISTRIB_SINGLE_H_
+#define _RTE_DISTRIB_SINGLE_H_
 
 /**
  * @file
@@ -19,7 +19,7 @@ extern "C" {
 
 #define RTE_DISTRIBUTOR_NAMESIZE 32 /**< Length of name for instance */
 
-struct rte_distributor_v20;
+struct rte_distributor_single;
 struct rte_mbuf;
 
 /**
@@ -38,8 +38,8 @@ struct rte_mbuf;
  * @return
  *   The newly created distributor instance
  */
-struct rte_distributor_v20 *
-rte_distributor_create_v20(const char *name, unsigned int socket_id,
+struct rte_distributor_single *
+rte_distributor_create_single(const char *name, unsigned int socket_id,
 		unsigned int num_workers);
 
 /*  *** APIS to be called on the distributor lcore ***  */
@@ -74,7 +74,7 @@ rte_distributor_create_v20(const char *name, unsigned int socket_id,
  *   The number of mbufs processed.
  */
 int
-rte_distributor_process_v20(struct rte_distributor_v20 *d,
+rte_distributor_process_single(struct rte_distributor_single *d,
 		struct rte_mbuf **mbufs, unsigned int num_mbufs);
 
 /**
@@ -92,7 +92,7 @@ rte_distributor_process_v20(struct rte_distributor_v20 *d,
  *   The number of mbufs returned in the mbufs array.
  */
 int
-rte_distributor_returned_pkts_v20(struct rte_distributor_v20 *d,
+rte_distributor_returned_pkts_single(struct rte_distributor_single *d,
 		struct rte_mbuf **mbufs, unsigned int max_mbufs);
 
 /**
@@ -107,7 +107,7 @@ rte_distributor_returned_pkts_v20(struct rte_distributor_v20 *d,
  *   The number of queued/in-flight packets that were completed by this call.
  */
 int
-rte_distributor_flush_v20(struct rte_distributor_v20 *d);
+rte_distributor_flush_single(struct rte_distributor_single *d);
 
 /**
  * Clears the array of returned packets used as the source for the
@@ -119,7 +119,7 @@ rte_distributor_flush_v20(struct rte_distributor_v20 *d);
  *   The distributor instance to be used
  */
 void
-rte_distributor_clear_returns_v20(struct rte_distributor_v20 *d);
+rte_distributor_clear_returns_single(struct rte_distributor_single *d);
 
 /*  *** APIS to be called on the worker lcores ***  */
 /*
@@ -148,7 +148,7 @@ rte_distributor_clear_returns_v20(struct rte_distributor_v20 *d);
  *   A new packet to be processed by the worker thread.
  */
 struct rte_mbuf *
-rte_distributor_get_pkt_v20(struct rte_distributor_v20 *d,
+rte_distributor_get_pkt_single(struct rte_distributor_single *d,
 		unsigned int worker_id, struct rte_mbuf *oldpkt);
 
 /**
@@ -164,7 +164,7 @@ rte_distributor_get_pkt_v20(struct rte_distributor_v20 *d,
  *   The previous packet being processed by the worker
  */
 int
-rte_distributor_return_pkt_v20(struct rte_distributor_v20 *d,
+rte_distributor_return_pkt_single(struct rte_distributor_single *d,
 		unsigned int worker_id, struct rte_mbuf *mbuf);
 
 /**
@@ -188,7 +188,7 @@ rte_distributor_return_pkt_v20(struct rte_distributor_v20 *d,
  *   The previous packet, if any, being processed by the worker
  */
 void
-rte_distributor_request_pkt_v20(struct rte_distributor_v20 *d,
+rte_distributor_request_pkt_single(struct rte_distributor_single *d,
 		unsigned int worker_id, struct rte_mbuf *oldpkt);
 
 /**
@@ -208,7 +208,7 @@ rte_distributor_request_pkt_v20(struct rte_distributor_v20 *d,
  *   packet is yet available.
  */
 struct rte_mbuf *
-rte_distributor_poll_pkt_v20(struct rte_distributor_v20 *d,
+rte_distributor_poll_pkt_single(struct rte_distributor_single *d,
 		unsigned int worker_id);
 
 #ifdef __cplusplus
lib/librte_distributor/rte_distributor_version.map +1 -17
index 3a285b394e..00e26b4804 100644
@@ -1,19 +1,3 @@
-DPDK_2.0 {
-	global:
-
-	rte_distributor_clear_returns;
-	rte_distributor_create;
-	rte_distributor_flush;
-	rte_distributor_get_pkt;
-	rte_distributor_poll_pkt;
-	rte_distributor_process;
-	rte_distributor_request_pkt;
-	rte_distributor_return_pkt;
-	rte_distributor_returned_pkts;
-
-	local: *;
-};
-
 DPDK_17.05 {
 	global:
 
@@ -26,4 +10,4 @@ DPDK_17.05 {
 	rte_distributor_request_pkt;
 	rte_distributor_return_pkt;
 	rte_distributor_returned_pkts;
-} DPDK_2.0;
+};
Signature · 1 line
2.17.1
#78 lore raw

PATCH v6 8/10 drivers/octeontx: add missing public symbol

In reply to Anatoly Burakov

The logtype symbol was missing from the .map file. Add it.

Fixes d8dd31652cf4 ("common/octeontx: move mbox to common folder")

---

Notes:
v2:
- add this patch to avoid compile breakage when bumping ABI

 drivers/common/octeontx/rte_common_octeontx_version.map | 1 +
 1 file changed, 1 insertion(+)
drivers/common/octeontx/rte_common_octeontx_version.map +1 -0
index f04b3b7f8a..a9b3cff9bc 100644
@@ -1,6 +1,7 @@
 DPDK_18.05 {
 	global:
 
+	octeontx_logtype_mbox;
 	octeontx_mbox_set_ram_mbox_base;
 	octeontx_mbox_set_reg;
 	octeontx_mbox_send;
Signature · 1 line
2.17.1
#79 lore raw

PATCH v6 9/10 build: change ABI version to 20.0

In reply to Anatoly Burakov

From: Pawel Modrak <[email protected]>

Merge all vesions in linker version script files to DPDK_20.0.

This commit was generated by running the following command:

:~/DPDK$ buildtools/update-abi.sh 20.0
---
 .../rte_pmd_bbdev_fpga_lte_fec_version.map    |   8 +-
 .../null/rte_pmd_bbdev_null_version.map       |   2 +-
 .../rte_pmd_bbdev_turbo_sw_version.map        |   2 +-
 drivers/bus/dpaa/rte_bus_dpaa_version.map     | 113 +++---
 drivers/bus/fslmc/rte_bus_fslmc_version.map   | 154 ++++-----
 drivers/bus/ifpga/rte_bus_ifpga_version.map   |  14 +-
 drivers/bus/pci/rte_bus_pci_version.map       |   2 +-
 drivers/bus/vdev/rte_bus_vdev_version.map     |  12 +-
 drivers/bus/vmbus/rte_bus_vmbus_version.map   |  12 +-
 drivers/common/cpt/rte_common_cpt_version.map |   9 +-
 .../common/dpaax/rte_common_dpaax_version.map |  14 +-
 .../common/mvep/rte_common_mvep_version.map   |   6 +-
 .../octeontx/rte_common_octeontx_version.map  |   6 +-
 .../rte_common_octeontx2_version.map          |  16 +-
 .../compress/isal/rte_pmd_isal_version.map    |   2 +-
 .../rte_pmd_octeontx_compress_version.map     |   2 +-
 drivers/compress/qat/rte_pmd_qat_version.map  |   2 +-
 .../compress/zlib/rte_pmd_zlib_version.map    |   2 +-
 .../aesni_gcm/rte_pmd_aesni_gcm_version.map   |   2 +-
 .../aesni_mb/rte_pmd_aesni_mb_version.map     |   2 +-
 .../crypto/armv8/rte_pmd_armv8_version.map    |   2 +-
 .../caam_jr/rte_pmd_caam_jr_version.map       |   3 +-
 drivers/crypto/ccp/rte_pmd_ccp_version.map    |   3 +-
 .../dpaa2_sec/rte_pmd_dpaa2_sec_version.map   |  10 +-
 .../dpaa_sec/rte_pmd_dpaa_sec_version.map     |  10 +-
 .../crypto/kasumi/rte_pmd_kasumi_version.map  |   2 +-
 .../crypto/mvsam/rte_pmd_mvsam_version.map    |   2 +-
 .../crypto/nitrox/rte_pmd_nitrox_version.map  |   2 +-
 .../null/rte_pmd_null_crypto_version.map      |   2 +-
 .../rte_pmd_octeontx_crypto_version.map       |   3 +-
 .../rte_pmd_octeontx2_crypto_version.map      |   3 +-
 .../openssl/rte_pmd_openssl_version.map       |   2 +-
 .../rte_pmd_crypto_scheduler_version.map      |  19 +-
 .../crypto/snow3g/rte_pmd_snow3g_version.map  |   2 +-
 .../virtio/rte_pmd_virtio_crypto_version.map  |   2 +-
 drivers/crypto/zuc/rte_pmd_zuc_version.map    |   2 +-
 .../event/dpaa/rte_pmd_dpaa_event_version.map |   3 +-
 .../dpaa2/rte_pmd_dpaa2_event_version.map     |   2 +-
 .../event/dsw/rte_pmd_dsw_event_version.map   |   2 +-
 .../rte_pmd_octeontx_event_version.map        |   2 +-
 .../rte_pmd_octeontx2_event_version.map       |   3 +-
 .../event/opdl/rte_pmd_opdl_event_version.map |   2 +-
 .../rte_pmd_skeleton_event_version.map        |   3 +-
 drivers/event/sw/rte_pmd_sw_event_version.map |   2 +-
 .../bucket/rte_mempool_bucket_version.map     |   3 +-
 .../mempool/dpaa/rte_mempool_dpaa_version.map |   2 +-
 .../dpaa2/rte_mempool_dpaa2_version.map       |  12 +-
 .../octeontx/rte_mempool_octeontx_version.map |   2 +-
 .../rte_mempool_octeontx2_version.map         |   4 +-
 .../mempool/ring/rte_mempool_ring_version.map |   3 +-
 .../stack/rte_mempool_stack_version.map       |   3 +-
 .../af_packet/rte_pmd_af_packet_version.map   |   3 +-
 drivers/net/af_xdp/rte_pmd_af_xdp_version.map |   2 +-
 drivers/net/ark/rte_pmd_ark_version.map       |   5 +-
 .../net/atlantic/rte_pmd_atlantic_version.map |   6 -
 drivers/net/avp/rte_pmd_avp_version.map       |   2 +-
 drivers/net/axgbe/rte_pmd_axgbe_version.map   |   2 +-
 drivers/net/bnx2x/rte_pmd_bnx2x_version.map   |   3 +-
 drivers/net/bnxt/rte_pmd_bnxt_version.map     |   4 +-
 drivers/net/bonding/rte_pmd_bond_version.map  |  47 +--
 drivers/net/cxgbe/rte_pmd_cxgbe_version.map   |   3 +-
 drivers/net/dpaa/rte_pmd_dpaa_version.map     |  11 +-
 drivers/net/dpaa2/rte_pmd_dpaa2_version.map   |  12 +-
 drivers/net/e1000/rte_pmd_e1000_version.map   |   3 +-
 drivers/net/ena/rte_pmd_ena_version.map       |   3 +-
 drivers/net/enetc/rte_pmd_enetc_version.map   |   3 +-
 drivers/net/enic/rte_pmd_enic_version.map     |   3 +-
 .../net/failsafe/rte_pmd_failsafe_version.map |   3 +-
 drivers/net/fm10k/rte_pmd_fm10k_version.map   |   3 +-
 drivers/net/hinic/rte_pmd_hinic_version.map   |   3 +-
 drivers/net/hns3/rte_pmd_hns3_version.map     |   4 +-
 drivers/net/i40e/rte_pmd_i40e_version.map     |  65 +---
 drivers/net/iavf/rte_pmd_iavf_version.map     |   3 +-
 drivers/net/ice/rte_pmd_ice_version.map       |   3 +-
 drivers/net/ifc/rte_pmd_ifc_version.map       |   3 +-
 drivers/net/ipn3ke/rte_pmd_ipn3ke_version.map |   3 +-
 drivers/net/ixgbe/rte_pmd_ixgbe_version.map   |  62 ++--
 drivers/net/kni/rte_pmd_kni_version.map       |   3 +-
 .../net/liquidio/rte_pmd_liquidio_version.map |   3 +-
 drivers/net/memif/rte_pmd_memif_version.map   |   5 +-
 drivers/net/mlx4/rte_pmd_mlx4_version.map     |   3 +-
 drivers/net/mlx5/rte_pmd_mlx5_version.map     |   2 +-
 drivers/net/mvneta/rte_pmd_mvneta_version.map |   2 +-
 drivers/net/mvpp2/rte_pmd_mvpp2_version.map   |   2 +-
 drivers/net/netvsc/rte_pmd_netvsc_version.map |   4 +-
 drivers/net/nfb/rte_pmd_nfb_version.map       |   3 +-
 drivers/net/nfp/rte_pmd_nfp_version.map       |   2 +-
 drivers/net/null/rte_pmd_null_version.map     |   3 +-
 .../net/octeontx/rte_pmd_octeontx_version.map |  10 +-
 .../octeontx2/rte_pmd_octeontx2_version.map   |   3 +-
 drivers/net/pcap/rte_pmd_pcap_version.map     |   3 +-
 drivers/net/pfe/rte_pmd_pfe_version.map       |   3 +-
 drivers/net/qede/rte_pmd_qede_version.map     |   3 +-
 drivers/net/ring/rte_pmd_ring_version.map     |  10 +-
 drivers/net/sfc/rte_pmd_sfc_version.map       |   3 +-
 .../net/softnic/rte_pmd_softnic_version.map   |   2 +-
 .../net/szedata2/rte_pmd_szedata2_version.map |   2 +-
 drivers/net/tap/rte_pmd_tap_version.map       |   3 +-
 .../net/thunderx/rte_pmd_thunderx_version.map |   3 +-
 .../rte_pmd_vdev_netvsc_version.map           |   3 +-
 drivers/net/vhost/rte_pmd_vhost_version.map   |  11 +-
 drivers/net/virtio/rte_pmd_virtio_version.map |   3 +-
 .../net/vmxnet3/rte_pmd_vmxnet3_version.map   |   3 +-
 .../rte_rawdev_dpaa2_cmdif_version.map        |   3 +-
 .../rte_rawdev_dpaa2_qdma_version.map         |   4 +-
 .../raw/ifpga/rte_rawdev_ifpga_version.map    |   3 +-
 drivers/raw/ioat/rte_rawdev_ioat_version.map  |   3 +-
 drivers/raw/ntb/rte_rawdev_ntb_version.map    |   5 +-
 .../rte_rawdev_octeontx2_dma_version.map      |   3 +-
 .../skeleton/rte_rawdev_skeleton_version.map  |   3 +-
 lib/librte_acl/rte_acl_version.map            |   2 +-
 .../rte_bitratestats_version.map              |   2 +-
 lib/librte_cfgfile/rte_cfgfile_version.map    |  34 +-
 lib/librte_cmdline/rte_cmdline_version.map    |  10 +-
 .../rte_cryptodev_version.map                 | 102 ++----
 .../rte_distributor_version.map               |   4 +-
 lib/librte_eal/rte_eal_version.map            | 324 ++++++------------
 lib/librte_efd/rte_efd_version.map            |   2 +-
 lib/librte_ethdev/rte_ethdev_version.map      | 160 +++------
 lib/librte_eventdev/rte_eventdev_version.map  | 130 +++----
 lib/librte_gro/rte_gro_version.map            |   2 +-
 lib/librte_gso/rte_gso_version.map            |   2 +-
 lib/librte_hash/rte_hash_version.map          |  43 +--
 lib/librte_ip_frag/rte_ip_frag_version.map    |  10 +-
 lib/librte_jobstats/rte_jobstats_version.map  |  10 +-
 lib/librte_kni/rte_kni_version.map            |   2 +-
 lib/librte_kvargs/rte_kvargs_version.map      |   4 +-
 .../rte_latencystats_version.map              |   2 +-
 lib/librte_lpm/rte_lpm_version.map            |  39 +--
 lib/librte_mbuf/rte_mbuf_version.map          |  49 +--
 lib/librte_member/rte_member_version.map      |   2 +-
 lib/librte_mempool/rte_mempool_version.map    |  44 +--
 lib/librte_meter/rte_meter_version.map        |  13 +-
 lib/librte_metrics/rte_metrics_version.map    |   2 +-
 lib/librte_net/rte_net_version.map            |  23 +-
 lib/librte_pci/rte_pci_version.map            |   2 +-
 lib/librte_pdump/rte_pdump_version.map        |   2 +-
 lib/librte_pipeline/rte_pipeline_version.map  |  36 +-
 lib/librte_port/rte_port_version.map          |  64 +---
 lib/librte_power/rte_power_version.map        |  24 +-
 lib/librte_rawdev/rte_rawdev_version.map      |   4 +-
 lib/librte_reorder/rte_reorder_version.map    |   8 +-
 lib/librte_ring/rte_ring_version.map          |  10 +-
 lib/librte_sched/rte_sched_version.map        |  14 +-
 lib/librte_security/rte_security_version.map  |   2 +-
 lib/librte_table/rte_table_version.map        |   2 +-
 lib/librte_timer/rte_timer_version.map        |  12 +-
 lib/librte_vhost/rte_vhost_version.map        |  52 +--
 148 files changed, 695 insertions(+), 1438 deletions(-)
drivers/baseband/fpga_lte_fec/rte_pmd_bbdev_fpga_lte_fec_version.map +2 -6
index f64b0f9c27..d9de5102db 100644
@@ -1,10 +1,6 @@
-DPDK_19.08 {
-    local: *;
-};
-
 EXPERIMENTAL {
-    global:
+	global:
 
-    fpga_lte_fec_configure;
+	fpga_lte_fec_configure;
 
 };
drivers/baseband/null/rte_pmd_bbdev_null_version.map +1 -1
index 58b94270d4..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.02 {
+DPDK_20.0 {
 	local: *;
 };
drivers/baseband/turbo_sw/rte_pmd_bbdev_turbo_sw_version.map +1 -1
index 58b94270d4..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.02 {
+DPDK_20.0 {
 	local: *;
 };
drivers/bus/dpaa/rte_bus_dpaa_version.map +40 -73

167 lines not on this page · raw message

drivers/bus/fslmc/rte_bus_fslmc_version.map +60 -94

204 lines not on this page · raw message

drivers/bus/ifpga/rte_bus_ifpga_version.map +4 -10
index 964c9a9c45..05b4a28c1b 100644
@@ -1,17 +1,11 @@
-DPDK_18.05 {
+DPDK_20.0 {
 	global:
 
-	rte_ifpga_get_integer32_arg;
-	rte_ifpga_get_string_arg;
 	rte_ifpga_driver_register;
 	rte_ifpga_driver_unregister;
+	rte_ifpga_find_afu_by_name;
+	rte_ifpga_get_integer32_arg;
+	rte_ifpga_get_string_arg;
 
 	local: *;
 };
-
-DPDK_19.05 {
-	global:
-
-	rte_ifpga_find_afu_by_name;
-
-} DPDK_18.05;
drivers/bus/pci/rte_bus_pci_version.map +1 -1
index 27e9c4f101..012d817e14 100644
@@ -1,4 +1,4 @@
-DPDK_17.11 {
+DPDK_20.0 {
 	global:
 
 	rte_pci_dump;
drivers/bus/vdev/rte_bus_vdev_version.map +3 -9
index 590cf9b437..5abb10ecb0 100644
@@ -1,18 +1,12 @@
-DPDK_17.11 {
+DPDK_20.0 {
 	global:
 
+	rte_vdev_add_custom_scan;
 	rte_vdev_init;
 	rte_vdev_register;
+	rte_vdev_remove_custom_scan;
 	rte_vdev_uninit;
 	rte_vdev_unregister;
 
 	local: *;
 };
-
-DPDK_18.02 {
-	global:
-
-	rte_vdev_add_custom_scan;
-	rte_vdev_remove_custom_scan;
-
-} DPDK_17.11;
drivers/bus/vmbus/rte_bus_vmbus_version.map +2 -10
index ae231ad329..cbaaebc06c 100644
@@ -1,6 +1,4 @@
-/* SPDX-License-Identifier: BSD-3-Clause */
-
-DPDK_18.08 {
+DPDK_20.0 {
 	global:
 
 	rte_vmbus_chan_close;
@@ -20,6 +18,7 @@ DPDK_18.08 {
 	rte_vmbus_probe;
 	rte_vmbus_register;
 	rte_vmbus_scan;
+	rte_vmbus_set_latency;
 	rte_vmbus_sub_channel_index;
 	rte_vmbus_subchan_open;
 	rte_vmbus_unmap_device;
@@ -27,10 +26,3 @@ DPDK_18.08 {
 
 	local: *;
 };
-
-DPDK_18.11 {
-	global:
-
-	rte_vmbus_set_latency;
-
-} DPDK_18.08;
drivers/common/cpt/rte_common_cpt_version.map +2 -7
index 382ec4bd44..7f1929d58e 100644
@@ -1,14 +1,9 @@
-DPDK_18.11 {
+DPDK_20.0 {
 	global:
 
+	cpt_pmd_ops_helper_asym_get_mlen;
 	cpt_pmd_ops_helper_get_mlen_direct_mode;
 	cpt_pmd_ops_helper_get_mlen_sg_mode;
-};
-
-DPDK_19.11 {
-	global:
-
-	cpt_pmd_ops_helper_asym_get_mlen;
 
 	local: *;
 };
drivers/common/dpaax/rte_common_dpaax_version.map +4 -10
index a7699ae4dd..f72eba761d 100644
@@ -1,29 +1,23 @@
-DPDK_18.11 {
+DPDK_20.0 {
 	global:
 
-	dpaax_iova_table_update;
 	dpaax_iova_table_depopulate;
 	dpaax_iova_table_dump;
 	dpaax_iova_table_p;
 	dpaax_iova_table_populate;
-
-	local: *;
-};
-
-DPDK_19.11 {
-	global:
+	dpaax_iova_table_update;
 	of_device_is_available;
 	of_device_is_compatible;
 	of_find_compatible_node;
 	of_find_node_by_phandle;
 	of_get_address;
 	of_get_mac_address;
+	of_get_next_child;
 	of_get_parent;
 	of_get_property;
 	of_init_path;
 	of_n_addr_cells;
 	of_translate_address;
-	of_get_next_child;
 
 	local: *;
-} DPDK_18.11;
+};
drivers/common/mvep/rte_common_mvep_version.map +4 -2
index c71722d79f..030928439d 100644
@@ -1,6 +1,8 @@
-DPDK_18.11 {
+DPDK_20.0 {
 	global:
 
-	rte_mvep_init;
 	rte_mvep_deinit;
+	rte_mvep_init;
+
+	local: *;
 };
drivers/common/octeontx/rte_common_octeontx_version.map +4 -2
index a9b3cff9bc..c15fb89112 100644
@@ -1,8 +1,10 @@
-DPDK_18.05 {
+DPDK_20.0 {
 	global:
 
 	octeontx_logtype_mbox;
+	octeontx_mbox_send;
 	octeontx_mbox_set_ram_mbox_base;
 	octeontx_mbox_set_reg;
-	octeontx_mbox_send;
+
+	local: *;
 };
drivers/common/octeontx2/rte_common_octeontx2_version.map +6 -10
index 4400120da0..adad21a2d6 100644
@@ -1,39 +1,35 @@
-DPDK_19.08 {
+DPDK_20.0 {
 	global:
 
 	otx2_dev_active_vfs;
 	otx2_dev_fini;
 	otx2_dev_priv_init;
-
+	otx2_disable_irqs;
+	otx2_intra_dev_get_cfg;
 	otx2_logtype_base;
 	otx2_logtype_dpi;
 	otx2_logtype_mbox;
+	otx2_logtype_nix;
 	otx2_logtype_npa;
 	otx2_logtype_npc;
-	otx2_logtype_nix;
 	otx2_logtype_sso;
-	otx2_logtype_tm;
 	otx2_logtype_tim;
-
+	otx2_logtype_tm;
 	otx2_mbox_alloc_msg_rsp;
 	otx2_mbox_get_rsp;
 	otx2_mbox_get_rsp_tmo;
 	otx2_mbox_id2name;
 	otx2_mbox_msg_send;
 	otx2_mbox_wait_for_rsp;
-
-	otx2_intra_dev_get_cfg;
 	otx2_npa_lf_active;
 	otx2_npa_lf_obj_get;
 	otx2_npa_lf_obj_ref;
 	otx2_npa_pf_func_get;
 	otx2_npa_set_defaults;
+	otx2_register_irq;
 	otx2_sso_pf_func_get;
 	otx2_sso_pf_func_set;
-
-	otx2_disable_irqs;
 	otx2_unregister_irq;
-	otx2_register_irq;
 
 	local: *;
 };
drivers/compress/isal/rte_pmd_isal_version.map +1 -1
index de8e412ff1..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.05 {
+DPDK_20.0 {
 	local: *;
 };
drivers/compress/octeontx/rte_pmd_octeontx_compress_version.map +1 -1
index ad6e191e49..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.08 {
+DPDK_20.0 {
 	local: *;
 };
drivers/compress/qat/rte_pmd_qat_version.map +1 -1
index ad6e191e49..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.08 {
+DPDK_20.0 {
 	local: *;
 };
drivers/compress/zlib/rte_pmd_zlib_version.map +1 -1
index ad6e191e49..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.08 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/aesni_gcm/rte_pmd_aesni_gcm_version.map +1 -1
index dc4d417b7b..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_16.04 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/aesni_mb/rte_pmd_aesni_mb_version.map +1 -1
index ad607bbedd..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_2.2 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/armv8/rte_pmd_armv8_version.map +1 -1
index 1f84b68a83..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_17.02 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/caam_jr/rte_pmd_caam_jr_version.map +1 -2
index 521e51f411..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.11 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/ccp/rte_pmd_ccp_version.map +1 -2
index 9b9ab1a4cf..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map +3 -7
index 0bfb986d0b..5952d645fd 100644
@@ -1,12 +1,8 @@
-DPDK_17.05 {
-
-	local: *;
-};
-
-DPDK_18.11 {
+DPDK_20.0 {
 	global:
 
 	dpaa2_sec_eventq_attach;
 	dpaa2_sec_eventq_detach;
 
-} DPDK_17.05;
+	local: *;
+};
drivers/crypto/dpaa_sec/rte_pmd_dpaa_sec_version.map +3 -7
index cc7f2162e0..8580fa13db 100644
@@ -1,12 +1,8 @@
-DPDK_17.11 {
-
-	local: *;
-};
-
-DPDK_19.11 {
+DPDK_20.0 {
 	global:
 
 	dpaa_sec_eventq_attach;
 	dpaa_sec_eventq_detach;
 
-} DPDK_17.11;
+	local: *;
+};
drivers/crypto/kasumi/rte_pmd_kasumi_version.map +1 -1
index 8ffeca934e..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_16.07 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/mvsam/rte_pmd_mvsam_version.map +1 -1
index a753031720..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_17.11 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/nitrox/rte_pmd_nitrox_version.map +1 -1
index 406964d1fc..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_19.11 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/null/rte_pmd_null_crypto_version.map +1 -1
index dc4d417b7b..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_16.04 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/octeontx/rte_pmd_octeontx_crypto_version.map +1 -2
index 521e51f411..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.11 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/octeontx2/rte_pmd_octeontx2_crypto_version.map +1 -2
index b7b7c91683..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.11 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/openssl/rte_pmd_openssl_version.map +1 -1
index cc5829e30b..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_16.11 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/scheduler/rte_pmd_crypto_scheduler_version.map +7 -12
index 5c43127cf2..077afedce7 100644
@@ -1,21 +1,16 @@
-DPDK_17.02 {
+DPDK_20.0 {
 	global:
 
 	rte_cryptodev_scheduler_load_user_scheduler;
-	rte_cryptodev_scheduler_slave_attach;
-	rte_cryptodev_scheduler_slave_detach;
-	rte_cryptodev_scheduler_ordering_set;
-	rte_cryptodev_scheduler_ordering_get;
-
-};
-
-DPDK_17.05 {
-	global:
-
 	rte_cryptodev_scheduler_mode_get;
 	rte_cryptodev_scheduler_mode_set;
 	rte_cryptodev_scheduler_option_get;
 	rte_cryptodev_scheduler_option_set;
+	rte_cryptodev_scheduler_ordering_get;
+	rte_cryptodev_scheduler_ordering_set;
+	rte_cryptodev_scheduler_slave_attach;
+	rte_cryptodev_scheduler_slave_detach;
 	rte_cryptodev_scheduler_slaves_get;
 
-} DPDK_17.02;
+	local: *;
+};
drivers/crypto/snow3g/rte_pmd_snow3g_version.map +1 -1
index dc4d417b7b..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_16.04 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/virtio/rte_pmd_virtio_crypto_version.map +1 -1
index de8e412ff1..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.05 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/zuc/rte_pmd_zuc_version.map +1 -1
index cc5829e30b..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_16.11 {
+DPDK_20.0 {
 	local: *;
 };
drivers/event/dpaa/rte_pmd_dpaa_event_version.map +1 -2
index 179140fb87..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.02 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/event/dpaa2/rte_pmd_dpaa2_event_version.map +1 -1
index 1c0b7559dc..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_17.08 {
+DPDK_20.0 {
 	local: *;
 };
drivers/event/dsw/rte_pmd_dsw_event_version.map +1 -1
index 24bd5cdb35..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.11 {
+DPDK_20.0 {
 	local: *;
 };
drivers/event/octeontx/rte_pmd_octeontx_event_version.map +1 -1
index 5352e7e3bd..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_17.05 {
+DPDK_20.0 {
 	local: *;
 };
drivers/event/octeontx2/rte_pmd_octeontx2_event_version.map +1 -2
index 41c65c8c9c..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.08 {
+DPDK_20.0 {
 	local: *;
 };
-
drivers/event/opdl/rte_pmd_opdl_event_version.map +1 -1
index 58b94270d4..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.02 {
+DPDK_20.0 {
 	local: *;
 };
drivers/event/skeleton/rte_pmd_skeleton_event_version.map +1 -2
index 8591cc0b18..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_17.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/event/sw/rte_pmd_sw_event_version.map +1 -1
index 5352e7e3bd..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_17.05 {
+DPDK_20.0 {
 	local: *;
 };
drivers/mempool/bucket/rte_mempool_bucket_version.map +1 -2
index 9b9ab1a4cf..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/mempool/dpaa/rte_mempool_dpaa_version.map +1 -1
index 60bf50b2d1..9eebaf7ffd 100644
@@ -1,4 +1,4 @@
-DPDK_17.11 {
+DPDK_20.0 {
 	global:
 
 	rte_dpaa_bpid_info;
drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map +3 -9
index b45e7a9ac1..cd4bc88273 100644
@@ -1,16 +1,10 @@
-DPDK_17.05 {
+DPDK_20.0 {
 	global:
 
 	rte_dpaa2_bpid_info;
 	rte_dpaa2_mbuf_alloc_bulk;
-
-	local: *;
-};
-
-DPDK_18.05 {
-	global:
-
 	rte_dpaa2_mbuf_from_buf_addr;
 	rte_dpaa2_mbuf_pool_bpid;
 
-} DPDK_17.05;
+	local: *;
+};
drivers/mempool/octeontx/rte_mempool_octeontx_version.map +1 -1
index a753031720..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_17.11 {
+DPDK_20.0 {
 	local: *;
 };
drivers/mempool/octeontx2/rte_mempool_octeontx2_version.map +2 -2
index d703368c31..d4f81aed8e 100644
@@ -1,8 +1,8 @@
-DPDK_19.08 {
+DPDK_20.0 {
 	global:
 
-	otx2_npa_lf_init;
 	otx2_npa_lf_fini;
+	otx2_npa_lf_init;
 
 	local: *;
 };
drivers/mempool/ring/rte_mempool_ring_version.map +1 -2
index 8591cc0b18..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_17.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/mempool/stack/rte_mempool_stack_version.map +1 -2
index 8591cc0b18..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_17.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/af_packet/rte_pmd_af_packet_version.map +1 -2
index ef35398402..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.0 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/af_xdp/rte_pmd_af_xdp_version.map +1 -1
index c6db030fe6..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_19.05 {
+DPDK_20.0 {
 	local: *;
 };
drivers/net/ark/rte_pmd_ark_version.map +2 -3
index 1062e0429f..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_17.05 {
-	 local: *;
-
+DPDK_20.0 {
+	local: *;
 };
drivers/net/atlantic/rte_pmd_atlantic_version.map +0 -6
index b16faa999f..74146e9c09 100644
@@ -1,8 +1,3 @@
-DPDK_18.11 {
-
-	local: *;
-};
-
 EXPERIMENTAL {
 	global:
 
@@ -13,4 +8,3 @@ EXPERIMENTAL {
 	rte_pmd_atl_macsec_select_txsa;
 	rte_pmd_atl_macsec_select_rxsa;
 };
-
drivers/net/avp/rte_pmd_avp_version.map +1 -1
index 5352e7e3bd..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_17.05 {
+DPDK_20.0 {
 	local: *;
 };
drivers/net/axgbe/rte_pmd_axgbe_version.map +1 -1
index de8e412ff1..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.05 {
+DPDK_20.0 {
 	local: *;
 };
drivers/net/bnx2x/rte_pmd_bnx2x_version.map +1 -2
index bd8138a034..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.1 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/bnxt/rte_pmd_bnxt_version.map +2 -2
index 4750d40ad6..bb52562347 100644
@@ -1,4 +1,4 @@
-DPDK_17.08 {
+DPDK_20.0 {
 	global:
 
 	rte_pmd_bnxt_get_vf_rx_status;
@@ -10,13 +10,13 @@ DPDK_17.08 {
 	rte_pmd_bnxt_set_tx_loopback;
 	rte_pmd_bnxt_set_vf_mac_addr;
 	rte_pmd_bnxt_set_vf_mac_anti_spoof;
+	rte_pmd_bnxt_set_vf_persist_stats;
 	rte_pmd_bnxt_set_vf_rate_limit;
 	rte_pmd_bnxt_set_vf_rxmode;
 	rte_pmd_bnxt_set_vf_vlan_anti_spoof;
 	rte_pmd_bnxt_set_vf_vlan_filter;
 	rte_pmd_bnxt_set_vf_vlan_insert;
 	rte_pmd_bnxt_set_vf_vlan_stripq;
-	rte_pmd_bnxt_set_vf_persist_stats;
 
 	local: *;
 };
drivers/net/bonding/rte_pmd_bond_version.map +13 -34

58 lines not on this page · raw message

drivers/net/cxgbe/rte_pmd_cxgbe_version.map +1 -2
index bd8138a034..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.1 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/dpaa/rte_pmd_dpaa_version.map +4 -7
index 8cb4500b51..f403a1526d 100644
@@ -1,12 +1,9 @@
-DPDK_17.11 {
-
-	local: *;
-};
-
-DPDK_18.08 {
+DPDK_20.0 {
 	global:
 
 	dpaa_eth_eventq_attach;
 	dpaa_eth_eventq_detach;
 	rte_pmd_dpaa_set_tx_loopback;
-} DPDK_17.11;
+
+	local: *;
+};
drivers/net/dpaa2/rte_pmd_dpaa2_version.map +4 -8
index d1b4cdb232..f2bb793319 100644
@@ -1,15 +1,11 @@
-DPDK_17.05 {
-
-	local: *;
-};
-
-DPDK_17.11 {
+DPDK_20.0 {
 	global:
 
 	dpaa2_eth_eventq_attach;
 	dpaa2_eth_eventq_detach;
 
-} DPDK_17.05;
+	local: *;
+};
 
 EXPERIMENTAL {
 	global:
@@ -17,4 +13,4 @@ EXPERIMENTAL {
 	rte_pmd_dpaa2_mux_flow_create;
 	rte_pmd_dpaa2_set_custom_hash;
 	rte_pmd_dpaa2_set_timestamp;
-} DPDK_17.11;
+};
drivers/net/e1000/rte_pmd_e1000_version.map +1 -2
index ef35398402..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.0 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/ena/rte_pmd_ena_version.map +1 -2
index 349c6e1c22..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_16.04 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/enetc/rte_pmd_enetc_version.map +1 -2
index 521e51f411..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.11 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/enic/rte_pmd_enic_version.map +1 -2
index ef35398402..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.0 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/failsafe/rte_pmd_failsafe_version.map +1 -2
index b6d2840be4..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_17.08 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/fm10k/rte_pmd_fm10k_version.map +1 -2
index ef35398402..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.0 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/hinic/rte_pmd_hinic_version.map +1 -2
index 9a61188cd5..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.08 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/hns3/rte_pmd_hns3_version.map +2 -2
index 35e5f2debb..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_19.11 {
-	 local: *;
+DPDK_20.0 {
+	local: *;
 };
drivers/net/i40e/rte_pmd_i40e_version.map +19 -46

86 lines not on this page · raw message

drivers/net/iavf/rte_pmd_iavf_version.map +1 -2
index 179140fb87..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.02 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/ice/rte_pmd_ice_version.map +1 -2
index 7b23b609da..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.02 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/ifc/rte_pmd_ifc_version.map +1 -2
index 9b9ab1a4cf..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/ipn3ke/rte_pmd_ipn3ke_version.map +1 -2
index fc8c95e919..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/ixgbe/rte_pmd_ixgbe_version.map +22 -40

79 lines not on this page · raw message

drivers/net/kni/rte_pmd_kni_version.map +1 -2
index 8591cc0b18..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_17.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/liquidio/rte_pmd_liquidio_version.map +1 -2
index 8591cc0b18..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_17.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/memif/rte_pmd_memif_version.map +2 -3
index 8861484fb3..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.08 {
-
-        local: *;
+DPDK_20.0 {
+	local: *;
 };
drivers/net/mlx4/rte_pmd_mlx4_version.map +1 -2
index ef35398402..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.0 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/mlx5/rte_pmd_mlx5_version.map +1 -1
index ad607bbedd..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_2.2 {
+DPDK_20.0 {
 	local: *;
 };
drivers/net/mvneta/rte_pmd_mvneta_version.map +1 -1
index 24bd5cdb35..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.11 {
+DPDK_20.0 {
 	local: *;
 };
drivers/net/mvpp2/rte_pmd_mvpp2_version.map +1 -1
index a753031720..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_17.11 {
+DPDK_20.0 {
 	local: *;
 };
drivers/net/netvsc/rte_pmd_netvsc_version.map +1 -3
index d534019a6b..f9f17e4f6e 100644
@@ -1,5 +1,3 @@
-/* SPDX-License-Identifier: BSD-3-Clause */
-
-DPDK_18.08 {
+DPDK_20.0 {
 	local: *;
 };
drivers/net/nfb/rte_pmd_nfb_version.map +1 -2
index fc8c95e919..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/nfp/rte_pmd_nfp_version.map +1 -1
index ad607bbedd..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_2.2 {
+DPDK_20.0 {
 	local: *;
 };
drivers/net/null/rte_pmd_null_version.map +1 -2
index ef35398402..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.0 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/octeontx/rte_pmd_octeontx_version.map +3 -7
index a3161b14d0..f7cae02fac 100644
@@ -1,11 +1,7 @@
-DPDK_17.11 {
-
-	local: *;
-};
-
-DPDK_18.02 {
+DPDK_20.0 {
 	global:
 
 	rte_octeontx_pchan_map;
 
-} DPDK_17.11;
+	local: *;
+};
drivers/net/octeontx2/rte_pmd_octeontx2_version.map +1 -2
index 9a61188cd5..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.08 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/pcap/rte_pmd_pcap_version.map +1 -2
index ef35398402..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.0 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/pfe/rte_pmd_pfe_version.map +1 -2
index b7b7c91683..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.11 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/qede/rte_pmd_qede_version.map +1 -2
index 349c6e1c22..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_16.04 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/ring/rte_pmd_ring_version.map +2 -8
index 1f785d9409..ebb6be2733 100644
@@ -1,14 +1,8 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
+	rte_eth_from_ring;
 	rte_eth_from_rings;
 
 	local: *;
 };
-
-DPDK_2.2 {
-	global:
-
-	rte_eth_from_ring;
-
-} DPDK_2.0;
drivers/net/sfc/rte_pmd_sfc_version.map +1 -2
index 31eca32ebe..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_17.02 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/softnic/rte_pmd_softnic_version.map +1 -1
index bc44b06f98..50f113d5a2 100644
@@ -1,4 +1,4 @@
-DPDK_17.11 {
+DPDK_20.0 {
 	global:
 
 	rte_pmd_softnic_run;
drivers/net/szedata2/rte_pmd_szedata2_version.map +1 -1
index ad607bbedd..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_2.2 {
+DPDK_20.0 {
 	local: *;
 };
drivers/net/tap/rte_pmd_tap_version.map +1 -2
index 31eca32ebe..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_17.02 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/thunderx/rte_pmd_thunderx_version.map +1 -2
index 1901bcb3b3..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_16.07 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/vdev_netvsc/rte_pmd_vdev_netvsc_version.map +1 -2
index 179140fb87..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.02 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/vhost/rte_pmd_vhost_version.map +3 -8
index 695db85749..16b591ccc4 100644
@@ -1,13 +1,8 @@
-DPDK_16.04 {
+DPDK_20.0 {
 	global:
 
 	rte_eth_vhost_get_queue_event;
-
-	local: *;
-};
-
-DPDK_16.11 {
-	global:
-
 	rte_eth_vhost_get_vid_from_port_id;
+
+	local: *;
 };
drivers/net/virtio/rte_pmd_virtio_version.map +1 -2
index ef35398402..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.0 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/vmxnet3/rte_pmd_vmxnet3_version.map +1 -2
index ef35398402..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.0 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/raw/dpaa2_cmdif/rte_rawdev_dpaa2_cmdif_version.map +1 -2
index 9b9ab1a4cf..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/raw/dpaa2_qdma/rte_rawdev_dpaa2_qdma_version.map +2 -2
index d16a136fc8..ca6a0d7626 100644
@@ -1,4 +1,4 @@
-DPDK_19.05 {
+DPDK_20.0 {
 	global:
 
 	rte_qdma_attr_get;
@@ -9,9 +9,9 @@ DPDK_19.05 {
 	rte_qdma_start;
 	rte_qdma_stop;
 	rte_qdma_vq_create;
-	rte_qdma_vq_destroy;
 	rte_qdma_vq_dequeue;
 	rte_qdma_vq_dequeue_multi;
+	rte_qdma_vq_destroy;
 	rte_qdma_vq_enqueue;
 	rte_qdma_vq_enqueue_multi;
 	rte_qdma_vq_stats;
drivers/raw/ifpga/rte_rawdev_ifpga_version.map +1 -2
index 9b9ab1a4cf..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/raw/ioat/rte_rawdev_ioat_version.map +1 -2
index 9a61188cd5..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.08 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/raw/ntb/rte_rawdev_ntb_version.map +2 -3
index 8861484fb3..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.08 {
-
-        local: *;
+DPDK_20.0 {
+	local: *;
 };
drivers/raw/octeontx2_dma/rte_rawdev_octeontx2_dma_version.map +1 -2
index 9a61188cd5..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.08 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/raw/skeleton/rte_rawdev_skeleton_version.map +1 -2
index 179140fb87..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.02 {
-
+DPDK_20.0 {
 	local: *;
 };
lib/librte_acl/rte_acl_version.map +1 -1
index b09370a104..c3daca8115 100644
@@ -1,4 +1,4 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
 	rte_acl_add_rules;
lib/librte_bitratestats/rte_bitratestats_version.map +1 -1
index fe7454452d..88fc2912db 100644
@@ -1,4 +1,4 @@
-DPDK_17.05 {
+DPDK_20.0 {
 	global:
 
 	rte_stats_bitrate_calc;
lib/librte_cfgfile/rte_cfgfile_version.map +8 -26
index a0a11cea8d..906eee96bf 100644
@@ -1,40 +1,22 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
+	rte_cfgfile_add_entry;
+	rte_cfgfile_add_section;
 	rte_cfgfile_close;
+	rte_cfgfile_create;
 	rte_cfgfile_get_entry;
 	rte_cfgfile_has_entry;
 	rte_cfgfile_has_section;
 	rte_cfgfile_load;
+	rte_cfgfile_load_with_params;
 	rte_cfgfile_num_sections;
+	rte_cfgfile_save;
 	rte_cfgfile_section_entries;
+	rte_cfgfile_section_entries_by_index;
 	rte_cfgfile_section_num_entries;
 	rte_cfgfile_sections;
+	rte_cfgfile_set_entry;
 
 	local: *;
 };
-
-DPDK_16.04 {
-	global:
-
-	rte_cfgfile_section_entries_by_index;
-
-} DPDK_2.0;
-
-DPDK_17.05 {
-	global:
-
-	rte_cfgfile_load_with_params;
-
-} DPDK_16.04;
-
-DPDK_17.11 {
-	global:
-
-	rte_cfgfile_add_entry;
-	rte_cfgfile_add_section;
-	rte_cfgfile_create;
-	rte_cfgfile_save;
-	rte_cfgfile_set_entry;
-
-} DPDK_17.05;
lib/librte_cmdline/rte_cmdline_version.map +2 -8
index 04bcb387f2..95fce812ff 100644
@@ -1,4 +1,4 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
 	cirbuf_add_buf_head;
@@ -40,6 +40,7 @@ DPDK_2.0 {
 	cmdline_parse_num;
 	cmdline_parse_portlist;
 	cmdline_parse_string;
+	cmdline_poll;
 	cmdline_printf;
 	cmdline_quit;
 	cmdline_set_prompt;
@@ -68,10 +69,3 @@ DPDK_2.0 {
 
 	local: *;
 };
-
-DPDK_2.1 {
-	global:
-
-	cmdline_poll;
-
-} DPDK_2.0;
lib/librte_cryptodev/rte_cryptodev_version.map +36 -66

128 lines not on this page · raw message

lib/librte_distributor/rte_distributor_version.map +3 -1
index 00e26b4804..1b7c643005 100644
@@ -1,4 +1,4 @@
-DPDK_17.05 {
+DPDK_20.0 {
 	global:
 
 	rte_distributor_clear_returns;
@@ -10,4 +10,6 @@ DPDK_17.05 {
 	rte_distributor_request_pkt;
 	rte_distributor_return_pkt;
 	rte_distributor_returned_pkts;
+
+	local: *;
 };
lib/librte_eal/rte_eal_version.map +114 -210

423 lines not on this page · raw message

lib/librte_efd/rte_efd_version.map +1 -1
index ae60a64178..e010eecfe4 100644
@@ -1,4 +1,4 @@
-DPDK_17.02 {
+DPDK_20.0 {
 	global:
 
 	rte_efd_create;
lib/librte_ethdev/rte_ethdev_version.map +47 -113

243 lines not on this page · raw message

lib/librte_eventdev/rte_eventdev_version.map +47 -83

163 lines not on this page · raw message

lib/librte_gro/rte_gro_version.map +1 -1
index 1606b6dc72..9f6fe79e57 100644
@@ -1,4 +1,4 @@
-DPDK_17.08 {
+DPDK_20.0 {
 	global:
 
 	rte_gro_ctx_create;
lib/librte_gso/rte_gso_version.map +1 -1
index e1fd453edb..8505a59c27 100644
@@ -1,4 +1,4 @@
-DPDK_17.11 {
+DPDK_20.0 {
 	global:
 
 	rte_gso_segment;
lib/librte_hash/rte_hash_version.map +9 -34

67 lines not on this page · raw message

lib/librte_ip_frag/rte_ip_frag_version.map +2 -8
index a193007c61..5dd34f828c 100644
@@ -1,8 +1,9 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
 	rte_ip_frag_free_death_row;
 	rte_ip_frag_table_create;
+	rte_ip_frag_table_destroy;
 	rte_ip_frag_table_statistics_dump;
 	rte_ipv4_frag_reassemble_packet;
 	rte_ipv4_fragment_packet;
@@ -12,13 +13,6 @@ DPDK_2.0 {
 	local: *;
 };
 
-DPDK_17.08 {
-	global:
-
-	rte_ip_frag_table_destroy;
-
-} DPDK_2.0;
-
 EXPERIMENTAL {
 	global:
 
lib/librte_jobstats/rte_jobstats_version.map +2 -8
index f89441438e..dbd2664ae2 100644
@@ -1,6 +1,7 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
+	rte_jobstats_abort;
 	rte_jobstats_context_finish;
 	rte_jobstats_context_init;
 	rte_jobstats_context_reset;
@@ -17,10 +18,3 @@ DPDK_2.0 {
 
 	local: *;
 };
-
-DPDK_16.04 {
-	global:
-
-	rte_jobstats_abort;
-
-} DPDK_2.0;
lib/librte_kni/rte_kni_version.map +1 -1
index c877dc6aaa..9cd3cedc54 100644
@@ -1,4 +1,4 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
 	rte_kni_alloc;
lib/librte_kvargs/rte_kvargs_version.map +2 -2
index 8f4b4e3f8f..3ba0f4b59c 100644
@@ -1,4 +1,4 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
 	rte_kvargs_count;
@@ -15,4 +15,4 @@ EXPERIMENTAL {
 	rte_kvargs_parse_delim;
 	rte_kvargs_strcmp;
 
-} DPDK_2.0;
+};
lib/librte_latencystats/rte_latencystats_version.map +1 -1
index ac8403e821..e04e63463f 100644
@@ -1,4 +1,4 @@
-DPDK_17.05 {
+DPDK_20.0 {
 	global:
 
 	rte_latencystats_get;
lib/librte_lpm/rte_lpm_version.map +8 -31
index 90beac853d..500f58b806 100644
@@ -1,13 +1,6 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
-	rte_lpm_add;
-	rte_lpm_create;
-	rte_lpm_delete;
-	rte_lpm_delete_all;
-	rte_lpm_find_existing;
-	rte_lpm_free;
-	rte_lpm_is_rule_present;
 	rte_lpm6_add;
 	rte_lpm6_create;
 	rte_lpm6_delete;
@@ -18,29 +11,13 @@ DPDK_2.0 {
 	rte_lpm6_is_rule_present;
 	rte_lpm6_lookup;
 	rte_lpm6_lookup_bulk_func;
+	rte_lpm_add;
+	rte_lpm_create;
+	rte_lpm_delete;
+	rte_lpm_delete_all;
+	rte_lpm_find_existing;
+	rte_lpm_free;
+	rte_lpm_is_rule_present;
 
 	local: *;
 };
-
-DPDK_16.04 {
-	global:
-
-	rte_lpm_add;
-	rte_lpm_find_existing;
-	rte_lpm_create;
-	rte_lpm_free;
-	rte_lpm_is_rule_present;
-	rte_lpm_delete;
-	rte_lpm_delete_all;
-
-} DPDK_2.0;
-
-DPDK_17.05 {
-	global:
-
-	rte_lpm6_add;
-	rte_lpm6_is_rule_present;
-	rte_lpm6_lookup;
-	rte_lpm6_lookup_bulk_func;
-
-} DPDK_16.04;
lib/librte_mbuf/rte_mbuf_version.map +13 -36

71 lines not on this page · raw message

lib/librte_member/rte_member_version.map +1 -1
index 019e4cd962..87780ae611 100644
@@ -1,4 +1,4 @@
-DPDK_17.11 {
+DPDK_20.0 {
 	global:
 
 	rte_member_add;
lib/librte_mempool/rte_mempool_version.map +13 -31

70 lines not on this page · raw message

lib/librte_meter/rte_meter_version.map +4 -9
index 4b460d5803..46410b0369 100644
@@ -1,21 +1,16 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
 	rte_meter_srtcm_color_aware_check;
 	rte_meter_srtcm_color_blind_check;
 	rte_meter_srtcm_config;
+	rte_meter_srtcm_profile_config;
 	rte_meter_trtcm_color_aware_check;
 	rte_meter_trtcm_color_blind_check;
 	rte_meter_trtcm_config;
-
-	local: *;
-};
-
-DPDK_18.08 {
-	global:
-
-	rte_meter_srtcm_profile_config;
 	rte_meter_trtcm_profile_config;
+
+	local: *;
 };
 
 EXPERIMENTAL {
lib/librte_metrics/rte_metrics_version.map +1 -1
index 6ac99a44a1..85663f356e 100644
@@ -1,4 +1,4 @@
-DPDK_17.05 {
+DPDK_20.0 {
 	global:
 
 	rte_metrics_get_names;
lib/librte_net/rte_net_version.map +6 -17
index fffc4a3723..8a4e75a3a0 100644
@@ -1,25 +1,14 @@
-DPDK_16.11 {
-	global:
-	rte_net_get_ptype;
-
-	local: *;
-};
-
-DPDK_17.05 {
-	global:
-
-	rte_net_crc_calc;
-	rte_net_crc_set_alg;
-
-} DPDK_16.11;
-
-DPDK_19.08 {
+DPDK_20.0 {
 	global:
 
 	rte_eth_random_addr;
 	rte_ether_format_addr;
+	rte_net_crc_calc;
+	rte_net_crc_set_alg;
+	rte_net_get_ptype;
 
-} DPDK_17.05;
+	local: *;
+};
 
 EXPERIMENTAL {
 	global:
lib/librte_pci/rte_pci_version.map +1 -1
index 03790cb0f0..67eb845796 100644
@@ -1,4 +1,4 @@
-DPDK_17.11 {
+DPDK_20.0 {
 	global:
 
 	pci_map_resource;
lib/librte_pdump/rte_pdump_version.map +1 -1
index 3e744f3012..6d02ccce6d 100644
@@ -1,4 +1,4 @@
-DPDK_16.07 {
+DPDK_20.0 {
 	global:
 
 	rte_pdump_disable;
lib/librte_pipeline/rte_pipeline_version.map +9 -27
index 420f065d6e..64d38afecd 100644
@@ -1,6 +1,8 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
+	rte_pipeline_ah_packet_drop;
+	rte_pipeline_ah_packet_hijack;
 	rte_pipeline_check;
 	rte_pipeline_create;
 	rte_pipeline_flush;
@@ -9,42 +11,22 @@ DPDK_2.0 {
 	rte_pipeline_port_in_create;
 	rte_pipeline_port_in_disable;
 	rte_pipeline_port_in_enable;
+	rte_pipeline_port_in_stats_read;
 	rte_pipeline_port_out_create;
 	rte_pipeline_port_out_packet_insert;
+	rte_pipeline_port_out_stats_read;
 	rte_pipeline_run;
 	rte_pipeline_table_create;
 	rte_pipeline_table_default_entry_add;
 	rte_pipeline_table_default_entry_delete;
 	rte_pipeline_table_entry_add;
-	rte_pipeline_table_entry_delete;
-
-	local: *;
-};
-
-DPDK_2.1 {
-	global:
-
-	rte_pipeline_port_in_stats_read;
-	rte_pipeline_port_out_stats_read;
-	rte_pipeline_table_stats_read;
-
-} DPDK_2.0;
-
-DPDK_2.2 {
-	global:
-
 	rte_pipeline_table_entry_add_bulk;
+	rte_pipeline_table_entry_delete;
 	rte_pipeline_table_entry_delete_bulk;
+	rte_pipeline_table_stats_read;
 
-} DPDK_2.1;
-
-DPDK_16.04 {
-	global:
-
-	rte_pipeline_ah_packet_hijack;
-	rte_pipeline_ah_packet_drop;
-
-} DPDK_2.2;
+	local: *;
+};
 
 EXPERIMENTAL {
 	global:
lib/librte_port/rte_port_version.map +17 -47

82 lines not on this page · raw message

lib/librte_power/rte_power_version.map +6 -18
index 7729838137..55a168f56e 100644
@@ -1,39 +1,27 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
 	rte_power_exit;
+	rte_power_freq_disable_turbo;
 	rte_power_freq_down;
+	rte_power_freq_enable_turbo;
 	rte_power_freq_max;
[… more lines in the raw message]

Lines of this file are not shown. View the raw message.

lib/librte_rawdev/rte_rawdev_version.map +2 -2
index b61dbff11c..d847c9e0d3 100644

Lines of this file are not shown. View the raw message.

lib/librte_reorder/rte_reorder_version.map +4 -4
index 0a8a54de83..cf444062df 100644

Lines of this file are not shown. View the raw message.

lib/librte_ring/rte_ring_version.map +2 -8
index 510c1386e0..89d84bcf48 100644

Lines of this file are not shown. View the raw message.

lib/librte_sched/rte_sched_version.map +4 -10
index f33761e63e..cefd990367 100644

Lines of this file are not shown. View the raw message.

lib/librte_security/rte_security_version.map +1 -1
index 53267bf3cc..b07314bbf4 100644

Lines of this file are not shown. View the raw message.

lib/librte_table/rte_table_version.map +1 -1
index 6237252bec..40f72b1fe8 100644

Lines of this file are not shown. View the raw message.

lib/librte_timer/rte_timer_version.map +1 -11
index 72f75c8181..2a59d3f081 100644

Lines of this file are not shown. View the raw message.

lib/librte_vhost/rte_vhost_version.map +11 -41

52 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.17.1

Part of the diff is not shown here. View the raw message.

#80 lore raw

PATCH v6 10/10 buildtools: add ABI versioning check script

In reply to Anatoly Burakov

From: Marcin Baran <[email protected]>

Add a shell script that checks whether built libraries are versioned with expected ABI (current ABI, current ABI + 1, or EXPERIMENTAL).

The following command was used to verify current source tree (assuming build directory is in ./build):

find ./build/lib ./build/drivers -name \*.so \
-exec ./buildtools/check-abi-version.sh {} \; -print

---

Notes:
v2:
- Moved this to the end of the patchset
- Fixed bug when ABI symbols were not found because the .so did not declare any public symbols

 buildtools/check-abi-version.sh | 54 +++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)
 create mode 100755 buildtools/check-abi-version.sh
buildtools/check-abi-version.sh new file +54 -0
new file mode 100755
index 0000000000..29aea97735
@@ -0,0 +1,54 @@
+#!/bin/sh
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2019 Intel Corporation
+
+# Check whether library symbols have correct
+# version (provided ABI number or provided ABI
+# number + 1 or EXPERIMENTAL).
+# Args:
+#   $1: path of the library .so file
+#   $2: ABI major version number to check
+#       (defaults to ABI_VERSION file value)
+
+if [ -z "$1" ]; then
+    echo "Script checks whether library symbols have"
+    echo "correct version (ABI_VER/ABI_VER+1/EXPERIMENTAL)"
+    echo "Usage:"
+    echo "  $0 SO_FILE_PATH [ABI_VER]"
+    exit 1
+fi
+
+LIB="$1"
+DEFAULT_ABI=$(cat "$(dirname \
+            $(readlink -f $0))/../config/ABI_VERSION" | \
+            cut -d'.' -f 1)
+ABIVER="DPDK_${2-$DEFAULT_ABI}"
+NEXT_ABIVER="DPDK_$((${2-$DEFAULT_ABI}+1))"
+
+ret=0
+
+# get output of objdump
+OBJ_DUMP_OUTPUT=`objdump -TC --section=.text ${LIB} 2>&1 | grep ".text"`
+
+# there may not be any .text sections in the .so file, in which case exit early
+echo "${OBJ_DUMP_OUTPUT}" | grep "not found in any input file" -q
+if [ "$?" -eq 0 ]; then
+    exit 0
+fi
+
+# we have symbols, so let's see if the versions are correct
+for SYM in `echo "${OBJ_DUMP_OUTPUT}" | awk '{print $(NF-1) "-" $NF}'`
+do
+    version=$(echo $SYM | cut -d'-' -f 1)
+    symbol=$(echo $SYM | cut -d'-' -f 2)
+    case $version in (*"$ABIVER"*|*"$NEXT_ABIVER"*|"EXPERIMENTAL")
+        ;;
+    (*)
+        echo "Warning: symbol $symbol ($version) should be annotated " \
+             "as ABI version $ABIVER / $NEXT_ABIVER, or EXPERIMENTAL."
+        ret=1
+    ;;
+    esac
+done
+
+exit $ret
Signature · 1 line
2.17.1
#81 lore raw

v7 cover Implement the new ABI policy and add helper scripts

In reply to Anatoly Burakov

This patchset prepares the codebase for the new ABI policy and adds a few helper scripts.

There are two new scripts for managing ABI versions added. The first one is a Python script that will read in a .map file, flatten it and update the ABI version to the ABI version specified on the command-line.

The second one is a shell script that will run the above mentioned Python script recursively over the source tree and set the ABI version to either that which is defined in config/ABI_VERSION, or a user-specified one.

Example of its usage: buildtools/update-abi.sh 20.0

This will recurse into lib/ and drivers/ directory and update whatever .map files it can find.

The other shell script that's added is one that can take in a .so file and ensure that its declared public ABI matches either current ABI, next ABI, or EXPERIMENTAL. This was moved to the last commit because it made no sense to have it beforehand.

The source tree was verified to follow the new ABI policy using the following command (assuming built binaries are in build/):

find ./build/lib ./build/drivers -name \*.so \
-exec ./buildtools/check-abi-version.sh {} \; -print

This returns 0.

Changes since v6:
- Rebase on top of latest master
- Fixed map file generation to generate stable ABI if it was there, even if it was empty

Changes since v5:
- Addressed David's comments regarding libtool error messages
- Fixed map file generation to not generate empty stable ABI if it wasn't there before

Changes since v4:
- Fixed shared library build issue for distributor

Changes since v3:
- Put distributor code back and cleaned it up
- Rebased on latest master and regenerated commit 9

Changes since v2:
- Addressed Bruce's review comments
- Removed single distributor mode as per Dave's suggestion

Changes since v1:
- Reordered patchset to have removal of old ABI's before introducing the new one to avoid compile breakages between patches
- Added a new patch fixing missing symbol in octeontx common
- Split script commits into multiple commits and reordered them
- Re-generated the ABI bump commit
- Verified all scripts to work

Anatoly Burakov (2):
buildtools: add ABI update shell script
drivers/octeontx: add missing public symbol

Marcin Baran (6):
config: change ABI versioning to global
timer: remove deprecated code
lpm: remove deprecated code
distributor: remove deprecated code
distributor: rename v2.0 ABI to _single suffix
buildtools: add ABI versioning check script

Pawel Modrak (2):
buildtools: add script for updating symbols abi version
build: change ABI version to 20.0

 buildtools/check-abi-version.sh               |   54 +
 buildtools/meson.build                        |    2 +
 buildtools/update-abi.sh                      |   42 +
 buildtools/update_version_map_abi.py          |  173 +++
 config/ABI_VERSION                            |    1 +
 config/meson.build                            |    4 +-
 .../rte_pmd_bbdev_fpga_lte_fec_version.map    |    8 +-
 .../null/rte_pmd_bbdev_null_version.map       |    2 +-
 .../rte_pmd_bbdev_turbo_sw_version.map        |    2 +-
 drivers/bus/dpaa/rte_bus_dpaa_version.map     |  113 +-
 drivers/bus/fslmc/rte_bus_fslmc_version.map   |  154 +--
 drivers/bus/ifpga/rte_bus_ifpga_version.map   |   14 +-
 drivers/bus/pci/rte_bus_pci_version.map       |    2 +-
 drivers/bus/vdev/rte_bus_vdev_version.map     |   12 +-
 drivers/bus/vmbus/rte_bus_vmbus_version.map   |   12 +-
 drivers/common/cpt/rte_common_cpt_version.map |    9 +-
 .../common/dpaax/rte_common_dpaax_version.map |   14 +-
 .../common/mvep/rte_common_mvep_version.map   |    6 +-
 .../octeontx/rte_common_octeontx_version.map  |    7 +-
 .../rte_common_octeontx2_version.map          |   16 +-
 .../compress/isal/rte_pmd_isal_version.map    |    2 +-
 .../rte_pmd_octeontx_compress_version.map     |    2 +-
 drivers/compress/qat/rte_pmd_qat_version.map  |    2 +-
 .../compress/zlib/rte_pmd_zlib_version.map    |    2 +-
 .../aesni_gcm/rte_pmd_aesni_gcm_version.map   |    2 +-
 .../aesni_mb/rte_pmd_aesni_mb_version.map     |    2 +-
 .../crypto/armv8/rte_pmd_armv8_version.map    |    2 +-
 .../caam_jr/rte_pmd_caam_jr_version.map       |    3 +-
 drivers/crypto/ccp/rte_pmd_ccp_version.map    |    3 +-
 .../dpaa2_sec/rte_pmd_dpaa2_sec_version.map   |   10 +-
 .../dpaa_sec/rte_pmd_dpaa_sec_version.map     |   10 +-
 .../crypto/kasumi/rte_pmd_kasumi_version.map  |    2 +-
 .../crypto/mvsam/rte_pmd_mvsam_version.map    |    2 +-
 .../crypto/nitrox/rte_pmd_nitrox_version.map  |    2 +-
 .../null/rte_pmd_null_crypto_version.map      |    2 +-
 .../rte_pmd_octeontx_crypto_version.map       |    3 +-
 .../rte_pmd_octeontx2_crypto_version.map      |    3 +-
 .../openssl/rte_pmd_openssl_version.map       |    2 +-
 .../rte_pmd_crypto_scheduler_version.map      |   19 +-
 .../crypto/snow3g/rte_pmd_snow3g_version.map  |    2 +-
 .../virtio/rte_pmd_virtio_crypto_version.map  |    2 +-
 drivers/crypto/zuc/rte_pmd_zuc_version.map    |    2 +-
 .../event/dpaa/rte_pmd_dpaa_event_version.map |    3 +-
 .../dpaa2/rte_pmd_dpaa2_event_version.map     |    2 +-
 .../event/dsw/rte_pmd_dsw_event_version.map   |    2 +-
 .../rte_pmd_octeontx_event_version.map        |    2 +-
 .../rte_pmd_octeontx2_event_version.map       |    3 +-
 .../event/opdl/rte_pmd_opdl_event_version.map |    2 +-
 .../rte_pmd_skeleton_event_version.map        |    3 +-
 drivers/event/sw/rte_pmd_sw_event_version.map |    2 +-
 .../bucket/rte_mempool_bucket_version.map     |    3 +-
 .../mempool/dpaa/rte_mempool_dpaa_version.map |    2 +-
 .../dpaa2/rte_mempool_dpaa2_version.map       |   12 +-
 .../octeontx/rte_mempool_octeontx_version.map |    2 +-
 .../rte_mempool_octeontx2_version.map         |    4 +-
 .../mempool/ring/rte_mempool_ring_version.map |    3 +-
 .../stack/rte_mempool_stack_version.map       |    3 +-
 drivers/meson.build                           |   20 +-
 .../af_packet/rte_pmd_af_packet_version.map   |    3 +-
 drivers/net/af_xdp/rte_pmd_af_xdp_version.map |    2 +-
 drivers/net/ark/rte_pmd_ark_version.map       |    5 +-
 .../net/atlantic/rte_pmd_atlantic_version.map |    4 +-
 drivers/net/avp/rte_pmd_avp_version.map       |    2 +-
 drivers/net/axgbe/rte_pmd_axgbe_version.map   |    2 +-
 drivers/net/bnx2x/rte_pmd_bnx2x_version.map   |    3 +-
 drivers/net/bnxt/rte_pmd_bnxt_version.map     |    4 +-
 drivers/net/bonding/rte_pmd_bond_version.map  |   47 +-
 drivers/net/cxgbe/rte_pmd_cxgbe_version.map   |    3 +-
 drivers/net/dpaa/rte_pmd_dpaa_version.map     |   11 +-
 drivers/net/dpaa2/rte_pmd_dpaa2_version.map   |   12 +-
 drivers/net/e1000/rte_pmd_e1000_version.map   |    3 +-
 drivers/net/ena/rte_pmd_ena_version.map       |    3 +-
 drivers/net/enetc/rte_pmd_enetc_version.map   |    3 +-
 drivers/net/enic/rte_pmd_enic_version.map     |    3 +-
 .../net/failsafe/rte_pmd_failsafe_version.map |    3 +-
 drivers/net/fm10k/rte_pmd_fm10k_version.map   |    3 +-
 drivers/net/hinic/rte_pmd_hinic_version.map   |    3 +-
 drivers/net/hns3/rte_pmd_hns3_version.map     |    4 +-
 drivers/net/i40e/rte_pmd_i40e_version.map     |   65 +-
 drivers/net/iavf/rte_pmd_iavf_version.map     |    3 +-
 drivers/net/ice/rte_pmd_ice_version.map       |    3 +-
 drivers/net/ifc/rte_pmd_ifc_version.map       |    3 +-
 drivers/net/ipn3ke/rte_pmd_ipn3ke_version.map |    3 +-
 drivers/net/ixgbe/rte_pmd_ixgbe_version.map   |   62 +-
 drivers/net/kni/rte_pmd_kni_version.map       |    3 +-
 .../net/liquidio/rte_pmd_liquidio_version.map |    3 +-
 drivers/net/memif/rte_pmd_memif_version.map   |    5 +-
 drivers/net/mlx4/rte_pmd_mlx4_version.map     |    3 +-
 drivers/net/mlx5/rte_pmd_mlx5_version.map     |    2 +-
 drivers/net/mvneta/rte_pmd_mvneta_version.map |    2 +-
 drivers/net/mvpp2/rte_pmd_mvpp2_version.map   |    2 +-
 drivers/net/netvsc/rte_pmd_netvsc_version.map |    4 +-
 drivers/net/nfb/rte_pmd_nfb_version.map       |    3 +-
 drivers/net/nfp/rte_pmd_nfp_version.map       |    2 +-
 drivers/net/null/rte_pmd_null_version.map     |    3 +-
 .../net/octeontx/rte_pmd_octeontx_version.map |   10 +-
 .../octeontx2/rte_pmd_octeontx2_version.map   |    3 +-
 drivers/net/pcap/rte_pmd_pcap_version.map     |    3 +-
 drivers/net/pfe/rte_pmd_pfe_version.map       |    3 +-
 drivers/net/qede/rte_pmd_qede_version.map     |    3 +-
 drivers/net/ring/rte_pmd_ring_version.map     |   10 +-
 drivers/net/sfc/rte_pmd_sfc_version.map       |    3 +-
 .../net/softnic/rte_pmd_softnic_version.map   |    2 +-
 .../net/szedata2/rte_pmd_szedata2_version.map |    2 +-
 drivers/net/tap/rte_pmd_tap_version.map       |    3 +-
 .../net/thunderx/rte_pmd_thunderx_version.map |    3 +-
 .../rte_pmd_vdev_netvsc_version.map           |    3 +-
 drivers/net/vhost/rte_pmd_vhost_version.map   |   11 +-
 drivers/net/virtio/rte_pmd_virtio_version.map |    3 +-
 .../net/vmxnet3/rte_pmd_vmxnet3_version.map   |    3 +-
 .../rte_rawdev_dpaa2_cmdif_version.map        |    3 +-
 .../rte_rawdev_dpaa2_qdma_version.map         |    4 +-
 .../raw/ifpga/rte_rawdev_ifpga_version.map    |    3 +-
 drivers/raw/ioat/rte_rawdev_ioat_version.map  |    3 +-
 drivers/raw/ntb/rte_rawdev_ntb_version.map    |    5 +-
 .../rte_rawdev_octeontx2_dma_version.map      |    3 +-
 .../skeleton/rte_rawdev_skeleton_version.map  |    3 +-
 lib/librte_acl/rte_acl_version.map            |    2 +-
 .../rte_bitratestats_version.map              |    2 +-
 lib/librte_cfgfile/rte_cfgfile_version.map    |   34 +-
 lib/librte_cmdline/rte_cmdline_version.map    |   10 +-
 .../rte_cryptodev_version.map                 |  102 +-
 lib/librte_distributor/Makefile               |    2 +-
 lib/librte_distributor/distributor_private.h  |   10 +-
 lib/librte_distributor/meson.build            |    2 +-
 lib/librte_distributor/rte_distributor.c      |   98 +-
 ...ributor_v20.c => rte_distributor_single.c} |   73 +-
 ...ributor_v20.h => rte_distributor_single.h} |   26 +-
 .../rte_distributor_v1705.h                   |   61 -
 .../rte_distributor_version.map               |   16 +-
 lib/librte_eal/rte_eal_version.map            |  324 ++----
 lib/librte_efd/rte_efd_version.map            |    2 +-
 lib/librte_ethdev/rte_ethdev_version.map      |  160 +--
 lib/librte_eventdev/rte_eventdev_version.map  |  130 +--
 lib/librte_gro/rte_gro_version.map            |    2 +-
 lib/librte_gso/rte_gso_version.map            |    2 +-
 lib/librte_hash/rte_hash_version.map          |   43 +-
 lib/librte_ip_frag/rte_ip_frag_version.map    |   10 +-
 lib/librte_jobstats/rte_jobstats_version.map  |   10 +-
 lib/librte_kni/rte_kni_version.map            |    2 +-
 lib/librte_kvargs/rte_kvargs_version.map      |    4 +-
 .../rte_latencystats_version.map              |    2 +-
 lib/librte_lpm/rte_lpm.c                      | 1010 +----------------
 lib/librte_lpm/rte_lpm.h                      |   88 --
 lib/librte_lpm/rte_lpm6.c                     |  140 +--
 lib/librte_lpm/rte_lpm6.h                     |   25 -
 lib/librte_lpm/rte_lpm_version.map            |   39 +-
 lib/librte_mbuf/rte_mbuf_version.map          |   49 +-
 lib/librte_member/rte_member_version.map      |    2 +-
 lib/librte_mempool/rte_mempool_version.map    |   44 +-
 lib/librte_meter/rte_meter_version.map        |   13 +-
 lib/librte_metrics/rte_metrics_version.map    |    2 +-
 lib/librte_net/rte_net_version.map            |   23 +-
 lib/librte_pci/rte_pci_version.map            |    2 +-
 lib/librte_pdump/rte_pdump_version.map        |    2 +-
 lib/librte_pipeline/rte_pipeline_version.map  |   36 +-
 lib/librte_port/rte_port_version.map          |   64 +-
 lib/librte_power/rte_power_version.map        |   24 +-
 lib/librte_rawdev/rte_rawdev_version.map      |    4 +-
 lib/librte_reorder/rte_reorder_version.map    |    8 +-
 lib/librte_ring/rte_ring_version.map          |   10 +-
 lib/librte_sched/rte_sched_version.map        |   14 +-
 lib/librte_security/rte_security_version.map  |    2 +-
 lib/librte_table/rte_table_version.map        |    2 +-
 lib/librte_timer/rte_timer.c                  |  100 +-
 lib/librte_timer/rte_timer.h                  |   15 -
 lib/librte_timer/rte_timer_version.map        |   12 +-
 lib/librte_vhost/rte_vhost_version.map        |   52 +-
 lib/meson.build                               |   18 +-
 meson_options.txt                             |    2 -
 mk/rte.lib.mk                                 |   13 +-
 171 files changed, 1152 insertions(+), 2971 deletions(-)
 create mode 100755 buildtools/check-abi-version.sh
 create mode 100755 buildtools/update-abi.sh
 create mode 100755 buildtools/update_version_map_abi.py
 create mode 100644 config/ABI_VERSION
 rename lib/librte_distributor/{rte_distributor_v20.c => rte_distributor_single.c} (84%)
 rename lib/librte_distributor/{rte_distributor_v20.h => rte_distributor_single.h} (89%)
 delete mode 100644 lib/librte_distributor/rte_distributor_v1705.h
Signature · 1 line
2.17.1
#82 lore raw

PATCH v7 1/10 config: change ABI versioning to global

From: Marcin Baran <[email protected]>

As per new ABI policy, all of the libraries are now versioned using one global ABI version. Changes in this patch implement the necessary steps to enable that.

---

Notes:
v6:
- Silenced grep error message on trying to grep a directory

v3:
- Removed Windows support from Makefile changes
- Removed unneeded path conversions from meson files

 buildtools/meson.build |  2 ++
 config/ABI_VERSION     |  1 +
 config/meson.build     |  4 +++-
 drivers/meson.build    | 20 ++++++++++++--------
 lib/meson.build        | 18 ++++++++++++------
 meson_options.txt      |  2 --
 mk/rte.lib.mk          | 13 ++++---------
 7 files changed, 34 insertions(+), 26 deletions(-)
 create mode 100644 config/ABI_VERSION
buildtools/meson.build +2 -0
index 32c79c1308..78ce69977d 100644
@@ -12,3 +12,5 @@ if python3.found()
 else
 	map_to_def_cmd = ['meson', 'runpython', files('map_to_def.py')]
 endif
+
+is_experimental_cmd = [find_program('grep', 'findstr'), '^DPDK_']
config/ABI_VERSION new file +1 -0
new file mode 100644
index 0000000000..9a7c1e503f
@@ -0,0 +1 @@
+20.0
config/meson.build +3 -1
index 2b1cb92e7e..30aa2a5313 100644
@@ -18,6 +18,8 @@ endforeach
 # depending on the configuration options
 pver = meson.project_version().split('.')
 major_version = '@0@.@1@'.format(pver.get(0), pver.get(1))
+abi_version = run_command(find_program('cat', 'more'),
+	files('ABI_VERSION')).stdout().strip()
 
 # extract all version information into the build configuration
 dpdk_conf.set('RTE_VER_YEAR', pver.get(0).to_int())
@@ -37,7 +39,7 @@ endif
 
 pmd_subdir_opt = get_option('drivers_install_subdir')
 if pmd_subdir_opt.contains('<VERSION>')
-	pmd_subdir_opt = major_version.join(pmd_subdir_opt.split('<VERSION>'))
+	pmd_subdir_opt = abi_version.join(pmd_subdir_opt.split('<VERSION>'))
 endif
 driver_install_path = join_paths(get_option('libdir'), pmd_subdir_opt)
 eal_pmd_path = join_paths(get_option('prefix'), driver_install_path)
drivers/meson.build +12 -8
index 156d2dc717..b03e0c3159 100644
@@ -124,12 +124,19 @@ foreach class:dpdk_driver_classes
 					output: out_filename,
 					depends: [pmdinfogen, tmp_lib])
 
-			if get_option('per_library_versions')
-				lib_version = '@[email protected]'.format(version)
-				so_version = '@0@'.format(version)
+			version_map = '@0@/@1@/@2@_version.map'.format(
+					meson.current_source_dir(),
+					drv_path, lib_name)
+
+			is_experimental = run_command(is_experimental_cmd,
+				files(version_map)).returncode()
+
+			if is_experimental != 0
+				lib_version = '0.1'
+				so_version = '0'
 			else
-				lib_version = major_version
-				so_version = major_version
+				lib_version = abi_version
+				so_version = abi_version
 			endif
 
 			# now build the static driver
@@ -142,9 +149,6 @@ foreach class:dpdk_driver_classes
 				install: true)
 
 			# now build the shared driver
-			version_map = '@0@/@1@/@2@_version.map'.format(
-					meson.current_source_dir(),
-					drv_path, lib_name)
 			shared_lib = shared_library(lib_name,
 				sources,
 				objects: objs,
lib/meson.build +12 -6
index b2ec9c09a9..3cff2482b1 100644
@@ -106,12 +106,18 @@ foreach l:libraries
 				cflags += '-DRTE_USE_FUNCTION_VERSIONING'
 			endif
 
-			if get_option('per_library_versions')
-				lib_version = '@[email protected]'.format(version)
-				so_version = '@0@'.format(version)
+			version_map = '@0@/@1@/rte_@2@_version.map'.format(
+					meson.current_source_dir(), dir_name, name)
+
+			is_experimental = run_command(is_experimental_cmd,
+					files(version_map)).returncode()
+
+			if is_experimental != 0
+				lib_version = '0.1'
+				so_version = '0'
 			else
-				lib_version = major_version
-				so_version = major_version
+				lib_version = abi_version
+				so_version = abi_version
 			endif
 
 			# first build static lib
@@ -127,7 +133,7 @@ foreach l:libraries
 					dependencies: static_deps)
 
 			if not use_function_versioning
-				# use pre-build objects to build shared lib
+				# then use pre-build objects to build shared lib
 				sources = []
 				objs += static_lib.extract_all_objects(recursive: false)
 			else
meson_options.txt +0 -2
index 89650b0e9c..da6a7f0302 100644
@@ -30,8 +30,6 @@ option('max_lcores', type: 'integer', value: 128,
 	description: 'maximum number of cores/threads supported by EAL')
 option('max_numa_nodes', type: 'integer', value: 4,
 	description: 'maximum number of NUMA nodes supported by EAL')
-option('per_library_versions', type: 'boolean', value: true,
-	description: 'true: each lib gets its own version number, false: DPDK version used for each lib')
 option('tests', type: 'boolean', value: true,
 	description: 'build unit tests')
 option('use_hpet', type: 'boolean', value: false,
mk/rte.lib.mk +4 -9
index 4df8849a08..b49af9192b 100644
@@ -11,20 +11,15 @@ EXTLIB_BUILD ?= n
 # VPATH contains at least SRCDIR
 VPATH += $(SRCDIR)
 
-ifneq ($(CONFIG_RTE_MAJOR_ABI),)
-ifneq ($(LIBABIVER),)
-LIBABIVER := $(CONFIG_RTE_MAJOR_ABI)
-endif
+ifneq ($(shell grep -s "^DPDK_" $(SRCDIR)/$(EXPORT_MAP)),)
+LIBABIVER := $(shell cat $(RTE_SRCDIR)/config/ABI_VERSION)
+else
+LIBABIVER := 0
 endif
 
 ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
 LIB := $(patsubst %.a,%.so.$(LIBABIVER),$(LIB))
 ifeq ($(EXTLIB_BUILD),n)
-ifeq ($(CONFIG_RTE_MAJOR_ABI),)
-ifeq ($(CONFIG_RTE_NEXT_ABI),y)
-LIB := $(LIB).1
-endif
-endif
 CPU_LDFLAGS += --version-script=$(SRCDIR)/$(EXPORT_MAP)
 endif
 endif
Signature · 1 line
2.17.1
#83 lore raw

Re: [dpdk-dev] [PATCH v7 01/10] config: change ABI versioning to global

08/11/2019 17:25, Anatoly Burakov:

Quoted 5 lines

From: Marcin Baran <[email protected]>

As per new ABI policy, all of the libraries are now versioned using one global ABI version. Changes in this patch implement the necessary steps to enable that.

For the history, would be nice to describe the "why" of each change here. Please do not be lazy :)

buildtools/meson.build if python3.found() · line 16

Quoted 3 lines
buildtools/meson.build +1 -0
+is_experimental_cmd = [find_program('grep', 'findstr'), '^DPDK_']

A comment is missing to explain the relationship between "experimental" and "^DPDK_".

config/ABI_VERSION line 1

Quoted 3 lines
config/ABI_VERSION new file +1 -0
+20.0

Why in config/ directory and not in root as for VERSION file?

config/ABI_VERSION

Quoted 2 lines
config/ABI_VERSION new file +2 -0
+			if is_experimental != 0
+				lib_version = '0.1'

Why 0.1 and not 0.0?
How do we increment the minor version of experimental libs?

config/ABI_VERSION

Quoted 1 line
config/ABI_VERSION new file +1 -0
+				so_version = '0'

How so_version is incremented?
It would deserve a comment here.

config/ABI_VERSION

Quoted 3 lines
config/ABI_VERSION new file +1 -1
 			if not use_function_versioning
-				# use pre-build objects to build shared lib
+				# then use pre-build objects to build shared lib

Is this change relevant?

config/ABI_VERSION

Quoted 2 lines
config/ABI_VERSION new file +0 -2
-option('per_library_versions', type: 'boolean', value: true,
-	description: 'true: each lib gets its own version number, false: DPDK version used for each lib')

Good to see this option removed.

#84 lore raw

Re: [dpdk-dev] [PATCH v7 01/10] config: change ABI versioning to global

Quoted 8 lines · Thomas Monjalon

08/11/2019 17:25, Anatoly Burakov:

Quoted 5 lines

From: Marcin Baran <[email protected]>

As per new ABI policy, all of the libraries are now versioned using one global ABI version. Changes in this patch implement the necessary steps to enable that.

For the history, would be nice to describe the "why" of each change here.

Here and other review comments:

I never really touched this script because my meson-foo and ABI-foo is non-existent. I would really appreciate some help here on what the changes are supposed to do (esp. with regards to ABI versioning mechanics), because i understand very little of what this patch does.

Quoted 1 line

Please do not be lazy :)

Says the guy who waited until last moment to review it!

Signature · 2 lines
Thanks,
Anatoly
#85 lore raw

Re: [dpdk-dev] [PATCH v7 01/10] config: change ABI versioning to global

In reply to Anatoly Burakov
Quoted 93 lines

-----Original Message-----
From: Burakov, Anatoly <[email protected]>
Sent: Friday 8 November 2019 16:25
To: [email protected]
Cc: Baran, MarcinX <[email protected]>; Thomas Monjalon <[email protected]>; Richardson, Bruce <[email protected]>; Mcnamara, John <[email protected]>; Kinsella, Ray <[email protected]>; [email protected]; Pawel Modrak <[email protected]>
Subject: [PATCH v7 01/10] config: change ABI versioning to global

From: Marcin Baran <[email protected]>

As per new ABI policy, all of the libraries are now versioned using one global ABI version. Changes in this patch implement the necessary steps to enable that.

---

Notes:
v6:
- Silenced grep error message on trying to grep a directory

v3:
- Removed Windows support from Makefile changes
- Removed unneeded path conversions from meson files

 buildtools/meson.build |  2 ++
 config/ABI_VERSION     |  1 +
 config/meson.build     |  4 +++-
 drivers/meson.build    | 20 ++++++++++++--------
 lib/meson.build        | 18 ++++++++++++------
 meson_options.txt      |  2 --
 mk/rte.lib.mk          | 13 ++++---------
 7 files changed, 34 insertions(+), 26 deletions(-)  create mode 100644

config/ABI_VERSION

buildtools/meson.build index renamed from buildtools/meson.build +0 -0

32c79c1308..78ce69977d 100644

buildtools/meson.build +0 -0
@@ -12,3 +12,5 @@ if python3.found()
 else
 	map_to_def_cmd = ['meson', 'runpython', files('map_to_def.py')]

endif

buildtools/meson.build +2 -0
+
+is_experimental_cmd = [find_program('grep', 'findstr'), '^DPDK_']
config/ABI_VERSION new file mode renamed from config/ABI_VERSION +0 -0

100644 index 0000000000..9a7c1e503f

config/ABI_VERSION new file +1 -0
@@ -0,0 +1 @@
+20.0
config/meson.build index renamed from config/meson.build +0 -0

2b1cb92e7e..30aa2a5313 100644

config/meson.build +2 -0
@@ -18,6 +18,8 @@ endforeach
 # depending on the configuration options  pver =
 meson.project_version().split('.')
 major_version = '@0@.@1@'.format(pver.get(0), pver.get(1))
+abi_version = run_command(find_program('cat', 'more'),
+	files('ABI_VERSION')).stdout().strip()
 
 # extract all version information into the build configuration

dpdk_conf.set('RTE_VER_YEAR', pver.get(0).to_int()) @@ -37,7 +39,7 @@ endif

pmd_subdir_opt = get_option('drivers_install_subdir') if pmd_subdir_opt.contains('<VERSION>')

config/meson.build +0 -1
-	pmd_subdir_opt =

major_version.join(pmd_subdir_opt.split('<VERSION>'))

config/meson.build +1 -0
+	pmd_subdir_opt =

abi_version.join(pmd_subdir_opt.split('<VERSION>'))
endif
driver_install_path = join_paths(get_option('libdir'), pmd_subdir_opt)
eal_pmd_path = join_paths(get_option('prefix'), driver_install_path)

drivers/meson.build index renamed from drivers/meson.build +0 -0

156d2dc717..b03e0c3159 100644

drivers/meson.build +0 -2
@@ -124,12 +124,19 @@ foreach class:dpdk_driver_classes
 					output: out_filename,
 					depends: [pmdinfogen, tmp_lib])
 
-			if get_option('per_library_versions')
-				lib_version = '@[email protected]'.format(version)

drivers/meson.build foreach class:dpdk_driver_classes · line 135

Quoted 10 lines
drivers/meson.build +9 -1
-				so_version = '@0@'.format(version)
+			version_map = '@0@/@1@/@2@_version.map'.format(
+					meson.current_source_dir(),
+					drv_path, lib_name)
+
+			is_experimental = run_command(is_experimental_cmd,
+				files(version_map)).returncode()
+
+			if is_experimental != 0
+				lib_version = '0.1'

[rk] This all makes sense - except this part.
[rk] I would expect the experimental major version to always be zero ...
[rk] However I would expect the minor version to increment with each new release or at the maintainers discretion.

Quoted 96 lines
drivers/meson.build +3 -5
+				so_version = '0'
 			else
-				lib_version = major_version
-				so_version = major_version
+				lib_version = abi_version
+				so_version = abi_version
 			endif
 
 			# now build the static driver
@@ -142,9 +149,6 @@ foreach class:dpdk_driver_classes
 				install: true)
 
 			# now build the shared driver
-			version_map = '@0@/@1@/@2@_version.map'.format(
-					meson.current_source_dir(),
-					drv_path, lib_name)
 			shared_lib = shared_library(lib_name,
 				sources,
 				objects: objs,
lib/meson.build index renamed from lib/meson.build +0 -0

b2ec9c09a9..3cff2482b1 100644

lib/meson.build +12 -6
@@ -106,12 +106,18 @@ foreach l:libraries
 				cflags += '-DRTE_USE_FUNCTION_VERSIONING'
 			endif
 
-			if get_option('per_library_versions')
-				lib_version = '@[email protected]'.format(version)
-				so_version = '@0@'.format(version)
+			version_map = '@0@/@1@/rte_@2@_version.map'.format(
+					meson.current_source_dir(), dir_name, name)
+
+			is_experimental = run_command(is_experimental_cmd,
+					files(version_map)).returncode()
+
+			if is_experimental != 0
+				lib_version = '0.1'
+				so_version = '0'
 			else
-				lib_version = major_version
-				so_version = major_version
+				lib_version = abi_version
+				so_version = abi_version
 			endif
 
 			# first build static lib
@@ -127,7 +133,7 @@ foreach l:libraries
 					dependencies: static_deps)
 
 			if not use_function_versioning
-				# use pre-build objects to build shared lib
+				# then use pre-build objects to build shared lib
 				sources = []
 				objs += static_lib.extract_all_objects(recursive:
 false)
lib/meson.build +0 -0
 			else
meson_options.txt index renamed from meson_options.txt +0 -0

89650b0e9c..da6a7f0302 100644

meson_options.txt +0 -1
@@ -30,8 +30,6 @@ option('max_lcores', type: 'integer', value: 128,
 	description: 'maximum number of cores/threads supported by EAL')
 option('max_numa_nodes', type: 'integer', value: 4,
 	description: 'maximum number of NUMA nodes supported by EAL') -
 option('per_library_versions', type: 'boolean', value: true,
-	description: 'true: each lib gets its own version number, false:
 DPDK version used for each lib')
 option('tests', type: 'boolean', value: true,
 	description: 'build unit tests')
 option('use_hpet', type: 'boolean', value: false, diff --git

a/mk/rte.lib.mk b/mk/rte.lib.mk index 4df8849a08..b49af9192b 100644

mk/rte.lib.mk +1 -4
@@ -11,20 +11,15 @@ EXTLIB_BUILD ?= n
 # VPATH contains at least SRCDIR
 VPATH += $(SRCDIR)
 
-ifneq ($(CONFIG_RTE_MAJOR_ABI),)
-ifneq ($(LIBABIVER),)
-LIBABIVER := $(CONFIG_RTE_MAJOR_ABI)
-endif
+ifneq ($(shell grep -s "^DPDK_" $(SRCDIR)/$(EXPORT_MAP)),) LIBABIVER

:=
+$(shell cat $(RTE_SRCDIR)/config/ABI_VERSION) else LIBABIVER := 0
endif

ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
LIB := $(patsubst %.a,%.so.$(LIBABIVER),$(LIB)) ifeq
($(EXTLIB_BUILD),n) -ifeq ($(CONFIG_RTE_MAJOR_ABI),) -ifeq ($(CONFIG_RTE_NEXT_ABI),y) -LIB := $(LIB).1 -endif -endif CPU_LDFLAGS += --version-script=$(SRCDIR)/$(EXPORT_MAP)
endif
endif
--
2.17.1

#86 lore raw

Re: [dpdk-dev] [PATCH v7 01/10] config: change ABI versioning to global

20/11/2019 13:10, Kinsella, Ray:

Quoted 8 lines

From: Burakov, Anatoly <[email protected]>

drivers/meson.build

Quoted 4 lines
drivers/meson.build +2 -0
+			if is_experimental != 0
+				lib_version = '0.1'

[rk] This all makes sense - except this part.
[rk] I would expect the experimental major version to always be zero ...
[rk] However I would expect the minor version to increment with each new release or at the maintainers discretion.

Yes, the minor must be incremented with each new release
if we want to allow 2 DPDK versions to be installed in the same system.

This policy must be changed:
"
Experimental libraries always have a major version of 0 to indicate they exist outside of ABI Versioning,
with the minor version incremented with each ABI change to library. "

I propose to re-use the global ABI version for experimental by prefixing with "0.".
So for ABI 20.0, it could be 0.20.0 or 0.200? Which one?

#87 lore raw

Re: [dpdk-dev] [PATCH v7 01/10] config: change ABI versioning to global

+1 - that's a plan.

Ray K

Quoted 37 lines

-----Original Message-----
From: Thomas Monjalon <[email protected]>
Sent: Wednesday 20 November 2019 13:32
To: Kinsella, Ray <[email protected]>; Burakov, Anatoly <[email protected]>
Cc: [email protected]; Baran, MarcinX <[email protected]>; Richardson, Bruce <[email protected]>; Mcnamara, John <[email protected]>; [email protected]; Pawel Modrak <[email protected]>; Yigit, Ferruh <[email protected]>
Subject: Re: [PATCH v7 01/10] config: change ABI versioning to global

20/11/2019 13:10, Kinsella, Ray:

Quoted 7 lines

From: Burakov, Anatoly <[email protected]>

drivers/meson.build

Quoted 4 lines
drivers/meson.build +2 -0
+			if is_experimental != 0
+				lib_version = '0.1'

[rk] This all makes sense - except this part.
[rk] I would expect the experimental major version to always be zero

...

Quoted 1 line

[rk] However I would expect the minor version to increment with each

new release or at the maintainers discretion.

Yes, the minor must be incremented with each new release if we want to allow 2 DPDK versions to be installed in the same system.

This policy must be changed:
"
Experimental libraries always have a major version of 0 to indicate they exist outside of ABI Versioning, with the minor version incremented with each ABI change to library.
"

I propose to re-use the global ABI version for experimental by prefixing with "0.".
So for ABI 20.0, it could be 0.20.0 or 0.200? Which one?

#88 lore raw

PATCH v7 2/10 buildtools: add script for updating symbols abi version

In reply to Anatoly Burakov

From: Pawel Modrak <[email protected]>

Add a script that automatically merges all stable ABI's under one ABI section with the new version, while leaving experimental section exactly as it is.

---

Notes:
v7:
- Do not remove stable ABI if it was empty

v6:
- Split map file generation function in two
- Do not print stable ABI if it wasn't present

v3:
- Add comments to regex patterns

v2:
- Reworked script to be pep8-compliant and more reliable

 buildtools/update_version_map_abi.py | 173 +++++++++++++++++++++++++++
 1 file changed, 173 insertions(+)
 create mode 100755 buildtools/update_version_map_abi.py
buildtools/update_version_map_abi.py new file +173 -0
new file mode 100755
index 0000000000..0f6196140e
@@ -0,0 +1,173 @@
+#!/usr/bin/env python
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2019 Intel Corporation
+
+"""
+A Python program to update the ABI version and function names in a DPDK
+lib_*_version.map file. Called from the buildtools/update_abi.sh utility.
+"""
+
+from __future__ import print_function
+import argparse
+import sys
+import re
+
+
+def __parse_map_file(f_in):
+    # match function name, followed by semicolon, followed by EOL, optionally
+    # with whitespace inbetween each item
+    func_line_regex = re.compile(r"\s*"
+                                 r"(?P<func>[a-zA-Z_0-9]+)"
+                                 r"\s*"
+                                 r";"
+                                 r"\s*"
+                                 r"$")
+    # match section name, followed by opening bracked, followed by EOL,
+    # optionally with whitespace inbetween each item
+    section_begin_regex = re.compile(r"\s*"
+                                     r"(?P<version>[a-zA-Z0-9_\.]+)"
+                                     r"\s*"
+                                     r"{"
+                                     r"\s*"
+                                     r"$")
+    # match closing bracket, optionally followed by section name (for when we
+    # inherit from another ABI version), followed by semicolon, followed by
+    # EOL, optionally with whitespace inbetween each item
+    section_end_regex = re.compile(r"\s*"
+                                   r"}"
+                                   r"\s*"
+                                   r"(?P<parent>[a-zA-Z0-9_\.]+)?"
+                                   r"\s*"
+                                   r";"
+                                   r"\s*"
+                                   r"$")
+
+    # for stable ABI, we don't care about which version introduced which
+    # function, we just flatten the list. there are dupes in certain files, so
+    # use a set instead of a list
+    stable_lines = set()
+    # copy experimental section as is
+    experimental_lines = []
+    in_experimental = False
+    has_stable = False
+
+    # gather all functions
+    for line in f_in:
+        # clean up the line
+        line = line.strip('\n').strip()
+
+        # is this an end of section?
+        match = section_end_regex.match(line)
+        if match:
+            # whatever section this was, it's not active any more
+            in_experimental = False
+            continue
+
+        # if we're in the middle of experimental section, we need to copy
+        # the section verbatim, so just add the line
+        if in_experimental:
+            experimental_lines += [line]
+            continue
+
+        # skip empty lines
+        if not line:
+            continue
+
+        # is this a beginning of a new section?
+        match = section_begin_regex.match(line)
+        if match:
+            cur_section = match.group("version")
+            # is it experimental?
+            in_experimental = cur_section == "EXPERIMENTAL"
+            if not in_experimental:
+                has_stable = True
+            continue
+
+        # is this a function?
+        match = func_line_regex.match(line)
+        if match:
+            stable_lines.add(match.group("func"))
+
+    return has_stable, stable_lines, experimental_lines
+
+
+def __generate_stable_abi(f_out, abi_version, lines):
+    # print ABI version header
+    print("DPDK_{} {{".format(abi_version), file=f_out)
+
+    # print global section if it exists
+    if lines:
+        print("\tglobal:", file=f_out)
+        # blank line
+        print(file=f_out)
+
+        # print all stable lines, alphabetically sorted
+        for line in sorted(lines):
+            print("\t{};".format(line), file=f_out)
+
+        # another blank line
+        print(file=f_out)
+
+    # print local section
+    print("\tlocal: *;", file=f_out)
+
+    # end stable version
+    print("};", file=f_out)
+
+
+def __generate_experimental_abi(f_out, lines):
+    # start experimental section
+    print("EXPERIMENTAL {", file=f_out)
+
+    # print all experimental lines as they were
+    for line in lines:
+        # don't print empty whitespace
+        if not line:
+            print("", file=f_out)
+        else:
+            print("\t{}".format(line), file=f_out)
+
+    # end section
+    print("};", file=f_out)
+
+
+def __main():
+    arg_parser = argparse.ArgumentParser(
+        description='Merge versions in linker version script.')
+
+    arg_parser.add_argument("map_file", type=str,
+                            help='path to linker version script file '
+                                 '(pattern: *version.map)')
+    arg_parser.add_argument("abi_version", type=str,
+                            help='target ABI version (pattern: MAJOR.MINOR)')
+
+    parsed = arg_parser.parse_args()
+
+    if not parsed.map_file.endswith('version.map'):
+        print("Invalid input file: {}".format(parsed.map_file),
+              file=sys.stderr)
+        arg_parser.print_help()
+        sys.exit(1)
+
+    if not re.match(r"\d{1,2}\.\d{1,2}", parsed.abi_version):
+        print("Invalid ABI version: {}".format(parsed.abi_version),
+              file=sys.stderr)
+        arg_parser.print_help()
+        sys.exit(1)
+
+    with open(parsed.map_file) as f_in:
+        has_stable, stable_lines, experimental_lines = __parse_map_file(f_in)
+
+    with open(parsed.map_file, 'w') as f_out:
+        need_newline = has_stable and experimental_lines
+        if has_stable:
+            __generate_stable_abi(f_out, parsed.abi_version, stable_lines)
+        if need_newline:
+            # separate sections with a newline
+            print(file=f_out)
+        if experimental_lines:
+            __generate_experimental_abi(f_out, experimental_lines)
+
+
+if __name__ == "__main__":
+    __main()
Signature · 1 line
2.17.1
#89 lore raw

Re: [dpdk-dev] [PATCH v7 02/10] buildtools: add script for updating symbols abi version

08/11/2019 17:25, Anatoly Burakov:

Quoted 12 lines

From: Pawel Modrak <[email protected]>

Add a script that automatically merges all stable ABI's under one ABI section with the new version, while leaving experimental section exactly as it is.

---

buildtools/update_version_map_abi.py line 8

Quoted 4 lines
buildtools/update_version_map_abi.py new file +4 -0
+"""
+A Python program to update the ABI version and function names in a DPDK
+lib_*_version.map file. Called from the buildtools/update_abi.sh utility.
+"""

Clearly this script is doing more than updating a version number and names. I already see more in the commit log.
Please would you like to add something in this description?

#90 lore raw

Re: [dpdk-dev] [PATCH v7 02/10] buildtools: add script for updating symbols abi version

Quoted 7 lines · Thomas Monjalon

08/11/2019 17:25, Anatoly Burakov:

Quoted 6 lines

From: Pawel Modrak <[email protected]>

Add a script that automatically merges all stable ABI's under one ABI section with the new version, while leaving experimental section exactly as it is.

Quoted 16 lines

buildtools/update_version_map_abi.py line 8

Quoted 10 lines

---

buildtools/update_version_map_abi.py new file +4 -0
+"""
+A Python program to update the ABI version and function names in a DPDK
+lib_*_version.map file. Called from the buildtools/update_abi.sh utility.
+"""

Clearly this script is doing more than updating a version number and names. I already see more in the commit log.
Please would you like to add something in this description?

Not sure what you're referring to. That's exactly what it's doing. What else is there that i'm missing?

Signature · 2 lines
Thanks,
Anatoly
#91 lore raw

Re: [dpdk-dev] [PATCH v7 02/10] buildtools: add script for updating symbols abi version

19/11/2019 16:38, Burakov, Anatoly:

Quoted 23 lines · Thomas Monjalon
Quoted 7 lines

08/11/2019 17:25, Anatoly Burakov:

Quoted 6 lines

From: Pawel Modrak <[email protected]>

Add a script that automatically merges all stable ABI's under one ABI section with the new version, while leaving experimental section exactly as it is.

Quoted 14 lines

buildtools/update_version_map_abi.py line 8

Quoted 10 lines

---

buildtools/update_version_map_abi.py new file +4 -0
+"""
+A Python program to update the ABI version and function names in a DPDK
+lib_*_version.map file. Called from the buildtools/update_abi.sh utility.
+"""

Clearly this script is doing more than updating a version number and names. I already see more in the commit log.
Please would you like to add something in this description?

Quoted 2 lines

Not sure what you're referring to. That's exactly what it's doing. What else is there that i'm missing?

"merges all stable ABI's under one ABI section" "while leaving experimental section exactly as it is"

I think this needs to be in the comment at the top of the file, so we have an introduction for the code in the rest of the file.

#92 lore raw

PATCH v7 3/10 buildtools: add ABI update shell script

In reply to Anatoly Burakov

In order to facilitate mass updating of version files, add a shell script that recurses into lib/ and drivers/ directories and calls the ABI version update script.

---

Notes:
v3:
- Switch to sh rather than bash, and remove bash-isms
- Address review comments

v2:
- Add this patch to split the shell script from previous commit
- Fixup miscellaneous bugs

 buildtools/update-abi.sh | 42 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100755 buildtools/update-abi.sh
buildtools/update-abi.sh new file +42 -0
new file mode 100755
index 0000000000..89ba5804a6
@@ -0,0 +1,42 @@
+#!/bin/sh
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2019 Intel Corporation
+
+abi_version=$1
+abi_version_file="./config/ABI_VERSION"
+update_path="lib drivers"
+
+if [ -z "$1" ]; then
+      # output to stderr
+      >&2 echo "Please provide ABI version"
+      exit 1
+fi
+
+# check version string format
+echo $abi_version | grep -q -e "^[[:digit:]]\{1,2\}\.[[:digit:]]\{1,2\}$"
+if [ "$?" -ne 0 ]; then
+      # output to stderr
+      >&2 echo "ABI version must be formatted as MAJOR.MINOR version"
+      exit 1
+fi
+
+if [ -n "$2" ]; then
+      abi_version_file=$2
+fi
+
+if [ -n "$3" ]; then
+      # drop $1 and $2
+      shift 2
+      # assign all other arguments as update paths
+      update_path=$@
+fi
+
+echo "New ABI version:" $abi_version
+echo "ABI_VERSION path:" $abi_version_file
+echo "Path to update:" $update_path
+
+echo $abi_version > $abi_version_file
+
+find $update_path -name  \*version.map -exec \
+      ./buildtools/update_version_map_abi.py {} \
+      $abi_version \; -print
Signature · 1 line
2.17.1
#93 lore raw

Re: [dpdk-dev] [PATCH v7 03/10] buildtools: add ABI update shell script

08/11/2019 17:25, Anatoly Burakov:

buildtools/update-abi.sh line 1

Quoted 10 lines

In order to facilitate mass updating of version files, add a shell script that recurses into lib/ and drivers/ directories and calls the ABI version update script.

buildtools/update-abi.sh new file +1 -0
@@ -0,0 +1,42 @@
+#!/bin/sh

For such script, I think -e is mandatory, so we do not miss any error. It would just require merge following check in the "if":

Quoted 7 lines
buildtools/update-abi.sh new file +7 -0
+# check version string format
+echo $abi_version | grep -q -e "^[[:digit:]]\{1,2\}\.[[:digit:]]\{1,2\}$"
+if [ "$?" -ne 0 ]; then
+      # output to stderr
+      >&2 echo "ABI version must be formatted as MAJOR.MINOR version"
+      exit 1
+fi
#94 lore raw

Re: [dpdk-dev] [PATCH v7 03/10] buildtools: add ABI update shell script

Quoted 5 lines · Thomas Monjalon

08/11/2019 17:25, Anatoly Burakov:

Quoted 4 lines

In order to facilitate mass updating of version files, add a shell script that recurses into lib/ and drivers/ directories and calls the ABI version update script.

Quoted 10 lines

buildtools/update-abi.sh line 1

Quoted 6 lines
buildtools/update-abi.sh new file +1 -0
@@ -0,0 +1,42 @@
+#!/bin/sh

For such script, I think -e is mandatory, so we do not miss any error. It would just require merge following check in the "if":

As was discussed on IRC, i'm fine with -e added to shebang, but i don't like if statements that take half of my monitor :) I would rather put it into a function. I just tested it:

```
#!/bin/sh -e

func() {
        false
}

if [ !func ]; then
        echo "Error"
fi
func
echo "This is never reached"
```

This outputs "Error". So i think i'll go ahead and make it into a function. This would still leave the code readable, *and* satisfy the "#!/bin/sh -e" shebang requirement :)

Signature · 2 lines
Thanks,
Anatoly
#95 lore raw

PATCH v7 4/10 timer: remove deprecated code

In reply to Anatoly Burakov

From: Marcin Baran <[email protected]>

Remove code for old ABI versions ahead of ABI version bump.

---

Notes:
v2:
- Moved this to before ABI version bump to avoid compile breakage

 lib/librte_timer/rte_timer.c | 100 ++++-------------------------------
 lib/librte_timer/rte_timer.h |  15 ------
 2 files changed, 10 insertions(+), 105 deletions(-)
lib/librte_timer/rte_timer.c +10 -90
index 381a9f43f8..ca88454ff6 100644
@@ -68,9 +68,6 @@ static struct rte_timer_data *rte_timer_data_arr;
 static const uint32_t default_data_id;
 static uint32_t rte_timer_subsystem_initialized;
 
-/* For maintaining older interfaces for a period */
-static struct rte_timer_data default_timer_data;
-
 /* when debug is enabled, store some statistics */
 #ifdef RTE_LIBRTE_TIMER_DEBUG
 #define __TIMER_STAT_ADD(priv_timer, name, n) do {			\
@@ -131,30 +128,14 @@ rte_timer_data_dealloc(uint32_t id)
 	return 0;
 }
 
-void __vsym
-rte_timer_subsystem_init_v20(void)
-{
-	unsigned lcore_id;
-	struct priv_timer *priv_timer = default_timer_data.priv_timer;
-
-	/* since priv_timer is static, it's zeroed by default, so only init some
-	 * fields.
-	 */
-	for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id ++) {
-		rte_spinlock_init(&priv_timer[lcore_id].list_lock);
-		priv_timer[lcore_id].prev_lcore = lcore_id;
-	}
-}
-VERSION_SYMBOL(rte_timer_subsystem_init, _v20, 2.0);
-
 /* Init the timer library. Allocate an array of timer data structs in shared
  * memory, and allocate the zeroth entry for use with original timer
  * APIs. Since the intersection of the sets of lcore ids in primary and
  * secondary processes should be empty, the zeroth entry can be shared by
  * multiple processes.
  */
-int __vsym
-rte_timer_subsystem_init_v1905(void)
+int
+rte_timer_subsystem_init(void)
 {
 	const struct rte_memzone *mz;
 	struct rte_timer_data *data;
@@ -209,9 +190,6 @@ rte_timer_subsystem_init_v1905(void)
 
 	return 0;
 }
-MAP_STATIC_SYMBOL(int rte_timer_subsystem_init(void),
-		  rte_timer_subsystem_init_v1905);
-BIND_DEFAULT_SYMBOL(rte_timer_subsystem_init, _v1905, 19.05);
 
 void
 rte_timer_subsystem_finalize(void)
@@ -551,43 +529,14 @@ __rte_timer_reset(struct rte_timer *tim, uint64_t expire,
 }
 
 /* Reset and start the timer associated with the timer handle tim */
-int __vsym
-rte_timer_reset_v20(struct rte_timer *tim, uint64_t ticks,
-		    enum rte_timer_type type, unsigned int tim_lcore,
-		    rte_timer_cb_t fct, void *arg)
-{
-	uint64_t cur_time = rte_get_timer_cycles();
-	uint64_t period;
-
-	if (unlikely((tim_lcore != (unsigned)LCORE_ID_ANY) &&
-			!(rte_lcore_is_enabled(tim_lcore) ||
-			  rte_lcore_has_role(tim_lcore, ROLE_SERVICE))))
-		return -1;
-
-	if (type == PERIODICAL)
-		period = ticks;
-	else
-		period = 0;
-
-	return __rte_timer_reset(tim,  cur_time + ticks, period, tim_lcore,
-			  fct, arg, 0, &default_timer_data);
-}
-VERSION_SYMBOL(rte_timer_reset, _v20, 2.0);
-
-int __vsym
-rte_timer_reset_v1905(struct rte_timer *tim, uint64_t ticks,
+int
+rte_timer_reset(struct rte_timer *tim, uint64_t ticks,
 		      enum rte_timer_type type, unsigned int tim_lcore,
 		      rte_timer_cb_t fct, void *arg)
 {
 	return rte_timer_alt_reset(default_data_id, tim, ticks, type,
 				   tim_lcore, fct, arg);
 }
-MAP_STATIC_SYMBOL(int rte_timer_reset(struct rte_timer *tim, uint64_t ticks,
-				      enum rte_timer_type type,
-				      unsigned int tim_lcore,
-				      rte_timer_cb_t fct, void *arg),
-		  rte_timer_reset_v1905);
-BIND_DEFAULT_SYMBOL(rte_timer_reset, _v1905, 19.05);
 
 int
 rte_timer_alt_reset(uint32_t timer_data_id, struct rte_timer *tim,
@@ -657,21 +606,11 @@ __rte_timer_stop(struct rte_timer *tim, int local_is_locked,
 }
 
 /* Stop the timer associated with the timer handle tim */
-int __vsym
-rte_timer_stop_v20(struct rte_timer *tim)
-{
-	return __rte_timer_stop(tim, 0, &default_timer_data);
-}
-VERSION_SYMBOL(rte_timer_stop, _v20, 2.0);
-
-int __vsym
-rte_timer_stop_v1905(struct rte_timer *tim)
+int
+rte_timer_stop(struct rte_timer *tim)
 {
 	return rte_timer_alt_stop(default_data_id, tim);
 }
-MAP_STATIC_SYMBOL(int rte_timer_stop(struct rte_timer *tim),
-		  rte_timer_stop_v1905);
-BIND_DEFAULT_SYMBOL(rte_timer_stop, _v1905, 19.05);
 
 int
 rte_timer_alt_stop(uint32_t timer_data_id, struct rte_timer *tim)
@@ -817,15 +756,8 @@ __rte_timer_manage(struct rte_timer_data *timer_data)
 	priv_timer[lcore_id].running_tim = NULL;
 }
 
-void __vsym
-rte_timer_manage_v20(void)
-{
-	__rte_timer_manage(&default_timer_data);
-}
-VERSION_SYMBOL(rte_timer_manage, _v20, 2.0);
-
-int __vsym
-rte_timer_manage_v1905(void)
+int
+rte_timer_manage(void)
 {
 	struct rte_timer_data *timer_data;
 
@@ -835,8 +767,6 @@ rte_timer_manage_v1905(void)
 
 	return 0;
 }
-MAP_STATIC_SYMBOL(int rte_timer_manage(void), rte_timer_manage_v1905);
-BIND_DEFAULT_SYMBOL(rte_timer_manage, _v1905, 19.05);
 
 int
 rte_timer_alt_manage(uint32_t timer_data_id,
@@ -1074,21 +1004,11 @@ __rte_timer_dump_stats(struct rte_timer_data *timer_data __rte_unused, FILE *f)
 #endif
 }
 
-void __vsym
-rte_timer_dump_stats_v20(FILE *f)
-{
-	__rte_timer_dump_stats(&default_timer_data, f);
-}
-VERSION_SYMBOL(rte_timer_dump_stats, _v20, 2.0);
-
-int __vsym
-rte_timer_dump_stats_v1905(FILE *f)
+int
+rte_timer_dump_stats(FILE *f)
 {
 	return rte_timer_alt_dump_stats(default_data_id, f);
 }
-MAP_STATIC_SYMBOL(int rte_timer_dump_stats(FILE *f),
-		  rte_timer_dump_stats_v1905);
-BIND_DEFAULT_SYMBOL(rte_timer_dump_stats, _v1905, 19.05);
 
 int
 rte_timer_alt_dump_stats(uint32_t timer_data_id __rte_unused, FILE *f)
lib/librte_timer/rte_timer.h +0 -15
index 05d287d8f2..9dc5fc3092 100644
@@ -181,8 +181,6 @@ int rte_timer_data_dealloc(uint32_t id);
  *      subsystem
  */
 int rte_timer_subsystem_init(void);
-int rte_timer_subsystem_init_v1905(void);
-void rte_timer_subsystem_init_v20(void);
 
 /**
  * @warning
@@ -250,13 +248,6 @@ void rte_timer_init(struct rte_timer *tim);
 int rte_timer_reset(struct rte_timer *tim, uint64_t ticks,
 		    enum rte_timer_type type, unsigned tim_lcore,
 		    rte_timer_cb_t fct, void *arg);
-int rte_timer_reset_v1905(struct rte_timer *tim, uint64_t ticks,
-			  enum rte_timer_type type, unsigned int tim_lcore,
-			  rte_timer_cb_t fct, void *arg);
-int rte_timer_reset_v20(struct rte_timer *tim, uint64_t ticks,
-			enum rte_timer_type type, unsigned int tim_lcore,
-			rte_timer_cb_t fct, void *arg);
-
 
 /**
  * Loop until rte_timer_reset() succeeds.
@@ -313,8 +304,6 @@ rte_timer_reset_sync(struct rte_timer *tim, uint64_t ticks,
  *   - (-1): The timer is in the RUNNING or CONFIG state.
  */
 int rte_timer_stop(struct rte_timer *tim);
-int rte_timer_stop_v1905(struct rte_timer *tim);
-int rte_timer_stop_v20(struct rte_timer *tim);
 
 /**
  * Loop until rte_timer_stop() succeeds.
@@ -358,8 +347,6 @@ int rte_timer_pending(struct rte_timer *tim);
  *   - -EINVAL: timer subsystem not yet initialized
  */
 int rte_timer_manage(void);
-int rte_timer_manage_v1905(void);
-void rte_timer_manage_v20(void);
 
 /**
  * Dump statistics about timers.
@@ -371,8 +358,6 @@ void rte_timer_manage_v20(void);
  *   - -EINVAL: timer subsystem not yet initialized
  */
 int rte_timer_dump_stats(FILE *f);
-int rte_timer_dump_stats_v1905(FILE *f);
-void rte_timer_dump_stats_v20(FILE *f);
 
 /**
  * @warning
Signature · 1 line
2.17.1
#96 lore raw

Re: [dpdk-dev] [PATCH v7 04/10] timer: remove deprecated code

Quoted 9 lines · Anatoly Burakov

From: Marcin Baran <[email protected]>

Remove code for old ABI versions ahead of ABI version bump.

Quoted 5 lines

---

Notes:
v2:
- Moved this to before ABI version bump to avoid compile breakage

The .map should have been cleaned up at the same time those symbols are removed.

(quoted diff) +0 -0

b/lib/librte_timer/rte_timer_version.map
index 72f75c818..92c69b2e2 100644

lib/librte_timer/rte_timer_version.map +0 -5
@@ -1,15 +1,10 @@
 DPDK_2.0 {
        global:
 
-       rte_timer_dump_stats;
        rte_timer_init;
-       rte_timer_manage;
        rte_timer_pending;
-       rte_timer_reset;
        rte_timer_reset_sync;
-       rte_timer_stop;
        rte_timer_stop_sync;
-       rte_timer_subsystem_init;
 
        local: *;
 };

--
David Marchand

#97 lore raw

PATCH v7 5/10 lpm: remove deprecated code

In reply to Anatoly Burakov

From: Marcin Baran <[email protected]>

Remove code for old ABI versions ahead of ABI version bump.

---

Notes:
v2:
- Moved this to before ABI version bump to avoid compile breakage

 lib/librte_lpm/rte_lpm.c  | 1010 ++-----------------------------------
 lib/librte_lpm/rte_lpm.h  |   88 ----
 lib/librte_lpm/rte_lpm6.c |  140 +----
 lib/librte_lpm/rte_lpm6.h |   25 -
 4 files changed, 59 insertions(+), 1204 deletions(-)
lib/librte_lpm/rte_lpm.c +41 -969
index 106916dc82..b78c487447 100644
@@ -90,34 +90,8 @@ depth_to_range(uint8_t depth)
 /*
  * Find an existing lpm table and return a pointer to it.
  */
-struct rte_lpm_v20 * __vsym
-rte_lpm_find_existing_v20(const char *name)
-{
-	struct rte_lpm_v20 *l = NULL;
-	struct rte_tailq_entry *te;
-	struct rte_lpm_list *lpm_list;
-
-	lpm_list = RTE_TAILQ_CAST(rte_lpm_tailq.head, rte_lpm_list);
-
-	rte_mcfg_tailq_read_lock();
-	TAILQ_FOREACH(te, lpm_list, next) {
-		l = te->data;
-		if (strncmp(name, l->name, RTE_LPM_NAMESIZE) == 0)
-			break;
-	}
-	rte_mcfg_tailq_read_unlock();
-
-	if (te == NULL) {
-		rte_errno = ENOENT;
-		return NULL;
-	}
-
-	return l;
-}
-VERSION_SYMBOL(rte_lpm_find_existing, _v20, 2.0);
-
-struct rte_lpm * __vsym
-rte_lpm_find_existing_v1604(const char *name)
+struct rte_lpm *
+rte_lpm_find_existing(const char *name)
 {
 	struct rte_lpm *l = NULL;
 	struct rte_tailq_entry *te;
@@ -140,88 +114,12 @@ rte_lpm_find_existing_v1604(const char *name)
 
 	return l;
 }
-BIND_DEFAULT_SYMBOL(rte_lpm_find_existing, _v1604, 16.04);
-MAP_STATIC_SYMBOL(struct rte_lpm *rte_lpm_find_existing(const char *name),
-		rte_lpm_find_existing_v1604);
 
 /*
  * Allocates memory for LPM object
  */
-struct rte_lpm_v20 * __vsym
-rte_lpm_create_v20(const char *name, int socket_id, int max_rules,
-		__rte_unused int flags)
-{
-	char mem_name[RTE_LPM_NAMESIZE];
-	struct rte_lpm_v20 *lpm = NULL;
-	struct rte_tailq_entry *te;
-	uint32_t mem_size;
-	struct rte_lpm_list *lpm_list;
-
-	lpm_list = RTE_TAILQ_CAST(rte_lpm_tailq.head, rte_lpm_list);
-
-	RTE_BUILD_BUG_ON(sizeof(struct rte_lpm_tbl_entry_v20) != 2);
-
-	/* Check user arguments. */
-	if ((name == NULL) || (socket_id < -1) || (max_rules == 0)) {
-		rte_errno = EINVAL;
-		return NULL;
-	}
-
-	snprintf(mem_name, sizeof(mem_name), "LPM_%s", name);
-
-	/* Determine the amount of memory to allocate. */
-	mem_size = sizeof(*lpm) + (sizeof(lpm->rules_tbl[0]) * max_rules);
-
-	rte_mcfg_tailq_write_lock();
-
-	/* guarantee there's no existing */
-	TAILQ_FOREACH(te, lpm_list, next) {
-		lpm = te->data;
-		if (strncmp(name, lpm->name, RTE_LPM_NAMESIZE) == 0)
-			break;
-	}
-
-	if (te != NULL) {
-		lpm = NULL;
-		rte_errno = EEXIST;
-		goto exit;
-	}
-
-	/* allocate tailq entry */
-	te = rte_zmalloc("LPM_TAILQ_ENTRY", sizeof(*te), 0);
-	if (te == NULL) {
-		RTE_LOG(ERR, LPM, "Failed to allocate tailq entry\n");
-		rte_errno = ENOMEM;
-		goto exit;
-	}
-
-	/* Allocate memory to store the LPM data structures. */
-	lpm = rte_zmalloc_socket(mem_name, mem_size,
-			RTE_CACHE_LINE_SIZE, socket_id);
-	if (lpm == NULL) {
-		RTE_LOG(ERR, LPM, "LPM memory allocation failed\n");
-		rte_free(te);
-		rte_errno = ENOMEM;
-		goto exit;
-	}
-
-	/* Save user arguments. */
-	lpm->max_rules = max_rules;
-	strlcpy(lpm->name, name, sizeof(lpm->name));
-
-	te->data = lpm;
-
-	TAILQ_INSERT_TAIL(lpm_list, te, next);
-
-exit:
-	rte_mcfg_tailq_write_unlock();
-
-	return lpm;
-}
-VERSION_SYMBOL(rte_lpm_create, _v20, 2.0);
-
-struct rte_lpm * __vsym
-rte_lpm_create_v1604(const char *name, int socket_id,
+struct rte_lpm *
+rte_lpm_create(const char *name, int socket_id,
 		const struct rte_lpm_config *config)
 {
 	char mem_name[RTE_LPM_NAMESIZE];
@@ -321,45 +219,12 @@ rte_lpm_create_v1604(const char *name, int socket_id,
 
 	return lpm;
 }
-BIND_DEFAULT_SYMBOL(rte_lpm_create, _v1604, 16.04);
-MAP_STATIC_SYMBOL(
-	struct rte_lpm *rte_lpm_create(const char *name, int socket_id,
-			const struct rte_lpm_config *config), rte_lpm_create_v1604);
 
 /*
  * Deallocates memory for given LPM table.
  */
-void __vsym
-rte_lpm_free_v20(struct rte_lpm_v20 *lpm)
-{
-	struct rte_lpm_list *lpm_list;
-	struct rte_tailq_entry *te;
-
-	/* Check user arguments. */
-	if (lpm == NULL)
-		return;
-
-	lpm_list = RTE_TAILQ_CAST(rte_lpm_tailq.head, rte_lpm_list);
-
-	rte_mcfg_tailq_write_lock();
-
-	/* find our tailq entry */
-	TAILQ_FOREACH(te, lpm_list, next) {
-		if (te->data == (void *) lpm)
-			break;
-	}
-	if (te != NULL)
-		TAILQ_REMOVE(lpm_list, te, next);
-
-	rte_mcfg_tailq_write_unlock();
-
-	rte_free(lpm);
-	rte_free(te);
-}
-VERSION_SYMBOL(rte_lpm_free, _v20, 2.0);
-
-void __vsym
-rte_lpm_free_v1604(struct rte_lpm *lpm)
+void
+rte_lpm_free(struct rte_lpm *lpm)
 {
 	struct rte_lpm_list *lpm_list;
 	struct rte_tailq_entry *te;
@@ -387,9 +252,6 @@ rte_lpm_free_v1604(struct rte_lpm *lpm)
 	rte_free(lpm);
 	rte_free(te);
 }
-BIND_DEFAULT_SYMBOL(rte_lpm_free, _v1604, 16.04);
-MAP_STATIC_SYMBOL(void rte_lpm_free(struct rte_lpm *lpm),
-		rte_lpm_free_v1604);
 
 /*
  * Adds a rule to the rule table.
@@ -402,79 +264,7 @@ MAP_STATIC_SYMBOL(void rte_lpm_free(struct rte_lpm *lpm),
  * NOTE: Valid range for depth parameter is 1 .. 32 inclusive.
  */
 static int32_t
-rule_add_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked, uint8_t depth,
-	uint8_t next_hop)
-{
-	uint32_t rule_gindex, rule_index, last_rule;
-	int i;
-
-	VERIFY_DEPTH(depth);
-
-	/* Scan through rule group to see if rule already exists. */
-	if (lpm->rule_info[depth - 1].used_rules > 0) {
-
-		/* rule_gindex stands for rule group index. */
-		rule_gindex = lpm->rule_info[depth - 1].first_rule;
-		/* Initialise rule_index to point to start of rule group. */
-		rule_index = rule_gindex;
-		/* Last rule = Last used rule in this rule group. */
-		last_rule = rule_gindex + lpm->rule_info[depth - 1].used_rules;
-
-		for (; rule_index < last_rule; rule_index++) {
-
-			/* If rule already exists update its next_hop and return. */
-			if (lpm->rules_tbl[rule_index].ip == ip_masked) {
-				lpm->rules_tbl[rule_index].next_hop = next_hop;
-
-				return rule_index;
-			}
-		}
-
-		if (rule_index == lpm->max_rules)
-			return -ENOSPC;
-	} else {
-		/* Calculate the position in which the rule will be stored. */
-		rule_index = 0;
-
-		for (i = depth - 1; i > 0; i--) {
-			if (lpm->rule_info[i - 1].used_rules > 0) {
-				rule_index = lpm->rule_info[i - 1].first_rule
-						+ lpm->rule_info[i - 1].used_rules;
-				break;
-			}
-		}
-		if (rule_index == lpm->max_rules)
-			return -ENOSPC;
-
-		lpm->rule_info[depth - 1].first_rule = rule_index;
-	}
-
-	/* Make room for the new rule in the array. */
-	for (i = RTE_LPM_MAX_DEPTH; i > depth; i--) {
-		if (lpm->rule_info[i - 1].first_rule
-				+ lpm->rule_info[i - 1].used_rules == lpm->max_rules)
-			return -ENOSPC;
-
-		if (lpm->rule_info[i - 1].used_rules > 0) {
-			lpm->rules_tbl[lpm->rule_info[i - 1].first_rule
-				+ lpm->rule_info[i - 1].used_rules]
-					= lpm->rules_tbl[lpm->rule_info[i - 1].first_rule];
-			lpm->rule_info[i - 1].first_rule++;
-		}
-	}
-
-	/* Add the new rule. */
-	lpm->rules_tbl[rule_index].ip = ip_masked;
-	lpm->rules_tbl[rule_index].next_hop = next_hop;
-
-	/* Increment the used rules counter for this rule group. */
-	lpm->rule_info[depth - 1].used_rules++;
-
-	return rule_index;
-}
-
-static int32_t
-rule_add_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
+rule_add(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
 	uint32_t next_hop)
 {
 	uint32_t rule_gindex, rule_index, last_rule;
@@ -550,30 +340,7 @@ rule_add_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
  * NOTE: Valid range for depth parameter is 1 .. 32 inclusive.
  */
 static void
-rule_delete_v20(struct rte_lpm_v20 *lpm, int32_t rule_index, uint8_t depth)
-{
-	int i;
-
-	VERIFY_DEPTH(depth);
-
-	lpm->rules_tbl[rule_index] =
-			lpm->rules_tbl[lpm->rule_info[depth - 1].first_rule
-				+ lpm->rule_info[depth - 1].used_rules - 1];
-
-	for (i = depth; i < RTE_LPM_MAX_DEPTH; i++) {
-		if (lpm->rule_info[i].used_rules > 0) {
-			lpm->rules_tbl[lpm->rule_info[i].first_rule - 1] =
-				lpm->rules_tbl[lpm->rule_info[i].first_rule
-					+ lpm->rule_info[i].used_rules - 1];
-			lpm->rule_info[i].first_rule--;
-		}
-	}
-
-	lpm->rule_info[depth - 1].used_rules--;
-}
-
-static void
-rule_delete_v1604(struct rte_lpm *lpm, int32_t rule_index, uint8_t depth)
+rule_delete(struct rte_lpm *lpm, int32_t rule_index, uint8_t depth)
 {
 	int i;
 
@@ -600,28 +367,7 @@ rule_delete_v1604(struct rte_lpm *lpm, int32_t rule_index, uint8_t depth)
  * NOTE: Valid range for depth parameter is 1 .. 32 inclusive.
  */
 static int32_t
-rule_find_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked, uint8_t depth)
-{
-	uint32_t rule_gindex, last_rule, rule_index;
-
-	VERIFY_DEPTH(depth);
-
-	rule_gindex = lpm->rule_info[depth - 1].first_rule;
-	last_rule = rule_gindex + lpm->rule_info[depth - 1].used_rules;
-
-	/* Scan used rules at given depth to find rule. */
-	for (rule_index = rule_gindex; rule_index < last_rule; rule_index++) {
-		/* If rule is found return the rule index. */
-		if (lpm->rules_tbl[rule_index].ip == ip_masked)
-			return rule_index;
-	}
-
-	/* If rule is not found return -EINVAL. */
-	return -EINVAL;
-}
-
-static int32_t
-rule_find_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth)
+rule_find(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth)
 {
 	uint32_t rule_gindex, last_rule, rule_index;
 
@@ -645,42 +391,7 @@ rule_find_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth)
  * Find, clean and allocate a tbl8.
  */
 static int32_t
-tbl8_alloc_v20(struct rte_lpm_tbl_entry_v20 *tbl8)
-{
-	uint32_t group_idx; /* tbl8 group index. */
-	struct rte_lpm_tbl_entry_v20 *tbl8_entry;
-
-	/* Scan through tbl8 to find a free (i.e. INVALID) tbl8 group. */
-	for (group_idx = 0; group_idx < RTE_LPM_TBL8_NUM_GROUPS;
-			group_idx++) {
-		tbl8_entry = &tbl8[group_idx * RTE_LPM_TBL8_GROUP_NUM_ENTRIES];
-		/* If a free tbl8 group is found clean it and set as VALID. */
-		if (!tbl8_entry->valid_group) {
-			struct rte_lpm_tbl_entry_v20 new_tbl8_entry = {
-				.valid = INVALID,
-				.depth = 0,
-				.valid_group = VALID,
-			};
-			new_tbl8_entry.next_hop = 0;
-
-			memset(&tbl8_entry[0], 0,
-					RTE_LPM_TBL8_GROUP_NUM_ENTRIES *
-					sizeof(tbl8_entry[0]));
-
-			__atomic_store(tbl8_entry, &new_tbl8_entry,
-					__ATOMIC_RELAXED);
-
-			/* Return group index for allocated tbl8 group. */
-			return group_idx;
-		}
-	}
-
-	/* If there are no tbl8 groups free then return error. */
-	return -ENOSPC;
-}
-
-static int32_t
-tbl8_alloc_v1604(struct rte_lpm_tbl_entry *tbl8, uint32_t number_tbl8s)
+tbl8_alloc(struct rte_lpm_tbl_entry *tbl8, uint32_t number_tbl8s)
 {
 	uint32_t group_idx; /* tbl8 group index. */
 	struct rte_lpm_tbl_entry *tbl8_entry;
@@ -714,22 +425,7 @@ tbl8_alloc_v1604(struct rte_lpm_tbl_entry *tbl8, uint32_t number_tbl8s)
 }
 
 static void
-tbl8_free_v20(struct rte_lpm_tbl_entry_v20 *tbl8, uint32_t tbl8_group_start)
-{
-	/* Set tbl8 group invalid*/
-	struct rte_lpm_tbl_entry_v20 zero_tbl8_entry = {
-		.valid = INVALID,
-		.depth = 0,
-		.valid_group = INVALID,
-	};
-	zero_tbl8_entry.next_hop = 0;
-
-	__atomic_store(&tbl8[tbl8_group_start], &zero_tbl8_entry,
-			__ATOMIC_RELAXED);
-}
-
-static void
-tbl8_free_v1604(struct rte_lpm_tbl_entry *tbl8, uint32_t tbl8_group_start)
+tbl8_free(struct rte_lpm_tbl_entry *tbl8, uint32_t tbl8_group_start)
 {
 	/* Set tbl8 group invalid*/
 	struct rte_lpm_tbl_entry zero_tbl8_entry = {0};
@@ -739,78 +435,7 @@ tbl8_free_v1604(struct rte_lpm_tbl_entry *tbl8, uint32_t tbl8_group_start)
 }
 
 static __rte_noinline int32_t
-add_depth_small_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth,
-		uint8_t next_hop)
-{
-	uint32_t tbl24_index, tbl24_range, tbl8_index, tbl8_group_end, i, j;
-
-	/* Calculate the index into Table24. */
-	tbl24_index = ip >> 8;
-	tbl24_range = depth_to_range(depth);
-
-	for (i = tbl24_index; i < (tbl24_index + tbl24_range); i++) {
-		/*
-		 * For invalid OR valid and non-extended tbl 24 entries set
-		 * entry.
-		 */
-		if (!lpm->tbl24[i].valid || (lpm->tbl24[i].valid_group == 0 &&
-				lpm->tbl24[i].depth <= depth)) {
-
-			struct rte_lpm_tbl_entry_v20 new_tbl24_entry = {
-				.valid = VALID,
-				.valid_group = 0,
-				.depth = depth,
-			};
-			new_tbl24_entry.next_hop = next_hop;
-
-			/* Setting tbl24 entry in one go to avoid race
-			 * conditions
-			 */
-			__atomic_store(&lpm->tbl24[i], &new_tbl24_entry,
-					__ATOMIC_RELEASE);
-
-			continue;
-		}
-
-		if (lpm->tbl24[i].valid_group == 1) {
-			/* If tbl24 entry is valid and extended calculate the
-			 *  index into tbl8.
-			 */
-			tbl8_index = lpm->tbl24[i].group_idx *
-					RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-			tbl8_group_end = tbl8_index +
-					RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-
-			for (j = tbl8_index; j < tbl8_group_end; j++) {
-				if (!lpm->tbl8[j].valid ||
-						lpm->tbl8[j].depth <= depth) {
-					struct rte_lpm_tbl_entry_v20
-						new_tbl8_entry = {
-						.valid = VALID,
-						.valid_group = VALID,
-						.depth = depth,
-					};
-					new_tbl8_entry.next_hop = next_hop;
-
-					/*
-					 * Setting tbl8 entry in one go to avoid
-					 * race conditions
-					 */
-					__atomic_store(&lpm->tbl8[j],
-						&new_tbl8_entry,
-						__ATOMIC_RELAXED);
-
-					continue;
-				}
-			}
-		}
-	}
-
-	return 0;
-}
-
-static __rte_noinline int32_t
-add_depth_small_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
+add_depth_small(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
 		uint32_t next_hop)
 {
 #define group_idx next_hop
@@ -882,150 +507,7 @@ add_depth_small_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
 }
 
 static __rte_noinline int32_t
-add_depth_big_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked, uint8_t depth,
-		uint8_t next_hop)
-{
-	uint32_t tbl24_index;
-	int32_t tbl8_group_index, tbl8_group_start, tbl8_group_end, tbl8_index,
-		tbl8_range, i;
-
-	tbl24_index = (ip_masked >> 8);
-	tbl8_range = depth_to_range(depth);
-
-	if (!lpm->tbl24[tbl24_index].valid) {
-		/* Search for a free tbl8 group. */
-		tbl8_group_index = tbl8_alloc_v20(lpm->tbl8);
-
-		/* Check tbl8 allocation was successful. */
-		if (tbl8_group_index < 0) {
-			return tbl8_group_index;
-		}
-
-		/* Find index into tbl8 and range. */
-		tbl8_index = (tbl8_group_index *
-				RTE_LPM_TBL8_GROUP_NUM_ENTRIES) +
-				(ip_masked & 0xFF);
-
-		/* Set tbl8 entry. */
-		for (i = tbl8_index; i < (tbl8_index + tbl8_range); i++) {
-			struct rte_lpm_tbl_entry_v20 new_tbl8_entry = {
-				.valid = VALID,
-				.depth = depth,
-				.valid_group = lpm->tbl8[i].valid_group,
-			};
-			new_tbl8_entry.next_hop = next_hop;
-			__atomic_store(&lpm->tbl8[i], &new_tbl8_entry,
-					__ATOMIC_RELAXED);
-		}
-
-		/*
-		 * Update tbl24 entry to point to new tbl8 entry. Note: The
-		 * ext_flag and tbl8_index need to be updated simultaneously,
-		 * so assign whole structure in one go
-		 */
-
-		struct rte_lpm_tbl_entry_v20 new_tbl24_entry = {
-			.group_idx = (uint8_t)tbl8_group_index,
-			.valid = VALID,
-			.valid_group = 1,
-			.depth = 0,
-		};
-
-		__atomic_store(&lpm->tbl24[tbl24_index], &new_tbl24_entry,
-				__ATOMIC_RELEASE);
-
-	} /* If valid entry but not extended calculate the index into Table8. */
-	else if (lpm->tbl24[tbl24_index].valid_group == 0) {
-		/* Search for free tbl8 group. */
-		tbl8_group_index = tbl8_alloc_v20(lpm->tbl8);
-
-		if (tbl8_group_index < 0) {
-			return tbl8_group_index;
-		}
-
-		tbl8_group_start = tbl8_group_index *
-				RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-		tbl8_group_end = tbl8_group_start +
-				RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-
-		/* Populate new tbl8 with tbl24 value. */
-		for (i = tbl8_group_start; i < tbl8_group_end; i++) {
-			struct rte_lpm_tbl_entry_v20 new_tbl8_entry = {
-				.valid = VALID,
-				.depth = lpm->tbl24[tbl24_index].depth,
-				.valid_group = lpm->tbl8[i].valid_group,
-			};
-			new_tbl8_entry.next_hop =
-				lpm->tbl24[tbl24_index].next_hop;
-			__atomic_store(&lpm->tbl8[i], &new_tbl8_entry,
-					__ATOMIC_RELAXED);
-		}
-
-		tbl8_index = tbl8_group_start + (ip_masked & 0xFF);
-
-		/* Insert new rule into the tbl8 entry. */
-		for (i = tbl8_index; i < tbl8_index + tbl8_range; i++) {
-			struct rte_lpm_tbl_entry_v20 new_tbl8_entry = {
-				.valid = VALID,
-				.depth = depth,
-				.valid_group = lpm->tbl8[i].valid_group,
-			};
-			new_tbl8_entry.next_hop = next_hop;
-			__atomic_store(&lpm->tbl8[i], &new_tbl8_entry,
-					__ATOMIC_RELAXED);
-		}
-
-		/*
-		 * Update tbl24 entry to point to new tbl8 entry. Note: The
-		 * ext_flag and tbl8_index need to be updated simultaneously,
-		 * so assign whole structure in one go.
-		 */
-
-		struct rte_lpm_tbl_entry_v20 new_tbl24_entry = {
-				.group_idx = (uint8_t)tbl8_group_index,
-				.valid = VALID,
-				.valid_group = 1,
-				.depth = 0,
-		};
-
-		__atomic_store(&lpm->tbl24[tbl24_index], &new_tbl24_entry,
-				__ATOMIC_RELEASE);
-
-	} else { /*
-		* If it is valid, extended entry calculate the index into tbl8.
-		*/
-		tbl8_group_index = lpm->tbl24[tbl24_index].group_idx;
-		tbl8_group_start = tbl8_group_index *
-				RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-		tbl8_index = tbl8_group_start + (ip_masked & 0xFF);
-
-		for (i = tbl8_index; i < (tbl8_index + tbl8_range); i++) {
-
-			if (!lpm->tbl8[i].valid ||
-					lpm->tbl8[i].depth <= depth) {
-				struct rte_lpm_tbl_entry_v20 new_tbl8_entry = {
-					.valid = VALID,
-					.depth = depth,
-					.valid_group = lpm->tbl8[i].valid_group,
-				};
-				new_tbl8_entry.next_hop = next_hop;
-				/*
-				 * Setting tbl8 entry in one go to avoid race
-				 * condition
-				 */
-				__atomic_store(&lpm->tbl8[i], &new_tbl8_entry,
-						__ATOMIC_RELAXED);
-
-				continue;
-			}
-		}
-	}
-
-	return 0;
-}
-
-static __rte_noinline int32_t
-add_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
+add_depth_big(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
 		uint32_t next_hop)
 {
 #define group_idx next_hop
@@ -1038,7 +520,7 @@ add_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
 
 	if (!lpm->tbl24[tbl24_index].valid) {
 		/* Search for a free tbl8 group. */
-		tbl8_group_index = tbl8_alloc_v1604(lpm->tbl8, lpm->number_tbl8s);
+		tbl8_group_index = tbl8_alloc(lpm->tbl8, lpm->number_tbl8s);
 
 		/* Check tbl8 allocation was successful. */
 		if (tbl8_group_index < 0) {
@@ -1084,7 +566,7 @@ add_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
 	} /* If valid entry but not extended calculate the index into Table8. */
 	else if (lpm->tbl24[tbl24_index].valid_group == 0) {
 		/* Search for free tbl8 group. */
-		tbl8_group_index = tbl8_alloc_v1604(lpm->tbl8, lpm->number_tbl8s);
+		tbl8_group_index = tbl8_alloc(lpm->tbl8, lpm->number_tbl8s);
 
 		if (tbl8_group_index < 0) {
 			return tbl8_group_index;
@@ -1177,49 +659,8 @@ add_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
 /*
  * Add a route
  */
-int __vsym
-rte_lpm_add_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth,
-		uint8_t next_hop)
-{
-	int32_t rule_index, status = 0;
-	uint32_t ip_masked;
-
-	/* Check user arguments. */
-	if ((lpm == NULL) || (depth < 1) || (depth > RTE_LPM_MAX_DEPTH))
-		return -EINVAL;
-
-	ip_masked = ip & depth_to_mask(depth);
-
-	/* Add the rule to the rule table. */
-	rule_index = rule_add_v20(lpm, ip_masked, depth, next_hop);
-
-	/* If the is no space available for new rule return error. */
-	if (rule_index < 0) {
-		return rule_index;
-	}
-
-	if (depth <= MAX_DEPTH_TBL24) {
-		status = add_depth_small_v20(lpm, ip_masked, depth, next_hop);
-	} else { /* If depth > RTE_LPM_MAX_DEPTH_TBL24 */
-		status = add_depth_big_v20(lpm, ip_masked, depth, next_hop);
-
-		/*
-		 * If add fails due to exhaustion of tbl8 extensions delete
-		 * rule that was added to rule table.
-		 */
-		if (status < 0) {
-			rule_delete_v20(lpm, rule_index, depth);
-
-			return status;
-		}
-	}
-
-	return 0;
-}
-VERSION_SYMBOL(rte_lpm_add, _v20, 2.0);
-
-int __vsym
-rte_lpm_add_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
+int
+rte_lpm_add(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
 		uint32_t next_hop)
 {
 	int32_t rule_index, status = 0;
@@ -1232,7 +673,7 @@ rte_lpm_add_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
 	ip_masked = ip & depth_to_mask(depth);
 
 	/* Add the rule to the rule table. */
-	rule_index = rule_add_v1604(lpm, ip_masked, depth, next_hop);
+	rule_index = rule_add(lpm, ip_masked, depth, next_hop);
 
 	/* If the is no space available for new rule return error. */
 	if (rule_index < 0) {
@@ -1240,16 +681,16 @@ rte_lpm_add_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
 	}
 
 	if (depth <= MAX_DEPTH_TBL24) {
-		status = add_depth_small_v1604(lpm, ip_masked, depth, next_hop);
+		status = add_depth_small(lpm, ip_masked, depth, next_hop);
 	} else { /* If depth > RTE_LPM_MAX_DEPTH_TBL24 */
-		status = add_depth_big_v1604(lpm, ip_masked, depth, next_hop);
+		status = add_depth_big(lpm, ip_masked, depth, next_hop);
 
 		/*
 		 * If add fails due to exhaustion of tbl8 extensions delete
 		 * rule that was added to rule table.
 		 */
 		if (status < 0) {
-			rule_delete_v1604(lpm, rule_index, depth);
+			rule_delete(lpm, rule_index, depth);
 
 			return status;
 		}
@@ -1257,42 +698,12 @@ rte_lpm_add_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
 
 	return 0;
 }
-BIND_DEFAULT_SYMBOL(rte_lpm_add, _v1604, 16.04);
-MAP_STATIC_SYMBOL(int rte_lpm_add(struct rte_lpm *lpm, uint32_t ip,
-		uint8_t depth, uint32_t next_hop), rte_lpm_add_v1604);
 
 /*
  * Look for a rule in the high-level rules table
  */
-int __vsym
-rte_lpm_is_rule_present_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth,
-uint8_t *next_hop)
-{
-	uint32_t ip_masked;
-	int32_t rule_index;
-
-	/* Check user arguments. */
-	if ((lpm == NULL) ||
-		(next_hop == NULL) ||
-		(depth < 1) || (depth > RTE_LPM_MAX_DEPTH))
-		return -EINVAL;
-
-	/* Look for the rule using rule_find. */
-	ip_masked = ip & depth_to_mask(depth);
-	rule_index = rule_find_v20(lpm, ip_masked, depth);
-
-	if (rule_index >= 0) {
-		*next_hop = lpm->rules_tbl[rule_index].next_hop;
-		return 1;
-	}
-
-	/* If rule is not found return 0. */
-	return 0;
-}
-VERSION_SYMBOL(rte_lpm_is_rule_present, _v20, 2.0);
-
-int __vsym
-rte_lpm_is_rule_present_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
+int
+rte_lpm_is_rule_present(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
 uint32_t *next_hop)
 {
 	uint32_t ip_masked;
@@ -1306,7 +717,7 @@ uint32_t *next_hop)
 
 	/* Look for the rule using rule_find. */
 	ip_masked = ip & depth_to_mask(depth);
-	rule_index = rule_find_v1604(lpm, ip_masked, depth);
+	rule_index = rule_find(lpm, ip_masked, depth);
 
 	if (rule_index >= 0) {
 		*next_hop = lpm->rules_tbl[rule_index].next_hop;
@@ -1316,12 +727,9 @@ uint32_t *next_hop)
 	/* If rule is not found return 0. */
 	return 0;
 }
-BIND_DEFAULT_SYMBOL(rte_lpm_is_rule_present, _v1604, 16.04);
-MAP_STATIC_SYMBOL(int rte_lpm_is_rule_present(struct rte_lpm *lpm, uint32_t ip,
-		uint8_t depth, uint32_t *next_hop), rte_lpm_is_rule_present_v1604);
 
 static int32_t
-find_previous_rule_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth,
+find_previous_rule(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
 		uint8_t *sub_rule_depth)
 {
 	int32_t rule_index;
@@ -1331,7 +739,7 @@ find_previous_rule_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth,
 	for (prev_depth = (uint8_t)(depth - 1); prev_depth > 0; prev_depth--) {
 		ip_masked = ip & depth_to_mask(prev_depth);
 
-		rule_index = rule_find_v20(lpm, ip_masked, prev_depth);
+		rule_index = rule_find(lpm, ip_masked, prev_depth);
 
 		if (rule_index >= 0) {
 			*sub_rule_depth = prev_depth;
@@ -1343,133 +751,7 @@ find_previous_rule_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth,
 }
 
 static int32_t
-find_previous_rule_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
-		uint8_t *sub_rule_depth)
-{
-	int32_t rule_index;
-	uint32_t ip_masked;
-	uint8_t prev_depth;
-
-	for (prev_depth = (uint8_t)(depth - 1); prev_depth > 0; prev_depth--) {
-		ip_masked = ip & depth_to_mask(prev_depth);
-
-		rule_index = rule_find_v1604(lpm, ip_masked, prev_depth);
-
-		if (rule_index >= 0) {
-			*sub_rule_depth = prev_depth;
-			return rule_index;
-		}
-	}
-
-	return -1;
-}
-
-static int32_t
-delete_depth_small_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked,
-	uint8_t depth, int32_t sub_rule_index, uint8_t sub_rule_depth)
-{
-	uint32_t tbl24_range, tbl24_index, tbl8_group_index, tbl8_index, i, j;
-
-	/* Calculate the range and index into Table24. */
-	tbl24_range = depth_to_range(depth);
-	tbl24_index = (ip_masked >> 8);
-
-	/*
-	 * Firstly check the sub_rule_index. A -1 indicates no replacement rule
-	 * and a positive number indicates a sub_rule_index.
-	 */
-	if (sub_rule_index < 0) {
-		/*
-		 * If no replacement rule exists then invalidate entries
-		 * associated with this rule.
-		 */
-		for (i = tbl24_index; i < (tbl24_index + tbl24_range); i++) {
-
-			if (lpm->tbl24[i].valid_group == 0 &&
-					lpm->tbl24[i].depth <= depth) {
-				struct rte_lpm_tbl_entry_v20
-					zero_tbl24_entry = {
-						.valid = INVALID,
-						.depth = 0,
-						.valid_group = 0,
-					};
-					zero_tbl24_entry.next_hop = 0;
-				__atomic_store(&lpm->tbl24[i],
-					&zero_tbl24_entry, __ATOMIC_RELEASE);
-			} else if (lpm->tbl24[i].valid_group == 1) {
-				/*
-				 * If TBL24 entry is extended, then there has
-				 * to be a rule with depth >= 25 in the
-				 * associated TBL8 group.
-				 */
-
-				tbl8_group_index = lpm->tbl24[i].group_idx;
-				tbl8_index = tbl8_group_index *
-						RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-
-				for (j = tbl8_index; j < (tbl8_index +
-					RTE_LPM_TBL8_GROUP_NUM_ENTRIES); j++) {
-
-					if (lpm->tbl8[j].depth <= depth)
-						lpm->tbl8[j].valid = INVALID;
-				}
-			}
-		}
-	} else {
-		/*
-		 * If a replacement rule exists then modify entries
-		 * associated with this rule.
-		 */
-
-		struct rte_lpm_tbl_entry_v20 new_tbl24_entry = {
-			.next_hop = lpm->rules_tbl[sub_rule_index].next_hop,
-			.valid = VALID,
-			.valid_group = 0,
-			.depth = sub_rule_depth,
-		};
-
-		struct rte_lpm_tbl_entry_v20 new_tbl8_entry = {
-			.valid = VALID,
-			.valid_group = VALID,
-			.depth = sub_rule_depth,
-		};
-		new_tbl8_entry.next_hop =
-				lpm->rules_tbl[sub_rule_index].next_hop;
-
-		for (i = tbl24_index; i < (tbl24_index + tbl24_range); i++) {
-
-			if (lpm->tbl24[i].valid_group == 0 &&
-					lpm->tbl24[i].depth <= depth) {
-				__atomic_store(&lpm->tbl24[i], &new_tbl24_entry,
-						__ATOMIC_RELEASE);
-			} else  if (lpm->tbl24[i].valid_group == 1) {
-				/*
-				 * If TBL24 entry is extended, then there has
-				 * to be a rule with depth >= 25 in the
-				 * associated TBL8 group.
-				 */
-
-				tbl8_group_index = lpm->tbl24[i].group_idx;
-				tbl8_index = tbl8_group_index *
-						RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-
-				for (j = tbl8_index; j < (tbl8_index +
-					RTE_LPM_TBL8_GROUP_NUM_ENTRIES); j++) {
-
-					if (lpm->tbl8[j].depth <= depth)
-						__atomic_store(&lpm->tbl8[j],
-							&new_tbl8_entry,
-							__ATOMIC_RELAXED);
-				}
-			}
-		}
-	}
-
-	return 0;
-}
-
-static int32_t
-delete_depth_small_v1604(struct rte_lpm *lpm, uint32_t ip_masked,
+delete_depth_small(struct rte_lpm *lpm, uint32_t ip_masked,
 	uint8_t depth, int32_t sub_rule_index, uint8_t sub_rule_depth)
 {
 #define group_idx next_hop
@@ -1576,7 +858,7 @@ delete_depth_small_v1604(struct rte_lpm *lpm, uint32_t ip_masked,
  * thus can be recycled
  */
 static int32_t
-tbl8_recycle_check_v20(struct rte_lpm_tbl_entry_v20 *tbl8,
+tbl8_recycle_check(struct rte_lpm_tbl_entry *tbl8,
 		uint32_t tbl8_group_start)
 {
 	uint32_t tbl8_group_end, i;
@@ -1623,140 +905,7 @@ tbl8_recycle_check_v20(struct rte_lpm_tbl_entry_v20 *tbl8,
 }
 
 static int32_t
-tbl8_recycle_check_v1604(struct rte_lpm_tbl_entry *tbl8,
-		uint32_t tbl8_group_start)
-{
-	uint32_t tbl8_group_end, i;
-	tbl8_group_end = tbl8_group_start + RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-
-	/*
-	 * Check the first entry of the given tbl8. If it is invalid we know
-	 * this tbl8 does not contain any rule with a depth < RTE_LPM_MAX_DEPTH
-	 *  (As they would affect all entries in a tbl8) and thus this table
-	 *  can not be recycled.
-	 */
-	if (tbl8[tbl8_group_start].valid) {
-		/*
-		 * If first entry is valid check if the depth is less than 24
-		 * and if so check the rest of the entries to verify that they
-		 * are all of this depth.
-		 */
-		if (tbl8[tbl8_group_start].depth <= MAX_DEPTH_TBL24) {
-			for (i = (tbl8_group_start + 1); i < tbl8_group_end;
-					i++) {
-
-				if (tbl8[i].depth !=
-						tbl8[tbl8_group_start].depth) {
-
-					return -EEXIST;
-				}
-			}
-			/* If all entries are the same return the tb8 index */
-			return tbl8_group_start;
-		}
-
-		return -EEXIST;
-	}
-	/*
-	 * If the first entry is invalid check if the rest of the entries in
-	 * the tbl8 are invalid.
-	 */
-	for (i = (tbl8_group_start + 1); i < tbl8_group_end; i++) {
-		if (tbl8[i].valid)
-			return -EEXIST;
-	}
-	/* If no valid entries are found then return -EINVAL. */
-	return -EINVAL;
-}
-
-static int32_t
-delete_depth_big_v20(struct rte_lpm_v20 *lpm, uint32_t ip_masked,
-	uint8_t depth, int32_t sub_rule_index, uint8_t sub_rule_depth)
-{
-	uint32_t tbl24_index, tbl8_group_index, tbl8_group_start, tbl8_index,
-			tbl8_range, i;
-	int32_t tbl8_recycle_index;
-
-	/*
-	 * Calculate the index into tbl24 and range. Note: All depths larger
-	 * than MAX_DEPTH_TBL24 are associated with only one tbl24 entry.
-	 */
-	tbl24_index = ip_masked >> 8;
-
-	/* Calculate the index into tbl8 and range. */
-	tbl8_group_index = lpm->tbl24[tbl24_index].group_idx;
-	tbl8_group_start = tbl8_group_index * RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-	tbl8_index = tbl8_group_start + (ip_masked & 0xFF);
-	tbl8_range = depth_to_range(depth);
-
-	if (sub_rule_index < 0) {
-		/*
-		 * Loop through the range of entries on tbl8 for which the
-		 * rule_to_delete must be removed or modified.
-		 */
-		for (i = tbl8_index; i < (tbl8_index + tbl8_range); i++) {
-			if (lpm->tbl8[i].depth <= depth)
-				lpm->tbl8[i].valid = INVALID;
-		}
-	} else {
-		/* Set new tbl8 entry. */
-		struct rte_lpm_tbl_entry_v20 new_tbl8_entry = {
-			.valid = VALID,
-			.depth = sub_rule_depth,
-			.valid_group = lpm->tbl8[tbl8_group_start].valid_group,
-		};
-
-		new_tbl8_entry.next_hop =
-				lpm->rules_tbl[sub_rule_index].next_hop;
-		/*
-		 * Loop through the range of entries on tbl8 for which the
-		 * rule_to_delete must be modified.
-		 */
-		for (i = tbl8_index; i < (tbl8_index + tbl8_range); i++) {
-			if (lpm->tbl8[i].depth <= depth)
-				__atomic_store(&lpm->tbl8[i], &new_tbl8_entry,
-						__ATOMIC_RELAXED);
-		}
-	}
-
-	/*
-	 * Check if there are any valid entries in this tbl8 group. If all
-	 * tbl8 entries are invalid we can free the tbl8 and invalidate the
-	 * associated tbl24 entry.
-	 */
-
-	tbl8_recycle_index = tbl8_recycle_check_v20(lpm->tbl8, tbl8_group_start);
-
-	if (tbl8_recycle_index == -EINVAL) {
-		/* Set tbl24 before freeing tbl8 to avoid race condition.
-		 * Prevent the free of the tbl8 group from hoisting.
-		 */
-		lpm->tbl24[tbl24_index].valid = 0;
-		__atomic_thread_fence(__ATOMIC_RELEASE);
-		tbl8_free_v20(lpm->tbl8, tbl8_group_start);
-	} else if (tbl8_recycle_index > -1) {
-		/* Update tbl24 entry. */
-		struct rte_lpm_tbl_entry_v20 new_tbl24_entry = {
-			.next_hop = lpm->tbl8[tbl8_recycle_index].next_hop,
-			.valid = VALID,
-			.valid_group = 0,
-			.depth = lpm->tbl8[tbl8_recycle_index].depth,
-		};
-
-		/* Set tbl24 before freeing tbl8 to avoid race condition.
-		 * Prevent the free of the tbl8 group from hoisting.
-		 */
-		__atomic_store(&lpm->tbl24[tbl24_index], &new_tbl24_entry,
-				__ATOMIC_RELAXED);
-		__atomic_thread_fence(__ATOMIC_RELEASE);
-		tbl8_free_v20(lpm->tbl8, tbl8_group_start);
-	}
-
-	return 0;
-}
-
-static int32_t
-delete_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked,
+delete_depth_big(struct rte_lpm *lpm, uint32_t ip_masked,
 	uint8_t depth, int32_t sub_rule_index, uint8_t sub_rule_depth)
 {
 #define group_idx next_hop
@@ -1811,7 +960,7 @@ delete_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked,
 	 * associated tbl24 entry.
 	 */
 
-	tbl8_recycle_index = tbl8_recycle_check_v1604(lpm->tbl8, tbl8_group_start);
+	tbl8_recycle_index = tbl8_recycle_check(lpm->tbl8, tbl8_group_start);
 
 	if (tbl8_recycle_index == -EINVAL) {
 		/* Set tbl24 before freeing tbl8 to avoid race condition.
@@ -1819,7 +968,7 @@ delete_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked,
 		 */
 		lpm->tbl24[tbl24_index].valid = 0;
 		__atomic_thread_fence(__ATOMIC_RELEASE);
-		tbl8_free_v1604(lpm->tbl8, tbl8_group_start);
+		tbl8_free(lpm->tbl8, tbl8_group_start);
 	} else if (tbl8_recycle_index > -1) {
 		/* Update tbl24 entry. */
 		struct rte_lpm_tbl_entry new_tbl24_entry = {
@@ -1835,7 +984,7 @@ delete_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked,
 		__atomic_store(&lpm->tbl24[tbl24_index], &new_tbl24_entry,
 				__ATOMIC_RELAXED);
 		__atomic_thread_fence(__ATOMIC_RELEASE);
-		tbl8_free_v1604(lpm->tbl8, tbl8_group_start);
+		tbl8_free(lpm->tbl8, tbl8_group_start);
 	}
 #undef group_idx
 	return 0;
@@ -1844,8 +993,8 @@ delete_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked,
 /*
  * Deletes a rule
  */
-int __vsym
-rte_lpm_delete_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth)
+int
+rte_lpm_delete(struct rte_lpm *lpm, uint32_t ip, uint8_t depth)
 {
 	int32_t rule_to_delete_index, sub_rule_index;
 	uint32_t ip_masked;
@@ -1864,7 +1013,7 @@ rte_lpm_delete_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth)
 	 * Find the index of the input rule, that needs to be deleted, in the
 	 * rule table.
 	 */
-	rule_to_delete_index = rule_find_v20(lpm, ip_masked, depth);
+	rule_to_delete_index = rule_find(lpm, ip_masked, depth);
 
 	/*
 	 * Check if rule_to_delete_index was found. If no rule was found the
@@ -1874,7 +1023,7 @@ rte_lpm_delete_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth)
 		return -EINVAL;
 
 	/* Delete the rule from the rule table. */
-	rule_delete_v20(lpm, rule_to_delete_index, depth);
+	rule_delete(lpm, rule_to_delete_index, depth);
 
 	/*
 	 * Find rule to replace the rule_to_delete. If there is no rule to
@@ -1882,100 +1031,26 @@ rte_lpm_delete_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth)
 	 * entries associated with this rule.
 	 */
 	sub_rule_depth = 0;
-	sub_rule_index = find_previous_rule_v20(lpm, ip, depth, &sub_rule_depth);
+	sub_rule_index = find_previous_rule(lpm, ip, depth, &sub_rule_depth);
 
 	/*
 	 * If the input depth value is less than 25 use function
 	 * delete_depth_small otherwise use delete_depth_big.
 	 */
 	if (depth <= MAX_DEPTH_TBL24) {
-		return delete_depth_small_v20(lpm, ip_masked, depth,
+		return delete_depth_small(lpm, ip_masked, depth,
 				sub_rule_index, sub_rule_depth);
 	} else { /* If depth > MAX_DEPTH_TBL24 */
-		return delete_depth_big_v20(lpm, ip_masked, depth, sub_rule_index,
+		return delete_depth_big(lpm, ip_masked, depth, sub_rule_index,
 				sub_rule_depth);
 	}
 }
-VERSION_SYMBOL(rte_lpm_delete, _v20, 2.0);
-
-int __vsym
-rte_lpm_delete_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth)
-{
-	int32_t rule_to_delete_index, sub_rule_index;
-	uint32_t ip_masked;
-	uint8_t sub_rule_depth;
-	/*
-	 * Check input arguments. Note: IP must be a positive integer of 32
-	 * bits in length therefore it need not be checked.
-	 */
-	if ((lpm == NULL) || (depth < 1) || (depth > RTE_LPM_MAX_DEPTH)) {
-		return -EINVAL;
-	}
-
-	ip_masked = ip & depth_to_mask(depth);
-
-	/*
-	 * Find the index of the input rule, that needs to be deleted, in the
-	 * rule table.
-	 */
-	rule_to_delete_index = rule_find_v1604(lpm, ip_masked, depth);
-
-	/*
-	 * Check if rule_to_delete_index was found. If no rule was found the
-	 * function rule_find returns -EINVAL.
-	 */
-	if (rule_to_delete_index < 0)
-		return -EINVAL;
-
-	/* Delete the rule from the rule table. */
-	rule_delete_v1604(lpm, rule_to_delete_index, depth);
-
-	/*
-	 * Find rule to replace the rule_to_delete. If there is no rule to
-	 * replace the rule_to_delete we return -1 and invalidate the table
-	 * entries associated with this rule.
-	 */
-	sub_rule_depth = 0;
-	sub_rule_index = find_previous_rule_v1604(lpm, ip, depth, &sub_rule_depth);
-
-	/*
-	 * If the input depth value is less than 25 use function
-	 * delete_depth_small otherwise use delete_depth_big.
-	 */
-	if (depth <= MAX_DEPTH_TBL24) {
-		return delete_depth_small_v1604(lpm, ip_masked, depth,
-				sub_rule_index, sub_rule_depth);
-	} else { /* If depth > MAX_DEPTH_TBL24 */
-		return delete_depth_big_v1604(lpm, ip_masked, depth, sub_rule_index,
-				sub_rule_depth);
-	}
-}
-BIND_DEFAULT_SYMBOL(rte_lpm_delete, _v1604, 16.04);
-MAP_STATIC_SYMBOL(int rte_lpm_delete(struct rte_lpm *lpm, uint32_t ip,
-		uint8_t depth), rte_lpm_delete_v1604);
 
 /*
  * Delete all rules from the LPM table.
  */
-void __vsym
-rte_lpm_delete_all_v20(struct rte_lpm_v20 *lpm)
-{
-	/* Zero rule information. */
-	memset(lpm->rule_info, 0, sizeof(lpm->rule_info));
-
-	/* Zero tbl24. */
-	memset(lpm->tbl24, 0, sizeof(lpm->tbl24));
-
-	/* Zero tbl8. */
-	memset(lpm->tbl8, 0, sizeof(lpm->tbl8));
-
-	/* Delete all rules form the rules table. */
-	memset(lpm->rules_tbl, 0, sizeof(lpm->rules_tbl[0]) * lpm->max_rules);
-}
-VERSION_SYMBOL(rte_lpm_delete_all, _v20, 2.0);
-
-void __vsym
-rte_lpm_delete_all_v1604(struct rte_lpm *lpm)
+void
+rte_lpm_delete_all(struct rte_lpm *lpm)
 {
 	/* Zero rule information. */
 	memset(lpm->rule_info, 0, sizeof(lpm->rule_info));
@@ -1990,6 +1065,3 @@ rte_lpm_delete_all_v1604(struct rte_lpm *lpm)
 	/* Delete all rules form the rules table. */
 	memset(lpm->rules_tbl, 0, sizeof(lpm->rules_tbl[0]) * lpm->max_rules);
 }
-BIND_DEFAULT_SYMBOL(rte_lpm_delete_all, _v1604, 16.04);
-MAP_STATIC_SYMBOL(void rte_lpm_delete_all(struct rte_lpm *lpm),
-		rte_lpm_delete_all_v1604);
lib/librte_lpm/rte_lpm.h +0 -88

154 lines not on this page · raw message

lib/librte_lpm/rte_lpm6.c +18 -122

213 lines not on this page · raw message

lib/librte_lpm/rte_lpm6.h +0 -25
index 5d59ccb1fe..37dfb20249 100644
@@ -96,12 +96,6 @@ rte_lpm6_free(struct rte_lpm6 *lpm);
 int
 rte_lpm6_add(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth,
 		uint32_t next_hop);
-int
-rte_lpm6_add_v20(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth,
-		uint8_t next_hop);
-int
-rte_lpm6_add_v1705(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth,
-		uint32_t next_hop);
 
 /**
  * Check if a rule is present in the LPM table,
@@ -121,12 +115,6 @@ rte_lpm6_add_v1705(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth,
 int
 rte_lpm6_is_rule_present(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth,
 		uint32_t *next_hop);
-int
-rte_lpm6_is_rule_present_v20(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth,
-		uint8_t *next_hop);
-int
-rte_lpm6_is_rule_present_v1705(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth,
-		uint32_t *next_hop);
 
 /**
  * Delete a rule from the LPM table.
@@ -184,11 +172,6 @@ rte_lpm6_delete_all(struct rte_lpm6 *lpm);
  */
 int
 rte_lpm6_lookup(const struct rte_lpm6 *lpm, uint8_t *ip, uint32_t *next_hop);
-int
-rte_lpm6_lookup_v20(const struct rte_lpm6 *lpm, uint8_t *ip, uint8_t *next_hop);
-int
-rte_lpm6_lookup_v1705(const struct rte_lpm6 *lpm, uint8_t *ip,
-		uint32_t *next_hop);
 
 /**
  * Lookup multiple IP addresses in an LPM table.
@@ -210,14 +193,6 @@ int
 rte_lpm6_lookup_bulk_func(const struct rte_lpm6 *lpm,
 		uint8_t ips[][RTE_LPM6_IPV6_ADDR_SIZE],
 		int32_t *next_hops, unsigned int n);
-int
-rte_lpm6_lookup_bulk_func_v20(const struct rte_lpm6 *lpm,
-		uint8_t ips[][RTE_LPM6_IPV6_ADDR_SIZE],
-		int16_t *next_hops, unsigned int n);
-int
-rte_lpm6_lookup_bulk_func_v1705(const struct rte_lpm6 *lpm,
-		uint8_t ips[][RTE_LPM6_IPV6_ADDR_SIZE],
-		int32_t *next_hops, unsigned int n);
 
 #ifdef __cplusplus
 }
Signature · 1 line
2.17.1
#98 lore raw

Re: [dpdk-dev] [PATCH v7 05/10] lpm: remove deprecated code

Quoted 5 lines · Anatoly Burakov

From: Marcin Baran <[email protected]>

Remove code for old ABI versions ahead of ABI version bump.

Quoted 8 lines

---

Notes:
v2:
- Moved this to before ABI version bump to avoid compile breakage

Idem, those symbols must be removed from the lib .map.

lib/librte_lpm/rte_lpm_version.map +0 -11
@@ -1,23 +1,12 @@
 DPDK_2.0 {
        global:
 
-       rte_lpm_add;
-       rte_lpm_create;
-       rte_lpm_delete;
-       rte_lpm_delete_all;
-       rte_lpm_find_existing;
-       rte_lpm_free;
-       rte_lpm_is_rule_present;
-       rte_lpm6_add;
        rte_lpm6_create;
        rte_lpm6_delete;
        rte_lpm6_delete_all;
        rte_lpm6_delete_bulk_func;
        rte_lpm6_find_existing;
        rte_lpm6_free;
-       rte_lpm6_is_rule_present;
-       rte_lpm6_lookup;
-       rte_lpm6_lookup_bulk_func;
 
        local: *;
 };

--
David Marchand

#99 lore raw

PATCH v7 6/10 distributor: remove deprecated code

In reply to Anatoly Burakov

From: Marcin Baran <[email protected]>

Remove code for old ABI versions ahead of ABI version bump.

---

Notes:
v5:
- Fixed shared library linking error due to versioning still enabled

v2:
- Moved this to before ABI version bump to avoid compile breakage

v2:
- Moved this to before ABI version bump to avoid compile breakage

 lib/librte_distributor/rte_distributor.c      | 74 +++++--------------
 .../rte_distributor_v1705.h                   | 61 ---------------
 lib/librte_distributor/rte_distributor_v20.c  |  9 ---
 3 files changed, 18 insertions(+), 126 deletions(-)
 delete mode 100644 lib/librte_distributor/rte_distributor_v1705.h
lib/librte_distributor/rte_distributor.c +18 -56
index 2cc32ddba2..a4c8ff6a96 100644
@@ -18,7 +18,6 @@
 
 #include "rte_distributor.h"
 #include "rte_distributor_v20.h"
-#include "rte_distributor_v1705.h"
 #include "distributor_private.h"
 
 TAILQ_HEAD(rte_dist_burst_list, rte_distributor);
@@ -32,8 +31,8 @@ EAL_REGISTER_TAILQ(rte_dist_burst_tailq)
 
 /**** Burst Packet APIs called by workers ****/
 
-void __vsym
-rte_distributor_request_pkt_v1705(struct rte_distributor *d,
+void
+rte_distributor_request_pkt(struct rte_distributor *d,
 		unsigned int worker_id, struct rte_mbuf **oldpkt,
 		unsigned int count)
 {
@@ -83,14 +82,9 @@ rte_distributor_request_pkt_v1705(struct rte_distributor *d,
 	__atomic_store_n(retptr64, *retptr64 | RTE_DISTRIB_GET_BUF,
 			__ATOMIC_RELEASE);
 }
-BIND_DEFAULT_SYMBOL(rte_distributor_request_pkt, _v1705, 17.05);
-MAP_STATIC_SYMBOL(void rte_distributor_request_pkt(struct rte_distributor *d,
-		unsigned int worker_id, struct rte_mbuf **oldpkt,
-		unsigned int count),
-		rte_distributor_request_pkt_v1705);
 
-int __vsym
-rte_distributor_poll_pkt_v1705(struct rte_distributor *d,
+int
+rte_distributor_poll_pkt(struct rte_distributor *d,
 		unsigned int worker_id, struct rte_mbuf **pkts)
 {
 	struct rte_distributor_buffer *buf = &d->bufs[worker_id];
@@ -129,13 +123,9 @@ rte_distributor_poll_pkt_v1705(struct rte_distributor *d,
 
 	return count;
 }
-BIND_DEFAULT_SYMBOL(rte_distributor_poll_pkt, _v1705, 17.05);
-MAP_STATIC_SYMBOL(int rte_distributor_poll_pkt(struct rte_distributor *d,
-		unsigned int worker_id, struct rte_mbuf **pkts),
-		rte_distributor_poll_pkt_v1705);
 
-int __vsym
-rte_distributor_get_pkt_v1705(struct rte_distributor *d,
+int
+rte_distributor_get_pkt(struct rte_distributor *d,
 		unsigned int worker_id, struct rte_mbuf **pkts,
 		struct rte_mbuf **oldpkt, unsigned int return_count)
 {
@@ -163,14 +153,9 @@ rte_distributor_get_pkt_v1705(struct rte_distributor *d,
 	}
 	return count;
 }
-BIND_DEFAULT_SYMBOL(rte_distributor_get_pkt, _v1705, 17.05);
-MAP_STATIC_SYMBOL(int rte_distributor_get_pkt(struct rte_distributor *d,
-		unsigned int worker_id, struct rte_mbuf **pkts,
-		struct rte_mbuf **oldpkt, unsigned int return_count),
-		rte_distributor_get_pkt_v1705);
 
-int __vsym
-rte_distributor_return_pkt_v1705(struct rte_distributor *d,
+int
+rte_distributor_return_pkt(struct rte_distributor *d,
 		unsigned int worker_id, struct rte_mbuf **oldpkt, int num)
 {
 	struct rte_distributor_buffer *buf = &d->bufs[worker_id];
@@ -202,10 +187,6 @@ rte_distributor_return_pkt_v1705(struct rte_distributor *d,
 
 	return 0;
 }
-BIND_DEFAULT_SYMBOL(rte_distributor_return_pkt, _v1705, 17.05);
-MAP_STATIC_SYMBOL(int rte_distributor_return_pkt(struct rte_distributor *d,
-		unsigned int worker_id, struct rte_mbuf **oldpkt, int num),
-		rte_distributor_return_pkt_v1705);
 
 /**** APIs called on distributor core ***/
 
@@ -359,8 +340,8 @@ release(struct rte_distributor *d, unsigned int wkr)
 
 
 /* process a set of packets to distribute them to workers */
-int __vsym
-rte_distributor_process_v1705(struct rte_distributor *d,
+int
+rte_distributor_process(struct rte_distributor *d,
 		struct rte_mbuf **mbufs, unsigned int num_mbufs)
 {
 	unsigned int next_idx = 0;
@@ -500,14 +481,10 @@ rte_distributor_process_v1705(struct rte_distributor *d,
 
 	return num_mbufs;
 }
-BIND_DEFAULT_SYMBOL(rte_distributor_process, _v1705, 17.05);
-MAP_STATIC_SYMBOL(int rte_distributor_process(struct rte_distributor *d,
-		struct rte_mbuf **mbufs, unsigned int num_mbufs),
-		rte_distributor_process_v1705);
 
 /* return to the caller, packets returned from workers */
-int __vsym
-rte_distributor_returned_pkts_v1705(struct rte_distributor *d,
+int
+rte_distributor_returned_pkts(struct rte_distributor *d,
 		struct rte_mbuf **mbufs, unsigned int max_mbufs)
 {
 	struct rte_distributor_returned_pkts *returns = &d->returns;
@@ -532,10 +509,6 @@ rte_distributor_returned_pkts_v1705(struct rte_distributor *d,
 
 	return retval;
 }
-BIND_DEFAULT_SYMBOL(rte_distributor_returned_pkts, _v1705, 17.05);
-MAP_STATIC_SYMBOL(int rte_distributor_returned_pkts(struct rte_distributor *d,
-		struct rte_mbuf **mbufs, unsigned int max_mbufs),
-		rte_distributor_returned_pkts_v1705);
 
 /*
  * Return the number of packets in-flight in a distributor, i.e. packets
@@ -556,8 +529,8 @@ total_outstanding(const struct rte_distributor *d)
  * Flush the distributor, so that there are no outstanding packets in flight or
  * queued up.
  */
-int __vsym
-rte_distributor_flush_v1705(struct rte_distributor *d)
+int
+rte_distributor_flush(struct rte_distributor *d)
 {
 	unsigned int flushed;
 	unsigned int wkr;
@@ -586,13 +559,10 @@ rte_distributor_flush_v1705(struct rte_distributor *d)
 
 	return flushed;
 }
-BIND_DEFAULT_SYMBOL(rte_distributor_flush, _v1705, 17.05);
-MAP_STATIC_SYMBOL(int rte_distributor_flush(struct rte_distributor *d),
-		rte_distributor_flush_v1705);
 
 /* clears the internal returns array in the distributor */
-void __vsym
-rte_distributor_clear_returns_v1705(struct rte_distributor *d)
+void
+rte_distributor_clear_returns(struct rte_distributor *d)
 {
 	unsigned int wkr;
 
@@ -608,13 +578,10 @@ rte_distributor_clear_returns_v1705(struct rte_distributor *d)
 		__atomic_store_n(&(d->bufs[wkr].retptr64[0]), 0,
 				__ATOMIC_RELEASE);
 }
-BIND_DEFAULT_SYMBOL(rte_distributor_clear_returns, _v1705, 17.05);
-MAP_STATIC_SYMBOL(void rte_distributor_clear_returns(struct rte_distributor *d),
-		rte_distributor_clear_returns_v1705);
 
 /* creates a distributor instance */
-struct rte_distributor * __vsym
-rte_distributor_create_v1705(const char *name,
+struct rte_distributor *
+rte_distributor_create(const char *name,
 		unsigned int socket_id,
 		unsigned int num_workers,
 		unsigned int alg_type)
@@ -688,8 +655,3 @@ rte_distributor_create_v1705(const char *name,
 
 	return d;
 }
-BIND_DEFAULT_SYMBOL(rte_distributor_create, _v1705, 17.05);
-MAP_STATIC_SYMBOL(struct rte_distributor *rte_distributor_create(
-		const char *name, unsigned int socket_id,
-		unsigned int num_workers, unsigned int alg_type),
-		rte_distributor_create_v1705);
lib/librte_distributor/rte_distributor_v1705.h deleted +0 -61

61 lines not on this page · raw message

lib/librte_distributor/rte_distributor_v20.c +0 -9
index 7a6fddf556..655944bdb3 100644
@@ -41,7 +41,6 @@ rte_distributor_request_pkt_v20(struct rte_distributor_v20 *d,
 	/* Sync with distributor on GET_BUF flag. */
 	__atomic_store_n(&(buf->bufptr64), req, __ATOMIC_RELEASE);
 }
-VERSION_SYMBOL(rte_distributor_request_pkt, _v20, 2.0);
 
 struct rte_mbuf * __vsym
 rte_distributor_poll_pkt_v20(struct rte_distributor_v20 *d,
@@ -57,7 +56,6 @@ rte_distributor_poll_pkt_v20(struct rte_distributor_v20 *d,
 	int64_t ret = buf->bufptr64 >> RTE_DISTRIB_FLAG_BITS;
 	return (struct rte_mbuf *)((uintptr_t)ret);
 }
-VERSION_SYMBOL(rte_distributor_poll_pkt, _v20, 2.0);
 
 struct rte_mbuf * __vsym
 rte_distributor_get_pkt_v20(struct rte_distributor_v20 *d,
@@ -69,7 +67,6 @@ rte_distributor_get_pkt_v20(struct rte_distributor_v20 *d,
 		rte_pause();
 	return ret;
 }
-VERSION_SYMBOL(rte_distributor_get_pkt, _v20, 2.0);
 
 int __vsym
 rte_distributor_return_pkt_v20(struct rte_distributor_v20 *d,
@@ -82,7 +79,6 @@ rte_distributor_return_pkt_v20(struct rte_distributor_v20 *d,
 	__atomic_store_n(&(buf->bufptr64), req, __ATOMIC_RELEASE);
 	return 0;
 }
-VERSION_SYMBOL(rte_distributor_return_pkt, _v20, 2.0);
 
 /**** APIs called on distributor core ***/
 
@@ -318,7 +314,6 @@ rte_distributor_process_v20(struct rte_distributor_v20 *d,
 	d->returns.count = ret_count;
 	return num_mbufs;
 }
-VERSION_SYMBOL(rte_distributor_process, _v20, 2.0);
 
 /* return to the caller, packets returned from workers */
 int __vsym
@@ -339,7 +334,6 @@ rte_distributor_returned_pkts_v20(struct rte_distributor_v20 *d,
 
 	return retval;
 }
-VERSION_SYMBOL(rte_distributor_returned_pkts, _v20, 2.0);
 
 /* return the number of packets in-flight in a distributor, i.e. packets
  * being worked on or queued up in a backlog.
@@ -369,7 +363,6 @@ rte_distributor_flush_v20(struct rte_distributor_v20 *d)
 
 	return flushed;
 }
-VERSION_SYMBOL(rte_distributor_flush, _v20, 2.0);
 
 /* clears the internal returns array in the distributor */
 void __vsym
@@ -380,7 +373,6 @@ rte_distributor_clear_returns_v20(struct rte_distributor_v20 *d)
 	memset(d->returns.mbufs, 0, sizeof(d->returns.mbufs));
 #endif
 }
-VERSION_SYMBOL(rte_distributor_clear_returns, _v20, 2.0);
 
 /* creates a distributor instance */
 struct rte_distributor_v20 * __vsym
@@ -424,4 +416,3 @@ rte_distributor_create_v20(const char *name,
 
 	return d;
 }
-VERSION_SYMBOL(rte_distributor_create, _v20, 2.0);
Signature · 1 line
2.17.1
#100 lore raw

PATCH v7 7/10 distributor: rename v2.0 ABI to _single suffix

In reply to Anatoly Burakov

From: Marcin Baran <[email protected]>

The original ABI versioning was slightly misleading in that the DPDK 2.0 ABI was really a single mode for the distributor, and is used as such throughout the distributor code.

Fix this by renaming all _v20 API's to _single API's, and remove symbol versioning.

---

Notes:
v4:
- Changed it back to how it was with v2
- Removed remaining v2.0 symbols

v3:
- Removed single mode from distributor as per Dave's comments

v2:
- Moved this to before ABI version bump to avoid compile breakage

 lib/librte_distributor/Makefile               |  2 +-
 lib/librte_distributor/distributor_private.h  | 10 +--
 lib/librte_distributor/meson.build            |  2 +-
 lib/librte_distributor/rte_distributor.c      | 24 +++----
 ...ributor_v20.c => rte_distributor_single.c} | 64 +++++++++----------
 ...ributor_v20.h => rte_distributor_single.h} | 26 ++++----
 .../rte_distributor_version.map               | 18 +-----
 7 files changed, 66 insertions(+), 80 deletions(-)
 rename lib/librte_distributor/{rte_distributor_v20.c => rte_distributor_single.c} (87%)
 rename lib/librte_distributor/{rte_distributor_v20.h => rte_distributor_single.h} (89%)
lib/librte_distributor/Makefile +1 -1
index 0ef80dcff4..d9d0089166 100644
@@ -15,7 +15,7 @@ EXPORT_MAP := rte_distributor_version.map
 LIBABIVER := 1
 
 # all source are stored in SRCS-y
-SRCS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) := rte_distributor_v20.c
+SRCS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) := rte_distributor_single.c
 SRCS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) += rte_distributor.c
 ifeq ($(CONFIG_RTE_ARCH_X86),y)
 SRCS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) += rte_distributor_match_sse.c
lib/librte_distributor/distributor_private.h +5 -5
index c89371123e..489aef2acb 100644
@@ -55,7 +55,7 @@ extern "C" {
  * the next cache line to worker 0, we pad this out to three cache lines.
  * Only 64-bits of the memory is actually used though.
  */
-union rte_distributor_buffer_v20 {
+union rte_distributor_buffer_single {
 	volatile int64_t bufptr64;
 	char pad[RTE_CACHE_LINE_SIZE*3];
 } __rte_cache_aligned;
@@ -80,8 +80,8 @@ struct rte_distributor_returned_pkts {
 	struct rte_mbuf *mbufs[RTE_DISTRIB_MAX_RETURNS];
 };
 
-struct rte_distributor_v20 {
-	TAILQ_ENTRY(rte_distributor_v20) next;    /**< Next in list. */
+struct rte_distributor_single {
+	TAILQ_ENTRY(rte_distributor_single) next;    /**< Next in list. */
 
 	char name[RTE_DISTRIBUTOR_NAMESIZE];  /**< Name of the ring. */
 	unsigned int num_workers;             /**< Number of workers polling */
@@ -96,7 +96,7 @@ struct rte_distributor_v20 {
 
 	struct rte_distributor_backlog backlog[RTE_DISTRIB_MAX_WORKERS];
 
-	union rte_distributor_buffer_v20 bufs[RTE_DISTRIB_MAX_WORKERS];
+	union rte_distributor_buffer_single bufs[RTE_DISTRIB_MAX_WORKERS];
 
 	struct rte_distributor_returned_pkts returns;
 };
@@ -154,7 +154,7 @@ struct rte_distributor {
 
 	enum rte_distributor_match_function dist_match_fn;
 
-	struct rte_distributor_v20 *d_v20;
+	struct rte_distributor_single *d_single;
 };
 
 void
lib/librte_distributor/meson.build +1 -1
index c9617d7b14..50b91887b5 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-sources = files('rte_distributor.c', 'rte_distributor_v20.c')
+sources = files('rte_distributor.c', 'rte_distributor_single.c')
 if arch_subdir == 'x86'
 	sources += files('rte_distributor_match_sse.c')
 else
lib/librte_distributor/rte_distributor.c +13 -11
index a4c8ff6a96..6c5b0c86e8 100644
@@ -17,7 +17,7 @@
 #include <rte_tailq.h>
 
 #include "rte_distributor.h"
-#include "rte_distributor_v20.h"
+#include "rte_distributor_single.h"
 #include "distributor_private.h"
 
 TAILQ_HEAD(rte_dist_burst_list, rte_distributor);
@@ -42,7 +42,7 @@ rte_distributor_request_pkt(struct rte_distributor *d,
 	volatile int64_t *retptr64;
 
 	if (unlikely(d->alg_type == RTE_DIST_ALG_SINGLE)) {
-		rte_distributor_request_pkt_v20(d->d_v20,
+		rte_distributor_request_pkt_single(d->d_single,
 			worker_id, oldpkt[0]);
 		return;
 	}
@@ -93,7 +93,8 @@ rte_distributor_poll_pkt(struct rte_distributor *d,
 	unsigned int i;
 
 	if (unlikely(d->alg_type == RTE_DIST_ALG_SINGLE)) {
-		pkts[0] = rte_distributor_poll_pkt_v20(d->d_v20, worker_id);
+		pkts[0] = rte_distributor_poll_pkt_single(d->d_single,
+			worker_id);
 		return (pkts[0]) ? 1 : 0;
 	}
 
@@ -133,7 +134,7 @@ rte_distributor_get_pkt(struct rte_distributor *d,
 
 	if (unlikely(d->alg_type == RTE_DIST_ALG_SINGLE)) {
 		if (return_count <= 1) {
-			pkts[0] = rte_distributor_get_pkt_v20(d->d_v20,
+			pkts[0] = rte_distributor_get_pkt_single(d->d_single,
 				worker_id, oldpkt[0]);
 			return (pkts[0]) ? 1 : 0;
 		} else
@@ -163,7 +164,7 @@ rte_distributor_return_pkt(struct rte_distributor *d,
 
 	if (unlikely(d->alg_type == RTE_DIST_ALG_SINGLE)) {
 		if (num == 1)
-			return rte_distributor_return_pkt_v20(d->d_v20,
+			return rte_distributor_return_pkt_single(d->d_single,
 				worker_id, oldpkt[0]);
 		else
 			return -EINVAL;
@@ -354,7 +355,8 @@ rte_distributor_process(struct rte_distributor *d,
 
 	if (d->alg_type == RTE_DIST_ALG_SINGLE) {
 		/* Call the old API */
-		return rte_distributor_process_v20(d->d_v20, mbufs, num_mbufs);
+		return rte_distributor_process_single(d->d_single,
+			mbufs, num_mbufs);
 	}
 
 	if (unlikely(num_mbufs == 0)) {
@@ -494,7 +496,7 @@ rte_distributor_returned_pkts(struct rte_distributor *d,
 
 	if (d->alg_type == RTE_DIST_ALG_SINGLE) {
 		/* Call the old API */
-		return rte_distributor_returned_pkts_v20(d->d_v20,
+		return rte_distributor_returned_pkts_single(d->d_single,
 				mbufs, max_mbufs);
 	}
 
@@ -537,7 +539,7 @@ rte_distributor_flush(struct rte_distributor *d)
 
 	if (d->alg_type == RTE_DIST_ALG_SINGLE) {
 		/* Call the old API */
-		return rte_distributor_flush_v20(d->d_v20);
+		return rte_distributor_flush_single(d->d_single);
 	}
 
 	flushed = total_outstanding(d);
@@ -568,7 +570,7 @@ rte_distributor_clear_returns(struct rte_distributor *d)
 
 	if (d->alg_type == RTE_DIST_ALG_SINGLE) {
 		/* Call the old API */
-		rte_distributor_clear_returns_v20(d->d_v20);
+		rte_distributor_clear_returns_single(d->d_single);
 		return;
 	}
 
@@ -610,9 +612,9 @@ rte_distributor_create(const char *name,
 			rte_errno = ENOMEM;
 			return NULL;
 		}
-		d->d_v20 = rte_distributor_create_v20(name,
+		d->d_single = rte_distributor_create_single(name,
 				socket_id, num_workers);
-		if (d->d_v20 == NULL) {
+		if (d->d_single == NULL) {
 			free(d);
 			/* rte_errno will have been set */
 			return NULL;
lib/librte_distributor/rte_distributor_single.c renamed from lib/librte_distributor/rte_distributor_v20.c +32 -32

169 lines not on this page · raw message

lib/librte_distributor/rte_distributor_single.h renamed from lib/librte_distributor/rte_distributor_v20.h +13 -13
similarity index 89%
rename from lib/librte_distributor/rte_distributor_v20.h
rename to lib/librte_distributor/rte_distributor_single.h
index 12865658ba..2f80aa43d1 100644
@@ -2,8 +2,8 @@
  * Copyright(c) 2010-2014 Intel Corporation
  */
 
-#ifndef _RTE_DISTRIB_V20_H_
-#define _RTE_DISTRIB_V20_H_
+#ifndef _RTE_DISTRIB_SINGLE_H_
+#define _RTE_DISTRIB_SINGLE_H_
 
 /**
  * @file
@@ -19,7 +19,7 @@ extern "C" {
 
 #define RTE_DISTRIBUTOR_NAMESIZE 32 /**< Length of name for instance */
 
-struct rte_distributor_v20;
+struct rte_distributor_single;
 struct rte_mbuf;
 
 /**
@@ -38,8 +38,8 @@ struct rte_mbuf;
  * @return
  *   The newly created distributor instance
  */
-struct rte_distributor_v20 *
-rte_distributor_create_v20(const char *name, unsigned int socket_id,
+struct rte_distributor_single *
+rte_distributor_create_single(const char *name, unsigned int socket_id,
 		unsigned int num_workers);
 
 /*  *** APIS to be called on the distributor lcore ***  */
@@ -74,7 +74,7 @@ rte_distributor_create_v20(const char *name, unsigned int socket_id,
  *   The number of mbufs processed.
  */
 int
-rte_distributor_process_v20(struct rte_distributor_v20 *d,
+rte_distributor_process_single(struct rte_distributor_single *d,
 		struct rte_mbuf **mbufs, unsigned int num_mbufs);
 
 /**
@@ -92,7 +92,7 @@ rte_distributor_process_v20(struct rte_distributor_v20 *d,
  *   The number of mbufs returned in the mbufs array.
  */
 int
-rte_distributor_returned_pkts_v20(struct rte_distributor_v20 *d,
+rte_distributor_returned_pkts_single(struct rte_distributor_single *d,
 		struct rte_mbuf **mbufs, unsigned int max_mbufs);
 
 /**
@@ -107,7 +107,7 @@ rte_distributor_returned_pkts_v20(struct rte_distributor_v20 *d,
  *   The number of queued/in-flight packets that were completed by this call.
  */
 int
-rte_distributor_flush_v20(struct rte_distributor_v20 *d);
+rte_distributor_flush_single(struct rte_distributor_single *d);
 
 /**
  * Clears the array of returned packets used as the source for the
@@ -119,7 +119,7 @@ rte_distributor_flush_v20(struct rte_distributor_v20 *d);
  *   The distributor instance to be used
  */
 void
-rte_distributor_clear_returns_v20(struct rte_distributor_v20 *d);
+rte_distributor_clear_returns_single(struct rte_distributor_single *d);
 
 /*  *** APIS to be called on the worker lcores ***  */
 /*
@@ -148,7 +148,7 @@ rte_distributor_clear_returns_v20(struct rte_distributor_v20 *d);
  *   A new packet to be processed by the worker thread.
  */
 struct rte_mbuf *
-rte_distributor_get_pkt_v20(struct rte_distributor_v20 *d,
+rte_distributor_get_pkt_single(struct rte_distributor_single *d,
 		unsigned int worker_id, struct rte_mbuf *oldpkt);
 
 /**
@@ -164,7 +164,7 @@ rte_distributor_get_pkt_v20(struct rte_distributor_v20 *d,
  *   The previous packet being processed by the worker
  */
 int
-rte_distributor_return_pkt_v20(struct rte_distributor_v20 *d,
+rte_distributor_return_pkt_single(struct rte_distributor_single *d,
 		unsigned int worker_id, struct rte_mbuf *mbuf);
 
 /**
@@ -188,7 +188,7 @@ rte_distributor_return_pkt_v20(struct rte_distributor_v20 *d,
  *   The previous packet, if any, being processed by the worker
  */
 void
-rte_distributor_request_pkt_v20(struct rte_distributor_v20 *d,
+rte_distributor_request_pkt_single(struct rte_distributor_single *d,
 		unsigned int worker_id, struct rte_mbuf *oldpkt);
 
 /**
@@ -208,7 +208,7 @@ rte_distributor_request_pkt_v20(struct rte_distributor_v20 *d,
  *   packet is yet available.
  */
 struct rte_mbuf *
-rte_distributor_poll_pkt_v20(struct rte_distributor_v20 *d,
+rte_distributor_poll_pkt_single(struct rte_distributor_single *d,
 		unsigned int worker_id);
 
 #ifdef __cplusplus
lib/librte_distributor/rte_distributor_version.map +1 -17
index 3a285b394e..00e26b4804 100644
@@ -1,19 +1,3 @@
-DPDK_2.0 {
-	global:
-
-	rte_distributor_clear_returns;
-	rte_distributor_create;
-	rte_distributor_flush;
-	rte_distributor_get_pkt;
-	rte_distributor_poll_pkt;
-	rte_distributor_process;
-	rte_distributor_request_pkt;
-	rte_distributor_return_pkt;
-	rte_distributor_returned_pkts;
-
-	local: *;
-};
-
 DPDK_17.05 {
 	global:
 
@@ -26,4 +10,4 @@ DPDK_17.05 {
 	rte_distributor_request_pkt;
 	rte_distributor_return_pkt;
 	rte_distributor_returned_pkts;
-} DPDK_2.0;
+};
Signature · 1 line
2.17.1
#101 lore raw

PATCH v7 8/10 drivers/octeontx: add missing public symbol

In reply to Anatoly Burakov

The logtype symbol was missing from the .map file. Add it.

Fixes d8dd31652cf4 ("common/octeontx: move mbox to common folder")

---

Notes:
v2:
- add this patch to avoid compile breakage when bumping ABI

 drivers/common/octeontx/rte_common_octeontx_version.map | 1 +
 1 file changed, 1 insertion(+)
drivers/common/octeontx/rte_common_octeontx_version.map +1 -0
index f04b3b7f8a..a9b3cff9bc 100644
@@ -1,6 +1,7 @@
 DPDK_18.05 {
 	global:
 
+	octeontx_logtype_mbox;
 	octeontx_mbox_set_ram_mbox_base;
 	octeontx_mbox_set_reg;
 	octeontx_mbox_send;
Signature · 1 line
2.17.1
#102 lore raw

PATCH v7 9/10 build: change ABI version to 20.0

In reply to Anatoly Burakov

From: Pawel Modrak <[email protected]>

Merge all vesions in linker version script files to DPDK_20.0.

This commit was generated by running the following command:

:~/DPDK$ buildtools/update-abi.sh 20.0
---
 .../rte_pmd_bbdev_fpga_lte_fec_version.map    |   8 +-
 .../null/rte_pmd_bbdev_null_version.map       |   2 +-
 .../rte_pmd_bbdev_turbo_sw_version.map        |   2 +-
 drivers/bus/dpaa/rte_bus_dpaa_version.map     | 113 +++---
 drivers/bus/fslmc/rte_bus_fslmc_version.map   | 154 ++++-----
 drivers/bus/ifpga/rte_bus_ifpga_version.map   |  14 +-
 drivers/bus/pci/rte_bus_pci_version.map       |   2 +-
 drivers/bus/vdev/rte_bus_vdev_version.map     |  12 +-
 drivers/bus/vmbus/rte_bus_vmbus_version.map   |  12 +-
 drivers/common/cpt/rte_common_cpt_version.map |   9 +-
 .../common/dpaax/rte_common_dpaax_version.map |  14 +-
 .../common/mvep/rte_common_mvep_version.map   |   6 +-
 .../octeontx/rte_common_octeontx_version.map  |   6 +-
 .../rte_common_octeontx2_version.map          |  16 +-
 .../compress/isal/rte_pmd_isal_version.map    |   2 +-
 .../rte_pmd_octeontx_compress_version.map     |   2 +-
 drivers/compress/qat/rte_pmd_qat_version.map  |   2 +-
 .../compress/zlib/rte_pmd_zlib_version.map    |   2 +-
 .../aesni_gcm/rte_pmd_aesni_gcm_version.map   |   2 +-
 .../aesni_mb/rte_pmd_aesni_mb_version.map     |   2 +-
 .../crypto/armv8/rte_pmd_armv8_version.map    |   2 +-
 .../caam_jr/rte_pmd_caam_jr_version.map       |   3 +-
 drivers/crypto/ccp/rte_pmd_ccp_version.map    |   3 +-
 .../dpaa2_sec/rte_pmd_dpaa2_sec_version.map   |  10 +-
 .../dpaa_sec/rte_pmd_dpaa_sec_version.map     |  10 +-
 .../crypto/kasumi/rte_pmd_kasumi_version.map  |   2 +-
 .../crypto/mvsam/rte_pmd_mvsam_version.map    |   2 +-
 .../crypto/nitrox/rte_pmd_nitrox_version.map  |   2 +-
 .../null/rte_pmd_null_crypto_version.map      |   2 +-
 .../rte_pmd_octeontx_crypto_version.map       |   3 +-
 .../rte_pmd_octeontx2_crypto_version.map      |   3 +-
 .../openssl/rte_pmd_openssl_version.map       |   2 +-
 .../rte_pmd_crypto_scheduler_version.map      |  19 +-
 .../crypto/snow3g/rte_pmd_snow3g_version.map  |   2 +-
 .../virtio/rte_pmd_virtio_crypto_version.map  |   2 +-
 drivers/crypto/zuc/rte_pmd_zuc_version.map    |   2 +-
 .../event/dpaa/rte_pmd_dpaa_event_version.map |   3 +-
 .../dpaa2/rte_pmd_dpaa2_event_version.map     |   2 +-
 .../event/dsw/rte_pmd_dsw_event_version.map   |   2 +-
 .../rte_pmd_octeontx_event_version.map        |   2 +-
 .../rte_pmd_octeontx2_event_version.map       |   3 +-
 .../event/opdl/rte_pmd_opdl_event_version.map |   2 +-
 .../rte_pmd_skeleton_event_version.map        |   3 +-
 drivers/event/sw/rte_pmd_sw_event_version.map |   2 +-
 .../bucket/rte_mempool_bucket_version.map     |   3 +-
 .../mempool/dpaa/rte_mempool_dpaa_version.map |   2 +-
 .../dpaa2/rte_mempool_dpaa2_version.map       |  12 +-
 .../octeontx/rte_mempool_octeontx_version.map |   2 +-
 .../rte_mempool_octeontx2_version.map         |   4 +-
 .../mempool/ring/rte_mempool_ring_version.map |   3 +-
 .../stack/rte_mempool_stack_version.map       |   3 +-
 .../af_packet/rte_pmd_af_packet_version.map   |   3 +-
 drivers/net/af_xdp/rte_pmd_af_xdp_version.map |   2 +-
 drivers/net/ark/rte_pmd_ark_version.map       |   5 +-
 .../net/atlantic/rte_pmd_atlantic_version.map |   4 +-
 drivers/net/avp/rte_pmd_avp_version.map       |   2 +-
 drivers/net/axgbe/rte_pmd_axgbe_version.map   |   2 +-
 drivers/net/bnx2x/rte_pmd_bnx2x_version.map   |   3 +-
 drivers/net/bnxt/rte_pmd_bnxt_version.map     |   4 +-
 drivers/net/bonding/rte_pmd_bond_version.map  |  47 +--
 drivers/net/cxgbe/rte_pmd_cxgbe_version.map   |   3 +-
 drivers/net/dpaa/rte_pmd_dpaa_version.map     |  11 +-
 drivers/net/dpaa2/rte_pmd_dpaa2_version.map   |  12 +-
 drivers/net/e1000/rte_pmd_e1000_version.map   |   3 +-
 drivers/net/ena/rte_pmd_ena_version.map       |   3 +-
 drivers/net/enetc/rte_pmd_enetc_version.map   |   3 +-
 drivers/net/enic/rte_pmd_enic_version.map     |   3 +-
 .../net/failsafe/rte_pmd_failsafe_version.map |   3 +-
 drivers/net/fm10k/rte_pmd_fm10k_version.map   |   3 +-
 drivers/net/hinic/rte_pmd_hinic_version.map   |   3 +-
 drivers/net/hns3/rte_pmd_hns3_version.map     |   4 +-
 drivers/net/i40e/rte_pmd_i40e_version.map     |  65 +---
 drivers/net/iavf/rte_pmd_iavf_version.map     |   3 +-
 drivers/net/ice/rte_pmd_ice_version.map       |   3 +-
 drivers/net/ifc/rte_pmd_ifc_version.map       |   3 +-
 drivers/net/ipn3ke/rte_pmd_ipn3ke_version.map |   3 +-
 drivers/net/ixgbe/rte_pmd_ixgbe_version.map   |  62 ++--
 drivers/net/kni/rte_pmd_kni_version.map       |   3 +-
 .../net/liquidio/rte_pmd_liquidio_version.map |   3 +-
 drivers/net/memif/rte_pmd_memif_version.map   |   5 +-
 drivers/net/mlx4/rte_pmd_mlx4_version.map     |   3 +-
 drivers/net/mlx5/rte_pmd_mlx5_version.map     |   2 +-
 drivers/net/mvneta/rte_pmd_mvneta_version.map |   2 +-
 drivers/net/mvpp2/rte_pmd_mvpp2_version.map   |   2 +-
 drivers/net/netvsc/rte_pmd_netvsc_version.map |   4 +-
 drivers/net/nfb/rte_pmd_nfb_version.map       |   3 +-
 drivers/net/nfp/rte_pmd_nfp_version.map       |   2 +-
 drivers/net/null/rte_pmd_null_version.map     |   3 +-
 .../net/octeontx/rte_pmd_octeontx_version.map |  10 +-
 .../octeontx2/rte_pmd_octeontx2_version.map   |   3 +-
 drivers/net/pcap/rte_pmd_pcap_version.map     |   3 +-
 drivers/net/pfe/rte_pmd_pfe_version.map       |   3 +-
 drivers/net/qede/rte_pmd_qede_version.map     |   3 +-
 drivers/net/ring/rte_pmd_ring_version.map     |  10 +-
 drivers/net/sfc/rte_pmd_sfc_version.map       |   3 +-
 .../net/softnic/rte_pmd_softnic_version.map   |   2 +-
 .../net/szedata2/rte_pmd_szedata2_version.map |   2 +-
 drivers/net/tap/rte_pmd_tap_version.map       |   3 +-
 .../net/thunderx/rte_pmd_thunderx_version.map |   3 +-
 .../rte_pmd_vdev_netvsc_version.map           |   3 +-
 drivers/net/vhost/rte_pmd_vhost_version.map   |  11 +-
 drivers/net/virtio/rte_pmd_virtio_version.map |   3 +-
 .../net/vmxnet3/rte_pmd_vmxnet3_version.map   |   3 +-
 .../rte_rawdev_dpaa2_cmdif_version.map        |   3 +-
 .../rte_rawdev_dpaa2_qdma_version.map         |   4 +-
 .../raw/ifpga/rte_rawdev_ifpga_version.map    |   3 +-
 drivers/raw/ioat/rte_rawdev_ioat_version.map  |   3 +-
 drivers/raw/ntb/rte_rawdev_ntb_version.map    |   5 +-
 .../rte_rawdev_octeontx2_dma_version.map      |   3 +-
 .../skeleton/rte_rawdev_skeleton_version.map  |   3 +-
 lib/librte_acl/rte_acl_version.map            |   2 +-
 .../rte_bitratestats_version.map              |   2 +-
 lib/librte_cfgfile/rte_cfgfile_version.map    |  34 +-
 lib/librte_cmdline/rte_cmdline_version.map    |  10 +-
 .../rte_cryptodev_version.map                 | 102 ++----
 .../rte_distributor_version.map               |   4 +-
 lib/librte_eal/rte_eal_version.map            | 324 ++++++------------
 lib/librte_efd/rte_efd_version.map            |   2 +-
 lib/librte_ethdev/rte_ethdev_version.map      | 160 +++------
 lib/librte_eventdev/rte_eventdev_version.map  | 130 +++----
 lib/librte_gro/rte_gro_version.map            |   2 +-
 lib/librte_gso/rte_gso_version.map            |   2 +-
 lib/librte_hash/rte_hash_version.map          |  43 +--
 lib/librte_ip_frag/rte_ip_frag_version.map    |  10 +-
 lib/librte_jobstats/rte_jobstats_version.map  |  10 +-
 lib/librte_kni/rte_kni_version.map            |   2 +-
 lib/librte_kvargs/rte_kvargs_version.map      |   4 +-
 .../rte_latencystats_version.map              |   2 +-
 lib/librte_lpm/rte_lpm_version.map            |  39 +--
 lib/librte_mbuf/rte_mbuf_version.map          |  49 +--
 lib/librte_member/rte_member_version.map      |   2 +-
 lib/librte_mempool/rte_mempool_version.map    |  44 +--
 lib/librte_meter/rte_meter_version.map        |  13 +-
 lib/librte_metrics/rte_metrics_version.map    |   2 +-
 lib/librte_net/rte_net_version.map            |  23 +-
 lib/librte_pci/rte_pci_version.map            |   2 +-
 lib/librte_pdump/rte_pdump_version.map        |   2 +-
 lib/librte_pipeline/rte_pipeline_version.map  |  36 +-
 lib/librte_port/rte_port_version.map          |  64 +---
 lib/librte_power/rte_power_version.map        |  24 +-
 lib/librte_rawdev/rte_rawdev_version.map      |   4 +-
 lib/librte_reorder/rte_reorder_version.map    |   8 +-
 lib/librte_ring/rte_ring_version.map          |  10 +-
 lib/librte_sched/rte_sched_version.map        |  14 +-
 lib/librte_security/rte_security_version.map  |   2 +-
 lib/librte_table/rte_table_version.map        |   2 +-
 lib/librte_timer/rte_timer_version.map        |  12 +-
 lib/librte_vhost/rte_vhost_version.map        |  52 +--
 148 files changed, 698 insertions(+), 1433 deletions(-)
drivers/baseband/fpga_lte_fec/rte_pmd_bbdev_fpga_lte_fec_version.map +4 -4
index f64b0f9c27..6bcea2cc7f 100644
@@ -1,10 +1,10 @@
-DPDK_19.08 {
-    local: *;
+DPDK_20.0 {
+	local: *;
 };
 
 EXPERIMENTAL {
-    global:
+	global:
 
-    fpga_lte_fec_configure;
+	fpga_lte_fec_configure;
 
 };
drivers/baseband/null/rte_pmd_bbdev_null_version.map +1 -1
index 58b94270d4..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.02 {
+DPDK_20.0 {
 	local: *;
 };
drivers/baseband/turbo_sw/rte_pmd_bbdev_turbo_sw_version.map +1 -1
index 58b94270d4..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.02 {
+DPDK_20.0 {
 	local: *;
 };
drivers/bus/dpaa/rte_bus_dpaa_version.map +40 -73

167 lines not on this page · raw message

drivers/bus/fslmc/rte_bus_fslmc_version.map +60 -94

204 lines not on this page · raw message

drivers/bus/ifpga/rte_bus_ifpga_version.map +4 -10
index 964c9a9c45..05b4a28c1b 100644
@@ -1,17 +1,11 @@
-DPDK_18.05 {
+DPDK_20.0 {
 	global:
 
-	rte_ifpga_get_integer32_arg;
-	rte_ifpga_get_string_arg;
 	rte_ifpga_driver_register;
 	rte_ifpga_driver_unregister;
+	rte_ifpga_find_afu_by_name;
+	rte_ifpga_get_integer32_arg;
+	rte_ifpga_get_string_arg;
 
 	local: *;
 };
-
-DPDK_19.05 {
-	global:
-
-	rte_ifpga_find_afu_by_name;
-
-} DPDK_18.05;
drivers/bus/pci/rte_bus_pci_version.map +1 -1
index 27e9c4f101..012d817e14 100644
@@ -1,4 +1,4 @@
-DPDK_17.11 {
+DPDK_20.0 {
 	global:
 
 	rte_pci_dump;
drivers/bus/vdev/rte_bus_vdev_version.map +3 -9
index 590cf9b437..5abb10ecb0 100644
@@ -1,18 +1,12 @@
-DPDK_17.11 {
+DPDK_20.0 {
 	global:
 
+	rte_vdev_add_custom_scan;
 	rte_vdev_init;
 	rte_vdev_register;
+	rte_vdev_remove_custom_scan;
 	rte_vdev_uninit;
 	rte_vdev_unregister;
 
 	local: *;
 };
-
-DPDK_18.02 {
-	global:
-
-	rte_vdev_add_custom_scan;
-	rte_vdev_remove_custom_scan;
-
-} DPDK_17.11;
drivers/bus/vmbus/rte_bus_vmbus_version.map +2 -10
index ae231ad329..cbaaebc06c 100644
@@ -1,6 +1,4 @@
-/* SPDX-License-Identifier: BSD-3-Clause */
-
-DPDK_18.08 {
+DPDK_20.0 {
 	global:
 
 	rte_vmbus_chan_close;
@@ -20,6 +18,7 @@ DPDK_18.08 {
 	rte_vmbus_probe;
 	rte_vmbus_register;
 	rte_vmbus_scan;
+	rte_vmbus_set_latency;
 	rte_vmbus_sub_channel_index;
 	rte_vmbus_subchan_open;
 	rte_vmbus_unmap_device;
@@ -27,10 +26,3 @@ DPDK_18.08 {
 
 	local: *;
 };
-
-DPDK_18.11 {
-	global:
-
-	rte_vmbus_set_latency;
-
-} DPDK_18.08;
drivers/common/cpt/rte_common_cpt_version.map +2 -7
index 382ec4bd44..7f1929d58e 100644
@@ -1,14 +1,9 @@
-DPDK_18.11 {
+DPDK_20.0 {
 	global:
 
+	cpt_pmd_ops_helper_asym_get_mlen;
 	cpt_pmd_ops_helper_get_mlen_direct_mode;
 	cpt_pmd_ops_helper_get_mlen_sg_mode;
-};
-
-DPDK_19.11 {
-	global:
-
-	cpt_pmd_ops_helper_asym_get_mlen;
 
 	local: *;
 };
drivers/common/dpaax/rte_common_dpaax_version.map +4 -10
index a7699ae4dd..f72eba761d 100644
@@ -1,29 +1,23 @@
-DPDK_18.11 {
+DPDK_20.0 {
 	global:
 
-	dpaax_iova_table_update;
 	dpaax_iova_table_depopulate;
 	dpaax_iova_table_dump;
 	dpaax_iova_table_p;
 	dpaax_iova_table_populate;
-
-	local: *;
-};
-
-DPDK_19.11 {
-	global:
+	dpaax_iova_table_update;
 	of_device_is_available;
 	of_device_is_compatible;
 	of_find_compatible_node;
 	of_find_node_by_phandle;
 	of_get_address;
 	of_get_mac_address;
+	of_get_next_child;
 	of_get_parent;
 	of_get_property;
 	of_init_path;
 	of_n_addr_cells;
 	of_translate_address;
-	of_get_next_child;
 
 	local: *;
-} DPDK_18.11;
+};
drivers/common/mvep/rte_common_mvep_version.map +4 -2
index c71722d79f..030928439d 100644
@@ -1,6 +1,8 @@
-DPDK_18.11 {
+DPDK_20.0 {
 	global:
 
-	rte_mvep_init;
 	rte_mvep_deinit;
+	rte_mvep_init;
+
+	local: *;
 };
drivers/common/octeontx/rte_common_octeontx_version.map +4 -2
index a9b3cff9bc..c15fb89112 100644
@@ -1,8 +1,10 @@
-DPDK_18.05 {
+DPDK_20.0 {
 	global:
 
 	octeontx_logtype_mbox;
+	octeontx_mbox_send;
 	octeontx_mbox_set_ram_mbox_base;
 	octeontx_mbox_set_reg;
-	octeontx_mbox_send;
+
+	local: *;
 };
drivers/common/octeontx2/rte_common_octeontx2_version.map +6 -10
index 4400120da0..adad21a2d6 100644
@@ -1,39 +1,35 @@
-DPDK_19.08 {
+DPDK_20.0 {
 	global:
 
 	otx2_dev_active_vfs;
 	otx2_dev_fini;
 	otx2_dev_priv_init;
-
+	otx2_disable_irqs;
+	otx2_intra_dev_get_cfg;
 	otx2_logtype_base;
 	otx2_logtype_dpi;
 	otx2_logtype_mbox;
+	otx2_logtype_nix;
 	otx2_logtype_npa;
 	otx2_logtype_npc;
-	otx2_logtype_nix;
 	otx2_logtype_sso;
-	otx2_logtype_tm;
 	otx2_logtype_tim;
-
+	otx2_logtype_tm;
 	otx2_mbox_alloc_msg_rsp;
 	otx2_mbox_get_rsp;
 	otx2_mbox_get_rsp_tmo;
 	otx2_mbox_id2name;
 	otx2_mbox_msg_send;
 	otx2_mbox_wait_for_rsp;
-
-	otx2_intra_dev_get_cfg;
 	otx2_npa_lf_active;
 	otx2_npa_lf_obj_get;
 	otx2_npa_lf_obj_ref;
 	otx2_npa_pf_func_get;
 	otx2_npa_set_defaults;
+	otx2_register_irq;
 	otx2_sso_pf_func_get;
 	otx2_sso_pf_func_set;
-
-	otx2_disable_irqs;
 	otx2_unregister_irq;
-	otx2_register_irq;
 
 	local: *;
 };
drivers/compress/isal/rte_pmd_isal_version.map +1 -1
index de8e412ff1..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.05 {
+DPDK_20.0 {
 	local: *;
 };
drivers/compress/octeontx/rte_pmd_octeontx_compress_version.map +1 -1
index ad6e191e49..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.08 {
+DPDK_20.0 {
 	local: *;
 };
drivers/compress/qat/rte_pmd_qat_version.map +1 -1
index ad6e191e49..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.08 {
+DPDK_20.0 {
 	local: *;
 };
drivers/compress/zlib/rte_pmd_zlib_version.map +1 -1
index ad6e191e49..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.08 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/aesni_gcm/rte_pmd_aesni_gcm_version.map +1 -1
index dc4d417b7b..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_16.04 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/aesni_mb/rte_pmd_aesni_mb_version.map +1 -1
index ad607bbedd..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_2.2 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/armv8/rte_pmd_armv8_version.map +1 -1
index 1f84b68a83..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_17.02 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/caam_jr/rte_pmd_caam_jr_version.map +1 -2
index 521e51f411..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.11 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/ccp/rte_pmd_ccp_version.map +1 -2
index 9b9ab1a4cf..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map +3 -7
index 0bfb986d0b..5952d645fd 100644
@@ -1,12 +1,8 @@
-DPDK_17.05 {
-
-	local: *;
-};
-
-DPDK_18.11 {
+DPDK_20.0 {
 	global:
 
 	dpaa2_sec_eventq_attach;
 	dpaa2_sec_eventq_detach;
 
-} DPDK_17.05;
+	local: *;
+};
drivers/crypto/dpaa_sec/rte_pmd_dpaa_sec_version.map +3 -7
index cc7f2162e0..8580fa13db 100644
@@ -1,12 +1,8 @@
-DPDK_17.11 {
-
-	local: *;
-};
-
-DPDK_19.11 {
+DPDK_20.0 {
 	global:
 
 	dpaa_sec_eventq_attach;
 	dpaa_sec_eventq_detach;
 
-} DPDK_17.11;
+	local: *;
+};
drivers/crypto/kasumi/rte_pmd_kasumi_version.map +1 -1
index 8ffeca934e..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_16.07 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/mvsam/rte_pmd_mvsam_version.map +1 -1
index a753031720..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_17.11 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/nitrox/rte_pmd_nitrox_version.map +1 -1
index 406964d1fc..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_19.11 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/null/rte_pmd_null_crypto_version.map +1 -1
index dc4d417b7b..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_16.04 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/octeontx/rte_pmd_octeontx_crypto_version.map +1 -2
index 521e51f411..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.11 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/octeontx2/rte_pmd_octeontx2_crypto_version.map +1 -2
index b7b7c91683..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.11 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/openssl/rte_pmd_openssl_version.map +1 -1
index cc5829e30b..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_16.11 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/scheduler/rte_pmd_crypto_scheduler_version.map +7 -12
index 5c43127cf2..077afedce7 100644
@@ -1,21 +1,16 @@
-DPDK_17.02 {
+DPDK_20.0 {
 	global:
 
 	rte_cryptodev_scheduler_load_user_scheduler;
-	rte_cryptodev_scheduler_slave_attach;
-	rte_cryptodev_scheduler_slave_detach;
-	rte_cryptodev_scheduler_ordering_set;
-	rte_cryptodev_scheduler_ordering_get;
-
-};
-
-DPDK_17.05 {
-	global:
-
 	rte_cryptodev_scheduler_mode_get;
 	rte_cryptodev_scheduler_mode_set;
 	rte_cryptodev_scheduler_option_get;
 	rte_cryptodev_scheduler_option_set;
+	rte_cryptodev_scheduler_ordering_get;
+	rte_cryptodev_scheduler_ordering_set;
+	rte_cryptodev_scheduler_slave_attach;
+	rte_cryptodev_scheduler_slave_detach;
 	rte_cryptodev_scheduler_slaves_get;
 
-} DPDK_17.02;
+	local: *;
+};
drivers/crypto/snow3g/rte_pmd_snow3g_version.map +1 -1
index dc4d417b7b..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_16.04 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/virtio/rte_pmd_virtio_crypto_version.map +1 -1
index de8e412ff1..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.05 {
+DPDK_20.0 {
 	local: *;
 };
drivers/crypto/zuc/rte_pmd_zuc_version.map +1 -1
index cc5829e30b..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_16.11 {
+DPDK_20.0 {
 	local: *;
 };
drivers/event/dpaa/rte_pmd_dpaa_event_version.map +1 -2
index 179140fb87..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.02 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/event/dpaa2/rte_pmd_dpaa2_event_version.map +1 -1
index 1c0b7559dc..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_17.08 {
+DPDK_20.0 {
 	local: *;
 };
drivers/event/dsw/rte_pmd_dsw_event_version.map +1 -1
index 24bd5cdb35..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.11 {
+DPDK_20.0 {
 	local: *;
 };
drivers/event/octeontx/rte_pmd_octeontx_event_version.map +1 -1
index 5352e7e3bd..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_17.05 {
+DPDK_20.0 {
 	local: *;
 };
drivers/event/octeontx2/rte_pmd_octeontx2_event_version.map +1 -2
index 41c65c8c9c..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.08 {
+DPDK_20.0 {
 	local: *;
 };
-
drivers/event/opdl/rte_pmd_opdl_event_version.map +1 -1
index 58b94270d4..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.02 {
+DPDK_20.0 {
 	local: *;
 };
drivers/event/skeleton/rte_pmd_skeleton_event_version.map +1 -2
index 8591cc0b18..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_17.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/event/sw/rte_pmd_sw_event_version.map +1 -1
index 5352e7e3bd..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_17.05 {
+DPDK_20.0 {
 	local: *;
 };
drivers/mempool/bucket/rte_mempool_bucket_version.map +1 -2
index 9b9ab1a4cf..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/mempool/dpaa/rte_mempool_dpaa_version.map +1 -1
index 60bf50b2d1..9eebaf7ffd 100644
@@ -1,4 +1,4 @@
-DPDK_17.11 {
+DPDK_20.0 {
 	global:
 
 	rte_dpaa_bpid_info;
drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map +3 -9
index b45e7a9ac1..cd4bc88273 100644
@@ -1,16 +1,10 @@
-DPDK_17.05 {
+DPDK_20.0 {
 	global:
 
 	rte_dpaa2_bpid_info;
 	rte_dpaa2_mbuf_alloc_bulk;
-
-	local: *;
-};
-
-DPDK_18.05 {
-	global:
-
 	rte_dpaa2_mbuf_from_buf_addr;
 	rte_dpaa2_mbuf_pool_bpid;
 
-} DPDK_17.05;
+	local: *;
+};
drivers/mempool/octeontx/rte_mempool_octeontx_version.map +1 -1
index a753031720..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_17.11 {
+DPDK_20.0 {
 	local: *;
 };
drivers/mempool/octeontx2/rte_mempool_octeontx2_version.map +2 -2
index d703368c31..d4f81aed8e 100644
@@ -1,8 +1,8 @@
-DPDK_19.08 {
+DPDK_20.0 {
 	global:
 
-	otx2_npa_lf_init;
 	otx2_npa_lf_fini;
+	otx2_npa_lf_init;
 
 	local: *;
 };
drivers/mempool/ring/rte_mempool_ring_version.map +1 -2
index 8591cc0b18..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_17.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/mempool/stack/rte_mempool_stack_version.map +1 -2
index 8591cc0b18..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_17.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/af_packet/rte_pmd_af_packet_version.map +1 -2
index ef35398402..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.0 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/af_xdp/rte_pmd_af_xdp_version.map +1 -1
index c6db030fe6..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_19.05 {
+DPDK_20.0 {
 	local: *;
 };
drivers/net/ark/rte_pmd_ark_version.map +2 -3
index 1062e0429f..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_17.05 {
-	 local: *;
-
+DPDK_20.0 {
+	local: *;
 };
drivers/net/atlantic/rte_pmd_atlantic_version.map +1 -3
index b16faa999f..9b04838d84 100644
@@ -1,5 +1,4 @@
-DPDK_18.11 {
-
+DPDK_20.0 {
 	local: *;
 };
 
@@ -13,4 +12,3 @@ EXPERIMENTAL {
 	rte_pmd_atl_macsec_select_txsa;
 	rte_pmd_atl_macsec_select_rxsa;
 };
-
drivers/net/avp/rte_pmd_avp_version.map +1 -1
index 5352e7e3bd..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_17.05 {
+DPDK_20.0 {
 	local: *;
 };
drivers/net/axgbe/rte_pmd_axgbe_version.map +1 -1
index de8e412ff1..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.05 {
+DPDK_20.0 {
 	local: *;
 };
drivers/net/bnx2x/rte_pmd_bnx2x_version.map +1 -2
index bd8138a034..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.1 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/bnxt/rte_pmd_bnxt_version.map +2 -2
index 4750d40ad6..bb52562347 100644
@@ -1,4 +1,4 @@
-DPDK_17.08 {
+DPDK_20.0 {
 	global:
 
 	rte_pmd_bnxt_get_vf_rx_status;
@@ -10,13 +10,13 @@ DPDK_17.08 {
 	rte_pmd_bnxt_set_tx_loopback;
 	rte_pmd_bnxt_set_vf_mac_addr;
 	rte_pmd_bnxt_set_vf_mac_anti_spoof;
+	rte_pmd_bnxt_set_vf_persist_stats;
 	rte_pmd_bnxt_set_vf_rate_limit;
 	rte_pmd_bnxt_set_vf_rxmode;
 	rte_pmd_bnxt_set_vf_vlan_anti_spoof;
 	rte_pmd_bnxt_set_vf_vlan_filter;
 	rte_pmd_bnxt_set_vf_vlan_insert;
 	rte_pmd_bnxt_set_vf_vlan_stripq;
-	rte_pmd_bnxt_set_vf_persist_stats;
 
 	local: *;
 };
drivers/net/bonding/rte_pmd_bond_version.map +13 -34

58 lines not on this page · raw message

drivers/net/cxgbe/rte_pmd_cxgbe_version.map +1 -2
index bd8138a034..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.1 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/dpaa/rte_pmd_dpaa_version.map +4 -7
index 8cb4500b51..f403a1526d 100644
@@ -1,12 +1,9 @@
-DPDK_17.11 {
-
-	local: *;
-};
-
-DPDK_18.08 {
+DPDK_20.0 {
 	global:
 
 	dpaa_eth_eventq_attach;
 	dpaa_eth_eventq_detach;
 	rte_pmd_dpaa_set_tx_loopback;
-} DPDK_17.11;
+
+	local: *;
+};
drivers/net/dpaa2/rte_pmd_dpaa2_version.map +4 -8
index d1b4cdb232..f2bb793319 100644
@@ -1,15 +1,11 @@
-DPDK_17.05 {
-
-	local: *;
-};
-
-DPDK_17.11 {
+DPDK_20.0 {
 	global:
 
 	dpaa2_eth_eventq_attach;
 	dpaa2_eth_eventq_detach;
 
-} DPDK_17.05;
+	local: *;
+};
 
 EXPERIMENTAL {
 	global:
@@ -17,4 +13,4 @@ EXPERIMENTAL {
 	rte_pmd_dpaa2_mux_flow_create;
 	rte_pmd_dpaa2_set_custom_hash;
 	rte_pmd_dpaa2_set_timestamp;
-} DPDK_17.11;
+};
drivers/net/e1000/rte_pmd_e1000_version.map +1 -2
index ef35398402..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.0 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/ena/rte_pmd_ena_version.map +1 -2
index 349c6e1c22..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_16.04 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/enetc/rte_pmd_enetc_version.map +1 -2
index 521e51f411..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.11 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/enic/rte_pmd_enic_version.map +1 -2
index ef35398402..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.0 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/failsafe/rte_pmd_failsafe_version.map +1 -2
index b6d2840be4..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_17.08 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/fm10k/rte_pmd_fm10k_version.map +1 -2
index ef35398402..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.0 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/hinic/rte_pmd_hinic_version.map +1 -2
index 9a61188cd5..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.08 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/hns3/rte_pmd_hns3_version.map +2 -2
index 35e5f2debb..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_19.11 {
-	 local: *;
+DPDK_20.0 {
+	local: *;
 };
drivers/net/i40e/rte_pmd_i40e_version.map +19 -46

86 lines not on this page · raw message

drivers/net/iavf/rte_pmd_iavf_version.map +1 -2
index 179140fb87..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.02 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/ice/rte_pmd_ice_version.map +1 -2
index 7b23b609da..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.02 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/ifc/rte_pmd_ifc_version.map +1 -2
index 9b9ab1a4cf..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/ipn3ke/rte_pmd_ipn3ke_version.map +1 -2
index fc8c95e919..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/ixgbe/rte_pmd_ixgbe_version.map +22 -40

79 lines not on this page · raw message

drivers/net/kni/rte_pmd_kni_version.map +1 -2
index 8591cc0b18..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_17.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/liquidio/rte_pmd_liquidio_version.map +1 -2
index 8591cc0b18..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_17.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/memif/rte_pmd_memif_version.map +2 -3
index 8861484fb3..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.08 {
-
-        local: *;
+DPDK_20.0 {
+	local: *;
 };
drivers/net/mlx4/rte_pmd_mlx4_version.map +1 -2
index ef35398402..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.0 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/mlx5/rte_pmd_mlx5_version.map +1 -1
index ad607bbedd..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_2.2 {
+DPDK_20.0 {
 	local: *;
 };
drivers/net/mvneta/rte_pmd_mvneta_version.map +1 -1
index 24bd5cdb35..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_18.11 {
+DPDK_20.0 {
 	local: *;
 };
drivers/net/mvpp2/rte_pmd_mvpp2_version.map +1 -1
index a753031720..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_17.11 {
+DPDK_20.0 {
 	local: *;
 };
drivers/net/netvsc/rte_pmd_netvsc_version.map +1 -3
index d534019a6b..f9f17e4f6e 100644
@@ -1,5 +1,3 @@
-/* SPDX-License-Identifier: BSD-3-Clause */
-
-DPDK_18.08 {
+DPDK_20.0 {
 	local: *;
 };
drivers/net/nfb/rte_pmd_nfb_version.map +1 -2
index fc8c95e919..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/nfp/rte_pmd_nfp_version.map +1 -1
index ad607bbedd..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_2.2 {
+DPDK_20.0 {
 	local: *;
 };
drivers/net/null/rte_pmd_null_version.map +1 -2
index ef35398402..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.0 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/octeontx/rte_pmd_octeontx_version.map +3 -7
index a3161b14d0..f7cae02fac 100644
@@ -1,11 +1,7 @@
-DPDK_17.11 {
-
-	local: *;
-};
-
-DPDK_18.02 {
+DPDK_20.0 {
 	global:
 
 	rte_octeontx_pchan_map;
 
-} DPDK_17.11;
+	local: *;
+};
drivers/net/octeontx2/rte_pmd_octeontx2_version.map +1 -2
index 9a61188cd5..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.08 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/pcap/rte_pmd_pcap_version.map +1 -2
index ef35398402..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.0 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/pfe/rte_pmd_pfe_version.map +1 -2
index b7b7c91683..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.11 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/qede/rte_pmd_qede_version.map +1 -2
index 349c6e1c22..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_16.04 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/ring/rte_pmd_ring_version.map +2 -8
index 1f785d9409..ebb6be2733 100644
@@ -1,14 +1,8 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
+	rte_eth_from_ring;
 	rte_eth_from_rings;
 
 	local: *;
 };
-
-DPDK_2.2 {
-	global:
-
-	rte_eth_from_ring;
-
-} DPDK_2.0;
drivers/net/sfc/rte_pmd_sfc_version.map +1 -2
index 31eca32ebe..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_17.02 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/softnic/rte_pmd_softnic_version.map +1 -1
index bc44b06f98..50f113d5a2 100644
@@ -1,4 +1,4 @@
-DPDK_17.11 {
+DPDK_20.0 {
 	global:
 
 	rte_pmd_softnic_run;
drivers/net/szedata2/rte_pmd_szedata2_version.map +1 -1
index ad607bbedd..f9f17e4f6e 100644
@@ -1,3 +1,3 @@
-DPDK_2.2 {
+DPDK_20.0 {
 	local: *;
 };
drivers/net/tap/rte_pmd_tap_version.map +1 -2
index 31eca32ebe..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_17.02 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/thunderx/rte_pmd_thunderx_version.map +1 -2
index 1901bcb3b3..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_16.07 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/vdev_netvsc/rte_pmd_vdev_netvsc_version.map +1 -2
index 179140fb87..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.02 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/vhost/rte_pmd_vhost_version.map +3 -8
index 695db85749..16b591ccc4 100644
@@ -1,13 +1,8 @@
-DPDK_16.04 {
+DPDK_20.0 {
 	global:
 
 	rte_eth_vhost_get_queue_event;
-
-	local: *;
-};
-
-DPDK_16.11 {
-	global:
-
 	rte_eth_vhost_get_vid_from_port_id;
+
+	local: *;
 };
drivers/net/virtio/rte_pmd_virtio_version.map +1 -2
index ef35398402..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.0 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/net/vmxnet3/rte_pmd_vmxnet3_version.map +1 -2
index ef35398402..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_2.0 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/raw/dpaa2_cmdif/rte_rawdev_dpaa2_cmdif_version.map +1 -2
index 9b9ab1a4cf..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/raw/dpaa2_qdma/rte_rawdev_dpaa2_qdma_version.map +2 -2
index d16a136fc8..ca6a0d7626 100644
@@ -1,4 +1,4 @@
-DPDK_19.05 {
+DPDK_20.0 {
 	global:
 
 	rte_qdma_attr_get;
@@ -9,9 +9,9 @@ DPDK_19.05 {
 	rte_qdma_start;
 	rte_qdma_stop;
 	rte_qdma_vq_create;
-	rte_qdma_vq_destroy;
 	rte_qdma_vq_dequeue;
 	rte_qdma_vq_dequeue_multi;
+	rte_qdma_vq_destroy;
 	rte_qdma_vq_enqueue;
 	rte_qdma_vq_enqueue_multi;
 	rte_qdma_vq_stats;
drivers/raw/ifpga/rte_rawdev_ifpga_version.map +1 -2
index 9b9ab1a4cf..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.05 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/raw/ioat/rte_rawdev_ioat_version.map +1 -2
index 9a61188cd5..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.08 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/raw/ntb/rte_rawdev_ntb_version.map +2 -3
index 8861484fb3..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.08 {
-
-        local: *;
+DPDK_20.0 {
+	local: *;
 };
drivers/raw/octeontx2_dma/rte_rawdev_octeontx2_dma_version.map +1 -2
index 9a61188cd5..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_19.08 {
-
+DPDK_20.0 {
 	local: *;
 };
drivers/raw/skeleton/rte_rawdev_skeleton_version.map +1 -2
index 179140fb87..f9f17e4f6e 100644
@@ -1,4 +1,3 @@
-DPDK_18.02 {
-
+DPDK_20.0 {
 	local: *;
 };
lib/librte_acl/rte_acl_version.map +1 -1
index b09370a104..c3daca8115 100644
@@ -1,4 +1,4 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
 	rte_acl_add_rules;
lib/librte_bitratestats/rte_bitratestats_version.map +1 -1
index fe7454452d..88fc2912db 100644
@@ -1,4 +1,4 @@
-DPDK_17.05 {
+DPDK_20.0 {
 	global:
 
 	rte_stats_bitrate_calc;
lib/librte_cfgfile/rte_cfgfile_version.map +8 -26
index a0a11cea8d..906eee96bf 100644
@@ -1,40 +1,22 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
+	rte_cfgfile_add_entry;
+	rte_cfgfile_add_section;
 	rte_cfgfile_close;
+	rte_cfgfile_create;
 	rte_cfgfile_get_entry;
 	rte_cfgfile_has_entry;
 	rte_cfgfile_has_section;
 	rte_cfgfile_load;
+	rte_cfgfile_load_with_params;
 	rte_cfgfile_num_sections;
+	rte_cfgfile_save;
 	rte_cfgfile_section_entries;
+	rte_cfgfile_section_entries_by_index;
 	rte_cfgfile_section_num_entries;
 	rte_cfgfile_sections;
+	rte_cfgfile_set_entry;
 
 	local: *;
 };
-
-DPDK_16.04 {
-	global:
-
-	rte_cfgfile_section_entries_by_index;
-
-} DPDK_2.0;
-
-DPDK_17.05 {
-	global:
-
-	rte_cfgfile_load_with_params;
-
-} DPDK_16.04;
-
-DPDK_17.11 {
-	global:
-
-	rte_cfgfile_add_entry;
-	rte_cfgfile_add_section;
-	rte_cfgfile_create;
-	rte_cfgfile_save;
-	rte_cfgfile_set_entry;
-
-} DPDK_17.05;
lib/librte_cmdline/rte_cmdline_version.map +2 -8
index 04bcb387f2..95fce812ff 100644
@@ -1,4 +1,4 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
 	cirbuf_add_buf_head;
@@ -40,6 +40,7 @@ DPDK_2.0 {
 	cmdline_parse_num;
 	cmdline_parse_portlist;
 	cmdline_parse_string;
+	cmdline_poll;
 	cmdline_printf;
 	cmdline_quit;
 	cmdline_set_prompt;
@@ -68,10 +69,3 @@ DPDK_2.0 {
 
 	local: *;
 };
-
-DPDK_2.1 {
-	global:
-
-	cmdline_poll;
-
-} DPDK_2.0;
lib/librte_cryptodev/rte_cryptodev_version.map +36 -66

128 lines not on this page · raw message

lib/librte_distributor/rte_distributor_version.map +3 -1
index 00e26b4804..1b7c643005 100644
@@ -1,4 +1,4 @@
-DPDK_17.05 {
+DPDK_20.0 {
 	global:
 
 	rte_distributor_clear_returns;
@@ -10,4 +10,6 @@ DPDK_17.05 {
 	rte_distributor_request_pkt;
 	rte_distributor_return_pkt;
 	rte_distributor_returned_pkts;
+
+	local: *;
 };
lib/librte_eal/rte_eal_version.map +114 -210

423 lines not on this page · raw message

lib/librte_efd/rte_efd_version.map +1 -1
index ae60a64178..e010eecfe4 100644
@@ -1,4 +1,4 @@
-DPDK_17.02 {
+DPDK_20.0 {
 	global:
 
 	rte_efd_create;
lib/librte_ethdev/rte_ethdev_version.map +47 -113

243 lines not on this page · raw message

lib/librte_eventdev/rte_eventdev_version.map +47 -83

163 lines not on this page · raw message

lib/librte_gro/rte_gro_version.map +1 -1
index 1606b6dc72..9f6fe79e57 100644
@@ -1,4 +1,4 @@
-DPDK_17.08 {
+DPDK_20.0 {
 	global:
 
 	rte_gro_ctx_create;
lib/librte_gso/rte_gso_version.map +1 -1
index e1fd453edb..8505a59c27 100644
@@ -1,4 +1,4 @@
-DPDK_17.11 {
+DPDK_20.0 {
 	global:
 
 	rte_gso_segment;
lib/librte_hash/rte_hash_version.map +9 -34

67 lines not on this page · raw message

lib/librte_ip_frag/rte_ip_frag_version.map +2 -8
index a193007c61..5dd34f828c 100644
@@ -1,8 +1,9 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
 	rte_ip_frag_free_death_row;
 	rte_ip_frag_table_create;
+	rte_ip_frag_table_destroy;
 	rte_ip_frag_table_statistics_dump;
 	rte_ipv4_frag_reassemble_packet;
 	rte_ipv4_fragment_packet;
@@ -12,13 +13,6 @@ DPDK_2.0 {
 	local: *;
 };
 
-DPDK_17.08 {
-	global:
-
-	rte_ip_frag_table_destroy;
-
-} DPDK_2.0;
-
 EXPERIMENTAL {
 	global:
 
lib/librte_jobstats/rte_jobstats_version.map +2 -8
index f89441438e..dbd2664ae2 100644
@@ -1,6 +1,7 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
+	rte_jobstats_abort;
 	rte_jobstats_context_finish;
 	rte_jobstats_context_init;
 	rte_jobstats_context_reset;
@@ -17,10 +18,3 @@ DPDK_2.0 {
 
 	local: *;
 };
-
-DPDK_16.04 {
-	global:
-
-	rte_jobstats_abort;
-
-} DPDK_2.0;
lib/librte_kni/rte_kni_version.map +1 -1
index c877dc6aaa..9cd3cedc54 100644
@@ -1,4 +1,4 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
 	rte_kni_alloc;
lib/librte_kvargs/rte_kvargs_version.map +2 -2
index 8f4b4e3f8f..3ba0f4b59c 100644
@@ -1,4 +1,4 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
 	rte_kvargs_count;
@@ -15,4 +15,4 @@ EXPERIMENTAL {
 	rte_kvargs_parse_delim;
 	rte_kvargs_strcmp;
 
-} DPDK_2.0;
+};
lib/librte_latencystats/rte_latencystats_version.map +1 -1
index ac8403e821..e04e63463f 100644
@@ -1,4 +1,4 @@
-DPDK_17.05 {
+DPDK_20.0 {
 	global:
 
 	rte_latencystats_get;
lib/librte_lpm/rte_lpm_version.map +8 -31
index 90beac853d..500f58b806 100644
@@ -1,13 +1,6 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
-	rte_lpm_add;
-	rte_lpm_create;
-	rte_lpm_delete;
-	rte_lpm_delete_all;
-	rte_lpm_find_existing;
-	rte_lpm_free;
-	rte_lpm_is_rule_present;
 	rte_lpm6_add;
 	rte_lpm6_create;
 	rte_lpm6_delete;
@@ -18,29 +11,13 @@ DPDK_2.0 {
 	rte_lpm6_is_rule_present;
 	rte_lpm6_lookup;
 	rte_lpm6_lookup_bulk_func;
+	rte_lpm_add;
+	rte_lpm_create;
+	rte_lpm_delete;
+	rte_lpm_delete_all;
+	rte_lpm_find_existing;
+	rte_lpm_free;
+	rte_lpm_is_rule_present;
 
 	local: *;
 };
-
-DPDK_16.04 {
-	global:
-
-	rte_lpm_add;
-	rte_lpm_find_existing;
-	rte_lpm_create;
-	rte_lpm_free;
-	rte_lpm_is_rule_present;
-	rte_lpm_delete;
-	rte_lpm_delete_all;
-
-} DPDK_2.0;
-
-DPDK_17.05 {
-	global:
-
-	rte_lpm6_add;
-	rte_lpm6_is_rule_present;
-	rte_lpm6_lookup;
-	rte_lpm6_lookup_bulk_func;
-
-} DPDK_16.04;
lib/librte_mbuf/rte_mbuf_version.map +13 -36

71 lines not on this page · raw message

lib/librte_member/rte_member_version.map +1 -1
index 019e4cd962..87780ae611 100644
@@ -1,4 +1,4 @@
-DPDK_17.11 {
+DPDK_20.0 {
 	global:
 
 	rte_member_add;
lib/librte_mempool/rte_mempool_version.map +13 -31

70 lines not on this page · raw message

lib/librte_meter/rte_meter_version.map +4 -9
index 4b460d5803..46410b0369 100644
@@ -1,21 +1,16 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
 	rte_meter_srtcm_color_aware_check;
 	rte_meter_srtcm_color_blind_check;
 	rte_meter_srtcm_config;
+	rte_meter_srtcm_profile_config;
 	rte_meter_trtcm_color_aware_check;
 	rte_meter_trtcm_color_blind_check;
 	rte_meter_trtcm_config;
-
-	local: *;
-};
-
-DPDK_18.08 {
-	global:
-
-	rte_meter_srtcm_profile_config;
 	rte_meter_trtcm_profile_config;
+
+	local: *;
 };
 
 EXPERIMENTAL {
lib/librte_metrics/rte_metrics_version.map +1 -1
index 6ac99a44a1..85663f356e 100644
@@ -1,4 +1,4 @@
-DPDK_17.05 {
+DPDK_20.0 {
 	global:
 
 	rte_metrics_get_names;
lib/librte_net/rte_net_version.map +6 -17
index fffc4a3723..8a4e75a3a0 100644
@@ -1,25 +1,14 @@
-DPDK_16.11 {
-	global:
-	rte_net_get_ptype;
-
-	local: *;
-};
-
-DPDK_17.05 {
-	global:
-
-	rte_net_crc_calc;
-	rte_net_crc_set_alg;
-
-} DPDK_16.11;
-
-DPDK_19.08 {
+DPDK_20.0 {
 	global:
 
 	rte_eth_random_addr;
 	rte_ether_format_addr;
+	rte_net_crc_calc;
+	rte_net_crc_set_alg;
+	rte_net_get_ptype;
 
-} DPDK_17.05;
+	local: *;
+};
 
 EXPERIMENTAL {
 	global:
lib/librte_pci/rte_pci_version.map +1 -1
index 03790cb0f0..67eb845796 100644
@@ -1,4 +1,4 @@
-DPDK_17.11 {
+DPDK_20.0 {
 	global:
 
 	pci_map_resource;
lib/librte_pdump/rte_pdump_version.map +1 -1
index 3e744f3012..6d02ccce6d 100644
@@ -1,4 +1,4 @@
-DPDK_16.07 {
+DPDK_20.0 {
 	global:
 
 	rte_pdump_disable;
lib/librte_pipeline/rte_pipeline_version.map +9 -27
index 420f065d6e..64d38afecd 100644
@@ -1,6 +1,8 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
+	rte_pipeline_ah_packet_drop;
+	rte_pipeline_ah_packet_hijack;
 	rte_pipeline_check;
 	rte_pipeline_create;
 	rte_pipeline_flush;
@@ -9,42 +11,22 @@ DPDK_2.0 {
 	rte_pipeline_port_in_create;
 	rte_pipeline_port_in_disable;
 	rte_pipeline_port_in_enable;
+	rte_pipeline_port_in_stats_read;
 	rte_pipeline_port_out_create;
 	rte_pipeline_port_out_packet_insert;
+	rte_pipeline_port_out_stats_read;
 	rte_pipeline_run;
 	rte_pipeline_table_create;
 	rte_pipeline_table_default_entry_add;
 	rte_pipeline_table_default_entry_delete;
 	rte_pipeline_table_entry_add;
-	rte_pipeline_table_entry_delete;
-
-	local: *;
-};
-
-DPDK_2.1 {
-	global:
-
-	rte_pipeline_port_in_stats_read;
-	rte_pipeline_port_out_stats_read;
-	rte_pipeline_table_stats_read;
-
-} DPDK_2.0;
-
-DPDK_2.2 {
-	global:
-
 	rte_pipeline_table_entry_add_bulk;
+	rte_pipeline_table_entry_delete;
 	rte_pipeline_table_entry_delete_bulk;
+	rte_pipeline_table_stats_read;
 
-} DPDK_2.1;
-
-DPDK_16.04 {
-	global:
-
-	rte_pipeline_ah_packet_hijack;
-	rte_pipeline_ah_packet_drop;
-
-} DPDK_2.2;
+	local: *;
+};
 
 EXPERIMENTAL {
 	global:
lib/librte_port/rte_port_version.map +17 -47

82 lines not on this page · raw message

lib/librte_power/rte_power_version.map +6 -18
index 7729838137..55a168f56e 100644
@@ -1,39 +1,27 @@
-DPDK_2.0 {
+DPDK_20.0 {
 	global:
 
 	rte_power_exit;
+	rte_power_freq_disable_turbo;
 	rte_power_freq_down;
+	rte_power_freq_enable_turbo;
 	rte_power_freq_max;
[… more lines in the raw message]

Lines of this file are not shown. View the raw message.

lib/librte_rawdev/rte_rawdev_version.map +2 -2
index b61dbff11c..d847c9e0d3 100644

Lines of this file are not shown. View the raw message.

lib/librte_reorder/rte_reorder_version.map +4 -4
index 0a8a54de83..cf444062df 100644

Lines of this file are not shown. View the raw message.

lib/librte_ring/rte_ring_version.map +2 -8
index 510c1386e0..89d84bcf48 100644

Lines of this file are not shown. View the raw message.

lib/librte_sched/rte_sched_version.map +4 -10
index f33761e63e..cefd990367 100644

Lines of this file are not shown. View the raw message.

lib/librte_security/rte_security_version.map +1 -1
index 53267bf3cc..b07314bbf4 100644

Lines of this file are not shown. View the raw message.

lib/librte_table/rte_table_version.map +1 -1
index 6237252bec..40f72b1fe8 100644

Lines of this file are not shown. View the raw message.

lib/librte_timer/rte_timer_version.map +1 -11
index 72f75c8181..2a59d3f081 100644

Lines of this file are not shown. View the raw message.

lib/librte_vhost/rte_vhost_version.map +11 -41

52 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.17.1

Part of the diff is not shown here. View the raw message.

#103 lore raw

Re: [dpdk-dev] [PATCH v7 09/10] build: change ABI version to 20.0

Reduced the Cc: list.

Quoted 9 lines · Anatoly Burakov

From: Pawel Modrak <[email protected]>

Merge all vesions in linker version script files to DPDK_20.0.

This commit was generated by running the following command:

:~/DPDK$ buildtools/update-abi.sh 20.0

I inspected the changes.
I caught just 3 oddities.
The first two were reported in the patches on timer and lpm.

The last one is in the dpaa bus driver:

Quoted 15 lines
drivers/bus/dpaa/rte_bus_dpaa_version.map +0 -11
index cf428a54dc..e6ca4361e0 100644
-DPDK_18.08 {
-       global:
-
-       fman_if_get_sg_enable;
-       fman_if_set_sg;
-
-} DPDK_18.02;
-
-DPDK_18.11 {
-       global:
-

drivers/bus/dpaa/rte_bus_dpaa_version.map DPDK_17.11 { · line 111

Quoted 10 lines
drivers/bus/dpaa/rte_bus_dpaa_version.map +0 -8
-       bman_thread_irq;
-       fman_if_get_sg_enable;
-       fman_if_set_sg;
-       qman_clear_irq;
-
-       qman_irqsource_add;
-       qman_irqsource_remove;
        qman_thread_fd;
        qman_thread_irq;
-

Here, we had fman_if_get_sg_enable and fman_if_set_sg in 18.08 and 18.11 sections, but no symbols for 18.08 were in the code. I'd say this is fine, as there was no ABI change between 18.08 and 18.11 on them.

The rest of the series looks good to me.
Thanks Anatoly.

Signature · 1 line
David Marchand
#104 lore raw

Re: [dpdk-dev] [PATCH v7 09/10] build: change ABI version to 20.0

Quoted 56 lines

-----Original Message-----
From: David Marchand <[email protected]>
Sent: Wednesday, November 20, 2019 3:20 AM
To: Anatoly Burakov <[email protected]>; Thomas Monjalon <[email protected]>
Cc: dev <[email protected]>; Hemant Agrawal <[email protected]>; Sachin Saxena <[email protected]>; Stephen Hemminger <[email protected]>; Mcnamara, John <[email protected]>; Kinsella, Ray <[email protected]>; Bruce Richardson <[email protected]>
Subject: Re: [PATCH v7 09/10] build: change ABI version to 20.0
Importance: High

Reduced the Cc: list.

Quoted 9 lines · Anatoly Burakov

From: Pawel Modrak <[email protected]>

Merge all vesions in linker version script files to DPDK_20.0.

This commit was generated by running the following command:

:~/DPDK$ buildtools/update-abi.sh 20.0

I inspected the changes.
I caught just 3 oddities.
The first two were reported in the patches on timer and lpm.

The last one is in the dpaa bus driver:

Quoted 23 lines
drivers/bus/dpaa/rte_bus_dpaa_version.map +0 -18
index cf428a54dc..e6ca4361e0 100644
-DPDK_18.08 {
-       global:
-
-       fman_if_get_sg_enable;
-       fman_if_set_sg;
-
-} DPDK_18.02;
-
-DPDK_18.11 {
-       global:
-
-       bman_thread_irq;
-       fman_if_get_sg_enable;
-       fman_if_set_sg;
-       qman_clear_irq;
-
-       qman_irqsource_add;
-       qman_irqsource_remove;
Quoted 9 lines
Quoted 3 lines
        qman_thread_fd;
        qman_thread_irq;

-

Here, we had fman_if_get_sg_enable and fman_if_set_sg in 18.08 and 18.11 sections, but no symbols for 18.08 were in the code. I'd say this is fine, as there was no ABI change between 18.08 and 18.11 on them.

[Sachin Saxena] Yes, we are also fine with this.

Quoted 7 lines

The rest of the series looks good to me.
Thanks Anatoly.

--
David Marchand

#105 lore raw

Re: [dpdk-dev] [PATCH v7 09/10] build: change ABI version to 20.0

In reply to Anatoly Burakov

08/11/2019 17:25, Anatoly Burakov:

Quoted 6 lines

From: Pawel Modrak <[email protected]>

Merge all vesions in linker version script files to DPDK_20.0.

This commit was generated by running the following command:

Quoted 7 lines
:~/DPDK$ buildtools/update-abi.sh 20.0

---

 148 files changed, 698 insertions(+), 1433 deletions(-)

That's really fantastic to have a tool doing that job! Hopefully the diff will be smaller in next versions.

Question: should we run this script at the beginning of each version, while incrementing the version numbers?

#106 lore raw

PATCH v7 10/10 buildtools: add ABI versioning check script

In reply to Anatoly Burakov

From: Marcin Baran <[email protected]>

Add a shell script that checks whether built libraries are versioned with expected ABI (current ABI, current ABI + 1, or EXPERIMENTAL).

The following command was used to verify current source tree (assuming build directory is in ./build):

find ./build/lib ./build/drivers -name \*.so \
-exec ./buildtools/check-abi-version.sh {} \; -print

---

Notes:
v2:
- Moved this to the end of the patchset
- Fixed bug when ABI symbols were not found because the .so did not declare any public symbols

 buildtools/check-abi-version.sh | 54 +++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)
 create mode 100755 buildtools/check-abi-version.sh
buildtools/check-abi-version.sh new file +54 -0
new file mode 100755
index 0000000000..29aea97735
@@ -0,0 +1,54 @@
+#!/bin/sh
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2019 Intel Corporation
+
+# Check whether library symbols have correct
+# version (provided ABI number or provided ABI
+# number + 1 or EXPERIMENTAL).
+# Args:
+#   $1: path of the library .so file
+#   $2: ABI major version number to check
+#       (defaults to ABI_VERSION file value)
+
+if [ -z "$1" ]; then
+    echo "Script checks whether library symbols have"
+    echo "correct version (ABI_VER/ABI_VER+1/EXPERIMENTAL)"
+    echo "Usage:"
+    echo "  $0 SO_FILE_PATH [ABI_VER]"
+    exit 1
+fi
+
+LIB="$1"
+DEFAULT_ABI=$(cat "$(dirname \
+            $(readlink -f $0))/../config/ABI_VERSION" | \
+            cut -d'.' -f 1)
+ABIVER="DPDK_${2-$DEFAULT_ABI}"
+NEXT_ABIVER="DPDK_$((${2-$DEFAULT_ABI}+1))"
+
+ret=0
+
+# get output of objdump
+OBJ_DUMP_OUTPUT=`objdump -TC --section=.text ${LIB} 2>&1 | grep ".text"`
+
+# there may not be any .text sections in the .so file, in which case exit early
+echo "${OBJ_DUMP_OUTPUT}" | grep "not found in any input file" -q
+if [ "$?" -eq 0 ]; then
+    exit 0
+fi
+
+# we have symbols, so let's see if the versions are correct
+for SYM in `echo "${OBJ_DUMP_OUTPUT}" | awk '{print $(NF-1) "-" $NF}'`
+do
+    version=$(echo $SYM | cut -d'-' -f 1)
+    symbol=$(echo $SYM | cut -d'-' -f 2)
+    case $version in (*"$ABIVER"*|*"$NEXT_ABIVER"*|"EXPERIMENTAL")
+        ;;
+    (*)
+        echo "Warning: symbol $symbol ($version) should be annotated " \
+             "as ABI version $ABIVER / $NEXT_ABIVER, or EXPERIMENTAL."
+        ret=1
+    ;;
+    esac
+done
+
+exit $ret
Signature · 1 line
2.17.1
#107 lore raw

Re: [dpdk-dev] [PATCH v7 10/10] buildtools: add ABI versioning check script

08/11/2019 17:25, Anatoly Burakov:

Quoted 2 lines

From: Marcin Baran <[email protected]>
+ echo "correct version (ABI_VER/ABI_VER+1/EXPERIMENTAL)"

I don't get why a symbol could be versioned for the next ABI? Assuming we upgrade the ABI version at the beginning of the cycle, every symbols should have the same version, right?

Quoted 1 line

+for SYM in echo "${OBJ_DUMP_OUTPUT}" | awk '{print $(NF-1) "-" $NF}'

Please, I really prefer we use the modern $() instead of backquotes.

#108 lore raw

v8 cover Implement the new ABI policy and add helper scripts

In reply to Anatoly Burakov

This patchset prepares the codebase for the new ABI policy and adds a few helper scripts.

There are two new scripts for managing ABI versions added. The first one is a Python script that will read in a .map file, flatten it and update the ABI version to the ABI version specified on the command-line.

The second one is a shell script that will run the above mentioned Python script recursively over the source tree and set the ABI version to either that which is defined in ABI_VERSION, or a user-specified one.

Example of its usage: buildtools/update-abi.sh 20.0

This will recurse into lib/ and drivers/ directory and update whatever .map files it can find.

The other shell script that's added is one that can take in a .so file and ensure that its declared public ABI matches either current ABI, next ABI, or EXPERIMENTAL. This was moved to the last commit because it made no sense to have it beforehand.

The source tree was verified to follow the new ABI policy using the following command (assuming built binaries are in build/):

find ./build/lib ./build/drivers -name \*.so \
-exec ./buildtools/check-abi-version.sh {} \; -print

This returns 0.

Changes since v7:
- Addressed review feedback from Thomas regarding scripts
- Addressed David's suggestion to remove old ABI from timer/lpm
- Changed the way that experimental libraries are versioned (they are now versioned using the same major/minor ABI versions, but are constructed differently (e.g. 0.201 for 20.1 release)
- Removed CONFIG_RTE_MAJOR_ABI from base config
- Removed traces of individual library versioning
- Adjusted the ABI policy documentation to state that minor ABI version is bumped every release for both stable and experimental ABI

Changes since v6:
- Rebase on top of latest master
- Fixed map file generation to generate stable ABI if it was there, even if it was empty

Changes since v5:
- Addressed David's comments regarding libtool error messages
- Fixed map file generation to not generate empty stable ABI if it wasn't there before

Changes since v4:
- Fixed shared library build issue for distributor

Changes since v3:
- Put distributor code back and cleaned it up
- Rebased on latest master and regenerated commit 9

Changes since v2:
- Addressed Bruce's review comments
- Removed single distributor mode as per Dave's suggestion

Changes since v1:
- Reordered patchset to have removal of old ABI's before introducing the new one to avoid compile breakages between patches
- Added a new patch fixing missing symbol in octeontx common
- Split script commits into multiple commits and reordered them
- Re-generated the ABI bump commit
- Verified all scripts to work

Anatoly Burakov (4):
config: remove CONFIG_RTE_MAJOR_ABI option
build: remove individual library versions
buildtools: add ABI update shell script
drivers/octeontx: add missing public symbol

Marcin Baran (6):
config: change ABI versioning to global
timer: remove deprecated code
lpm: remove deprecated code
distributor: remove deprecated code
distributor: rename v2.0 ABI to _single suffix
buildtools: add ABI versioning check script

Pawel Modrak (2):
buildtools: add script for updating symbols abi version
build: change ABI version to 20.0

 ABI_VERSION                                   |    1 +
 buildtools/check-abi-version.sh               |   54 +
 buildtools/meson.build                        |    3 +
 buildtools/update-abi.sh                      |   46 +
 buildtools/update_version_map_abi.py          |  175 +++
 config/common_base                            |    5 -
 config/meson.build                            |    7 +-
 doc/guides/contributing/abi_versioning.rst    |   17 +-
 doc/guides/contributing/coding_style.rst      |    8 +-
 drivers/baseband/fpga_lte_fec/Makefile        |    3 -
 .../rte_pmd_bbdev_fpga_lte_fec_version.map    |    8 +-
 drivers/baseband/null/Makefile                |    3 -
 .../null/rte_pmd_bbdev_null_version.map       |    2 +-
 drivers/baseband/turbo_sw/Makefile            |    3 -
 .../rte_pmd_bbdev_turbo_sw_version.map        |    2 +-
 drivers/bus/dpaa/Makefile                     |    2 -
 drivers/bus/dpaa/meson.build                  |    2 -
 drivers/bus/dpaa/rte_bus_dpaa_version.map     |  113 +-
 drivers/bus/fslmc/Makefile                    |    3 -
 drivers/bus/fslmc/meson.build                 |    2 -
 drivers/bus/fslmc/rte_bus_fslmc_version.map   |  154 +--
 drivers/bus/ifpga/Makefile                    |    3 -
 drivers/bus/ifpga/meson.build                 |    2 -
 drivers/bus/ifpga/rte_bus_ifpga_version.map   |   14 +-
 drivers/bus/pci/Makefile                      |    1 -
 drivers/bus/pci/meson.build                   |    2 -
 drivers/bus/pci/rte_bus_pci_version.map       |    2 +-
 drivers/bus/vdev/Makefile                     |    3 -
 drivers/bus/vdev/meson.build                  |    2 -
 drivers/bus/vdev/rte_bus_vdev_version.map     |   12 +-
 drivers/bus/vmbus/Makefile                    |    1 -
 drivers/bus/vmbus/meson.build                 |    2 -
 drivers/bus/vmbus/rte_bus_vmbus_version.map   |   12 +-
 drivers/common/cpt/Makefile                   |    2 -
 drivers/common/cpt/rte_common_cpt_version.map |    9 +-
 drivers/common/dpaax/Makefile                 |    3 -
 .../common/dpaax/rte_common_dpaax_version.map |   14 +-
 drivers/common/mvep/Makefile                  |    3 -
 .../common/mvep/rte_common_mvep_version.map   |    6 +-
 drivers/common/octeontx/Makefile              |    2 -
 .../octeontx/rte_common_octeontx_version.map  |    7 +-
 drivers/common/octeontx2/Makefile             |    2 -
 .../rte_common_octeontx2_version.map          |   16 +-
 drivers/compress/isal/Makefile                |    3 -
 .../compress/isal/rte_pmd_isal_version.map    |    2 +-
 drivers/compress/octeontx/Makefile            |    3 -
 .../rte_pmd_octeontx_compress_version.map     |    2 +-
 drivers/compress/qat/rte_pmd_qat_version.map  |    2 +-
 drivers/compress/zlib/Makefile                |    3 -
 .../compress/zlib/rte_pmd_zlib_version.map    |    2 +-
 drivers/crypto/aesni_gcm/Makefile             |    3 -
 .../aesni_gcm/rte_pmd_aesni_gcm_version.map   |    2 +-
 drivers/crypto/aesni_mb/Makefile              |    3 -
 .../aesni_mb/rte_pmd_aesni_mb_version.map     |    2 +-
 drivers/crypto/armv8/Makefile                 |    3 -
 .../crypto/armv8/rte_pmd_armv8_version.map    |    2 +-
 drivers/crypto/caam_jr/Makefile               |    3 -
 .../caam_jr/rte_pmd_caam_jr_version.map       |    3 +-
 drivers/crypto/ccp/Makefile                   |    3 -
 drivers/crypto/ccp/rte_pmd_ccp_version.map    |    3 +-
 drivers/crypto/dpaa2_sec/Makefile             |    3 -
 drivers/crypto/dpaa2_sec/meson.build          |    2 -
 .../dpaa2_sec/rte_pmd_dpaa2_sec_version.map   |   10 +-
 drivers/crypto/dpaa_sec/Makefile              |    3 -
 .../dpaa_sec/rte_pmd_dpaa_sec_version.map     |   10 +-
 drivers/crypto/kasumi/Makefile                |    3 -
 .../crypto/kasumi/rte_pmd_kasumi_version.map  |    2 +-
 drivers/crypto/mvsam/Makefile                 |    3 -
 .../crypto/mvsam/rte_pmd_mvsam_version.map    |    2 +-
 drivers/crypto/nitrox/Makefile                |    3 -
 .../crypto/nitrox/rte_pmd_nitrox_version.map  |    2 +-
 drivers/crypto/null/Makefile                  |    3 -
 .../null/rte_pmd_null_crypto_version.map      |    2 +-
 drivers/crypto/octeontx/Makefile              |    3 -
 .../rte_pmd_octeontx_crypto_version.map       |    3 +-
 drivers/crypto/octeontx2/Makefile             |    3 -
 .../rte_pmd_octeontx2_crypto_version.map      |    3 +-
 drivers/crypto/openssl/Makefile               |    3 -
 .../openssl/rte_pmd_openssl_version.map       |    2 +-
 drivers/crypto/scheduler/Makefile             |    3 -
 .../rte_pmd_crypto_scheduler_version.map      |   19 +-
 drivers/crypto/snow3g/Makefile                |    3 -
 .../crypto/snow3g/rte_pmd_snow3g_version.map  |    2 +-
 drivers/crypto/virtio/Makefile                |    2 -
 .../virtio/rte_pmd_virtio_crypto_version.map  |    2 +-
 drivers/crypto/zuc/Makefile                   |    3 -
 drivers/crypto/zuc/rte_pmd_zuc_version.map    |    2 +-
 drivers/event/dpaa/Makefile                   |    2 -
 .../event/dpaa/rte_pmd_dpaa_event_version.map |    3 +-
 drivers/event/dpaa2/Makefile                  |    2 -
 drivers/event/dpaa2/meson.build               |    2 -
 .../dpaa2/rte_pmd_dpaa2_event_version.map     |    2 +-
 drivers/event/dsw/Makefile                    |    2 -
 .../event/dsw/rte_pmd_dsw_event_version.map   |    2 +-
 drivers/event/octeontx/Makefile               |    2 -
 .../rte_pmd_octeontx_event_version.map        |    2 +-
 drivers/event/octeontx2/Makefile              |    2 -
 .../rte_pmd_octeontx2_event_version.map       |    3 +-
 drivers/event/opdl/Makefile                   |    3 -
 .../event/opdl/rte_pmd_opdl_event_version.map |    2 +-
 drivers/event/skeleton/Makefile               |    2 -
 .../rte_pmd_skeleton_event_version.map        |    3 +-
 drivers/event/sw/Makefile                     |    3 -
 drivers/event/sw/rte_pmd_sw_event_version.map |    2 +-
 drivers/mempool/bucket/Makefile               |    2 -
 .../bucket/rte_mempool_bucket_version.map     |    3 +-
 drivers/mempool/dpaa/Makefile                 |    3 -
 .../mempool/dpaa/rte_mempool_dpaa_version.map |    2 +-
 drivers/mempool/dpaa2/Makefile                |    3 -
 drivers/mempool/dpaa2/meson.build             |    2 -
 .../dpaa2/rte_mempool_dpaa2_version.map       |   12 +-
 drivers/mempool/octeontx/Makefile             |    2 -
 .../octeontx/rte_mempool_octeontx_version.map |    2 +-
 drivers/mempool/octeontx2/Makefile            |    2 -
 .../rte_mempool_octeontx2_version.map         |    4 +-
 drivers/mempool/ring/Makefile                 |    2 -
 .../mempool/ring/rte_mempool_ring_version.map |    3 +-
 drivers/mempool/stack/Makefile                |    2 -
 .../stack/rte_mempool_stack_version.map       |    3 +-
 drivers/meson.build                           |   18 +-
 drivers/net/af_packet/Makefile                |    2 -
 .../af_packet/rte_pmd_af_packet_version.map   |    3 +-
 drivers/net/af_xdp/Makefile                   |    2 -
 drivers/net/af_xdp/rte_pmd_af_xdp_version.map |    2 +-
 drivers/net/ark/Makefile                      |    2 -
 drivers/net/ark/rte_pmd_ark_version.map       |    5 +-
 drivers/net/atlantic/Makefile                 |    2 -
 .../net/atlantic/rte_pmd_atlantic_version.map |    4 +-
 drivers/net/avp/Makefile                      |    2 -
 drivers/net/avp/rte_pmd_avp_version.map       |    2 +-
 drivers/net/axgbe/Makefile                    |    2 -
 drivers/net/axgbe/rte_pmd_axgbe_version.map   |    2 +-
 drivers/net/bnx2x/Makefile                    |    2 -
 drivers/net/bnx2x/rte_pmd_bnx2x_version.map   |    3 +-
 drivers/net/bnxt/Makefile                     |    2 -
 drivers/net/bnxt/meson.build                  |    1 -
 drivers/net/bnxt/rte_pmd_bnxt_version.map     |    4 +-
 drivers/net/bonding/Makefile                  |    2 -
 drivers/net/bonding/meson.build               |    1 -
 drivers/net/bonding/rte_pmd_bond_version.map  |   47 +-
 drivers/net/cxgbe/Makefile                    |    2 -
 drivers/net/cxgbe/rte_pmd_cxgbe_version.map   |    3 +-
 drivers/net/dpaa/Makefile                     |    2 -
 drivers/net/dpaa/rte_pmd_dpaa_version.map     |   11 +-
 drivers/net/dpaa2/Makefile                    |    3 -
 drivers/net/dpaa2/meson.build                 |    2 -
 drivers/net/dpaa2/rte_pmd_dpaa2_version.map   |   12 +-
 drivers/net/e1000/Makefile                    |    2 -
 drivers/net/e1000/rte_pmd_e1000_version.map   |    3 +-
 drivers/net/ena/Makefile                      |    2 -
 drivers/net/ena/rte_pmd_ena_version.map       |    3 +-
 drivers/net/enetc/Makefile                    |    2 -
 drivers/net/enetc/rte_pmd_enetc_version.map   |    3 +-
 drivers/net/enic/Makefile                     |    2 -
 drivers/net/enic/rte_pmd_enic_version.map     |    3 +-
 drivers/net/failsafe/Makefile                 |    2 -
 .../net/failsafe/rte_pmd_failsafe_version.map |    3 +-
 drivers/net/fm10k/Makefile                    |    2 -
 drivers/net/fm10k/rte_pmd_fm10k_version.map   |    3 +-
 drivers/net/hinic/Makefile                    |    2 -
 drivers/net/hinic/rte_pmd_hinic_version.map   |    3 +-
 drivers/net/hns3/Makefile                     |    2 -
 drivers/net/hns3/rte_pmd_hns3_version.map     |    4 +-
 drivers/net/i40e/Makefile                     |    2 -
 drivers/net/i40e/meson.build                  |    2 -
 drivers/net/i40e/rte_pmd_i40e_version.map     |   65 +-
 drivers/net/iavf/Makefile                     |    2 -
 drivers/net/iavf/rte_pmd_iavf_version.map     |    3 +-
 drivers/net/ice/Makefile                      |    2 -
 drivers/net/ice/rte_pmd_ice_version.map       |    3 +-
 drivers/net/ifc/Makefile                      |    2 -
 drivers/net/ifc/rte_pmd_ifc_version.map       |    3 +-
 drivers/net/ipn3ke/Makefile                   |    2 -
 drivers/net/ipn3ke/rte_pmd_ipn3ke_version.map |    3 +-
 drivers/net/ixgbe/Makefile                    |    2 -
 drivers/net/ixgbe/meson.build                 |    2 -
 drivers/net/ixgbe/rte_pmd_ixgbe_version.map   |   62 +-
 drivers/net/kni/Makefile                      |    2 -
 drivers/net/kni/rte_pmd_kni_version.map       |    3 +-
 drivers/net/liquidio/Makefile                 |    2 -
 .../net/liquidio/rte_pmd_liquidio_version.map |    3 +-
 drivers/net/memif/Makefile                    |    2 -
 drivers/net/memif/rte_pmd_memif_version.map   |    5 +-
 drivers/net/mlx4/Makefile                     |    2 -
 drivers/net/mlx4/rte_pmd_mlx4_version.map     |    3 +-
 drivers/net/mlx5/Makefile                     |    2 -
 drivers/net/mlx5/rte_pmd_mlx5_version.map     |    2 +-
 drivers/net/mvneta/Makefile                   |    3 -
 drivers/net/mvneta/rte_pmd_mvneta_version.map |    2 +-
 drivers/net/mvpp2/Makefile                    |    3 -
 drivers/net/mvpp2/rte_pmd_mvpp2_version.map   |    2 +-
 drivers/net/netvsc/Makefile                   |    2 -
 drivers/net/netvsc/meson.build                |    1 -
 drivers/net/netvsc/rte_pmd_netvsc_version.map |    4 +-
 drivers/net/nfb/Makefile                      |    2 -
 drivers/net/nfb/rte_pmd_nfb_version.map       |    3 +-
 drivers/net/nfp/Makefile                      |    2 -
 drivers/net/nfp/rte_pmd_nfp_version.map       |    2 +-
 drivers/net/null/Makefile                     |    2 -
 drivers/net/null/meson.build                  |    1 -
 drivers/net/null/rte_pmd_null_version.map     |    3 +-
 drivers/net/octeontx/Makefile                 |    2 -
 .../net/octeontx/rte_pmd_octeontx_version.map |   10 +-
 drivers/net/octeontx2/Makefile                |    2 -
 .../octeontx2/rte_pmd_octeontx2_version.map   |    3 +-
 drivers/net/pcap/Makefile                     |    2 -
 drivers/net/pcap/rte_pmd_pcap_version.map     |    3 +-
 drivers/net/pfe/Makefile                      |    2 -
 drivers/net/pfe/rte_pmd_pfe_version.map       |    3 +-
 drivers/net/qede/Makefile                     |    2 -
 drivers/net/qede/rte_pmd_qede_version.map     |    3 +-
 drivers/net/ring/Makefile                     |    2 -
 drivers/net/ring/meson.build                  |    1 -
 drivers/net/ring/rte_pmd_ring_version.map     |   10 +-
 drivers/net/sfc/Makefile                      |    2 -
 drivers/net/sfc/rte_pmd_sfc_version.map       |    3 +-
 drivers/net/softnic/Makefile                  |    2 -
 .../net/softnic/rte_pmd_softnic_version.map   |    2 +-
 drivers/net/szedata2/Makefile                 |    2 -
 .../net/szedata2/rte_pmd_szedata2_version.map |    2 +-
 drivers/net/tap/Makefile                      |    2 -
 drivers/net/tap/rte_pmd_tap_version.map       |    3 +-
 drivers/net/thunderx/Makefile                 |    2 -
 .../net/thunderx/rte_pmd_thunderx_version.map |    3 +-
 drivers/net/vdev_netvsc/Makefile              |    1 -
 .../rte_pmd_vdev_netvsc_version.map           |    3 +-
 drivers/net/vhost/Makefile                    |    2 -
 drivers/net/vhost/meson.build                 |    1 -
 drivers/net/vhost/rte_pmd_vhost_version.map   |   11 +-
 drivers/net/virtio/Makefile                   |    2 -
 drivers/net/virtio/rte_pmd_virtio_version.map |    3 +-
 drivers/net/vmxnet3/Makefile                  |    2 -
 .../net/vmxnet3/rte_pmd_vmxnet3_version.map   |    3 +-
 drivers/raw/dpaa2_cmdif/Makefile              |    2 -
 drivers/raw/dpaa2_cmdif/meson.build           |    2 -
 .../rte_rawdev_dpaa2_cmdif_version.map        |    3 +-
 drivers/raw/dpaa2_qdma/Makefile               |    2 -
 drivers/raw/dpaa2_qdma/meson.build            |    2 -
 .../rte_rawdev_dpaa2_qdma_version.map         |    4 +-
 drivers/raw/ifpga/Makefile                    |    2 -
 drivers/raw/ifpga/meson.build                 |    2 -
 .../raw/ifpga/rte_rawdev_ifpga_version.map    |    3 +-
 drivers/raw/ioat/Makefile                     |    3 -
 drivers/raw/ioat/rte_rawdev_ioat_version.map  |    3 +-
 drivers/raw/ntb/Makefile                      |    2 -
 drivers/raw/ntb/rte_rawdev_ntb_version.map    |    5 +-
 drivers/raw/octeontx2_dma/Makefile            |    2 -
 .../rte_rawdev_octeontx2_dma_version.map      |    3 +-
 drivers/raw/skeleton/Makefile                 |    2 -
 .../skeleton/rte_rawdev_skeleton_version.map  |    3 +-
 examples/ethtool/lib/Makefile                 |    2 -
 lib/librte_acl/Makefile                       |    2 -
 lib/librte_acl/meson.build                    |    1 -
 lib/librte_acl/rte_acl_version.map            |    2 +-
 lib/librte_bbdev/Makefile                     |    3 -
 lib/librte_bitratestats/Makefile              |    2 -
 lib/librte_bitratestats/meson.build           |    1 -
 .../rte_bitratestats_version.map              |    2 +-
 lib/librte_bpf/Makefile                       |    2 -
 lib/librte_cfgfile/Makefile                   |    2 -
 lib/librte_cfgfile/meson.build                |    1 -
 lib/librte_cfgfile/rte_cfgfile_version.map    |   34 +-
 lib/librte_cmdline/Makefile                   |    2 -
 lib/librte_cmdline/meson.build                |    1 -
 lib/librte_cmdline/rte_cmdline_version.map    |   10 +-
 lib/librte_compressdev/Makefile               |    3 -
 lib/librte_cryptodev/Makefile                 |    3 -
 lib/librte_cryptodev/meson.build              |    1 -
 .../rte_cryptodev_version.map                 |  102 +-
 lib/librte_distributor/Makefile               |    4 +-
 lib/librte_distributor/distributor_private.h  |   10 +-
 lib/librte_distributor/meson.build            |    2 +-
 lib/librte_distributor/rte_distributor.c      |   98 +-
 ...ributor_v20.c => rte_distributor_single.c} |   73 +-
 ...ributor_v20.h => rte_distributor_single.h} |   26 +-
 .../rte_distributor_v1705.h                   |   61 -
 .../rte_distributor_version.map               |   16 +-
 lib/librte_eal/freebsd/eal/Makefile           |    2 -
 lib/librte_eal/linux/eal/Makefile             |    2 -
 lib/librte_eal/rte_eal_version.map            |  324 ++----
 lib/librte_efd/Makefile                       |    2 -
 lib/librte_efd/rte_efd_version.map            |    2 +-
 lib/librte_ethdev/Makefile                    |    2 -
 lib/librte_ethdev/meson.build                 |    1 -
 lib/librte_ethdev/rte_ethdev_version.map      |  160 +--
 lib/librte_eventdev/Makefile                  |    3 -
 lib/librte_eventdev/meson.build               |    1 -
 lib/librte_eventdev/rte_eventdev_version.map  |  130 +--
 lib/librte_fib/Makefile                       |    2 -
 lib/librte_flow_classify/Makefile             |    2 -
 lib/librte_gro/Makefile                       |    2 -
 lib/librte_gro/rte_gro_version.map            |    2 +-
 lib/librte_gso/Makefile                       |    2 -
 lib/librte_gso/rte_gso_version.map            |    2 +-
 lib/librte_hash/Makefile                      |    2 -
 lib/librte_hash/meson.build                   |    1 -
 lib/librte_hash/rte_hash_version.map          |   43 +-
 lib/librte_ip_frag/Makefile                   |    2 -
 lib/librte_ip_frag/rte_ip_frag_version.map    |   10 +-
 lib/librte_ipsec/Makefile                     |    2 -
 lib/librte_ipsec/meson.build                  |    1 -
 lib/librte_jobstats/Makefile                  |    2 -
 lib/librte_jobstats/rte_jobstats_version.map  |   10 +-
 lib/librte_kni/Makefile                       |    2 -
 lib/librte_kni/meson.build                    |    1 -
 lib/librte_kni/rte_kni_version.map            |    2 +-
 lib/librte_kvargs/Makefile                    |    2 -
 lib/librte_kvargs/meson.build                 |    1 -
 lib/librte_kvargs/rte_kvargs_version.map      |    4 +-
 lib/librte_latencystats/Makefile              |    2 -
 .../rte_latencystats_version.map              |    2 +-
 lib/librte_lpm/Makefile                       |    2 -
 lib/librte_lpm/meson.build                    |    1 -
 lib/librte_lpm/rte_lpm.c                      | 1010 +----------------
 lib/librte_lpm/rte_lpm.h                      |   88 --
 lib/librte_lpm/rte_lpm6.c                     |  140 +--
 lib/librte_lpm/rte_lpm6.h                     |   25 -
 lib/librte_lpm/rte_lpm_version.map            |   39 +-
 lib/librte_mbuf/Makefile                      |    2 -
 lib/librte_mbuf/meson.build                   |    1 -
 lib/librte_mbuf/rte_mbuf_version.map          |   49 +-
 lib/librte_member/Makefile                    |    2 -
 lib/librte_member/rte_member_version.map      |    2 +-
 lib/librte_mempool/Makefile                   |    2 -
 lib/librte_mempool/meson.build                |    1 -
 lib/librte_mempool/rte_mempool_version.map    |   44 +-
 lib/librte_meter/Makefile                     |    2 -
 lib/librte_meter/meson.build                  |    1 -
 lib/librte_meter/rte_meter_version.map        |   13 +-
 lib/librte_metrics/Makefile                   |    2 -
 lib/librte_metrics/rte_metrics_version.map    |    2 +-
 lib/librte_net/Makefile                       |    2 -
 lib/librte_net/meson.build                    |    1 -
 lib/librte_net/rte_net_version.map            |   23 +-
 lib/librte_pci/Makefile                       |    2 -
 lib/librte_pci/meson.build                    |    2 -
 lib/librte_pci/rte_pci_version.map            |    2 +-
 lib/librte_pdump/Makefile                     |    2 -
 lib/librte_pdump/meson.build                  |    1 -
 lib/librte_pdump/rte_pdump_version.map        |    2 +-
 lib/librte_pipeline/Makefile                  |    2 -
 lib/librte_pipeline/meson.build               |    1 -
 lib/librte_pipeline/rte_pipeline_version.map  |   36 +-
 lib/librte_port/Makefile                      |    2 -
 lib/librte_port/meson.build                   |    1 -
 lib/librte_port/rte_port_version.map          |   64 +-
 lib/librte_power/Makefile                     |    2 -
 lib/librte_power/rte_power_version.map        |   24 +-
 lib/librte_rawdev/Makefile                    |    3 -
 lib/librte_rawdev/rte_rawdev_version.map      |    4 +-
 lib/librte_rcu/Makefile                       |    2 -
 lib/librte_reorder/Makefile                   |    2 -
 lib/librte_reorder/rte_reorder_version.map    |    8 +-
 lib/librte_rib/Makefile                       |    2 -
 lib/librte_ring/Makefile                      |    2 -
 lib/librte_ring/meson.build                   |    1 -
 lib/librte_ring/rte_ring_version.map          |   10 +-
 lib/librte_sched/Makefile                     |    2 -
 lib/librte_sched/meson.build                  |    1 -
 lib/librte_sched/rte_sched_version.map        |   14 +-
 lib/librte_security/Makefile                  |    3 -
 lib/librte_security/meson.build               |    1 -
 lib/librte_security/rte_security_version.map  |    2 +-
 lib/librte_stack/Makefile                     |    2 -
 lib/librte_stack/meson.build                  |    1 -
 lib/librte_table/Makefile                     |    2 -
 lib/librte_table/meson.build                  |    1 -
 lib/librte_table/rte_table_version.map        |    2 +-
 lib/librte_telemetry/Makefile                 |    2 -
 lib/librte_timer/Makefile                     |    2 -
 lib/librte_timer/rte_timer.c                  |  100 +-
 lib/librte_timer/rte_timer.h                  |   15 -
 lib/librte_timer/rte_timer_version.map        |   12 +-
 lib/librte_vhost/Makefile                     |    2 -
 lib/librte_vhost/meson.build                  |    1 -
 lib/librte_vhost/rte_vhost_version.map        |   52 +-
 lib/meson.build                               |   17 +-
 meson_options.txt                             |    2 -
 mk/rte.lib.mk                                 |   14 +-
 379 files changed, 1172 insertions(+), 3409 deletions(-)
 create mode 100644 ABI_VERSION
 create mode 100755 buildtools/check-abi-version.sh
 create mode 100755 buildtools/update-abi.sh
 create mode 100755 buildtools/update_version_map_abi.py
 rename lib/librte_distributor/{rte_distributor_v20.c => rte_distributor_single.c} (84%)
 rename lib/librte_distributor/{rte_distributor_v20.h => rte_distributor_single.h} (89%)
 delete mode 100644 lib/librte_distributor/rte_distributor_v1705.h
Signature · 1 line
2.17.1
#109 lore raw

PATCH v8 1/12 config: change ABI versioning to global

From: Marcin Baran <[email protected]>

As per new ABI policy [1], all of the libraries are now versioned using one global ABI version. Stable libraries use the MAJOR.MINOR ABI version for their shared objects, while experimental libraries use the 0.MAJORMINOR convention for their versioning. Experimental library versioning is managed globally. Changes in this patch implement the necessary steps to enable that.

[1] https://doc.dpdk.org/guides/contributing/abi_policy.html

---

Notes:
v6:
- Silenced grep error message on trying to grep a directory

v3:
- Removed Windows support from Makefile changes
- Removed unneeded path conversions from meson files

v2:
- Moved this to before ABI version bump to avoid compile breakage

 ABI_VERSION                                |  1 +
 buildtools/meson.build                     |  3 +++
 config/meson.build                         |  7 ++++++-
 doc/guides/contributing/abi_versioning.rst | 17 +++++++++--------
 doc/guides/contributing/coding_style.rst   |  8 +-------
 drivers/meson.build                        | 18 ++++++++++++------
 lib/meson.build                            | 17 +++++++++++------
 meson_options.txt                          |  2 --
 mk/rte.lib.mk                              | 14 +++++---------
 9 files changed, 48 insertions(+), 39 deletions(-)
 create mode 100644 ABI_VERSION
ABI_VERSION new file +1 -0
new file mode 100644
index 0000000000..9a7c1e503f
@@ -0,0 +1 @@
+20.0
buildtools/meson.build +3 -0
index 8d0b9e0cd0..6ef2c5721c 100644
@@ -14,3 +14,6 @@ if python3.found()
 else
 	map_to_def_cmd = ['meson', 'runpython', files('map_to_def.py')]
 endif
+
+# stable ABI always starts with "DPDK_"
+is_experimental_cmd = [find_program('grep', 'findstr'), '^DPDK_']
config/meson.build +6 -1
index 2b1cb92e7e..3ffb73ab9c 100644
@@ -18,6 +18,11 @@ endforeach
 # depending on the configuration options
 pver = meson.project_version().split('.')
 major_version = '@0@.@1@'.format(pver.get(0), pver.get(1))
+abi_version = run_command(find_program('cat', 'more'),
+	files('../ABI_VERSION')).stdout().strip()
+# experimental libraries are versioned as 0.majorminor versions, e.g. 0.201
+ever = abi_version.split('.')
+experimental_abi_version = '0.@0@@1@'.format(ever.get(0), ever.get(1))
 
 # extract all version information into the build configuration
 dpdk_conf.set('RTE_VER_YEAR', pver.get(0).to_int())
@@ -37,7 +42,7 @@ endif
 
 pmd_subdir_opt = get_option('drivers_install_subdir')
 if pmd_subdir_opt.contains('<VERSION>')
-	pmd_subdir_opt = major_version.join(pmd_subdir_opt.split('<VERSION>'))
+	pmd_subdir_opt = abi_version.join(pmd_subdir_opt.split('<VERSION>'))
 endif
 driver_install_path = join_paths(get_option('libdir'), pmd_subdir_opt)
 eal_pmd_path = join_paths(get_option('prefix'), driver_install_path)
doc/guides/contributing/abi_versioning.rst +9 -8
index 050c971dd8..a21f4e7a41 100644
@@ -111,16 +111,17 @@ how this may be done.
  ...
 
 At the same time, the major ABI version is changed atomically across all
-libraries by incrementing the major version in individual library's soname, e.g.
-``libacl.so.21``. This is done by bumping the LIBABIVER number in the libraries
-Makefile to indicate to dynamic linking applications that this is a later, and
-possibly incompatible library version:
+libraries by incrementing the major version in the ABI_VERSION file. This is
+done globally for all libraries that declare a stable ABI. For libraries marked
+as EXPERIMENTAL, their major ABI version is always set to 0.
 
-.. code-block:: c
-
-   -LIBABIVER := 20
-   +LIBABIVER := 21
+Minor ABI versions
+~~~~~~~~~~~~~~~~~~
 
+Each non-LTS release will also increment minor ABI version, to permit multiple
+DPDK versions being installed alongside each other. Both stable and
+experimental ABI's are versioned using the global version file that is updated
+at the start of each release cycle, and are managed at the project level.
 
 Versioning Macros
 -----------------
doc/guides/contributing/coding_style.rst +1 -7
index a6843de5ad..841ef6d5c8 100644
@@ -803,9 +803,8 @@ lpm, etc. For drivers, the same format of Makefile is used.
 	CFLAGS += -O3
 	CFLAGS += $(WERROR_FLAGS)
 
-	# the symbol version information for the library, and .so version
+	# the symbol version information for the library
 	EXPORT_MAP := rte_<name>_version.map
-	LIBABIVER := 1
 
 	# all source filenames are stored in SRCS-y
 	SRCS-$(CONFIG_RTE_LIBRTE_<NAME>) += rte_<name>.c
@@ -955,11 +954,6 @@ use_function_versioning
 	twice with suitable parameters for each of shared or static library
 	builds.
 
-version
-	**Default Value = 1**.
-	Specifies the ABI version of the library, and is used as the major
-	version number of the resulting ``.so`` library.
-
 Meson Build File Contents - Drivers
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
drivers/meson.build +12 -6
index 823e3ef839..80cc7001fe 100644
@@ -41,7 +41,6 @@ foreach class:dpdk_driver_classes
 		build = true # set to false to disable, e.g. missing deps
 		reason = '<unknown reason>' # set if build == false to explain
 		name = drv
-		version = 1
 		allow_experimental_apis = false
 		sources = []
 		objs = []
@@ -124,12 +123,19 @@ foreach class:dpdk_driver_classes
 					output: out_filename,
 					depends: [pmdinfogen, tmp_lib])
 
-			if get_option('per_library_versions')
-				lib_version = '@[email protected]'.format(version)
-				so_version = '@0@'.format(version)
+			version_map = '@0@/@1@/@2@_version.map'.format(
+					meson.current_source_dir(),
+					drv_path, lib_name)
+
+			is_experimental = run_command(is_experimental_cmd,
+				files(version_map)).returncode()
+
+			if is_experimental != 0
+				lib_version = experimental_abi_version
+				so_version = experimental_abi_version
 			else
-				lib_version = major_version
-				so_version = major_version
+				lib_version = abi_version
+				so_version = abi_version
 			endif
 
 			# now build the static driver
lib/meson.build +11 -6
index bc8eb1d218..6ceb5e756e 100644
@@ -47,7 +47,6 @@ foreach l:libraries
 	build = true
 	reason = '<unknown reason>' # set if build == false to explain why
 	name = l
-	version = 1
 	allow_experimental_apis = false
 	use_function_versioning = false
 	sources = []
@@ -106,12 +105,18 @@ foreach l:libraries
 				cflags += '-DRTE_USE_FUNCTION_VERSIONING'
 			endif
 
-			if get_option('per_library_versions')
-				lib_version = '@[email protected]'.format(version)
-				so_version = '@0@'.format(version)
+			version_map = '@0@/@1@/rte_@2@_version.map'.format(
+					meson.current_source_dir(), dir_name, name)
+
+			is_experimental = run_command(is_experimental_cmd,
+					files(version_map)).returncode()
+
+			if is_experimental != 0
+				lib_version = experimental_abi_version
+				so_version = experimental_abi_version
 			else
-				lib_version = major_version
-				so_version = major_version
+				lib_version = abi_version
+				so_version = abi_version
 			endif
 
 			# first build static lib
meson_options.txt +0 -2
index e6fcb884be..bc369d06c9 100644
@@ -28,8 +28,6 @@ option('max_lcores', type: 'integer', value: 128,
 	description: 'maximum number of cores/threads supported by EAL')
 option('max_numa_nodes', type: 'integer', value: 4,
 	description: 'maximum number of NUMA nodes supported by EAL')
-option('per_library_versions', type: 'boolean', value: true,
-	description: 'true: each lib gets its own version number, false: DPDK version used for each lib')
 option('tests', type: 'boolean', value: true,
 	description: 'build unit tests')
 option('use_hpet', type: 'boolean', value: false,
mk/rte.lib.mk +5 -9
index 4df8849a08..3b318a5306 100644
@@ -11,20 +11,16 @@ EXTLIB_BUILD ?= n
 # VPATH contains at least SRCDIR
 VPATH += $(SRCDIR)
 
-ifneq ($(CONFIG_RTE_MAJOR_ABI),)
-ifneq ($(LIBABIVER),)
-LIBABIVER := $(CONFIG_RTE_MAJOR_ABI)
-endif
+ifneq ($(shell grep -s "^DPDK_" $(SRCDIR)/$(EXPORT_MAP)),)
+LIBABIVER := $(shell cat $(RTE_SRCDIR)/ABI_VERSION)
+else
+# EXPERIMENTAL ABI is versioned as 0.major+minor, e.g. 0.201 for 20.1 ABI
+LIBABIVER := 0.$(shell cat $(RTE_SRCDIR)/ABI_VERSION | td -d '.')
 endif
 
 ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
 LIB := $(patsubst %.a,%.so.$(LIBABIVER),$(LIB))
 ifeq ($(EXTLIB_BUILD),n)
-ifeq ($(CONFIG_RTE_MAJOR_ABI),)
-ifeq ($(CONFIG_RTE_NEXT_ABI),y)
-LIB := $(LIB).1
-endif
-endif
 CPU_LDFLAGS += --version-script=$(SRCDIR)/$(EXPORT_MAP)
 endif
 endif
Signature · 1 line
2.17.1
#110 lore raw

Re: [dpdk-dev] [PATCH v8 01/12] config: change ABI versioning to global

Quoted 9 lines · Anatoly Burakov

From: Marcin Baran <[email protected]>

As per new ABI policy [1], all of the libraries are now versioned using one global ABI version. Stable libraries use the MAJOR.MINOR ABI version for their shared objects, while experimental libraries use the 0.MAJORMINOR convention for their versioning. Experimental library versioning is managed globally. Changes in this patch implement the necessary steps to enable that.

The next patch just removes the config entry CONFIG_RTE_MAJOR_ABI while this patch entirely removes its usage.
I squashed patch 2 in patch 1 and added its commitlog here.

Quoted 7 lines

[1] https://doc.dpdk.org/guides/contributing/abi_policy.html

[snip]

Quoted 7 lines
mk/rte.lib.mk +0 -0
index 4df8849a08..3b318a5306 100644
@@ -11,20 +11,16 @@ EXTLIB_BUILD ?= n
 # VPATH contains at least SRCDIR
 VPATH += $(SRCDIR)

mk/rte.lib.mk EXTLIB_BUILD ?= n · line 18

Quoted 10 lines
mk/rte.lib.mk +5 -4
 
-ifneq ($(CONFIG_RTE_MAJOR_ABI),)
-ifneq ($(LIBABIVER),)
-LIBABIVER := $(CONFIG_RTE_MAJOR_ABI)
-endif
+ifneq ($(shell grep -s "^DPDK_" $(SRCDIR)/$(EXPORT_MAP)),)
+LIBABIVER := $(shell cat $(RTE_SRCDIR)/ABI_VERSION)
+else
+# EXPERIMENTAL ABI is versioned as 0.major+minor, e.g. 0.201 for 20.1 ABI
+LIBABIVER := 0.$(shell cat $(RTE_SRCDIR)/ABI_VERSION | td -d '.')

s/td/tr/

Will fix while applying.

Signature · 1 line
David Marchand
#111 lore raw

Re: [dpdk-dev] [PATCH v8 01/12] config: change ABI versioning to global

Quoted 47 lines · David Marchand
Quoted 9 lines · Anatoly Burakov

From: Marcin Baran <[email protected]>

As per new ABI policy [1], all of the libraries are now versioned using one global ABI version. Stable libraries use the MAJOR.MINOR ABI version for their shared objects, while experimental libraries use the 0.MAJORMINOR convention for their versioning. Experimental library versioning is managed globally. Changes in this patch implement the necessary steps to enable that.

The next patch just removes the config entry CONFIG_RTE_MAJOR_ABI while this patch entirely removes its usage.
I squashed patch 2 in patch 1 and added its commitlog here.

Quoted 7 lines

[1] https://doc.dpdk.org/guides/contributing/abi_policy.html

[snip]

Quoted 7 lines
mk/rte.lib.mk +0 -0
index 4df8849a08..3b318a5306 100644
@@ -11,20 +11,16 @@ EXTLIB_BUILD ?= n
 # VPATH contains at least SRCDIR
 VPATH += $(SRCDIR)

mk/rte.lib.mk EXTLIB_BUILD ?= n · line 18

Quoted 10 lines
mk/rte.lib.mk +5 -4
 
-ifneq ($(CONFIG_RTE_MAJOR_ABI),)
-ifneq ($(LIBABIVER),)
-LIBABIVER := $(CONFIG_RTE_MAJOR_ABI)
-endif
+ifneq ($(shell grep -s "^DPDK_" $(SRCDIR)/$(EXPORT_MAP)),)
+LIBABIVER := $(shell cat $(RTE_SRCDIR)/ABI_VERSION)
+else
+# EXPERIMENTAL ABI is versioned as 0.major+minor, e.g. 0.201 for 20.1 ABI
+LIBABIVER := 0.$(shell cat $(RTE_SRCDIR)/ABI_VERSION | td -d '.')

s/td/tr/

Quoted 1 line

Will fix while applying.

On this part again, for ethtool example library, this triggers a warning since ABI_VERSION does not exist in this example source directory.

mk/rte.lib.mk +1 -1
index 94a80e024..655a1b143 100644
@@ -13,7 +13,7 @@ VPATH += $(SRCDIR)
 
 ifneq ($(shell grep -s "^DPDK_" $(SRCDIR)/$(EXPORT_MAP)),)
 LIBABIVER := $(shell cat $(RTE_SRCDIR)/ABI_VERSION)
-else
+else ifeq ($(LIBABIVER),)
 # EXPERIMENTAL ABI is versioned as 0.major+minor, e.g. 0.201 for 20.1 ABI
 LIBABIVER := 0.$(shell cat $(RTE_SRCDIR)/ABI_VERSION | tr -d '.')
 endif

In the patch removing LIBABIVER, I let examples/ethtool/lib/Makefile untouched. With this, an external library manages its ABI version.

Signature · 1 line
David Marchand
#112 lore raw

PATCH v8 2/12 config: remove CONFIG_RTE_MAJOR_ABI option

In reply to Anatoly Burakov

The CONFIG_RTE_MAJOR_ABI option was introduced to permit multiple DPDK versions installed side by side. The problem is now addressed through the new ABI policy, and thus can be removed.

---
 config/common_base | 5 -----
 1 file changed, 5 deletions(-)
config/common_base +0 -5
index 914277856d..4948e1c572 100644
@@ -64,11 +64,6 @@ CONFIG_RTE_BUILD_SHARED_LIB=n
 #
 CONFIG_RTE_NEXT_ABI=y
 
-#
-# Major ABI to overwrite library specific LIBABIVER
-#
-CONFIG_RTE_MAJOR_ABI=
-
 #
 # Machine's cache line size
 #
Signature · 1 line
2.17.1
#113 lore raw

PATCH v8 3/12 build: remove individual library versions

In reply to Anatoly Burakov

Since the library versioning for both stable and experimental ABI's is now managed globally, the LIBABIVER and version variables no longer serve any useful purpose, and can be removed.

The replacement in Makefiles was done using the following regex:

	^(#.*\n)?LIBABIVER\s*:=\s*\d+\n(\s*\n)?

(LIBABIVER := numbers, optionally preceded by a comment and optionally succeeded by an empty line)

The replacement for meson files was done using the following regex:

	^(#.*\n)?version\s*=\s*\d+\n(\s*\n)?

(version = numbers, optionally preceded by a comment and optionally succeeded by an empty line)

---

Notes:
v6:
- Silenced grep error message on trying to grep a directory

v3:
- Removed Windows support from Makefile changes
- Removed unneeded path conversions from meson files

v2:
- Moved this to before ABI version bump to avoid compile breakage

 drivers/baseband/fpga_lte_fec/Makefile | 3 ---
 drivers/baseband/null/Makefile         | 3 ---
 drivers/baseband/turbo_sw/Makefile     | 3 ---
 drivers/bus/dpaa/Makefile              | 2 --
 drivers/bus/dpaa/meson.build           | 2 --
 drivers/bus/fslmc/Makefile             | 3 ---
 drivers/bus/fslmc/meson.build          | 2 --
 drivers/bus/ifpga/Makefile             | 3 ---
 drivers/bus/ifpga/meson.build          | 2 --
 drivers/bus/pci/Makefile               | 1 -
 drivers/bus/pci/meson.build            | 2 --
 drivers/bus/vdev/Makefile              | 3 ---
 drivers/bus/vdev/meson.build           | 2 --
 drivers/bus/vmbus/Makefile             | 1 -
 drivers/bus/vmbus/meson.build          | 2 --
 drivers/common/cpt/Makefile            | 2 --
 drivers/common/dpaax/Makefile          | 3 ---
 drivers/common/mvep/Makefile           | 3 ---
 drivers/common/octeontx/Makefile       | 2 --
 drivers/common/octeontx2/Makefile      | 2 --
 drivers/compress/isal/Makefile         | 3 ---
 drivers/compress/octeontx/Makefile     | 3 ---
 drivers/compress/zlib/Makefile         | 3 ---
 drivers/crypto/aesni_gcm/Makefile      | 3 ---
 drivers/crypto/aesni_mb/Makefile       | 3 ---
 drivers/crypto/armv8/Makefile          | 3 ---
 drivers/crypto/caam_jr/Makefile        | 3 ---
 drivers/crypto/ccp/Makefile            | 3 ---
 drivers/crypto/dpaa2_sec/Makefile      | 3 ---
 drivers/crypto/dpaa2_sec/meson.build   | 2 --
 drivers/crypto/dpaa_sec/Makefile       | 3 ---
 drivers/crypto/kasumi/Makefile         | 3 ---
 drivers/crypto/mvsam/Makefile          | 3 ---
 drivers/crypto/nitrox/Makefile         | 3 ---
 drivers/crypto/null/Makefile           | 3 ---
 drivers/crypto/octeontx/Makefile       | 3 ---
 drivers/crypto/octeontx2/Makefile      | 3 ---
 drivers/crypto/openssl/Makefile        | 3 ---
 drivers/crypto/scheduler/Makefile      | 3 ---
 drivers/crypto/snow3g/Makefile         | 3 ---
 drivers/crypto/virtio/Makefile         | 2 --
 drivers/crypto/zuc/Makefile            | 3 ---
 drivers/event/dpaa/Makefile            | 2 --
 drivers/event/dpaa2/Makefile           | 2 --
 drivers/event/dpaa2/meson.build        | 2 --
 drivers/event/dsw/Makefile             | 2 --
 drivers/event/octeontx/Makefile        | 2 --
 drivers/event/octeontx2/Makefile       | 2 --
 drivers/event/opdl/Makefile            | 3 ---
 drivers/event/skeleton/Makefile        | 2 --
 drivers/event/sw/Makefile              | 3 ---
 drivers/mempool/bucket/Makefile        | 2 --
 drivers/mempool/dpaa/Makefile          | 3 ---
 drivers/mempool/dpaa2/Makefile         | 3 ---
 drivers/mempool/dpaa2/meson.build      | 2 --
 drivers/mempool/octeontx/Makefile      | 2 --
 drivers/mempool/octeontx2/Makefile     | 2 --
 drivers/mempool/ring/Makefile          | 2 --
 drivers/mempool/stack/Makefile         | 2 --
 drivers/net/af_packet/Makefile         | 2 --
 drivers/net/af_xdp/Makefile            | 2 --
 drivers/net/ark/Makefile               | 2 --
 drivers/net/atlantic/Makefile          | 2 --
 drivers/net/avp/Makefile               | 2 --
 drivers/net/axgbe/Makefile             | 2 --
 drivers/net/bnx2x/Makefile             | 2 --
 drivers/net/bnxt/Makefile              | 2 --
 drivers/net/bnxt/meson.build           | 1 -
 drivers/net/bonding/Makefile           | 2 --
 drivers/net/bonding/meson.build        | 1 -
 drivers/net/cxgbe/Makefile             | 2 --
 drivers/net/dpaa/Makefile              | 2 --
 drivers/net/dpaa2/Makefile             | 3 ---
 drivers/net/dpaa2/meson.build          | 2 --
 drivers/net/e1000/Makefile             | 2 --
 drivers/net/ena/Makefile               | 2 --
 drivers/net/enetc/Makefile             | 2 --
 drivers/net/enic/Makefile              | 2 --
 drivers/net/failsafe/Makefile          | 2 --
 drivers/net/fm10k/Makefile             | 2 --
 drivers/net/hinic/Makefile             | 2 --
 drivers/net/hns3/Makefile              | 2 --
 drivers/net/i40e/Makefile              | 2 --
 drivers/net/i40e/meson.build           | 2 --
 drivers/net/iavf/Makefile              | 2 --
 drivers/net/ice/Makefile               | 2 --
 drivers/net/ifc/Makefile               | 2 --
 drivers/net/ipn3ke/Makefile            | 2 --
 drivers/net/ixgbe/Makefile             | 2 --
 drivers/net/ixgbe/meson.build          | 2 --
 drivers/net/kni/Makefile               | 2 --
 drivers/net/liquidio/Makefile          | 2 --
 drivers/net/memif/Makefile             | 2 --
 drivers/net/mlx4/Makefile              | 2 --
 drivers/net/mlx5/Makefile              | 2 --
 drivers/net/mvneta/Makefile            | 3 ---
 drivers/net/mvpp2/Makefile             | 3 ---
 drivers/net/netvsc/Makefile            | 2 --
 drivers/net/netvsc/meson.build         | 1 -
 drivers/net/nfb/Makefile               | 2 --
 drivers/net/nfp/Makefile               | 2 --
 drivers/net/null/Makefile              | 2 --
 drivers/net/null/meson.build           | 1 -
 drivers/net/octeontx/Makefile          | 2 --
 drivers/net/octeontx2/Makefile         | 2 --
 drivers/net/pcap/Makefile              | 2 --
 drivers/net/pfe/Makefile               | 2 --
 drivers/net/qede/Makefile              | 2 --
 drivers/net/ring/Makefile              | 2 --
 drivers/net/ring/meson.build           | 1 -
 drivers/net/sfc/Makefile               | 2 --
 drivers/net/softnic/Makefile           | 2 --
 drivers/net/szedata2/Makefile          | 2 --
 drivers/net/tap/Makefile               | 2 --
 drivers/net/thunderx/Makefile          | 2 --
 drivers/net/vdev_netvsc/Makefile       | 1 -
 drivers/net/vhost/Makefile             | 2 --
 drivers/net/vhost/meson.build          | 1 -
 drivers/net/virtio/Makefile            | 2 --
 drivers/net/vmxnet3/Makefile           | 2 --
 drivers/raw/dpaa2_cmdif/Makefile       | 2 --
 drivers/raw/dpaa2_cmdif/meson.build    | 2 --
 drivers/raw/dpaa2_qdma/Makefile        | 2 --
 drivers/raw/dpaa2_qdma/meson.build     | 2 --
 drivers/raw/ifpga/Makefile             | 2 --
 drivers/raw/ifpga/meson.build          | 2 --
 drivers/raw/ioat/Makefile              | 3 ---
 drivers/raw/ntb/Makefile               | 2 --
 drivers/raw/octeontx2_dma/Makefile     | 2 --
 drivers/raw/skeleton/Makefile          | 2 --
 examples/ethtool/lib/Makefile          | 2 --
 lib/librte_acl/Makefile                | 2 --
 lib/librte_acl/meson.build             | 1 -
 lib/librte_bbdev/Makefile              | 3 ---
 lib/librte_bitratestats/Makefile       | 2 --
 lib/librte_bitratestats/meson.build    | 1 -
 lib/librte_bpf/Makefile                | 2 --
 lib/librte_cfgfile/Makefile            | 2 --
 lib/librte_cfgfile/meson.build         | 1 -
 lib/librte_cmdline/Makefile            | 2 --
 lib/librte_cmdline/meson.build         | 1 -
 lib/librte_compressdev/Makefile        | 3 ---
 lib/librte_cryptodev/Makefile          | 3 ---
 lib/librte_cryptodev/meson.build       | 1 -
 lib/librte_distributor/Makefile        | 2 --
 lib/librte_eal/freebsd/eal/Makefile    | 2 --
 lib/librte_eal/linux/eal/Makefile      | 2 --
 lib/librte_efd/Makefile                | 2 --
 lib/librte_ethdev/Makefile             | 2 --
 lib/librte_ethdev/meson.build          | 1 -
 lib/librte_eventdev/Makefile           | 3 ---
 lib/librte_eventdev/meson.build        | 1 -
 lib/librte_fib/Makefile                | 2 --
 lib/librte_flow_classify/Makefile      | 2 --
 lib/librte_gro/Makefile                | 2 --
 lib/librte_gso/Makefile                | 2 --
 lib/librte_hash/Makefile               | 2 --
 lib/librte_hash/meson.build            | 1 -
 lib/librte_ip_frag/Makefile            | 2 --
 lib/librte_ipsec/Makefile              | 2 --
 lib/librte_ipsec/meson.build           | 1 -
 lib/librte_jobstats/Makefile           | 2 --
 lib/librte_kni/Makefile                | 2 --
 lib/librte_kni/meson.build             | 1 -
 lib/librte_kvargs/Makefile             | 2 --
 lib/librte_kvargs/meson.build          | 1 -
 lib/librte_latencystats/Makefile       | 2 --
 lib/librte_lpm/Makefile                | 2 --
 lib/librte_lpm/meson.build             | 1 -
 lib/librte_mbuf/Makefile               | 2 --
 lib/librte_mbuf/meson.build            | 1 -
 lib/librte_member/Makefile             | 2 --
 lib/librte_mempool/Makefile            | 2 --
 lib/librte_mempool/meson.build         | 1 -
 lib/librte_meter/Makefile              | 2 --
 lib/librte_meter/meson.build           | 1 -
 lib/librte_metrics/Makefile            | 2 --
 lib/librte_net/Makefile                | 2 --
 lib/librte_net/meson.build             | 1 -
 lib/librte_pci/Makefile                | 2 --
 lib/librte_pci/meson.build             | 2 --
 lib/librte_pdump/Makefile              | 2 --
 lib/librte_pdump/meson.build           | 1 -
 lib/librte_pipeline/Makefile           | 2 --
 lib/librte_pipeline/meson.build        | 1 -
 lib/librte_port/Makefile               | 2 --
 lib/librte_port/meson.build            | 1 -
 lib/librte_power/Makefile              | 2 --
 lib/librte_rawdev/Makefile             | 3 ---
 lib/librte_rcu/Makefile                | 2 --
 lib/librte_reorder/Makefile            | 2 --
 lib/librte_rib/Makefile                | 2 --
 lib/librte_ring/Makefile               | 2 --
 lib/librte_ring/meson.build            | 1 -
 lib/librte_sched/Makefile              | 2 --
 lib/librte_sched/meson.build           | 1 -
 lib/librte_security/Makefile           | 3 ---
 lib/librte_security/meson.build        | 1 -
 lib/librte_stack/Makefile              | 2 --
 lib/librte_stack/meson.build           | 1 -
 lib/librte_table/Makefile              | 2 --
 lib/librte_table/meson.build           | 1 -
 lib/librte_telemetry/Makefile          | 2 --
 lib/librte_timer/Makefile              | 2 --
 lib/librte_vhost/Makefile              | 2 --
 lib/librte_vhost/meson.build           | 1 -
 206 files changed, 420 deletions(-)
drivers/baseband/fpga_lte_fec/Makefile +0 -3
index 2369bd27fa..b4a442ca54 100644
@@ -17,9 +17,6 @@ LDLIBS += -lrte_pci -lrte_bus_pci
 # versioning export map
 EXPORT_MAP := rte_pmd_bbdev_fpga_lte_fec_version.map
 
-# library version
-LIBABIVER := 1
-
 # library source files
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_FPGA_LTE_FEC) += fpga_lte_fec.c
 
drivers/baseband/null/Makefile +0 -3
index f885a97bb3..28751eeb79 100644
@@ -16,9 +16,6 @@ LDLIBS += -lrte_bus_vdev
 # versioning export map
 EXPORT_MAP := rte_pmd_bbdev_null_version.map
 
-# library version
-LIBABIVER := 1
-
 # library source files
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_NULL) += bbdev_null.c
 
drivers/baseband/turbo_sw/Makefile +0 -3
index 4aa05d2db6..ec74d277e9 100644
@@ -47,9 +47,6 @@ LDLIBS += -L$(FLEXRAN_SDK)/lib_LDPC_ratematch_5gnr -lLDPC_ratematch_5gnr
 LDLIBS += -L$(FLEXRAN_SDK)/lib_rate_dematching_5gnr -lrate_dematching_5gnr
 endif
 
-# library version
-LIBABIVER := 1
-
 # library source files
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW) += bbdev_turbo_software.c
 
drivers/bus/dpaa/Makefile +0 -2
index 454ac12bf3..cd1093f744 100644
@@ -23,8 +23,6 @@ CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include
 # versioning export map
 EXPORT_MAP := rte_bus_dpaa_version.map
 
-LIBABIVER := 2
-
 # all source are stored in SRCS-y
 #
 SRCS-$(CONFIG_RTE_LIBRTE_DPAA_BUS) += \
drivers/bus/dpaa/meson.build +0 -2
index 0e561c2608..2b1cf19114 100644
@@ -1,8 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright 2018 NXP
 
-version = 2
-
 if not is_linux
 	build = false
 	reason = 'only supported on linux'
drivers/bus/fslmc/Makefile +0 -3
index 16f0a2ca4a..6d22860885 100644
@@ -25,9 +25,6 @@ LDLIBS += -lrte_common_dpaax
 # versioning export map
 EXPORT_MAP := rte_bus_fslmc_version.map
 
-# library version
-LIBABIVER := 2
-
 SRCS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS) += \
         qbman/qbman_portal.c \
         qbman/qbman_debug.c
drivers/bus/fslmc/meson.build +0 -2
index faebc4327f..6e709a8d5a 100644
@@ -1,8 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright 2018 NXP
 
-version = 2
-
 if not is_linux
 	build = false
 	reason = 'only supported on linux'
drivers/bus/ifpga/Makefile +0 -3
index 514452b39d..290c1124ba 100644
@@ -18,9 +18,6 @@ LDLIBS += -lrte_kvargs
 # versioning export map
 EXPORT_MAP := rte_bus_ifpga_version.map
 
-# library version
-LIBABIVER := 2
-
 SRCS-$(CONFIG_RTE_LIBRTE_IFPGA_BUS) += ifpga_bus.c
 SRCS-$(CONFIG_RTE_LIBRTE_IFPGA_BUS) += ifpga_common.c
 
drivers/bus/ifpga/meson.build +0 -2
index 0b5c38d54c..c9b08c8627 100644
@@ -1,8 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2010-2018 Intel Corporation
 
-version = 2
-
 deps += ['pci', 'kvargs', 'rawdev']
 install_headers('rte_bus_ifpga.h')
 sources = files('ifpga_common.c', 'ifpga_bus.c')
drivers/bus/pci/Makefile +0 -1
index 45d12427a1..975d796527 100644
@@ -4,7 +4,6 @@
 include $(RTE_SDK)/mk/rte.vars.mk
 
 LIB = librte_bus_pci.a
-LIBABIVER := 2
 EXPORT_MAP := rte_bus_pci_version.map
 
 CFLAGS := -I$(SRCDIR) $(CFLAGS)
drivers/bus/pci/meson.build +0 -2
index a312ecc034..a3feb86aea 100644
@@ -1,8 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 2
-
 deps += ['pci']
 install_headers('rte_bus_pci.h')
 sources = files('pci_common.c',
drivers/bus/vdev/Makefile +0 -3
index 803b8ea7b0..63c9b3f59b 100644
@@ -15,9 +15,6 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API
 # versioning export map
 EXPORT_MAP := rte_bus_vdev_version.map
 
-# library version
-LIBABIVER := 2
-
 SRCS-y += vdev.c
 SRCS-y += vdev_params.c
 
drivers/bus/vdev/meson.build +0 -2
index 803785f10f..12605e5c74 100644
@@ -1,8 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 2
-
 sources = files('vdev.c',
 	'vdev_params.c')
 install_headers('rte_bus_vdev.h')
drivers/bus/vmbus/Makefile +0 -1
index 8f3ec7af45..59e789db9b 100644
@@ -3,7 +3,6 @@
 include $(RTE_SDK)/mk/rte.vars.mk
 
 LIB = librte_bus_vmbus.a
-LIBABIVER := 2
 EXPORT_MAP := rte_bus_vmbus_version.map
 
 CFLAGS += -I$(SRCDIR)
drivers/bus/vmbus/meson.build +0 -2
index 79d4c685ec..251f21b662 100644
@@ -1,7 +1,5 @@
 # SPDX-License-Identifier: BSD-3-Clause
 
-version = 2
-
 allow_experimental_apis = true
 
 install_headers('rte_bus_vmbus.h','rte_vmbus_reg.h')
drivers/common/cpt/Makefile +0 -2
index 2340aa9616..859443218b 100644
@@ -13,8 +13,6 @@ CFLAGS += $(WERROR_FLAGS)
 CFLAGS += -I$(RTE_SDK)/drivers/bus/pci
 EXPORT_MAP := rte_common_cpt_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/common/dpaax/Makefile +0 -3
index a0a1de0283..59bd8ae15d 100644
@@ -20,9 +20,6 @@ CFLAGS += -I$(RTE_SDK)/drivers/common/dpaax
 # versioning export map
 EXPORT_MAP := rte_common_dpaax_version.map
 
-# library version
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/common/mvep/Makefile +0 -3
index 1f5f005d91..f91d295e5c 100644
@@ -15,9 +15,6 @@ endif
 # library name
 LIB = librte_common_mvep.a
 
-# library version
-LIBABIVER := 1
-
 # versioning export map
 EXPORT_MAP := rte_common_mvep_version.map
 
drivers/common/octeontx/Makefile +0 -2
index dfdb9f196e..5e67df0583 100644
@@ -12,8 +12,6 @@ LIB = librte_common_octeontx.a
 CFLAGS += $(WERROR_FLAGS)
 EXPORT_MAP := rte_common_octeontx_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/common/octeontx2/Makefile +0 -2
index afe570817c..eaff29433a 100644
@@ -24,8 +24,6 @@ endif
 
 EXPORT_MAP := rte_common_octeontx2_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/compress/isal/Makefile +0 -3
index 95904f6418..6438b75ce8 100644
@@ -17,9 +17,6 @@ LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
 LDLIBS += -lrte_compressdev
 LDLIBS += -lrte_bus_vdev
 
-# library version
-LIBABIVER := 1
-
 # versioning export map
 EXPORT_MAP := rte_pmd_isal_version.map
 
drivers/compress/octeontx/Makefile +0 -3
index f34424c87f..d6324b5302 100644
@@ -6,9 +6,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
 # library name
 LIB = librte_pmd_octeontx_zip.a
 
-# library version
-LIBABIVER := 1
-
 # build flags
 CFLAGS += $(WERROR_FLAGS)
 CFLAGS += -O3
drivers/compress/zlib/Makefile +0 -3
index 5cf8de6f83..1eba3560fe 100644
@@ -11,9 +11,6 @@ CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 
-# library version
-LIBABIVER := 1
-
 # versioning export map
 EXPORT_MAP := rte_pmd_zlib_version.map
 
drivers/crypto/aesni_gcm/Makefile +0 -3
index 39eff3db00..d8190a2ff4 100644
@@ -11,9 +11,6 @@ CFLAGS += -O3
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 CFLAGS += $(WERROR_FLAGS)
 
-# library version
-LIBABIVER := 1
-
 # versioning export map
 EXPORT_MAP := rte_pmd_aesni_gcm_version.map
 
drivers/crypto/aesni_mb/Makefile +0 -3
index f3035340ac..f1530e74c4 100644
@@ -11,9 +11,6 @@ CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 
-# library version
-LIBABIVER := 1
-
 # versioning export map
 EXPORT_MAP := rte_pmd_aesni_mb_version.map
 
drivers/crypto/armv8/Makefile +0 -3
index f71f6b14a4..1252836648 100644
@@ -19,9 +19,6 @@ LIB = librte_pmd_armv8.a
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 
-# library version
-LIBABIVER := 1
-
 # versioning export map
 EXPORT_MAP := rte_pmd_armv8_version.map
 
drivers/crypto/caam_jr/Makefile +0 -3
index fa35b79b85..1b1f25a2a2 100644
@@ -25,9 +25,6 @@ CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include
 # versioning export map
 EXPORT_MAP := rte_pmd_caam_jr_version.map
 
-# library version
-LIBABIVER := 1
-
 # library source files
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_CAAM_JR) += caam_jr.c
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_CAAM_JR) += caam_jr_capabilities.c
drivers/crypto/ccp/Makefile +0 -3
index f51d170f90..3f5da2adf3 100644
@@ -11,9 +11,6 @@ CFLAGS += -O3
 CFLAGS += -I$(SRCDIR)
 CFLAGS += $(WERROR_FLAGS)
 
-# library version
-LIBABIVER := 1
-
 # external library include paths
 LDLIBS += -lcrypto
 LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
drivers/crypto/dpaa2_sec/Makefile +0 -3
index ba30a955a9..96b9c78435 100644
@@ -33,9 +33,6 @@ CFLAGS += -I$(RTE_SDK)/drivers/mempool/dpaa2/
 # versioning export map
 EXPORT_MAP := rte_pmd_dpaa2_sec_version.map
 
-# library version
-LIBABIVER := 2
-
 # library source files
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += dpaa2_sec_dpseci.c
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += mc/dpseci.c
drivers/crypto/dpaa2_sec/meson.build +0 -2
index 9d1b170be7..ab9c8c8bf9 100644
@@ -1,8 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright 2018 NXP
 
-version = 2
-
 if not is_linux
 	build = false
 	reason = 'only supported on linux'
drivers/crypto/dpaa_sec/Makefile +0 -3
index 9acccaac4f..fbfd775855 100644
@@ -27,9 +27,6 @@ LDLIBS += -lrte_cryptodev
 # versioning export map
 EXPORT_MAP := rte_pmd_dpaa_sec_version.map
 
-# library version
-LIBABIVER := 1
-
 # library source files
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_DPAA_SEC) += dpaa_sec.c
 
drivers/crypto/kasumi/Makefile +0 -3
index 3de2f97edf..26f51375da 100644
@@ -17,9 +17,6 @@ CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 
-# library version
-LIBABIVER := 1
-
 # versioning export map
 EXPORT_MAP := rte_pmd_kasumi_version.map
 
drivers/crypto/mvsam/Makefile +0 -3
index 2b4d036c83..f0641ae7d9 100644
@@ -24,9 +24,6 @@ CFLAGS += -I$(LIBMUSDK_PATH)/include
 CFLAGS += -DMVCONF_TYPES_PUBLIC
 CFLAGS += -DMVCONF_DMA_PHYS_ADDR_T_PUBLIC
 
-# library version
-LIBABIVER := 1
-
 # versioning export map
 EXPORT_MAP := rte_pmd_mvsam_version.map
 
drivers/crypto/nitrox/Makefile +0 -3
index f569927704..fc42ac8088 100644
@@ -11,9 +11,6 @@ CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 
-# library version
-LIBABIVER := 1
-
 # versioning export map
 EXPORT_MAP := rte_pmd_nitrox_version.map
 
drivers/crypto/null/Makefile +0 -3
index 9e6400c1b4..4595055f01 100644
@@ -14,9 +14,6 @@ LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
 LDLIBS += -lrte_cryptodev
 LDLIBS += -lrte_bus_vdev
 
-# library version
-LIBABIVER := 1
-
 # versioning export map
 EXPORT_MAP := rte_pmd_null_crypto_version.map
 
drivers/crypto/octeontx/Makefile +0 -3
index 2752cbc364..08a99c8272 100644
@@ -7,9 +7,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
 # library name
 LIB = librte_pmd_octeontx_crypto.a
 
-# library version
-LIBABIVER := 1
-
 # build flags
 CFLAGS += $(WERROR_FLAGS)
 
drivers/crypto/octeontx2/Makefile +0 -3
index ce116b87bc..f7d6c37527 100644
@@ -7,9 +7,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
 # library name
 LIB = librte_pmd_octeontx2_crypto.a
 
-# library version
-LIBABIVER := 1
-
 # build flags
 CFLAGS += $(WERROR_FLAGS)
 
drivers/crypto/openssl/Makefile +0 -3
index ae6c3bcac1..58a26eced6 100644
@@ -11,9 +11,6 @@ CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 
-# library version
-LIBABIVER := 1
-
 # versioning export map
 EXPORT_MAP := rte_pmd_openssl_version.map
 
drivers/crypto/scheduler/Makefile +0 -3
index a9514e3386..67aac024c4 100644
@@ -13,9 +13,6 @@ LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
 LDLIBS += -lrte_cryptodev -lrte_kvargs -lrte_reorder
 LDLIBS += -lrte_bus_vdev
 
-# library version
-LIBABIVER := 1
-
 # versioning export map
 EXPORT_MAP := rte_pmd_crypto_scheduler_version.map
 
drivers/crypto/snow3g/Makefile +0 -3
index 37f77dbf84..4086c571da 100644
@@ -17,9 +17,6 @@ CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 
-# library version
-LIBABIVER := 1
-
 # versioning export map
 EXPORT_MAP := rte_pmd_snow3g_version.map
 
drivers/crypto/virtio/Makefile +0 -2
index be7b828fe1..32e2e4d5e9 100644
@@ -17,8 +17,6 @@ CFLAGS += $(WERROR_FLAGS)
 
 EXPORT_MAP := rte_pmd_virtio_crypto_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/crypto/zuc/Makefile +0 -3
index 8d625aa01d..a01bb6ecbc 100644
@@ -17,9 +17,6 @@ CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 
-# library version
-LIBABIVER := 1
-
 # versioning export map
 EXPORT_MAP := rte_pmd_zuc_version.map
 
drivers/event/dpaa/Makefile +0 -2
index befb21b1b6..2f53efdf9e 100644
@@ -27,8 +27,6 @@ CFLAGS += -I$(RTE_SDK)/drivers/crypto/dpaa_sec
 
 EXPORT_MAP := rte_pmd_dpaa_event_version.map
 
-LIBABIVER := 1
-
 # Interfaces with DPDK
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_DPAA_EVENTDEV) += dpaa_eventdev.c
 
drivers/event/dpaa2/Makefile +0 -2
index a29284f046..5a584c9d6b 100644
@@ -31,8 +31,6 @@ CFLAGS += -I$(RTE_SDK)/drivers/crypto/dpaa2_sec
 # versioning export map
 EXPORT_MAP := rte_pmd_dpaa2_event_version.map
 
-LIBABIVER := 2
-
 # depends on fslmc bus which uses experimental API
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 
drivers/event/dpaa2/meson.build +0 -2
index 72f97d4c1e..ca914ccc4d 100644
@@ -1,8 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright 2018 NXP
 
-version = 2
-
 if not is_linux
 	build = false
 	reason = 'only supported on linux'
drivers/event/dsw/Makefile +0 -2
index 922fe2e42b..f6e7dda1fd 100644
@@ -18,8 +18,6 @@ LDLIBS += -lrte_ring
 LDLIBS += -lrte_eventdev
 LDLIBS += -lrte_bus_vdev
 
-LIBABIVER := 1
-
 EXPORT_MAP := rte_pmd_dsw_event_version.map
 
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_DSW_EVENTDEV) += \
drivers/event/octeontx/Makefile +0 -2
index 2c92ccb35d..c1233e098d 100644
@@ -20,8 +20,6 @@ LDLIBS += -lrte_bus_vdev -lrte_ethdev
 
 EXPORT_MAP := rte_pmd_octeontx_event_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/event/octeontx2/Makefile +0 -2
index 8289f617a4..6dab69c590 100644
@@ -27,8 +27,6 @@ endif
 
 EXPORT_MAP := rte_pmd_octeontx2_event_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/event/opdl/Makefile +0 -3
index bf50a60a0b..6aab556ad9 100644
@@ -20,9 +20,6 @@ endif
 LDLIBS += -lrte_eal -lrte_eventdev -lrte_kvargs
 LDLIBS += -lrte_bus_vdev -lrte_mbuf -lrte_mempool
 
-# library version
-LIBABIVER := 1
-
 # versioning export map
 EXPORT_MAP := rte_pmd_opdl_event_version.map
 
drivers/event/skeleton/Makefile +0 -2
index 0f7f07eaf1..dc85ad3c4b 100644
@@ -16,8 +16,6 @@ LDLIBS += -lrte_bus_vdev
 
 EXPORT_MAP := rte_pmd_skeleton_event_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/event/sw/Makefile +0 -3
index c6600e8367..17937e295e 100644
@@ -20,9 +20,6 @@ LDLIBS += -lrte_eal -lrte_eventdev -lrte_kvargs -lrte_ring
 LDLIBS += -lrte_mempool -lrte_mbuf
 LDLIBS += -lrte_bus_vdev
 
-# library version
-LIBABIVER := 1
-
 # versioning export map
 EXPORT_MAP := rte_pmd_sw_event_version.map
 
drivers/mempool/bucket/Makefile +0 -2
index d6660b09cd..1dc0079f8f 100644
@@ -21,8 +21,6 @@ LDLIBS += -lrte_eal -lrte_mempool -lrte_ring
 
 EXPORT_MAP := rte_mempool_bucket_version.map
 
-LIBABIVER := 1
-
 SRCS-$(CONFIG_RTE_DRIVER_MEMPOOL_BUCKET) += rte_mempool_bucket.c
 
 include $(RTE_SDK)/mk/rte.lib.mk
drivers/mempool/dpaa/Makefile +0 -3
index 534e00733c..8c786ddbeb 100644
@@ -19,9 +19,6 @@ CFLAGS += -I$(RTE_SDK)/lib/librte_mempool
 # versioning export map
 EXPORT_MAP := rte_mempool_dpaa_version.map
 
-# Lbrary version
-LIBABIVER := 1
-
 # depends on dpaa bus which uses experimental API
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 
drivers/mempool/dpaa2/Makefile +0 -3
index bdb9410252..52565be9a9 100644
@@ -18,9 +18,6 @@ CFLAGS += -I$(RTE_SDK)/drivers/bus/fslmc/qbman/include
 # versioning export map
 EXPORT_MAP := rte_mempool_dpaa2_version.map
 
-# Lbrary version
-LIBABIVER := 2
-
 # depends on fslmc bus which uses experimental API
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 
drivers/mempool/dpaa2/meson.build +0 -2
index 3d25ba06d9..d79fc31644 100644
@@ -1,8 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright 2018 NXP
 
-version = 2
-
 if not is_linux
 	build = false
 	reason = 'only supported on linux'
drivers/mempool/octeontx/Makefile +0 -2
index 25efc5cf26..ee54c66dc2 100644
@@ -15,8 +15,6 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API
 
 EXPORT_MAP := rte_mempool_octeontx_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/mempool/octeontx2/Makefile +0 -2
index 4961a4a35b..337babf66e 100644
@@ -27,8 +27,6 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API
 
 EXPORT_MAP := rte_mempool_octeontx2_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/mempool/ring/Makefile +0 -2
index ddab522fec..8624502da9 100644
@@ -14,8 +14,6 @@ LDLIBS += -lrte_eal -lrte_mempool -lrte_ring
 
 EXPORT_MAP := rte_mempool_ring_version.map
 
-LIBABIVER := 1
-
 SRCS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) += rte_mempool_ring.c
 
 include $(RTE_SDK)/mk/rte.lib.mk
drivers/mempool/stack/Makefile +0 -2
index 1681a62bcc..97c3dab071 100644
@@ -18,8 +18,6 @@ LDLIBS += -lrte_eal -lrte_mempool -lrte_stack
 
 EXPORT_MAP := rte_mempool_stack_version.map
 
-LIBABIVER := 1
-
 SRCS-$(CONFIG_RTE_DRIVER_MEMPOOL_STACK) += rte_mempool_stack.c
 
 include $(RTE_SDK)/mk/rte.lib.mk
drivers/net/af_packet/Makefile +0 -2
index 39a1e0d24e..91dbf0a692 100644
@@ -13,8 +13,6 @@ LIB = librte_pmd_af_packet.a
 
 EXPORT_MAP := rte_pmd_af_packet_version.map
 
-LIBABIVER := 1
-
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
drivers/net/af_xdp/Makefile +0 -2
index eeba6b6933..55db6085ac 100644
@@ -10,8 +10,6 @@ LIB = librte_pmd_af_xdp.a
 
 EXPORT_MAP := rte_pmd_af_xdp_version.map
 
-LIBABIVER := 1
-
 CFLAGS += -O3
 
 CFLAGS += $(WERROR_FLAGS)
drivers/net/ark/Makefile +0 -2
index 34d341c235..c02080bdd0 100644
@@ -13,8 +13,6 @@ CFLAGS += $(WERROR_FLAGS) -Werror
 
 EXPORT_MAP := rte_pmd_ark_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/net/atlantic/Makefile +0 -2
index fc12e6a532..016e369283 100644
@@ -14,8 +14,6 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API
 
 EXPORT_MAP := rte_pmd_atlantic_version.map
 
-LIBABIVER := 1
-
 LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
 LDLIBS += -lrte_ethdev -lrte_net
 LDLIBS += -lrte_bus_pci
drivers/net/avp/Makefile +0 -2
index a7537656c9..8c12d3b7a0 100644
@@ -17,8 +17,6 @@ LDLIBS += -lrte_bus_pci
 
 EXPORT_MAP := rte_pmd_avp_version.map
 
-LIBABIVER := 1
-
 # install public header files to enable compilation of the hypervisor level
 # dpdk application
 SYMLINK-$(CONFIG_RTE_LIBRTE_AVP_PMD)-include += rte_avp_common.h
drivers/net/axgbe/Makefile +0 -2
index bcdcd544cf..0097a93074 100644
@@ -14,8 +14,6 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API
 
 EXPORT_MAP := rte_pmd_axgbe_version.map
 
-LIBABIVER := 1
-
 LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool
 LDLIBS += -lrte_pci -lrte_bus_pci
 LDLIBS += -lrte_ethdev -lrte_net
drivers/net/bnx2x/Makefile +0 -2
index adead9d002..5f6c39e4ee 100644
@@ -20,8 +20,6 @@ LDLIBS += -lrte_bus_pci
 
 EXPORT_MAP := rte_pmd_bnx2x_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/net/bnxt/Makefile +0 -2
index 21a5650630..b77532b817 100644
@@ -13,8 +13,6 @@ LIB = librte_pmd_bnxt.a
 
 EXPORT_MAP := rte_pmd_bnxt_version.map
 
-LIBABIVER := 2
-
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
drivers/net/bnxt/meson.build +0 -1
index 4dda28f5b0..0c311d235a 100644
@@ -2,7 +2,6 @@
 # Copyright(c) 2018 Intel Corporation
 
 install_headers('rte_pmd_bnxt.h')
-version = 2
 sources = files('bnxt_cpr.c',
 	'bnxt_ethdev.c',
 	'bnxt_filter.c',
drivers/net/bonding/Makefile +0 -2
index 26c1782554..a64296d8cf 100644
@@ -18,8 +18,6 @@ LDLIBS += -lrte_bus_vdev
 
 EXPORT_MAP := rte_pmd_bond_version.map
 
-LIBABIVER := 2
-
 #
 # all source are stored in SRCS-y
 #
drivers/net/bonding/meson.build +0 -1
index 6267210adf..d133375d4a 100644
@@ -2,7 +2,6 @@
 # Copyright(c) 2017 Intel Corporation
 
 name = 'bond' #, james bond :-)
-version = 2
 allow_experimental_apis = true
 sources = files('rte_eth_bond_api.c', 'rte_eth_bond_pmd.c', 'rte_eth_bond_flow.c',
 	'rte_eth_bond_args.c', 'rte_eth_bond_8023ad.c', 'rte_eth_bond_alb.c')
drivers/net/cxgbe/Makefile +0 -2
index d809f47209..79c6e1d1fb 100644
@@ -14,8 +14,6 @@ CFLAGS += $(WERROR_FLAGS)
 
 EXPORT_MAP := rte_pmd_cxgbe_version.map
 
-LIBABIVER := 1
-
 #
 # CFLAGS for gcc/clang
 #
drivers/net/dpaa/Makefile +0 -2
index 395e4d900f..8e049b2a0b 100644
@@ -25,8 +25,6 @@ CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include
 
 EXPORT_MAP := rte_pmd_dpaa_version.map
 
-LIBABIVER := 1
-
 # depends on dpaa bus which uses experimental API
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 
drivers/net/dpaa2/Makefile +0 -3
index e5a2d3fdee..806c88ff0c 100644
@@ -24,9 +24,6 @@ CFLAGS += -I$(RTE_SDK)/drivers/mempool/dpaa2
 # versioning export map
 EXPORT_MAP := rte_pmd_dpaa2_version.map
 
-# library version
-LIBABIVER := 2
-
 # depends on fslmc bus which uses experimental API
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 
drivers/net/dpaa2/meson.build +0 -2
index 1a4ab212c2..571cdb7d4b 100644
@@ -1,8 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright 2018 NXP
 
-version = 2
-
 if not is_linux
 	build = false
 	reason = 'only supported on linux'
drivers/net/e1000/Makefile +0 -2
index 0ed6276568..d93a5225c3 100644
@@ -17,8 +17,6 @@ LDLIBS += -lrte_bus_pci
 
 EXPORT_MAP := rte_pmd_e1000_version.map
 
-LIBABIVER := 1
-
 ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
 #
 # CFLAGS for icc
drivers/net/ena/Makefile +0 -2
index 8336b7606a..b44daa896f 100644
@@ -12,8 +12,6 @@ CFLAGS += $(WERROR_FLAGS) -O2
 INCLUDES :=-I$(SRCDIR) -I$(SRCDIR)/base/ena_defs -I$(SRCDIR)/base
 
 EXPORT_MAP := rte_pmd_ena_version.map
-LIBABIVER := 1
-
 # rte_fbarray is not yet part of stable API
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 
drivers/net/enetc/Makefile +0 -2
index 4498bc51f8..7276026e37 100644
@@ -12,8 +12,6 @@ CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 CFLAGS += -I$(RTE_SDK)/drivers/common/dpaax
 EXPORT_MAP := rte_pmd_enetc_version.map
-LIBABIVER := 1
-
 SRCS-$(CONFIG_RTE_LIBRTE_ENETC_PMD) += enetc_ethdev.c
 SRCS-$(CONFIG_RTE_LIBRTE_ENETC_PMD) += enetc_rxtx.c
 
drivers/net/enic/Makefile +0 -2
index 4e0c83da56..316088a3c7 100644
@@ -11,8 +11,6 @@ LIB = librte_pmd_enic.a
 
 EXPORT_MAP := rte_pmd_enic_version.map
 
-LIBABIVER := 1
-
 # Experimental APIs used: rte_intr_ack
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 CFLAGS += -I$(SRCDIR)/base/
drivers/net/failsafe/Makefile +0 -2
index 0d840a2721..bebc9056e0 100644
@@ -9,8 +9,6 @@ LIB = librte_pmd_failsafe.a
 
 EXPORT_MAP := rte_pmd_failsafe_version.map
 
-LIBABIVER := 1
-
 # Sources are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_FAILSAFE) += failsafe.c
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_FAILSAFE) += failsafe_args.c
drivers/net/fm10k/Makefile +0 -2
index 55e9cd5035..722bf1ee04 100644
@@ -14,8 +14,6 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API
 
 EXPORT_MAP := rte_pmd_fm10k_version.map
 
-LIBABIVER := 1
-
 ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
 #
 # CFLAGS for icc
drivers/net/hinic/Makefile +0 -2
index b78fd8d535..87fd843e41 100644
@@ -24,8 +24,6 @@ LDLIBS += -lpthread
 
 EXPORT_MAP := rte_pmd_hinic_version.map
 
-LIBABIVER := 1
-
 #
 # CFLAGS for 32-bits platforms
 #
drivers/net/hns3/Makefile +0 -2
index cbbbe042e5..ae0ee7e931 100644
@@ -23,8 +23,6 @@ LDLIBS += -lrte_bus_pci
 
 EXPORT_MAP := rte_pmd_hns3_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/net/i40e/Makefile +0 -2
index 1c3bbe329f..435eb511ad 100644
@@ -19,8 +19,6 @@ LDLIBS += -lrte_bus_pci
 
 EXPORT_MAP := rte_pmd_i40e_version.map
 
-LIBABIVER := 2
-
 #
 # Add extra flags for base driver files (also known as shared code)
 # to disable warnings
drivers/net/i40e/meson.build +0 -2
index dcbca39bf7..b01babba1f 100644
@@ -1,8 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 2
-
 cflags += ['-DPF_DRIVER',
 	'-DVF_DRIVER',
 	'-DINTEGRATED_VF',
drivers/net/iavf/Makefile +0 -2
index d3f9972f4f..81c9a0dbf2 100644
@@ -15,8 +15,6 @@ LDLIBS += -lrte_bus_pci
 
 EXPORT_MAP := rte_pmd_iavf_version.map
 
-LIBABIVER := 1
-
 #
 # Add extra flags for base driver files (also known as shared code)
 # to disable warnings
drivers/net/ice/Makefile +0 -2
index 7c3b6a7ffc..6c4d155268 100644
@@ -17,8 +17,6 @@ LDLIBS += -lrte_bus_pci -lrte_mempool -lrte_hash
 
 EXPORT_MAP := rte_pmd_ice_version.map
 
-LIBABIVER := 1
-
 #
 # Add extra flags for base driver files (also known as shared code)
 # to disable warnings
drivers/net/ifc/Makefile +0 -2
index 7755a87ebb..fe227b8110 100644
@@ -25,8 +25,6 @@ VPATH += $(SRCDIR)/base
 
 EXPORT_MAP := rte_pmd_ifc_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/net/ipn3ke/Makefile +0 -2
index 8c3ae3702d..100169ad4c 100644
@@ -27,8 +27,6 @@ LDLIBS += -lpthread
 
 EXPORT_MAP := rte_pmd_ipn3ke_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/net/ixgbe/Makefile +0 -2
index 7b6af35328..85762e2f2a 100644
@@ -14,8 +14,6 @@ CFLAGS += $(WERROR_FLAGS)
 
 EXPORT_MAP := rte_pmd_ixgbe_version.map
 
-LIBABIVER := 2
-
 ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
 #
 # CFLAGS for icc
drivers/net/ixgbe/meson.build +0 -2
index 544a141484..1b0f6d1efe 100644
@@ -1,8 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 2
-
 cflags += ['-DRTE_LIBRTE_IXGBE_BYPASS']
 
 allow_experimental_apis = true
drivers/net/kni/Makefile +0 -2
index 01eaef0564..0694ffd021 100644
@@ -17,8 +17,6 @@ LDLIBS += -lrte_bus_vdev
 
 EXPORT_MAP := rte_pmd_kni_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/net/liquidio/Makefile +0 -2
index f1092851a9..d7fda7f527 100644
@@ -17,8 +17,6 @@ LDLIBS += -lrte_bus_pci
 
 EXPORT_MAP := rte_pmd_liquidio_version.map
 
-LIBABIVER := 1
-
 VPATH += $(RTE_SDK)/drivers/net/liquidio/base
 
 #
drivers/net/memif/Makefile +0 -2
index 3d92b08f25..00f2a4cfc1 100644
@@ -10,8 +10,6 @@ LIB = librte_pmd_memif.a
 
 EXPORT_MAP := rte_pmd_memif_version.map
 
-LIBABIVER := 1
-
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 CFLAGS += -DALLOW_EXPERIMENTAL_API
drivers/net/mlx4/Makefile +0 -2
index 7ea6f74895..329569dc10 100644
@@ -57,8 +57,6 @@ LDLIBS += -lrte_bus_pci
 CFLAGS += -Wno-error=cast-qual
 
 EXPORT_MAP := rte_pmd_mlx4_version.map
-LIBABIVER := 1
-
 # DEBUG which is usually provided on the command-line may enable
 # CONFIG_RTE_LIBRTE_MLX4_DEBUG.
 ifeq ($(DEBUG),1)
drivers/net/mlx5/Makefile +0 -2
index 5b79631cf5..c5cf4397ac 100644
@@ -73,8 +73,6 @@ LDLIBS += -lrte_bus_pci
 CFLAGS += -Wno-error=cast-qual
 
 EXPORT_MAP := rte_pmd_mlx5_version.map
-LIBABIVER := 1
-
 # memseg walk is not part of stable API
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 
drivers/net/mvneta/Makefile +0 -3
index 05a0487cae..41e50479ff 100644
@@ -16,9 +16,6 @@ endif
 # library name
 LIB = librte_pmd_mvneta.a
 
-# library version
-LIBABIVER := 1
-
 # versioning export map
 EXPORT_MAP := rte_pmd_mvneta_version.map
 
drivers/net/mvpp2/Makefile +0 -3
index 661d2cdac5..8a3ec93a60 100644
@@ -16,9 +16,6 @@ endif
 # library name
 LIB = librte_pmd_mvpp2.a
 
-# library version
-LIBABIVER := 1
-
 # versioning export map
 EXPORT_MAP := rte_pmd_mvpp2_version.map
 
drivers/net/netvsc/Makefile +0 -2
index 71482591a9..45526e2a8e 100644
@@ -9,8 +9,6 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API
 
 EXPORT_MAP := rte_pmd_netvsc_version.map
 
-LIBABIVER := 1
-
 SRCS-$(CONFIG_RTE_LIBRTE_NETVSC_PMD) += hn_ethdev.c
 SRCS-$(CONFIG_RTE_LIBRTE_NETVSC_PMD) += hn_rxtx.c
 SRCS-$(CONFIG_RTE_LIBRTE_NETVSC_PMD) += hn_rndis.c
drivers/net/netvsc/meson.build +0 -1
index e9fe35344b..131dd2866e 100644
@@ -3,7 +3,6 @@
 
 build = dpdk_conf.has('RTE_LIBRTE_VMBUS_BUS')
 reason = 'missing dependency, DPDK VMBus driver'
-version = 2
 sources = files('hn_ethdev.c', 'hn_rxtx.c', 'hn_rndis.c', 'hn_nvs.c', 'hn_vf.c')
 
 deps += ['bus_vmbus' ]
drivers/net/nfb/Makefile +0 -2
index 8bba2ac046..e92d29dcd3 100644
@@ -23,8 +23,6 @@ LDLIBS += $(shell command -v pkg-config > /dev/null 2>&1 && pkg-config --libs ne
 
 EXPORT_MAP := rte_pmd_nfb_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/net/nfp/Makefile +0 -2
index d3fa5699b9..aa720d6698 100644
@@ -19,8 +19,6 @@ LDLIBS += -lrte_bus_pci
 
 EXPORT_MAP := rte_pmd_nfp_version.map
 
-LIBABIVER := 1
-
 VPATH += $(SRCDIR)/nfpcore
 
 SRCS-$(CONFIG_RTE_LIBRTE_NFP_PMD) += nfp_cppcore.c
drivers/net/null/Makefile +0 -2
index 6d44dfae8c..f51150c131 100644
@@ -16,8 +16,6 @@ LDLIBS += -lrte_bus_vdev
 
 EXPORT_MAP := rte_pmd_null_version.map
 
-LIBABIVER := 2
-
 #
 # all source are stored in SRCS-y
 #
drivers/net/null/meson.build +0 -1
index 60e2ce6c59..68ac0d2ae5 100644
@@ -1,5 +1,4 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 2
 sources = files('rte_eth_null.c')
drivers/net/octeontx/Makefile +0 -2
index 885f176845..8ddfc30894 100644
@@ -15,8 +15,6 @@ CFLAGS += -I$(RTE_SDK)/drivers/mempool/octeontx/
 
 EXPORT_MAP := rte_pmd_octeontx_version.map
 
-LIBABIVER := 1
-
 OBJS_BASE_DRIVER=$(patsubst %.c,%.o,$(notdir $(wildcard $(SRCDIR)/base/*.c)))
 $(foreach obj, $(OBJS_BASE_DRIVER), $(eval CFLAGS_$(obj)+=$(CFLAGS_BASE_DRIVER)))
 
drivers/net/octeontx2/Makefile +0 -2
index 0bfcecabfe..68f5765db6 100644
@@ -28,8 +28,6 @@ endif
 
 EXPORT_MAP := rte_pmd_octeontx2_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/net/pcap/Makefile +0 -2
index ef332162c3..f243d1a0fa 100644
@@ -19,8 +19,6 @@ LDLIBS += -lrte_bus_vdev
 
 EXPORT_MAP := rte_pmd_pcap_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/net/pfe/Makefile +0 -2
index 91815fc0c6..e5c60f536b 100644
@@ -15,8 +15,6 @@ CFLAGS += -I$(RTE_SDK)/drivers/net/pfe/base/
 CFLAGS += -I$(RTE_SDK)/drivers/common/dpaax
 
 EXPORT_MAP := rte_pmd_pfe_version.map
-LIBABIVER := 1
-
 # Driver uses below experimental APIs
 # rte_mem_iova2virt
 # rte_mem_virt2memseg
drivers/net/qede/Makefile +0 -2
index a11d5946a1..ada33800c4 100644
@@ -19,8 +19,6 @@ LDLIBS += -lrte_bus_pci
 
 EXPORT_MAP := rte_pmd_qede_version.map
 
-LIBABIVER := 1
-
 #
 # OS
 #
drivers/net/ring/Makefile +0 -2
index 517312e0e0..d6a3dec350 100644
@@ -16,8 +16,6 @@ LDLIBS += -lrte_bus_vdev
 
 EXPORT_MAP := rte_pmd_ring_version.map
 
-LIBABIVER := 2
-
 #
 # all source are stored in SRCS-y
 #
drivers/net/ring/meson.build +0 -1
index 7659b04f87..e877a4b4bd 100644
@@ -1,6 +1,5 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 2
 sources = files('rte_eth_ring.c')
 install_headers('rte_eth_ring.h')
drivers/net/sfc/Makefile +0 -2
index 7dd660dadf..1f9c0bc3e0 100644
@@ -62,8 +62,6 @@ $(foreach obj, $(BASE_DRIVER_OBJS), \
 
 EXPORT_MAP := rte_pmd_sfc_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/net/softnic/Makefile +0 -2
index 71cfd45ad8..5068ffa18a 100644
@@ -19,8 +19,6 @@ LDLIBS += -lrte_bus_vdev
 
 EXPORT_MAP := rte_pmd_softnic_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/net/szedata2/Makefile +0 -2
index b77fae16db..675d0938a2 100644
@@ -17,8 +17,6 @@ LDLIBS += -lrte_bus_pci
 
 EXPORT_MAP := rte_pmd_szedata2_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/net/tap/Makefile +0 -2
index 774828386d..088fa8f9a9 100644
@@ -10,8 +10,6 @@ LIB = librte_pmd_tap.a
 
 EXPORT_MAP := rte_pmd_tap_version.map
 
-LIBABIVER := 1
-
 #
 # TAP_MAX_QUEUES must be a power of 2
 #
drivers/net/thunderx/Makefile +0 -2
index e6bf497522..149638a499 100644
@@ -18,8 +18,6 @@ LDLIBS += -lrte_bus_pci
 
 EXPORT_MAP := rte_pmd_thunderx_version.map
 
-LIBABIVER := 1
-
 OBJS_BASE_DRIVER=$(sort $(patsubst %.c,%.o,$(notdir $(wildcard $(SRCDIR)/base/*.c))))
 $(foreach obj, $(OBJS_BASE_DRIVER), $(eval CFLAGS_$(obj)+=$(CFLAGS_BASE_DRIVER)))
 
drivers/net/vdev_netvsc/Makefile +0 -1
index 690cb8f88d..9cd81225b3 100644
@@ -6,7 +6,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
 
 # Properties of the generated library.
 LIB = librte_pmd_vdev_netvsc.a
-LIBABIVER := 1
 EXPORT_MAP := rte_pmd_vdev_netvsc_version.map
 
 # Additional compilation flags.
drivers/net/vhost/Makefile +0 -2
index 83b5a8b8e7..0461e29f2c 100644
@@ -18,8 +18,6 @@ CFLAGS += $(WERROR_FLAGS)
 
 EXPORT_MAP := rte_pmd_vhost_version.map
 
-LIBABIVER := 2
-
 #
 # all source are stored in SRCS-y
 #
drivers/net/vhost/meson.build +0 -1
index 9532a76050..d7930862a7 100644
@@ -3,7 +3,6 @@
 
 build = dpdk_conf.has('RTE_LIBRTE_VHOST')
 reason = 'missing dependency, DPDK vhost library'
-version = 2
 sources = files('rte_eth_vhost.c')
 install_headers('rte_eth_vhost.h')
 deps += 'vhost'
drivers/net/virtio/Makefile +0 -2
index 5144e7cc4a..efdcb0d93f 100644
@@ -20,8 +20,6 @@ endif
 
 EXPORT_MAP := rte_pmd_virtio_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/net/vmxnet3/Makefile +0 -2
index f1141da674..3a63cf2e91 100644
@@ -45,8 +45,6 @@ VPATH += $(SRCDIR)/base
 
 EXPORT_MAP := rte_pmd_vmxnet3_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/raw/dpaa2_cmdif/Makefile +0 -2
index a7c9802476..f671a30ccf 100644
@@ -26,8 +26,6 @@ LDLIBS += -lrte_common_dpaax
 
 EXPORT_MAP := rte_rawdev_dpaa2_cmdif_version.map
 
-LIBABIVER := 2
-
 #
 # all source are stored in SRCS-y
 #
drivers/raw/dpaa2_cmdif/meson.build +0 -2
index 9ba1ae2dea..70247622bc 100644
@@ -1,8 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright 2018 NXP
 
-version = 2
-
 build = dpdk_conf.has('RTE_LIBRTE_DPAA2_MEMPOOL')
 reason = 'missing dependency, DPDK DPAA2 mempool driver'
 deps += ['rawdev', 'mempool_dpaa2', 'bus_vdev']
drivers/raw/dpaa2_qdma/Makefile +0 -2
index 057b2a81a2..fc5b3435b0 100644
@@ -27,8 +27,6 @@ LDLIBS += -lrte_common_dpaax
 
 EXPORT_MAP := rte_rawdev_dpaa2_qdma_version.map
 
-LIBABIVER := 3
-
 #
 # all source are stored in SRCS-y
 #
drivers/raw/dpaa2_qdma/meson.build +0 -2
index f70ade3b4d..fe166d9183 100644
@@ -1,8 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright 2018 NXP
 
-version = 2
-
 build = dpdk_conf.has('RTE_LIBRTE_DPAA2_MEMPOOL')
 reason = 'missing dependency, DPDK DPAA2 mempool driver'
 deps += ['rawdev', 'mempool_dpaa2', 'ring', 'kvargs']
drivers/raw/ifpga/Makefile +0 -2
index 655b292883..b041a2bd70 100644
@@ -23,8 +23,6 @@ LDLIBS += -lrte_bus_ifpga
 
 EXPORT_MAP := rte_rawdev_ifpga_version.map
 
-LIBABIVER := 1
-
 VPATH += $(SRCDIR)/base
 
 include $(RTE_SDK)/drivers/raw/ifpga/base/Makefile
drivers/raw/ifpga/meson.build +0 -2
index 0ab6fd7110..5a221cd405 100644
@@ -1,8 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Intel Corporation
 
-version = 1
-
 subdir('base')
 objs = [base_objs]
 
drivers/raw/ioat/Makefile +0 -3
index e852afb57c..1609fe5e6c 100644
@@ -14,9 +14,6 @@ LDLIBS += -lrte_eal -lrte_rawdev
 LDLIBS += -lrte_pci -lrte_bus_pci
 LDLIBS += -lrte_mbuf -lrte_mempool
 
-# library version
-LIBABIVER := 1
-
 # versioning export map
 EXPORT_MAP := rte_rawdev_ioat_version.map
 
drivers/raw/ntb/Makefile +0 -2
index 814cd05ca1..d69b4306bc 100644
@@ -17,8 +17,6 @@ LDLIBS += -lrte_rawdev
 
 EXPORT_MAP := rte_rawdev_ntb_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/raw/octeontx2_dma/Makefile +0 -2
index f101e4916e..c64ca3497a 100644
@@ -24,8 +24,6 @@ endif
 
 EXPORT_MAP := rte_rawdev_octeontx2_dma_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
drivers/raw/skeleton/Makefile +0 -2
index 783b1e9522..2ac66fbd45 100644
@@ -17,8 +17,6 @@ LDLIBS += -lrte_kvargs
 
 EXPORT_MAP := rte_rawdev_skeleton_version.map
 
-LIBABIVER := 1
-
 #
 # all source are stored in SRCS-y
 #
examples/ethtool/lib/Makefile +0 -2
index 9da7dc3ba2..47cad4a1bc 100644
@@ -18,8 +18,6 @@ endif
 # library name
 LIB = librte_ethtool.a
 
-LIBABIVER := 1
-
 # all source are stored in SRC-Y
 SRCS-y := rte_ethtool.c
 
lib/librte_acl/Makefile +0 -2
index ea5edf00ab..f4332b0448 100644
@@ -12,8 +12,6 @@ LDLIBS += -lrte_eal
 
 EXPORT_MAP := rte_acl_version.map
 
-LIBABIVER := 2
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_ACL) += tb_mem.c
 
lib/librte_acl/meson.build +0 -1
index 98ece7d85f..d1e2c184cc 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 2
 sources = files('acl_bld.c', 'acl_gen.c', 'acl_run_scalar.c',
 		'rte_acl.c', 'tb_mem.c')
 headers = files('rte_acl.h', 'rte_acl_osdep.h')
lib/librte_bbdev/Makefile +0 -3
index 1451adb25d..cdabf64f47 100644
@@ -6,9 +6,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
 # library name
 LIB = librte_bbdev.a
 
-# library version
-LIBABIVER := 1
-
 # build flags
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 CFLAGS += -O3
lib/librte_bitratestats/Makefile +0 -2
index 59318388dd..4862c44b83 100644
@@ -11,8 +11,6 @@ LDLIBS += -lrte_eal -lrte_metrics -lrte_ethdev
 
 EXPORT_MAP := rte_bitratestats_version.map
 
-LIBABIVER := 2
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_BITRATE) := rte_bitrate.c
 
lib/librte_bitratestats/meson.build +0 -1
index c35b62b3dc..ede7e0a579 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 2
 sources = files('rte_bitrate.c')
 headers = files('rte_bitrate.h')
 deps += ['ethdev', 'metrics']
lib/librte_bpf/Makefile +0 -2
index 419a5162e0..3a20f95e74 100644
@@ -18,8 +18,6 @@ endif
 
 EXPORT_MAP := rte_bpf_version.map
 
-LIBABIVER := 1
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_BPF) += bpf.c
 SRCS-$(CONFIG_RTE_LIBRTE_BPF) += bpf_exec.c
lib/librte_cfgfile/Makefile +0 -2
index 2c7115f417..d3b08420ff 100644
@@ -15,8 +15,6 @@ LDLIBS += -lrte_eal
 
 EXPORT_MAP := rte_cfgfile_version.map
 
-LIBABIVER := 2
-
 #
 # all source are stored in SRCS-y
 #
lib/librte_cfgfile/meson.build +0 -1
index d97b38bc6f..88eb819856 100644
@@ -1,6 +1,5 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 2
 sources = files('rte_cfgfile.c')
 headers = files('rte_cfgfile.h')
lib/librte_cmdline/Makefile +0 -2
index 04057d7c67..5bcaecc338 100644
@@ -11,8 +11,6 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API
 
 EXPORT_MAP := rte_cmdline_version.map
 
-LIBABIVER := 2
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) := cmdline.c
 SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) += cmdline_cirbuf.c
lib/librte_cmdline/meson.build +0 -1
index 07334c1b09..a7dd319664 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 2
 allow_experimental_apis = true
 sources = files('cmdline.c',
 	'cmdline_cirbuf.c',
lib/librte_compressdev/Makefile +0 -3
index 7ef89e6130..112cdc5b28 100644
@@ -6,9 +6,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
 # library name
 LIB = librte_compressdev.a
 
-# library version
-LIBABIVER := 1
-
 # build flags
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
lib/librte_cryptodev/Makefile +0 -3
index 55d352a23a..7fac49afa3 100644
@@ -6,9 +6,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
 # library name
 LIB = librte_cryptodev.a
 
-# library version
-LIBABIVER := 8
-
 # build flags
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
lib/librte_cryptodev/meson.build +0 -1
index 0a2275d75b..49bae03a88 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017-2019 Intel Corporation
 
-version = 8
 allow_experimental_apis = true
 sources = files('rte_cryptodev.c', 'rte_cryptodev_pmd.c')
 headers = files('rte_cryptodev.h',
lib/librte_distributor/Makefile +0 -2
index 0ef80dcff4..a687f4a0f0 100644
@@ -12,8 +12,6 @@ LDLIBS += -lrte_eal -lrte_mbuf -lrte_ethdev
 
 EXPORT_MAP := rte_distributor_version.map
 
-LIBABIVER := 1
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) := rte_distributor_v20.c
 SRCS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) += rte_distributor.c
lib/librte_eal/freebsd/eal/Makefile +0 -2
index f530f568b6..b160b57906 100644
@@ -22,8 +22,6 @@ LDLIBS += -lrte_kvargs
 
 EXPORT_MAP := ../../rte_eal_version.map
 
-LIBABIVER := 12
-
 # specific to freebsd exec-env
 SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) := eal.c
 SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += eal_cpuflags.c
lib/librte_eal/linux/eal/Makefile +0 -2
index 7628e57119..e70cf104a4 100644
@@ -10,8 +10,6 @@ ARCH_DIR ?= $(RTE_ARCH)
 EXPORT_MAP := ../../rte_eal_version.map
 VPATH += $(RTE_SDK)/lib/librte_eal/common/arch/$(ARCH_DIR)
 
-LIBABIVER := 12
-
 VPATH += $(RTE_SDK)/lib/librte_eal/common
 
 CFLAGS += -DALLOW_EXPERIMENTAL_API
lib/librte_efd/Makefile +0 -2
index 5f5fcfcea2..2dc97132e0 100644
@@ -12,8 +12,6 @@ LDLIBS += -lrte_eal -lrte_ring -lrte_hash
 
 EXPORT_MAP := rte_efd_version.map
 
-LIBABIVER := 1
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_EFD) := rte_efd.c
 
lib/librte_ethdev/Makefile +0 -2
index 0efcdfa64d..b627e4e23b 100644
@@ -16,8 +16,6 @@ LDLIBS += -lrte_mbuf -lrte_kvargs -lrte_meter
 
 EXPORT_MAP := rte_ethdev_version.map
 
-LIBABIVER := 13
-
 SRCS-y += ethdev_private.c
 SRCS-y += rte_ethdev.c
 SRCS-y += rte_class_eth.c
lib/librte_ethdev/meson.build +0 -1
index c22cf81401..3537f22f59 100644
@@ -2,7 +2,6 @@
 # Copyright(c) 2017 Intel Corporation
 
 name = 'ethdev'
-version = 13
 allow_experimental_apis = true
 sources = files('ethdev_private.c',
 	'ethdev_profile.c',
lib/librte_eventdev/Makefile +0 -3
index 9e6a99aa15..1052ccdbb5 100644
@@ -7,9 +7,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
 # library name
 LIB = librte_eventdev.a
 
-# library version
-LIBABIVER := 8
-
 # build flags
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 CFLAGS += -O3
lib/librte_eventdev/meson.build +0 -1
index 9ba6c0393b..02ac61ad2c 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 8
 allow_experimental_apis = true
 
 if is_linux
lib/librte_fib/Makefile +0 -2
index 4abd80be68..7773427d19 100644
@@ -14,8 +14,6 @@ LDLIBS += -lrte_eal -lrte_rib
 
 EXPORT_MAP := rte_fib_version.map
 
-LIBABIVER := 1
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_FIB) := rte_fib.c rte_fib6.c dir24_8.c trie.c
 
lib/librte_flow_classify/Makefile +0 -2
index fe9fc47ab6..34298af1a4 100644
@@ -12,8 +12,6 @@ CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR)
 
 EXPORT_MAP := rte_flow_classify_version.map
 
-LIBABIVER := 1
-
 LDLIBS += -lrte_eal -lrte_ethdev -lrte_net -lrte_table -lrte_acl
 
 # all source are stored in SRCS-y
lib/librte_gro/Makefile +0 -2
index bec248f922..e848687acd 100644
@@ -12,8 +12,6 @@ LDLIBS += -lrte_eal -lrte_mbuf -lrte_ethdev -lrte_net
 
 EXPORT_MAP := rte_gro_version.map
 
-LIBABIVER := 1
-
 # source files
 SRCS-$(CONFIG_RTE_LIBRTE_GRO) += rte_gro.c
 SRCS-$(CONFIG_RTE_LIBRTE_GRO) += gro_tcp4.c
lib/librte_gso/Makefile +0 -2
index 1fac53a8f4..a34846e920 100644
@@ -12,8 +12,6 @@ LDLIBS += -lrte_mempool
 
 EXPORT_MAP := rte_gso_version.map
 
-LIBABIVER := 1
-
 #source files
 SRCS-$(CONFIG_RTE_LIBRTE_GSO) += rte_gso.c
 SRCS-$(CONFIG_RTE_LIBRTE_GSO) += gso_common.c
lib/librte_hash/Makefile +0 -2
index 5669d83f45..9b36097f47 100644
@@ -12,8 +12,6 @@ LDLIBS += -lrte_eal -lrte_ring
 
 EXPORT_MAP := rte_hash_version.map
 
-LIBABIVER := 2
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_HASH) := rte_cuckoo_hash.c
 SRCS-$(CONFIG_RTE_LIBRTE_HASH) += rte_fbk_hash.c
lib/librte_hash/meson.build +0 -1
index ebf70de890..5d02b3084f 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 2
 headers = files('rte_cmp_arm64.h',
 	'rte_cmp_x86.h',
 	'rte_crc_arm64.h',
lib/librte_ip_frag/Makefile +0 -2
index 4c3dc4d375..6b80d9f1f2 100644
@@ -13,8 +13,6 @@ LDLIBS += -lrte_hash
 
 EXPORT_MAP := rte_ip_frag_version.map
 
-LIBABIVER := 1
-
 #source files
 SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += rte_ipv4_fragmentation.c
 SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += rte_ipv6_fragmentation.c
lib/librte_ipsec/Makefile +0 -2
index 161ea9e3d9..f74e8a9045 100644
@@ -14,8 +14,6 @@ LDLIBS += -lrte_cryptodev -lrte_security -lrte_hash
 
 EXPORT_MAP := rte_ipsec_version.map
 
-LIBABIVER := 2
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += esp_inb.c
 SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += esp_outb.c
lib/librte_ipsec/meson.build +0 -1
index e8604dadd9..70358526b0 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Intel Corporation
 
-version = 2
 allow_experimental_apis = true
 
 sources = files('esp_inb.c', 'esp_outb.c', 'sa.c', 'ses.c', 'ipsec_sad.c')
lib/librte_jobstats/Makefile +0 -2
index 35e788f7fc..b30d046829 100644
@@ -12,8 +12,6 @@ LDLIBS += -lrte_eal
 
 EXPORT_MAP := rte_jobstats_version.map
 
-LIBABIVER := 1
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_JOBSTATS) := rte_jobstats.c
 
lib/librte_kni/Makefile +0 -2
index cbd6599ec2..9d440aa135 100644
@@ -11,8 +11,6 @@ LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev
 
 EXPORT_MAP := rte_kni_version.map
 
-LIBABIVER := 2
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_KNI) := rte_kni.c
 
lib/librte_kni/meson.build +0 -1
index 41fa2e39bb..963eae6fe0 100644
@@ -5,7 +5,6 @@ if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
 	build = false
 	reason = 'only supported on 64-bit linux'
 endif
-version = 2
 sources = files('rte_kni.c')
 headers = files('rte_kni.h')
 deps += ['ethdev', 'pci']
lib/librte_kvargs/Makefile +0 -2
index 8759395478..419be8bd7c 100644
@@ -11,8 +11,6 @@ CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include
 
 EXPORT_MAP := rte_kvargs_version.map
 
-LIBABIVER := 1
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_KVARGS) := rte_kvargs.c
 
lib/librte_kvargs/meson.build +0 -1
index ecaedf5a59..b746516965 100644
@@ -3,6 +3,5 @@
 
 includes = [global_inc]
 
-version = 1
 sources = files('rte_kvargs.c')
 headers = files('rte_kvargs.h')
lib/librte_latencystats/Makefile +0 -2
index ae0dbd8f06..b19e0b1788 100644
@@ -13,8 +13,6 @@ LDLIBS += -lrte_eal -lrte_metrics -lrte_ethdev -lrte_mbuf
 
 EXPORT_MAP := rte_latencystats_version.map
 
-LIBABIVER := 1
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_LATENCY_STATS) := rte_latencystats.c
 
lib/librte_lpm/Makefile +0 -2
index a7946a1c52..d682785b63 100644
@@ -12,8 +12,6 @@ LDLIBS += -lrte_eal -lrte_hash
 
 EXPORT_MAP := rte_lpm_version.map
 
-LIBABIVER := 2
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_LPM) := rte_lpm.c rte_lpm6.c
 
lib/librte_lpm/meson.build +0 -1
index 4e3920660b..27ce45b531 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 2
 sources = files('rte_lpm.c', 'rte_lpm6.c')
 headers = files('rte_lpm.h', 'rte_lpm6.h')
 # since header files have different names, we can install all vector headers
lib/librte_mbuf/Makefile +0 -2
index 019c8dd8ff..9f6e6387f9 100644
@@ -13,8 +13,6 @@ LDLIBS += -lrte_eal -lrte_mempool
 
 EXPORT_MAP := rte_mbuf_version.map
 
-LIBABIVER := 5
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_MBUF) := rte_mbuf.c rte_mbuf_ptype.c rte_mbuf_pool_ops.c
 SRCS-$(CONFIG_RTE_LIBRTE_MBUF) += rte_mbuf_dyn.c
lib/librte_mbuf/meson.build +0 -1
index 59fd07224d..d9b53b6ae3 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 5
 sources = files('rte_mbuf.c', 'rte_mbuf_ptype.c', 'rte_mbuf_pool_ops.c',
 	'rte_mbuf_dyn.c')
 headers = files('rte_mbuf.h', 'rte_mbuf_core.h',
lib/librte_member/Makefile +0 -2
index e9580c9679..ef9e2faeaf 100644
@@ -14,8 +14,6 @@ LDLIBS += -lrte_eal -lrte_hash
 
 EXPORT_MAP := rte_member_version.map
 
-LIBABIVER := 1
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_MEMBER) +=  rte_member.c rte_member_ht.c rte_member_vbf.c
 # install includes
lib/librte_mempool/Makefile +0 -2
index 20bf63fbca..a5649050b1 100644
@@ -12,8 +12,6 @@ LDLIBS += -lrte_eal -lrte_ring
 
 EXPORT_MAP := rte_mempool_version.map
 
-LIBABIVER := 5
-
 # memseg walk is not yet part of stable API
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 
lib/librte_mempool/meson.build +0 -1
index 38d7ae8905..f8710b61bc 100644
@@ -11,7 +11,6 @@ foreach flag: extra_flags
 	endif
 endforeach
 
-version = 5
 sources = files('rte_mempool.c', 'rte_mempool_ops.c',
 		'rte_mempool_ops_default.c')
 headers = files('rte_mempool.h')
lib/librte_meter/Makefile +0 -2
index 79ad79744f..48366e82b0 100644
@@ -16,8 +16,6 @@ LDLIBS += -lrte_eal
 
 EXPORT_MAP := rte_meter_version.map
 
-LIBABIVER := 3
-
 #
 # all source are stored in SRCS-y
 #
lib/librte_meter/meson.build +0 -1
index 422123e203..646fd4d43f 100644
@@ -1,6 +1,5 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 3
 sources = files('rte_meter.c')
 headers = files('rte_meter.h')
lib/librte_metrics/Makefile +0 -2
index 20e242f736..6b385f5cf1 100644
@@ -11,8 +11,6 @@ LDLIBS += -lrte_eal
 
 EXPORT_MAP := rte_metrics_version.map
 
-LIBABIVER := 1
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_METRICS) := rte_metrics.c
 
lib/librte_net/Makefile +0 -2
index c79f84d7c6..aabdf4879d 100644
@@ -10,8 +10,6 @@ CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) -O3
 LDLIBS += -lrte_mbuf -lrte_eal -lrte_mempool
 
 EXPORT_MAP := rte_net_version.map
-LIBABIVER := 1
-
 SRCS-$(CONFIG_RTE_LIBRTE_NET) := rte_net.c
 SRCS-$(CONFIG_RTE_LIBRTE_NET) += rte_net_crc.c
 SRCS-$(CONFIG_RTE_LIBRTE_NET) += rte_ether.c
lib/librte_net/meson.build +0 -1
index 090284b688..208eee2dc2 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 1
 allow_experimental_apis = true
 headers = files('rte_ip.h',
 	'rte_tcp.h',
lib/librte_pci/Makefile +0 -2
index 4c2682eadd..7943f30cab 100644
@@ -12,8 +12,6 @@ LDLIBS += -lrte_eal
 
 EXPORT_MAP := rte_pci_version.map
 
-LIBABIVER := 2
-
 SRCS-$(CONFIG_RTE_LIBRTE_PCI) += rte_pci.c
 
 SYMLINK-$(CONFIG_RTE_LIBRTE_PCI)-include += rte_pci.h
lib/librte_pci/meson.build +0 -2
index 376f04ac65..dd41cd5068 100644
@@ -1,7 +1,5 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 2
-
 sources = files('rte_pci.c')
 headers = files('rte_pci.h')
lib/librte_pdump/Makefile +0 -2
index 89593689a7..fde8ac92b8 100644
@@ -12,8 +12,6 @@ LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev
 
 EXPORT_MAP := rte_pdump_version.map
 
-LIBABIVER := 3
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_PDUMP) := rte_pdump.c
 
lib/librte_pdump/meson.build +0 -1
index b4b4f26c56..1173cdea34 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 3
 sources = files('rte_pdump.c')
 headers = files('rte_pdump.h')
 allow_experimental_apis = true
lib/librte_pipeline/Makefile +0 -2
index cf265503f7..d2abb5f3ff 100644
@@ -16,8 +16,6 @@ LDLIBS += -lrte_port -lrte_meter -lrte_sched -lrte_cryptodev
 
 EXPORT_MAP := rte_pipeline_version.map
 
-LIBABIVER := 3
-
 #
 # all source are stored in SRCS-y
 #
lib/librte_pipeline/meson.build +0 -1
index 04e5f51798..be8a3536af 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 3
 allow_experimental_apis = true
 sources = files('rte_pipeline.c', 'rte_port_in_action.c', 'rte_table_action.c')
 headers = files('rte_pipeline.h', 'rte_port_in_action.h', 'rte_table_action.h')
lib/librte_port/Makefile +0 -2
index de6f0428a4..57d2aedbc5 100644
@@ -21,8 +21,6 @@ CFLAGS += $(WERROR_FLAGS)
 
 EXPORT_MAP := rte_port_version.map
 
-LIBABIVER := 3
-
 #
 # all source are stored in SRCS-y
 #
lib/librte_port/meson.build +0 -1
index a232cb587b..0d5ede44a0 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 3
 sources = files(
 	'rte_port_ethdev.c',
 	'rte_port_fd.c',
lib/librte_power/Makefile +0 -2
index ab771528fe..9a6db07e5f 100644
@@ -12,8 +12,6 @@ LDLIBS += -lrte_eal -lrte_timer
 
 EXPORT_MAP := rte_power_version.map
 
-LIBABIVER := 1
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_POWER) := rte_power.c power_acpi_cpufreq.c
 SRCS-$(CONFIG_RTE_LIBRTE_POWER) += power_kvm_vm.c guest_channel.c
lib/librte_rawdev/Makefile +0 -3
index addb288d76..7dd1197dcd 100644
@@ -6,9 +6,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
 # library name
 LIB = librte_rawdev.a
 
-# library version
-LIBABIVER := 1
-
 # build flags
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
lib/librte_rcu/Makefile +0 -2
index 6aa677bd12..c4bb28d779 100644
@@ -12,8 +12,6 @@ LDLIBS += -lrte_eal
 
 EXPORT_MAP := rte_rcu_version.map
 
-LIBABIVER := 1
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_RCU) := rte_rcu_qsbr.c
 
lib/librte_reorder/Makefile +0 -2
index f19c624bd0..1914411d52 100644
@@ -12,8 +12,6 @@ LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf
 
 EXPORT_MAP := rte_reorder_version.map
 
-LIBABIVER := 1
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_REORDER) := rte_reorder.c
 
lib/librte_rib/Makefile +0 -2
index 6d861adb1c..4a1df4e06a 100644
@@ -14,8 +14,6 @@ LDLIBS += -lrte_eal -lrte_mempool
 
 EXPORT_MAP := rte_rib_version.map
 
-LIBABIVER := 1
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_RIB) := rte_rib.c rte_rib6.c
 
lib/librte_ring/Makefile +0 -2
index 21a36770d4..22454b0848 100644
@@ -11,8 +11,6 @@ LDLIBS += -lrte_eal
 
 EXPORT_MAP := rte_ring_version.map
 
-LIBABIVER := 2
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_RING) := rte_ring.c
 
lib/librte_ring/meson.build +0 -1
index ab8b0b469b..ca8a435e90 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 2
 sources = files('rte_ring.c')
 headers = files('rte_ring.h',
 		'rte_ring_c11_mem.h',
lib/librte_sched/Makefile +0 -2
index 6e4a72d896..aee93a1205 100644
@@ -18,8 +18,6 @@ LDLIBS += -lrte_timer
 
 EXPORT_MAP := rte_sched_version.map
 
-LIBABIVER := 4
-
 #
 # all source are stored in SRCS-y
 #
lib/librte_sched/meson.build +0 -1
index 9f40a2368f..f85d64df81 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 4
 sources = files('rte_sched.c', 'rte_red.c', 'rte_approx.c')
 headers = files('rte_sched.h', 'rte_sched_common.h',
 		'rte_red.h', 'rte_approx.h')
lib/librte_security/Makefile +0 -3
index 6a268ee2a7..825eaeff8e 100644
@@ -6,9 +6,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
 # library name
 LIB = librte_security.a
 
-# library version
-LIBABIVER := 3
-
 # build flags
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
lib/librte_security/meson.build +0 -1
index 6fed012731..5679c8b5c2 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017-2019 Intel Corporation
 
-version = 3
 sources = files('rte_security.c')
 headers = files('rte_security.h', 'rte_security_driver.h')
 deps += ['mempool', 'cryptodev']
lib/librte_stack/Makefile +0 -2
index b5e5bed7cf..94ee48d4b3 100644
@@ -12,8 +12,6 @@ LDLIBS += -lrte_eal
 
 EXPORT_MAP := rte_stack_version.map
 
-LIBABIVER := 1
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_STACK) := rte_stack.c \
 				   rte_stack_std.c \
lib/librte_stack/meson.build +0 -1
index 46fce0c20f..f420a5c223 100644
@@ -3,7 +3,6 @@
 
 allow_experimental_apis = true
 
-version = 1
 sources = files('rte_stack.c', 'rte_stack_std.c', 'rte_stack_lf.c')
 headers = files('rte_stack.h',
 		'rte_stack_std.h',
lib/librte_table/Makefile +0 -2
index f935678a52..6ad8a6b17d 100644
@@ -18,8 +18,6 @@ endif
 
 EXPORT_MAP := rte_table_version.map
 
-LIBABIVER := 3
-
 #
 # all source are stored in SRCS-y
 #
lib/librte_table/meson.build +0 -1
index 6ae3cd6c03..71d1347687 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 3
 sources = files('rte_table_acl.c',
 		'rte_table_lpm.c',
 		'rte_table_lpm_ipv6.c',
lib/librte_telemetry/Makefile +0 -2
index 1b3fe05475..f364548556 100644
@@ -17,8 +17,6 @@ LDLIBS += -ljansson
 
 EXPORT_MAP := rte_telemetry_version.map
 
-LIBABIVER := 1
-
 # library source files
 SRCS-$(CONFIG_RTE_LIBRTE_TELEMETRY) := rte_telemetry.c
 SRCS-$(CONFIG_RTE_LIBRTE_TELEMETRY) += rte_telemetry_parser.c
lib/librte_timer/Makefile +0 -2
index 8ec63f455f..1c290b4c2d 100644
@@ -12,8 +12,6 @@ LDLIBS += -lrte_eal
 
 EXPORT_MAP := rte_timer_version.map
 
-LIBABIVER := 1
-
 # all source are stored in SRCS-y
 SRCS-$(CONFIG_RTE_LIBRTE_TIMER) := rte_timer.c
 
lib/librte_vhost/Makefile +0 -2
index 87ce1fb270..c5cf6632d7 100644
@@ -8,8 +8,6 @@ LIB = librte_vhost.a
 
 EXPORT_MAP := rte_vhost_version.map
 
-LIBABIVER := 4
-
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) -O3
 CFLAGS += -I vhost_user
lib/librte_vhost/meson.build +0 -1
index 00435777e2..ef7a5bced4 100644
@@ -17,7 +17,6 @@ elif (toolchain == 'icc' and cc.version().version_compare('>=16.0.0'))
 endif
 dpdk_conf.set('RTE_LIBRTE_VHOST_POSTCOPY',
 	      cc.has_header('linux/userfaultfd.h'))
-version = 4
 allow_experimental_apis = true
 cflags += '-fno-strict-aliasing'
 sources = files('fd_man.c', 'iotlb.c', 'socket.c', 'vdpa.c',
Signature · 1 line
2.17.1
#114 lore raw

Re: [dpdk-dev] [PATCH v8 03/12] build: remove individual library versions

Quoted 12 lines · Anatoly Burakov

Since the library versioning for both stable and experimental ABI's is now managed globally, the LIBABIVER and version variables no longer serve any useful purpose, and can be removed.

The replacement in Makefiles was done using the following regex:

        ^(#.*\n)?LIBABIVER\s*:=\s*\d+\n(\s*\n)?

(LIBABIVER := numbers, optionally preceded by a comment and optionally succeeded by an empty line)

Quoted 8 lines

The replacement for meson files was done using the following regex:

        ^(#.*\n)?version\s*=\s*\d+\n(\s*\n)?

(version = numbers, optionally preceded by a comment and optionally succeeded by an empty line)

Caught two leftovers:

[dmarchan@dmarchan dpdk.org]$ git ls-tree -r HEAD --name-only |grep Makefile |xargs grep '\<LIBABIVER\>[[:space:]]*:*='
drivers/common/qat/Makefile: LIBABIVER := 1
[dmarchan@dmarchan dpdk.org]$ git ls-tree -r HEAD --name-only |grep meson.build |xargs grep '\<version\>[[:space:]]*=' lib/librte_eal/meson.build:version = 12 # the version of the EAL API

I will fix when applying and add a little note about them in the commitlog.

Signature · 1 line
David Marchand
#115 lore raw

PATCH v8 4/12 buildtools: add script for updating symbols abi version

In reply to Anatoly Burakov

From: Pawel Modrak <[email protected]>

Add a script that automatically merges all stable ABI's under one ABI section with the new version, while leaving experimental section exactly as it is.

---

Notes:
v7:
- Do not remove stable ABI if it was empty

v6:
- Split map file generation function in two
- Do not print stable ABI if it wasn't present

v3:
- Add comments to regex patterns

v2:
- Reworked script to be pep8-compliant and more reliable

 buildtools/update_version_map_abi.py | 175 +++++++++++++++++++++++++++
 1 file changed, 175 insertions(+)
 create mode 100755 buildtools/update_version_map_abi.py
buildtools/update_version_map_abi.py new file +175 -0
new file mode 100755
index 0000000000..87fed54653
@@ -0,0 +1,175 @@
+#!/usr/bin/env python
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2019 Intel Corporation
+
+"""
+A Python program that updates and merges all available stable ABI versions into
+one ABI version, while leaving experimental ABI exactly as it is. The intended
+ABI version is supplied via command-line parameter. This script is to be called
+from the buildtools/update_abi.sh utility.
+"""
+
+from __future__ import print_function
+import argparse
+import sys
+import re
+
+
+def __parse_map_file(f_in):
+    # match function name, followed by semicolon, followed by EOL, optionally
+    # with whitespace inbetween each item
+    func_line_regex = re.compile(r"\s*"
+                                 r"(?P<func>[a-zA-Z_0-9]+)"
+                                 r"\s*"
+                                 r";"
+                                 r"\s*"
+                                 r"$")
+    # match section name, followed by opening bracked, followed by EOL,
+    # optionally with whitespace inbetween each item
+    section_begin_regex = re.compile(r"\s*"
+                                     r"(?P<version>[a-zA-Z0-9_\.]+)"
+                                     r"\s*"
+                                     r"{"
+                                     r"\s*"
+                                     r"$")
+    # match closing bracket, optionally followed by section name (for when we
+    # inherit from another ABI version), followed by semicolon, followed by
+    # EOL, optionally with whitespace inbetween each item
+    section_end_regex = re.compile(r"\s*"
+                                   r"}"
+                                   r"\s*"
+                                   r"(?P<parent>[a-zA-Z0-9_\.]+)?"
+                                   r"\s*"
+                                   r";"
+                                   r"\s*"
+                                   r"$")
+
+    # for stable ABI, we don't care about which version introduced which
+    # function, we just flatten the list. there are dupes in certain files, so
+    # use a set instead of a list
+    stable_lines = set()
+    # copy experimental section as is
+    experimental_lines = []
+    in_experimental = False
+    has_stable = False
+
+    # gather all functions
+    for line in f_in:
+        # clean up the line
+        line = line.strip('\n').strip()
+
+        # is this an end of section?
+        match = section_end_regex.match(line)
+        if match:
+            # whatever section this was, it's not active any more
+            in_experimental = False
+            continue
+
+        # if we're in the middle of experimental section, we need to copy
+        # the section verbatim, so just add the line
+        if in_experimental:
+            experimental_lines += [line]
+            continue
+
+        # skip empty lines
+        if not line:
+            continue
+
+        # is this a beginning of a new section?
+        match = section_begin_regex.match(line)
+        if match:
+            cur_section = match.group("version")
+            # is it experimental?
+            in_experimental = cur_section == "EXPERIMENTAL"
+            if not in_experimental:
+                has_stable = True
+            continue
+
+        # is this a function?
+        match = func_line_regex.match(line)
+        if match:
+            stable_lines.add(match.group("func"))
+
+    return has_stable, stable_lines, experimental_lines
+
+
+def __generate_stable_abi(f_out, abi_version, lines):
+    # print ABI version header
+    print("DPDK_{} {{".format(abi_version), file=f_out)
+
+    # print global section if it exists
+    if lines:
+        print("\tglobal:", file=f_out)
+        # blank line
+        print(file=f_out)
+
+        # print all stable lines, alphabetically sorted
+        for line in sorted(lines):
+            print("\t{};".format(line), file=f_out)
+
+        # another blank line
+        print(file=f_out)
+
+    # print local section
+    print("\tlocal: *;", file=f_out)
+
+    # end stable version
+    print("};", file=f_out)
+
+
+def __generate_experimental_abi(f_out, lines):
+    # start experimental section
+    print("EXPERIMENTAL {", file=f_out)
+
+    # print all experimental lines as they were
+    for line in lines:
+        # don't print empty whitespace
+        if not line:
+            print("", file=f_out)
+        else:
+            print("\t{}".format(line), file=f_out)
+
+    # end section
+    print("};", file=f_out)
+
+
+def __main():
+    arg_parser = argparse.ArgumentParser(
+        description='Merge versions in linker version script.')
+
+    arg_parser.add_argument("map_file", type=str,
+                            help='path to linker version script file '
+                                 '(pattern: *version.map)')
+    arg_parser.add_argument("abi_version", type=str,
+                            help='target ABI version (pattern: MAJOR.MINOR)')
+
+    parsed = arg_parser.parse_args()
+
+    if not parsed.map_file.endswith('version.map'):
+        print("Invalid input file: {}".format(parsed.map_file),
+              file=sys.stderr)
+        arg_parser.print_help()
+        sys.exit(1)
+
+    if not re.match(r"\d{1,2}\.\d{1,2}", parsed.abi_version):
+        print("Invalid ABI version: {}".format(parsed.abi_version),
+              file=sys.stderr)
+        arg_parser.print_help()
+        sys.exit(1)
+
+    with open(parsed.map_file) as f_in:
+        has_stable, stable_lines, experimental_lines = __parse_map_file(f_in)
+
+    with open(parsed.map_file, 'w') as f_out:
+        need_newline = has_stable and experimental_lines
+        if has_stable:
+            __generate_stable_abi(f_out, parsed.abi_version, stable_lines)
+        if need_newline:
+            # separate sections with a newline
+            print(file=f_out)
+        if experimental_lines:
+            __generate_experimental_abi(f_out, experimental_lines)
+
+
+if __name__ == "__main__":
+    __main()
Signature · 1 line
2.17.1
#116 lore raw

Re: [dpdk-dev] [PATCH v8 04/12] buildtools: add script for updating symbols abi version

Quoted 6 lines · Anatoly Burakov
buildtools/update_version_map_abi.py new file +0 -0
new file mode 100755
index 0000000000..87fed54653

buildtools/update_version_map_abi.py line 9

Quoted 9 lines
buildtools/update_version_map_abi.py new file +9 -0
@@ -0,0 +1,175 @@
+#!/usr/bin/env python
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2019 Intel Corporation
+
+"""
+A Python program that updates and merges all available stable ABI versions into
+one ABI version, while leaving experimental ABI exactly as it is. The intended
+ABI version is supplied via command-line parameter. This script is to be called
+from the buildtools/update_abi.sh utility.

update-abi.sh

Will fix while applying.

Signature · 1 line
David Marchand