Skip to contentSkip to conversation

net/mlx5: fix wrong function of hairpin unbind

PATCH Applied Bing Zhao 2 participants 2 messages Nov 13, 2020 Network drivers

lore
Share & tools
lore

Bing Zhao

author
#0 lore raw

PATCH 1/1 net/mlx5: fix wrong function of hairpin unbind

In the implementation of mlx5_hairpin_unbind, a copy-paste error was inside. If a single peer Rx port needed to be unbound, it would be bound again by mistake.

All the hardware resources were released when stopping the device and no mess of the configuration was introduced. But when trying to unbind the ports again, the issue would appear.

The typo of the function call is fixed. If there is no hairpin queue bound between two ports, the unbinding process should be considered successful.

Fixes 37cd4501e873 ("net/mlx5: support two ports hairpin mode")
---
 drivers/net/mlx5/mlx5_trigger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mlx5/mlx5_trigger.c +1 -1
index 46e4191..bd02915 100644
@@ -934,7 +934,7 @@
 				return ret;
 		}
 	else
-		ret = mlx5_hairpin_bind_single_port(dev, rx_port);
+		ret = mlx5_hairpin_unbind_single_port(dev, rx_port);
 	return ret;
 }
 
Signature · 1 line
1.8.3.1
#1 lore raw

13/11/2020 08:05, Bing Zhao:

Quoted 8 lines

In the implementation of mlx5_hairpin_unbind, a copy-paste error was inside. If a single peer Rx port needed to be unbound, it would be bound again by mistake.

All the hardware resources were released when stopping the device and no mess of the configuration was introduced. But when trying to unbind the ports again, the issue would appear.

Quoted 8 lines

The typo of the function call is fixed. If there is no hairpin queue bound between two ports, the unbinding process should be considered successful.

Fixes 37cd4501e873 ("net/mlx5: support two ports hairpin mode")

Applied in next-net-mlx, thanks.