Skip to contentSkip to conversation

net/bnxt: fix compatibility with some old firmwares

PATCH In review David Marchand 3 participants 6 messages Mar 18, 2022 – May 23, 2022 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/bnxt: fix compatibility with some old firmwares

This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975.

Reported by Red Hat QE: with older firmware versions (at least versions 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this change.
Revert it for now, waiting for a more complete fix.

Fixes 3972281f47b2 ("net/bnxt: fix device readiness check")
---
 drivers/net/bnxt/bnxt_hwrm.c | 9 ---------
 1 file changed, 9 deletions(-)
drivers/net/bnxt/bnxt_hwrm.c +0 -9
index b4aeec593e..bff73a9566 100644
@@ -1244,11 +1244,6 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout)
 	else
 		HWRM_CHECK_RESULT();
 
-	if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY) {
-		rc = -EAGAIN;
-		goto error;
-	}
-
 	PMD_DRV_LOG(INFO, "%d.%d.%d:%d.%d.%d.%d\n",
 		resp->hwrm_intf_maj_8b, resp->hwrm_intf_min_8b,
 		resp->hwrm_intf_upd_8b, resp->hwrm_fw_maj_8b,
@@ -6149,10 +6144,6 @@ int bnxt_hwrm_poll_ver_get(struct bnxt *bp)
 	rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);
 
 	HWRM_CHECK_RESULT_SILENT();
-
-	if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY)
-		rc = -EAGAIN;
-
 	HWRM_UNLOCK();
 
 	return rc;
Signature · 1 line
2.23.0
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · David Marchand

This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975.

Reported by Red Hat QE: with older firmware versions (at least versions 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this change.
Revert it for now, waiting for a more complete fix.

Quoted 4 lines
Fixes 3972281f47b2 ("net/bnxt: fix device readiness check")

Patch applied to dpdk-next-net-brcm. Thanks

Quoted 34 lines
---
 drivers/net/bnxt/bnxt_hwrm.c | 9 ---------
 1 file changed, 9 deletions(-)
drivers/net/bnxt/bnxt_hwrm.c +0 -10
index b4aeec593e..bff73a9566 100644
@@ -1244,11 +1244,6 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout)
        else
                HWRM_CHECK_RESULT();
 
-       if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY) {
-               rc = -EAGAIN;
-               goto error;
-       }
-
        PMD_DRV_LOG(INFO, "%d.%d.%d:%d.%d.%d.%d\n",
                resp->hwrm_intf_maj_8b, resp->hwrm_intf_min_8b,
                resp->hwrm_intf_upd_8b, resp->hwrm_fw_maj_8b,
@@ -6149,10 +6144,6 @@ int bnxt_hwrm_poll_ver_get(struct bnxt *bp)
        rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);
 
        HWRM_CHECK_RESULT_SILENT();
-
-       if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY)
-               rc = -EAGAIN;
-
        HWRM_UNLOCK();
 
        return rc;
--

2.23.0

#2 lore raw

30/03/2022 01:21, Ajit Khaparde:

Quoted 10 lines
Quoted 8 lines · David Marchand

This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975.

Reported by Red Hat QE: with older firmware versions (at least versions 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this change.
Revert it for now, waiting for a more complete fix.

Quoted 7 lines
Quoted 4 lines
Fixes 3972281f47b2 ("net/bnxt: fix device readiness check")

Patch applied to dpdk-next-net-brcm. Thanks

It seems this patch has been lost.
I don't find it in dpdk-next-net-brcm.

#3 lore raw
Quoted 15 lines · Thomas Monjalon

30/03/2022 01:21, Ajit Khaparde:

Quoted 13 lines
Quoted 11 lines · David Marchand

This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975.

Reported by Red Hat QE: with older firmware versions (at least versions 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this change.
Revert it for now, waiting for a more complete fix.

Fixes 3972281f47b2 ("net/bnxt: fix device readiness check")
Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Patch applied to dpdk-next-net-brcm. Thanks

It seems this patch has been lost.
I don't find it in dpdk-next-net-brcm.

Hmm.. Yes.
I pushed it again. Please check. Thanks

Quoted 3 lines
#4 lore raw

18/05/2022 05:58, Ajit Khaparde:

Quoted 17 lines · Thomas Monjalon
Quoted 16 lines

30/03/2022 01:21, Ajit Khaparde:

Quoted 14 lines
Quoted 12 lines · David Marchand

This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975.

Reported by Red Hat QE: with older firmware versions (at least versions 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this change.
Revert it for now, waiting for a more complete fix.

Fixes 3972281f47b2 ("net/bnxt: fix device readiness check")
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Patch applied to dpdk-next-net-brcm. Thanks

It seems this patch has been lost.
I don't find it in dpdk-next-net-brcm.

Hmm.. Yes.
I pushed it again. Please check. Thanks

OK
Same issue with "net/bnxt: fix ulp parser to ignore segment offset "

#5 lore raw
Quoted 23 lines · Thomas Monjalon

18/05/2022 05:58, Ajit Khaparde:

Quoted 21 lines · Thomas Monjalon
Quoted 20 lines

30/03/2022 01:21, Ajit Khaparde:

Quoted 17 lines
Quoted 8 lines · David Marchand

This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975.

Reported by Red Hat QE: with older firmware versions (at least versions 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this change.
Revert it for now, waiting for a more complete fix.

Quoted 4 lines
Fixes 3972281f47b2 ("net/bnxt: fix device readiness check")

Patch applied to dpdk-next-net-brcm. Thanks

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

It seems this patch has been lost.
I don't find it in dpdk-next-net-brcm.

Hmm.. Yes.
I pushed it again. Please check. Thanks

OK
Same issue with "net/bnxt: fix ulp parser to ignore segment offset "

Thanks Thomas.
Pushed again to dpdk-next-net-brcm. Please apply.

Quoted 2 lines