Skip to contentSkip to conversation

ohci-s3c2410: use HUB_CHAR_*

PATCH New Sergei Shtylyov 1 participant 1 message Jan 18, 2015 1 message not in the archive

Subsystems (3)
USB Arm Samsung Exynos USB ohci driver
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Sergei Shtylyov

author
#1 lore raw

PATCH 12/23 ohci-s3c2410: use HUB_CHAR_*

Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in <linux/usb/ch11.h>.

While at it, stop setting already set HUB_CHAR_INDV_PORT_LPSM once again.

Signed-off-by Sergei Shtylyov <[email protected]>
---
 drivers/usb/host/ohci-s3c2410.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/usb/host/ohci-s3c2410.c +3 -3
Index: usb/drivers/usb/host/ohci-s3c2410.c
===================================================================
@@ -249,14 +249,14 @@ static int ohci_s3c2410_hub_control(
 		 */
 
 		desc->wHubCharacteristics &= ~cpu_to_le16(HUB_CHAR_LPSM);
-		desc->wHubCharacteristics |= cpu_to_le16(0x0001);
+		desc->wHubCharacteristics |= cpu_to_le16(
+			HUB_CHAR_INDV_PORT_LPSM);
 
 		if (info->enable_oc) {
 			desc->wHubCharacteristics &= ~cpu_to_le16(
 				HUB_CHAR_OCPM);
 			desc->wHubCharacteristics |=  cpu_to_le16(
-				0x0008 |
-				0x0001);
+				HUB_CHAR_INDV_PORT_OCPM);
 		}
 
 		dev_dbg(hcd->self.controller, "wHubCharacteristics after 0x%04x\n",