Skip to contentSkip to conversation

arm: dts: aspeed-bmc-tiogapass: enable second MAC

PATCH In review Paul Fertser 3 participants 4 messages Sep 30, 2020 – Nov 16, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: dts: aspeed-bmc-tiogapass: enable second MAC

Tioga Pass reference design includes Intel I210 Ethernet controller connected to the BMC with NC/SI.

MAC readout is not supported.

---
 arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts +8 -0
index 2d44d9ad4e40..b2ba798bf3c4 100644
@@ -196,6 +196,14 @@
 	use-ncsi;
 };
 
+&mac1 {
+	status = "okay";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_rmii2_default>;
+	use-ncsi;
+};
+
 &adc {
 	status = "okay";
 };
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 7 lines · Paul Fertser

Tioga Pass reference design includes Intel I210 Ethernet controller connected to the BMC with NC/SI.

MAC readout is not supported.

Vijay, can I get a review from you on this one please?

Quoted 26 lines
---
 arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts +8 -1
index 2d44d9ad4e40..b2ba798bf3c4 100644
@@ -196,6 +196,14 @@
        use-ncsi;
 };
 
+&mac1 {
+       status = "okay";
+
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_rmii2_default>;
+       use-ncsi;
+};
+
 &adc {
        status = "okay";
 };
--

2.17.1

Reviewed-by Tested-by
#2 lore raw

?On 10/27/20, 10:51 PM, "Joel Stanley" <[email protected]> wrote:

On Wed, 30 Sep 2020 at 19:27, Paul Fertser <[email protected]> wrote:
>
> Tioga Pass reference design includes Intel I210 Ethernet controller > connected to the BMC with NC/SI.
>
> MAC readout is not supported.
>
> Signed-off-by: Paul Fertser <[email protected]>

Vijay, can I get a review from you on this one please?

Sorry Joel, for late response, I have tested and verified this yesterday

Quoted 26 lines
---
 arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts +8 -1
index 2d44d9ad4e40..b2ba798bf3c4 100644
@@ -196,6 +196,14 @@
        use-ncsi;
 };
 
+&mac1 {
+       status = "okay";
+
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_rmii2_default>;
+       use-ncsi;
+};
+
 &adc {
        status = "okay";
 };
--

2.17.1

maintainer
#3 lore raw
Quoted 12 lines · Vijay Khemka

?On 10/27/20, 10:51 PM, "Joel Stanley" <[email protected]> wrote:

On Wed, 30 Sep 2020 at 19:27, Paul Fertser <[email protected]> wrote:
>
> Tioga Pass reference design includes Intel I210 Ethernet controller > connected to the BMC with NC/SI.
>
> MAC readout is not supported.
>

Quoted 8 lines

> Signed-off-by: Paul Fertser <[email protected]>

Vijay, can I get a review from you on this one please?

Sorry Joel, for late response, I have tested and verified this yesterday

Thanks for taking a look.

Paul, in the future please use scripts/get_maintainers.pl in the kernel tree to send this patch to the correct location. Importantly, you should cc linux-arm-kernel and myself (as the maintainer).

I've merged this for 5.11.

Cheers,

Joel

Quoted 28 lines
Quoted 27 lines
---
 arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts +8 -1
index 2d44d9ad4e40..b2ba798bf3c4 100644
@@ -196,6 +196,14 @@
        use-ncsi;
 };
 
+&mac1 {
+       status = "okay";
+
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_rmii2_default>;
+       use-ncsi;
+};
+
 &adc {
        status = "okay";
 };
--

2.17.1