Skip to contentSkip to conversation

graph: improve grammar of "invalid color" error message

PATCH RESEND In review Alex Henrie 3 participants 3 messages Jun 12, 2021 – Jun 15, 2021

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 graph: improve grammar of "invalid color" error message

Without the "d", it sounds like a command, not an error, and is liable to be translated incorrectly.

---
Resending to make sure that this patch isn't forgotten.

---
 graph.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
graph.c +1 -1
index c128ad0cce..e3828eb8f2 100644
@@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)
 		if (!color_parse_mem(start, comma - start, color))
 			strvec_push(colors, color);
 		else
-			warning(_("ignore invalid color '%.*s' in log.graphColors"),
+			warning(_("ignored invalid color '%.*s' in log.graphColors"),
 				(int)(comma - start), start);
 		start = comma + 1;
 	}
Signature · 1 line
2.31.1
#1 lore raw

Hi,

Quoted 3 lines · Alex Henrie

Without the "d", it sounds like a command, not an error, and is liable to be translated incorrectly.

s/liable/prone/

Quoted 13 lines

---
Resending to make sure that this patch isn't forgotten.

---
  graph.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
graph.c +0 -0
index c128ad0cce..e3828eb8f2 100644

graph.c static void parse_graph_colors_config(struct strvec *colors, const char *string) · line 101

Quoted 8 lines
graph.c +1 -1
@@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)
  		if (!color_parse_mem(start, comma - start, color))
  			strvec_push(colors, color);
  		else
-			warning(_("ignore invalid color '%.*s' in log.graphColors"),
+			warning(_("ignored invalid color '%.*s' in log.graphColors"),
  				(int)(comma - start), start);
  		start = comma + 1;
  	}

Why did you resend the patch?

Signature · 1 line
An old man doll... just what I always wanted! - Clara
#2 lore raw
In reply to Alex Henrie
Quoted 6 lines · Alex Henrie

Without the "d", it sounds like a command, not an error, and is liable to be translated incorrectly.

---
Resending to make sure that this patch isn't forgotten.

Thanks, will queue.

Quoted 17 lines
---
 graph.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
graph.c +1 -1
index c128ad0cce..e3828eb8f2 100644
@@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)
 		if (!color_parse_mem(start, comma - start, color))
 			strvec_push(colors, color);
 		else
-			warning(_("ignore invalid color '%.*s' in log.graphColors"),
+			warning(_("ignored invalid color '%.*s' in log.graphColors"),
 				(int)(comma - start), start);
 		start = comma + 1;
 	}