graph: improve grammar of "invalid color" error message
PATCH RESEND 1/1 graph: improve grammar of "invalid color" error message
Without the "d", it sounds like a command, not an error, and is liable to be translated incorrectly.
Signed-off-by Alex Henrie <[email protected]>
---
Resending to make sure that this patch isn't forgotten.
--- graph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
graph.c +1 -1
@@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)if (!color_parse_mem (start, comma - start, color))strvec_push (colors, color);else -warning (_ ("ignore invalid color '%.*s' in log.graphColors" ), +warning (_ ("ignored invalid color '%.*s' in log.graphColors" ), (int )(comma - start), start); start = comma +1 ; }
Signature · 1 line
2.31.1
Hi,
Quoted 3 lines · Alex Henrie
Without the "d", it sounds like a command, not an error, and is liable to be translated incorrectly.
s/liable/prone/
Quoted 13 lines
Signed-off-by Alex Henrie <[email protected]>---
Resending to make sure that this patch isn't forgotten.--- graph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)graph.c +0
-0
graph.c static void parse_graph_colors_config(struct strvec *colors, const char *string) · line 101
Quoted 8 lines
graph.c +1
-1@@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)if (!color_parse_mem (start, comma - start, color))strvec_push (colors, color);else -warning (_ ("ignore invalid color '%.*s' in log.graphColors" ), +warning (_ ("ignored invalid color '%.*s' in log.graphColors" ), (int )(comma - start), start); start = comma +1 ; }
Why did you resend the patch?
Signature · 1 line
An old man doll... just what I always wanted! - Clara
Quoted 6 lines · Alex Henrie
Without the "d", it sounds like a command, not an error, and is liable to be translated incorrectly.
Signed-off-by Alex Henrie <[email protected]>---
Resending to make sure that this patch isn't forgotten.
Thanks, will queue.
Quoted 17 lines
--- graph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)graph.c +1
-1@@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)if (!color_parse_mem (start, comma - start, color))strvec_push (colors, color);else -warning (_ ("ignore invalid color '%.*s' in log.graphColors" ), +warning (_ ("ignored invalid color '%.*s' in log.graphColors" ), (int )(comma - start), start); start = comma +1 ; }