Skip to contentSkip to conversation

moving DRM header files

DISCUSSION Dave Airlie 4 participants 7 messages Jul 14, 2005

lore
Share & tools
lore
#0 lore raw

Hi,
I'd like to move the interface DRM header files (drm.h and *_drm.h) somewhere more useful and also more "user-space" visible, (i.e. so kernel-headers could start picking them up.)

I'm thinking include/linux/drm/
but include/linux would also be possible.

Any suggestions or ideas?

Dave.

#1 lore raw
Quoted 9 lines · Dave Airlie

Hi,
I'd like to move the interface DRM header files (drm.h and *_drm.h) somewhere more useful and also more "user-space" visible, (i.e. so kernel-headers could start picking them up.)

I'm thinking include/linux/drm/
but include/linux would also be possible.

Any suggestions or ideas?

There is also include/linux/video

The duplicate defines need to get cleaned out of xf86drm.h or this is going to get real confusing.

Signature · 2 lines
Jon Smirl
[email protected]
#2 lore raw
In reply to Dave Airlie
Quoted 9 lines · Dave Airlie

Hi,
I'd like to move the interface DRM header files (drm.h and *_drm.h) somewhere more useful and also more "user-space" visible, (i.e. so kernel-headers could start picking them up.)

I'm thinking include/linux/drm/
but include/linux would also be possible.

Any suggestions or ideas?

If you're in a mood to move things, how about moving drivers/char/drm to drivers/video/drm.

Signature · 2 lines
Jon Smirl
[email protected]
#3 lore raw
Quoted 7 lines
Quoted 4 lines

I'm thinking include/linux/drm/
but include/linux would also be possible.

Any suggestions or ideas?

If you're in a mood to move things, how about moving drivers/char/drm to drivers/video/drm.

But that has little point beyond aesthetics... moving the header files is for a reason that I want them to start appearing in userspace includeable places.. as part of the cleanup for libdrm..

Moving c files internally in the kernel provides no real benefit over not moving them..

Dave.

#4 lore raw
Quoted 8 lines · Dave Airlie
Quoted 7 lines
Quoted 4 lines

I'm thinking include/linux/drm/
but include/linux would also be possible.

Any suggestions or ideas?

If you're in a mood to move things, how about moving drivers/char/drm to drivers/video/drm.

Quoted 6 lines

But that has little point beyond aesthetics... moving the header files is for a reason that I want them to start appearing in userspace includeable places.. as part of the cleanup for libdrm..

Moving c files internally in the kernel provides no real benefit over not moving them..

When you start merging DRM and fbdev you will be able to use relative paths that are closer together. For example #include "../char/drm/drmP.h" versus "#include "drm/drmP.h" for internal headers.

DRM and fbdev need to be moved next to each other in kconfig too if they start depending on each other. It if hard to figure out that a video option might not be visible because the char/drm/option is not turned on.

Signature · 2 lines
Jon Smirl
[email protected]
#5 lore raw
Quoted 5 lines

When you start merging DRM and fbdev you will be able to use relative paths that are closer together. For example #include "../char/drm/drmP.h" versus "#include "drm/drmP.h" for internal headers.

No. Using relative include paths is not good. I will most probarly not work with make O=.

Sam

#6 lore raw
In reply to Dave Airlie
Quoted 4 lines · Dave Airlie

Hi,
I'd like to move the interface DRM header files (drm.h and *_drm.h) somewhere more useful and also more "user-space" visible, (i.e. so kernel-headers could start picking them up.)

I would suggest making ONE userspace visible header, and just put that as include/linux/drm.h
and separate into that *ONLY* the userspace visible parts, and *NONE* of the kernel visible parts, and keep the kernel parts in drivers/char/drm.