Skip to contentSkip to conversation

pinctrl: freescale: imx8ulp: fix module autoloading

PATCH In review Krzysztof Kozlowski 4 participants 9 messages Apr 11, 2024 – Apr 17, 2024

Subsystems (11)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/5 pinctrl: freescale: imx8ulp: fix module autoloading

Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table. Pin controllers are considered core components, so usually they are built-in, however these can be built and used as modules on some generic kernel.

---

Changes in v2:
1. None

---
 drivers/pinctrl/freescale/pinctrl-imx8ulp.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/freescale/pinctrl-imx8ulp.c +1 -0
index 2e86ca9fc7ac..5632c7285147 100644
@@ -252,6 +252,7 @@ static const struct of_device_id imx8ulp_pinctrl_of_match[] = {
 	{ .compatible = "fsl,imx8ulp-iomuxc1", },
 	{ /* sentinel */ }
 };
+MODULE_DEVICE_TABLE(of, imx8ulp_pinctrl_of_match);
 
 static int imx8ulp_pinctrl_probe(struct platform_device *pdev)
 {
Signature · 1 line
2.34.1
#1 lore raw

PATCH v2 2/5 pinctrl: mediatek: fix module autoloading

Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table. Pin controllers are considered core components, so usually they are built-in, however these can be built and used as modules on some generic kernel.

---

Changes in v2:
1. None

---
 drivers/pinctrl/mediatek/pinctrl-mt6765.c | 1 +
 drivers/pinctrl/mediatek/pinctrl-mt6779.c | 1 +
 2 files changed, 2 insertions(+)
drivers/pinctrl/mediatek/pinctrl-mt6765.c +1 -0
index f6ec41eb6e0c..72609cf74760 100644
@@ -1086,6 +1086,7 @@ static const struct of_device_id mt6765_pinctrl_of_match[] = {
 	{ .compatible = "mediatek,mt6765-pinctrl", .data = &mt6765_data },
 	{ }
 };
+MODULE_DEVICE_TABLE(of, mt6765_pinctrl_of_match);
 
 static struct platform_driver mt6765_pinctrl_driver = {
 	.driver = {
drivers/pinctrl/mediatek/pinctrl-mt6779.c +1 -0
index 62d4f5ad6737..591905e4132a 100644
@@ -762,6 +762,7 @@ static const struct of_device_id mt6779_pinctrl_of_match[] = {
 	{ .compatible = "mediatek,mt6779-pinctrl", .data = &mt6779_data },
 	{ }
 };
+MODULE_DEVICE_TABLE(of, mt6779_pinctrl_of_match);
 
 static struct platform_driver mt6779_pinctrl_driver = {
 	.driver = {
Signature · 1 line
2.34.1
maintainer Reviewed-by on v2 2/5
#2 lore raw

Re: [PATCH v2 2/5] pinctrl: mediatek: fix module autoloading

Il 11/04/24 08:46, Krzysztof Kozlowski ha scritto:

Quoted 7 lines

Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table. Pin controllers are considered core components, so usually they are built-in, however these can be built and used as modules on some generic kernel.

#3 lore raw

PATCH v2 3/5 pinctrl: loongson2: fix module autoloading

In reply to Krzysztof Kozlowski

Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table. Pin controllers are considered core components, so usually they are built-in, however these can be built and used as modules on some generic kernel.

---

Changes in v2:
1. None

---
 drivers/pinctrl/pinctrl-loongson2.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/pinctrl-loongson2.c +1 -0
index a72ffeca26fb..4d4fbeadafb7 100644
@@ -286,6 +286,7 @@ static const struct of_device_id loongson2_pinctrl_dt_match[] = {
 	},
 	{ }
 };
+MODULE_DEVICE_TABLE(of, loongson2_pinctrl_dt_match);
 
 static struct platform_driver loongson2_pinctrl_driver = {
 	.probe		= loongson2_pinctrl_probe,
Signature · 1 line
2.34.1
#4 lore raw

PATCH v2 4/5 pinctrl: qcom: sm7150: fix module autoloading

In reply to Krzysztof Kozlowski

Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table. Pin controllers are considered core components, so usually they are built-in, however these can be built and used as modules on some generic kernel.

---

Changes in v2:
1. Add ack

---
 drivers/pinctrl/qcom/pinctrl-sm7150.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/qcom/pinctrl-sm7150.c +1 -0
index c25357ca1963..c542f9bc6bcd 100644
@@ -1246,6 +1246,7 @@ static const struct of_device_id sm7150_tlmm_of_match[] = {
 	{ .compatible = "qcom,sm7150-tlmm", },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, sm7150_tlmm_of_match);
 
 static struct platform_driver sm7150_tlmm_driver = {
 	.driver = {
Signature · 1 line
2.34.1
maintainer Reviewed-by on v2 4/5
#5 lore raw

Re: [PATCH v2 4/5] pinctrl: qcom: sm7150: fix module autoloading

Il 11/04/24 08:46, Krzysztof Kozlowski ha scritto:

Quoted 8 lines

Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table. Pin controllers are considered core components, so usually they are built-in, however these can be built and used as modules on some generic kernel.

Reviewed-by on v2 4/5
#6 lore raw

Re: [PATCH v2 4/5] pinctrl: qcom: sm7150: fix module autoloading

In reply to Krzysztof Kozlowski
Quoted 8 lines · Krzysztof Kozlowski

Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table. Pin controllers are considered core components, so usually they are built-in, however these can be built and used as modules on some generic kernel.

Regards,
Bjorn

Quoted 23 lines

---

Changes in v2:
1. Add ack

---
 drivers/pinctrl/qcom/pinctrl-sm7150.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/qcom/pinctrl-sm7150.c +1 -0
index c25357ca1963..c542f9bc6bcd 100644
@@ -1246,6 +1246,7 @@ static const struct of_device_id sm7150_tlmm_of_match[] = {
 	{ .compatible = "qcom,sm7150-tlmm", },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, sm7150_tlmm_of_match);
 
 static struct platform_driver sm7150_tlmm_driver = {
 	.driver = {
Signature · 1 line
2.34.1
#7 lore raw

PATCH v2 5/5 pinctrl: realtek: fix module autoloading

In reply to Krzysztof Kozlowski

Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table. Pin controllers are considered core components, so usually they are built-in, however these can be built and used as modules on some generic kernel.

---

Changes in v2:
1. Add missing yank-yank.
https://lore.kernel.org/all/[email protected]/

---
 drivers/pinctrl/realtek/pinctrl-rtd1315e.c | 1 +
 drivers/pinctrl/realtek/pinctrl-rtd1319d.c | 1 +
 2 files changed, 2 insertions(+)
drivers/pinctrl/realtek/pinctrl-rtd1315e.c +1 -0
index 10afc736a52b..86f919122bed 100644
@@ -1414,6 +1414,7 @@ static const struct of_device_id rtd1315e_pinctrl_of_match[] = {
 	{ .compatible = "realtek,rtd1315e-pinctrl", },
 	{},
 };
+MODULE_DEVICE_TABLE(of, rtd1315e_pinctrl_of_match);
 
 static struct platform_driver rtd1315e_pinctrl_driver = {
 	.driver = {
drivers/pinctrl/realtek/pinctrl-rtd1319d.c +1 -0
index b1a654ac30dc..474c337d2d05 100644
@@ -1584,6 +1584,7 @@ static const struct of_device_id rtd1319d_pinctrl_of_match[] = {
 	{ .compatible = "realtek,rtd1319d-pinctrl", },
 	{},
 };
+MODULE_DEVICE_TABLE(of, rtd1319d_pinctrl_of_match);
 
 static struct platform_driver rtd1319d_pinctrl_driver = {
 	.driver = {
Signature · 1 line
2.34.1
#8 lore raw
In reply to Krzysztof Kozlowski
Quoted 6 lines · Krzysztof Kozlowski

Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table. Pin controllers are considered core components, so usually they are built-in, however these can be built and used as modules on some generic kernel.

All five patches applied, thanks for fixing this Krzysztof!

Yours,
Linus Walleij