staging: rtl8188eu: core: Remove set but unused variable
PATCH 1/1 staging: rtl8188eu: core: Remove set but unused variable
Remove variable sec_idx because is set but unused. Issue detected by GCC with -Wunused-variable.
--- drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/rtl8188eu/core/rtw_ieee80211.c +1 -3
@@ -465,7 +465,7 @@ int rtw_parse_wpa2_ie(u8 *rsn_ie, int rsn_ie_len, int *group_cipher, int *pairwivoid rtw_get_sec_ie (u8 *in_ie,uint in_len,u8 *rsn_ie,u16 *rsn_len,u8 *wpa_ie,u16 *wpa_len) { -u8 authmode, sec_idx; +u8 authmode;u8 wpa_oui[4 ] = {0x0 ,0x50 ,0xf2 ,0x01 };uint cnt;
@@ -473,8 +473,6 @@ void rtw_get_sec_ie(u8 *in_ie, uint in_len, u8 *rsn_ie, u16 *rsn_len, u8 *wpa_ie cnt = _TIMESTAMP_ + _BEACON_ITERVAL_ + _CAPABILITY_; - sec_idx =0 ; -while (cnt < in_len) { authmode = in_ie[cnt];
Signature · 1 line
2.32.0
Greg Kroah-Hartman
maintainerQuoted 7 lines · Fabio M. De Francesco
Remove variable
sec_idxbecause is set but unused. Issue detected by GCC with -Wunused-variable.Signed-off-by Fabio M. De Francesco <[email protected]>--- drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
Does not apply to my tree :(
Quoted 4 lines · CEST Greg Kroah-Hartman
Quoted 3 lines · Fabio M. De Francesco
Remove variable
sec_idxbecause is set but unused. Issue detected by GCC with -Wunused-variable.
Quoted 8 lines
Quoted 5 lines
Signed-off-by Fabio M. De Francesco <[email protected]>---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)Does not apply to my tree :(
Your tree changed while my patch was expecting your review. This happened because someone else worked on the same code while
"the development tree you have sent a patch for is "closed" due to the timing of the merge window".
Unfortunately, I was unaware of a similar patch in your queue because I didn't notice that it was sent to the linux-staging list a few days before mine.
This is not the first time that something like this happens, so I think it's better to not work and send patches while you keep the development tree closed.
Sorry for wasting your time.
Thanks,
Fabio
Greg Kroah-Hartman
maintainerQuoted 18 lines · Fabio M. De Francesco
Quoted 4 lines · CEST Greg Kroah-Hartman
Quoted 3 lines · Fabio M. De Francesco
Remove variable
sec_idxbecause is set but unused. Issue detected by GCC with -Wunused-variable.Quoted 8 lines
Quoted 5 lines
Signed-off-by Fabio M. De Francesco <[email protected]>---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)Does not apply to my tree :(
Your tree changed while my patch was expecting your review. This happened because someone else worked on the same code while
"the development tree you have sent a patch for is "closed" due to the timing of the merge window".
Quoted 7 lines
Unfortunately, I was unaware of a similar patch in your queue because I didn't notice that it was sent to the linux-staging list a few days before mine.
This is not the first time that something like this happens, so I think it's better to not work and send patches while you keep the development tree closed.
The only time it is "closed" is during the merge window. No need to stop doing work during then, it's easy to rebase and resend if there are ever problems.
thanks,
greg k-h