: Add QuickCam Communicate Deluxe/S7500 to volume_control_quirks.

PATCH In review Con Kolivas 3 participants 5 messages Dec 9, 2016 Sound

lore

Share & tools

lore

Con Kolivas

author

2016-12-09 04:15 UTC #0 lore raw

PATCH 1/1 : Add QuickCam Communicate Deluxe/S7500 to volume_control_quirks.

The Logitech QuickCam Communicate Deluxe/S7500 microphone fails with the following warning.

[    6.778995] usb 2-1.2.2.2: Warning! Unlikely big volume range (=3072),
cval->res is probably wrong.
[    6.778996] usb 2-1.2.2.2: [5] FU [Mic Capture Volume] ch = 1, val =

4608/7680/1

Adding it to the list of devices in volume_control_quirks makes it work properly, fixing related typo.

Signed-off-by Con Kolivas <[email protected]>

---
 sound/usb/mixer.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

sound/usb/mixer.c +2 -1

index 2f8c388..4703cae 100644
@@ -932,9 +932,10 @@ static void volume_control_quirks(struct usb_mixer_elem_info *cval,
 	case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
 	case USB_ID(0x046d, 0x08ca): /* Logitech Quickcam Fusion */
 	case USB_ID(0x046d, 0x0991):
+	case USB_ID(0x046d, 0x09a2): /* QuickCam Communicate Deluxe/S7500 */
 	/* Most audio usb devices lie about volume resolution.
 	 * Most Logitech webcams have res = 384.
-	 * Proboly there is some logitech magic behind this number --fishor
+	 * Probably there is some logitech magic behind this number --fishor
 	 */
 		if (!strcmp(kctl->id.name, "Mic Capture Volume")) {
 			usb_audio_info(chip,

Signature · 1 line

2.7.4

Takashi Iwai

2016-12-09 10:22 UTC #1 lore raw

Quoted 7 lines · Con Kolivas

The Logitech QuickCam Communicate Deluxe/S7500 microphone fails with the following warning.
[    6.778995] usb 2-1.2.2.2: Warning! Unlikely big volume range (=3072),
cval->res is probably wrong.
[    6.778996] usb 2-1.2.2.2: [5] FU [Mic Capture Volume] ch = 1, val =

Quoted 6 lines

4608/7680/1
Adding it to the list of devices in volume_control_quirks makes it work properly, fixing related typo.
Signed-off-by Con Kolivas <[email protected]>

Applied (with Cc to stable), thanks.

Takashi

Quoted 26 lines

---
 sound/usb/mixer.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

sound/usb/mixer.c +2 -1

index 2f8c388..4703cae 100644
@@ -932,9 +932,10 @@ static void volume_control_quirks(struct usb_mixer_elem_info *cval,
 	case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
 	case USB_ID(0x046d, 0x08ca): /* Logitech Quickcam Fusion */
 	case USB_ID(0x046d, 0x0991):
+	case USB_ID(0x046d, 0x09a2): /* QuickCam Communicate Deluxe/S7500 */
 	/* Most audio usb devices lie about volume resolution.
 	 * Most Logitech webcams have res = 384.
-	 * Proboly there is some logitech magic behind this number --fishor
+	 * Probably there is some logitech magic behind this number --fishor
 	 */
 		if (!strcmp(kctl->id.name, "Mic Capture Volume")) {
 			usb_audio_info(chip,

Signature · 1 line

2.7.4

Con Kolivas

2016-12-09 20:28 UTC #2 lore raw

Quoted 11 lines · Takashi Iwai

Quoted 9 lines · Con Kolivas
The Logitech QuickCam Communicate Deluxe/S7500 microphone fails with the following warning.
[    6.778995] usb 2-1.2.2.2: Warning! Unlikely big volume range (=3072),
cval->res is probably wrong.
[    6.778996] usb 2-1.2.2.2: [5] FU [Mic Capture Volume] ch = 1, val =
4608/7680/1

Quoted 8 lines

Quoted 4 lines
Adding it to the list of devices in volume_control_quirks makes it work properly, fixing related typo.
Signed-off-by Con Kolivas <[email protected]>
Applied (with Cc to stable), thanks.

You're welcome. As there appear to be a lot of these devices from the same manufacturer with the same error, and there are likely a lot of devices out there that are missed from this whitelist, do you think it would be worthwhile changing the code to detect the combination of unlikely big volume range and usb vendor of 0x046d and automatically try using the volume_control_quirk on them instead of a discrete whitelist?

Thanks,
Con

Quoted 32 lines

Takashi

sound/usb/mixer.c static void volume_control_quirks(struct

Quoted 10 lines

---
 sound/usb/mixer.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

sound/usb/mixer.c +0 -0

index 2f8c388..4703cae 100644
@@ -932,9 +932,10 @@ static void volume_control_quirks(struct

usb_mixer_elem_info *cval,

sound/usb/mixer.c static void volume_control_quirks(struct usb_mixer_elem_info *cval,

Quoted 4 lines

sound/usb/mixer.c +1 -0

      case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
      case USB_ID(0x046d, 0x08ca): /* Logitech Quickcam Fusion */
      case USB_ID(0x046d, 0x0991):
+     case USB_ID(0x046d, 0x09a2): /* QuickCam Communicate Deluxe/S7500

sound/usb/mixer.c static void volume_control_quirks(struct usb_mixer_elem_info *cval,

Quoted 4 lines

sound/usb/mixer.c +1 -1

      /* Most audio usb devices lie about volume resolution.
       * Most Logitech webcams have res = 384.
-      * Proboly there is some logitech magic behind this number --fishor
+      * Probably there is some logitech magic behind this number

--fishor

Quoted 8 lines

sound/usb/mixer.c +0 -1

       */
              if (!strcmp(kctl->id.name, "Mic Capture Volume")) {
                      usb_audio_info(chip,
--

2.7.4

Con Kolivas

2016-12-09 20:35 UTC #3 lore raw

In reply to Takashi Iwai

Quoted 11 lines · AEDT Takashi Iwai

On Fri, 09 Dec 2016 05:15:57 +0100,
Quoted 8 lines · Con Kolivas
The Logitech QuickCam Communicate Deluxe/S7500 microphone fails with the following warning.
[    6.778995] usb 2-1.2.2.2: Warning! Unlikely big volume range (=3072),
cval->res is probably wrong.
[    6.778996] usb 2-1.2.2.2: [5] FU [Mic Capture Volume] ch = 1, val =
4608/7680/1

Quoted 6 lines

Quoted 4 lines
Adding it to the list of devices in volume_control_quirks makes it work properly, fixing related typo.
Signed-off-by Con Kolivas <[email protected]>
Applied (with Cc to stable), thanks.

(Apologies for google mail defaulting to html, resending with a proper mail client)

Thanks,

Con

Quoted 33 lines

Takashi

Quoted 29 lines

---

 sound/usb/mixer.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

sound/usb/mixer.c +0 -0

index 2f8c388..4703cae 100644
@@ -932,9 +932,10 @@ static void volume_control_quirks(struct

usb_mixer_elem_info *cval,>

sound/usb/mixer.c +2 -1

 	case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
 	case USB_ID(0x046d, 0x08ca): /* Logitech Quickcam Fusion */
 
 	case USB_ID(0x046d, 0x0991):
+	case USB_ID(0x046d, 0x09a2): /* QuickCam Communicate Deluxe/S7500 */
 
 	/* Most audio usb devices lie about volume resolution.
 
 	 * Most Logitech webcams have res = 384.
 
-	 * Proboly there is some logitech magic behind this number --fishor
+	 * Probably there is some logitech magic behind this number --fishor
 
 	 */
 
 		if (!strcmp(kctl->id.name, "Mic Capture Volume")) {
 
 			usb_audio_info(chip,

Signature · 1 line

-ck

Takashi Iwai

2016-12-09 20:53 UTC #4 lore raw

Quoted 23 lines · Con Kolivas

Quoted 11 lines · AEDT Takashi Iwai
On Fri, 09 Dec 2016 05:15:57 +0100,
Quoted 8 lines · Con Kolivas
The Logitech QuickCam Communicate Deluxe/S7500 microphone fails with the following warning.
[    6.778995] usb 2-1.2.2.2: Warning! Unlikely big volume range (=3072),
cval->res is probably wrong.
[    6.778996] usb 2-1.2.2.2: [5] FU [Mic Capture Volume] ch = 1, val =
4608/7680/1
Quoted 6 lines
Quoted 4 lines
Adding it to the list of devices in volume_control_quirks makes it work properly, fixing related typo.
Signed-off-by Con Kolivas <[email protected]>
Applied (with Cc to stable), thanks.
(Apologies for google mail defaulting to html, resending with a proper mail client)

Quoted 6 lines

You're welcome. As there appear to be a lot of these devices from the same manufacturer with the same error, and there are likely a lot of devices out there that are missed from this whitelist, do you think it would be worthwhile changing the code to detect the combination of unlikely big volume range and usb vendor of 0x046d and automatically try using the volume_control_quirk on them instead of a discrete whitelist?

Yeah, it sounds like a good idea!

thanks,

Takashi