Update ehci-platform driver to support devicetree

This patch adds devicetree support to the EHCI-platform driver, and removes the now unneeded ehci-vt8500.c

Existing platform properties are maintained, with the exception the power_(on/off) and suspend function pointers.

drivers/usb/host/ehci-platform.c +9 -0

+
+		/* Right now device-tree probed devices don't get dma_mask set.
+		 * Since shared usb code relies on it, set it here for now.
+		 * Once we have dma capability bindings this can go away.
+		 */
+		if (!dev->dev.dma_mask)
+			dev->dev.dma_mask = &ehci_dma_mask;
+	}
+
 	if (!pdata) {
 		WARN_ON(1);
 		return -ENODEV;

Hi Tony,

Quoted 5 lines · On Saturday 20 October 2012 16:17:32 Tony Prisk wrote:

This patch adds devicetree support to the EHCI-platform driver, and removes the now unneeded ehci-vt8500.c

Existing platform properties are maintained, with the exception the power_(on/off) and suspend function pointers.

Ok, so I have recently sent a bit patchset to remove most OHCI/EHCI drivers that could be converted to the generic variants, series starts here:
1349701906-16481-1-git-send-email-florian at openwrt.org

in this patchset I added a new property to the EHCI platform data:
need_io_watchdog, which needs to be handled too from DT ideally.

Adding device tree bindings is on my TODO after having a generic way to pass clocks to the ehci/ohci platform drivers, so you are right on time :)

Quoted 9 lines · Florian Fainelli

Hi Tony,

Quoted 5 lines · On Saturday 20 October 2012 16:17:32 Tony Prisk wrote:

This patch adds devicetree support to the EHCI-platform driver, and removes the now unneeded ehci-vt8500.c

Existing platform properties are maintained, with the exception the power_(on/off) and suspend function pointers.

Quoted 6 lines

Ok, so I have recently sent a bit patchset to remove most OHCI/EHCI drivers that could be converted to the generic variants, series starts here:
1349701906-16481-1-git-send-email-florian at openwrt.org

in this patchset I added a new property to the EHCI platform data:
need_io_watchdog, which needs to be handled too from DT ideally.

Actually the new property is "no_io_watchdog". See

	http://marc.info/?l=linux-usb&m=134970247511140&w=2

Quoted 2 lines

Adding device tree bindings is on my TODO after having a generic way to pass clocks to the ehci/ohci platform drivers, so you are right on time :)

At some point we'll need a way to handle the power_{on,off,suspend} callbacks. I don't know how that should be done.

Alan Stern

Hi Tony,

Quoted 5 lines · On Saturday 20 October 2012 16:17:32 Tony Prisk wrote:

This patch adds devicetree support to the EHCI-platform driver, and removes the now unneeded ehci-vt8500.c

Existing platform properties are maintained, with the exception the power_(on/off) and suspend function pointers.

Ok, so I have recently sent a bit patchset to remove most OHCI/EHCI drivers that could be converted to the generic variants, series starts here:
1349701906-16481-1-git-send-email-florian at openwrt.org

in this patchset I added a new property to the EHCI platform data:
need_io_watchdog, which needs to be handled too from DT ideally.

Adding device tree bindings is on my TODO after having a generic way to pass clocks to the ehci/ohci platform drivers, so you are right on time :)

[snip]

drivers/usb/host/ehci-platform.c static const struct hc_driver ehci_platform_hc_driver = { · line 102

Quoted 9 lines

drivers/usb/host/ehci-platform.c +9 -0

+	if (np) {
+		/*
+		 * No platform data is being passed, so initalize pdata.
+		 * Limitation: we can't support power_on, power_off or
+		 * power_suspend function pointers from DT.
+		 * TODO: The missing functions could be replaced with
+		 * power sequence handlers.
+		 */
+		pdata = devm_kzalloc(&dev->dev, sizeof(*pdata), GFP_KERNEL);

Missing allocation failure handling here. And you should free this in ehci_platform_remove() accordingly.

drivers/usb/host/ehci-platform.c static const struct hc_driver ehci_platform_hc_driver = { · line 114

Quoted 13 lines

drivers/usb/host/ehci-platform.c +12 -0

+		dev->dev.platform_data = pdata;
+
+		/* Read the optional properties from DT node */
+		of_property_read_u32(np, "caps-offset", &pdata->caps_offset);
+		if (of_property_read_bool(np, "has-tt"))
+			pdata->has_tt = 1;
+		if (of_property_read_bool(np, "has-synopsys-hc-bug"))
+			pdata->has_synopsys_hc_bug = 1;
+		if (of_property_read_bool(np, "big-endian-desc"))
+			pdata->big_endian_desc = 1;
+		if (of_property_read_bool(np, "big-endian-mmio"))
+			pdata->big_endian_mmio = 1;

I would rather we remain compatible with ehci-ppc-of, by handling the big-endian property you set big_endian_mmiod and big_endian_desc to 1, and by setting them individually, you get what you expect.

Quoted 17 lines

drivers/usb/host/ehci-platform.c +9 -0

+
+		/* Right now device-tree probed devices don't get dma_mask set.
+		 * Since shared usb code relies on it, set it here for now.
+		 * Once we have dma capability bindings this can go away.
+		 */
+		if (!dev->dev.dma_mask)
+			dev->dev.dma_mask = &ehci_dma_mask;
+	}
+
 	if (!pdata) {
 		WARN_ON(1);
 		return -ENODEV;

@@ -215,6 +250,16 @@ static const struct platform_device_id ehci_platform_table[] = {
 	{ "ehci-platform", 0 },
 	{ }
 };

drivers/usb/host/ehci-platform.c static const struct platform_device_id ehci_platform_table[] = { · line 257

Quoted 5 lines

drivers/usb/host/ehci-platform.c +5 -0

+
+#ifdef CONFIG_OF
+static const struct of_device_id ehci_platform_ids[] = {
+	{ .compatible = "ehci-platform", },
+	{}

ehci-platform is very linux-specific, so this should either be:
"linux,ehci-platform", or "usb-ehci", pretty much like the ppc-of ehci driver.

This patchset updates the ehci-platform.c driver to allow device tree probing. I have dropped support for the three function pointers (power_on, power_off and power_suspend). If someone has knowledge of the power sequence functions that are being implemented, these functions could be replaced (Sorry, I don't know anything about implementing it).

port_power_(on_off) properties are not supported in DT as Alan Stern indicated they are going to be removed.

I have included a binding document, but must admit most of the descriptions for the properties are guessed. Quite likely some of these descriptions are incorrect and/or need to be clarified.

Tony Prisk (2):
USB: Update EHCI-platform driver to devicetree.
USB: doc: Binding document for ehci-platform driver