Skip to contentSkip to conversation

i40e: fix the issue of port initialization failure

PATCH NAK Helin Zhang 3 participants 6 messages Dec 23, 2015 – Feb 5, 2016 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i40e: fix the issue of port initialization failure

Workaround for the issue of cannot processing adminq commands during initialization, when 2x40G or 4x10G is receiving packets in highest throughput. Register 0x002698a8 and 0x002698ac should be cleared at first, and restored with the default values at the end. No more details, as they are not exposed registers.

---
 drivers/net/i40e/i40e_ethdev.c | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)
drivers/net/i40e/i40e_ethdev.c +39 -0
index bf6220d..149a31e 100644
@@ -712,6 +712,41 @@ i40e_add_tx_flow_control_drop_filter(struct i40e_pf *pf)
 				  " frames from VSIs.");
 }
 
+/* Workaround for the issue of cannot processing adminq commands during
+ * initialization, when 2x40G or 4x10G is receiving packets in highest
+ * throughput. Register 0x002698a8 and 0x002698ac should be cleared at
+ * first, and restored with the default values at the end. No more details,
+ * as they are not exposed registers.
+ */
+static void
+i40e_clear_fdena(struct i40e_hw *hw)
+{
+	uint32_t fdena0, fdena1;
+
+	fdena0 = I40E_READ_REG(hw, 0x002698a8);
+	fdena1 = I40E_READ_REG(hw, 0x002698ac);
+	PMD_INIT_LOG(DEBUG, "[0x002698a8]: 0x%08x, [0x002698ac]: 0x%08x",
+		     fdena0, fdena1);
+
+	I40E_WRITE_REG(hw, 0x002698a8, 0x0);
+	I40E_WRITE_REG(hw, 0x002698ac, 0x0);
+	I40E_WRITE_FLUSH(hw);
+}
+
+/* Workaround for the issue of cannot processing adminq commands during
+ * initialization, when 2x40G or 4x10G is receiving packets in highest
+ * throughput. Register 0x002698a8 and 0x002698ac should be cleared at
+ * first, and restored with the default values at the end. No more details,
+ * as they are not exposed registers.
+ */
+static void
+i40e_restore_fdena(struct i40e_hw *hw)
+{
+	I40E_WRITE_REG(hw, 0x002698a8, 0xfc000000);
+	I40E_WRITE_REG(hw, 0x002698ac, 0x80007fdf);
+	I40E_WRITE_FLUSH(hw);
+}
+
 static int
 eth_i40e_dev_init(struct rte_eth_dev *dev)
 {
@@ -774,6 +809,8 @@ eth_i40e_dev_init(struct rte_eth_dev *dev)
 		return ret;
 	}
 
+	i40e_clear_fdena(hw);
+
 	/* Initialize the shared code (base driver) */
 	ret = i40e_init_shared_code(hw);
 	if (ret) {
@@ -934,6 +971,8 @@ eth_i40e_dev_init(struct rte_eth_dev *dev)
 		pf->flags &= ~I40E_FLAG_DCB;
 	}
 
+	i40e_restore_fdena(hw);
+
 	return 0;
 
 err_mac_alloc:
Signature · 1 line
1.9.3
#1 lore raw
Quoted 7 lines · Helin Zhang

Workaround for the issue of cannot processing adminq commands during initialization, when 2x40G or 4x10G is receiving packets in highest throughput. Register 0x002698a8 and 0x002698ac should be cleared at first, and restored with the default values at the end. No more details, as they are not exposed registers.

Hi Helin,

can you please add an appropriately "fixes" line to the patch, since the subject explicitly calls it out as a bug-fix. Also, the words "the issue" in the subject can be removed as they don't add value. It would also be worthwhile referencing the adminq in the subject too, since that is the failure being reported. How about:

"i40e: fix adminq failure on port init"

Regards,
/Bruce

#2 lore raw
Quoted 20 lines

-----Original Message-----
From: Richardson, Bruce
Sent: Thursday, February 4, 2016 12:31 AM
To: Zhang, Helin <[email protected]>
Cc: [email protected]
Subject: Re: [dpdk-dev] [PATCH] i40e: fix the issue of port initialization failure

Quoted 7 lines · Helin Zhang

Workaround for the issue of cannot processing adminq commands during initialization, when 2x40G or 4x10G is receiving packets in highest throughput. Register 0x002698a8 and 0x002698ac should be cleared at first, and restored with the default values at the end. No more details, as they are not exposed registers.

Hi Helin,

Quoted 7 lines

can you please add an appropriately "fixes" line to the patch, since the subject explicitly calls it out as a bug-fix. Also, the words "the issue" in the subject can be removed as they don't add value. It would also be worthwhile referencing the adminq in the subject too, since that is the failure being reported. How about:

"i40e: fix adminq failure on port init"

Oh, sorry, I forgot this patch.
Firmware finally fixed it in FVL5, and we need to use new AQ commands for reading/writing some registers. So I will drop this patch. Thanks!

Regards,
Helin

Quoted 3 lines

Regards,
/Bruce

#3 lore raw

2016-02-04 00:50, Zhang, Helin:

Quoted 7 lines

From: Richardson, Bruce

Quoted 6 lines

can you please add an appropriately "fixes" line to the patch, since the subject explicitly calls it out as a bug-fix. Also, the words "the issue" in the subject can be removed as they don't add value. It would also be worthwhile referencing the adminq in the subject too, since that is the failure being reported. How about:

Quoted 5 lines
Quoted 1 line

"i40e: fix adminq failure on port init"

Oh, sorry, I forgot this patch.
Firmware finally fixed it in FVL5, and we need to use new AQ commands for reading/writing some registers. So I will drop this patch. Thanks!

In such case, please mark it as "Rejected" in patchwork and self reply on the mailing list to advertise it is dropped.
Thanks

#4 lore raw
Quoted 20 lines

-----Original Message-----
From: Thomas Monjalon [mailto:[email protected]]
Sent: Thursday, February 4, 2016 4:44 PM
To: Zhang, Helin <[email protected]>
Cc: [email protected]; Richardson, Bruce <[email protected]>
Subject: Re: [dpdk-dev] [PATCH] i40e: fix the issue of port initialization failure

2016-02-04 00:50, Zhang, Helin:

Quoted 10 lines

From: Richardson, Bruce

Quoted 8 lines

can you please add an appropriately "fixes" line to the patch, since the subject explicitly calls it out as a bug-fix. Also, the words "the issue" in the subject can be removed as they don't add value. It would also be worthwhile referencing the adminq in the subject too, since that is the failure being reported. How
about:

"i40e: fix adminq failure on port init"

Quoted 8 lines
Quoted 2 lines

Oh, sorry, I forgot this patch.
Firmware finally fixed it in FVL5, and we need to use new AQ commands for

reading/writing some registers.

Quoted 1 line

So I will drop this patch. Thanks!

In such case, please mark it as "Rejected" in patchwork and self reply on the mailing list to advertise it is dropped.
Thanks

Done. Thanks!

Regards,
Helin

author NAK
#5 lore raw
In reply to Helin Zhang
Quoted 9 lines

-----Original Message-----
From: Zhang, Helin
Sent: Wednesday, December 23, 2015 1:33 PM
To: [email protected]
Cc: Xu, Qian Q; Zhang, Helin
Subject: [PATCH] i40e: fix the issue of port initialization failure

Quoted 7 lines

Workaround for the issue of cannot processing adminq commands during initialization, when 2x40G or 4x10G is receiving packets in highest throughput. Register 0x002698a8 and 0x002698ac should be cleared at first, and restored with the default values at the end. No more details, as they are not exposed registers.

NACK, as it will be fixed by firmware. This workaround in SW is not needed at all.