Skip to contentSkip to conversation

ARM: dts: rockchip: enable edp functionality

PATCH In review Heiko Stuebner 3 participants 16 messages Mar 18, 2016 – Jun 20, 2019

Subsystems (2)
Device tree bindings Arm Rockchip
lore
Share & tools
lore

Heiko Stuebner

author maintainer
#0 lore raw

cover ARM: dts: rockchip: enable edp functionality

This is the companion series to Yakir's rework of the analogix-dp driver used both by Exynos and Rockchip.

These patches have been sitting in my tree for some time, and already got tested (and thus refined) by a number of people.

So I'll post them now, to get applied after the driver-side gets accepted hopefully soonish.

Caesar Wang (1):
ARM: dts: rockchip: add rk3288-veyron-jaq backlight and panel
overrides

Heiko Stuebner (9):
ARM: dts: rockchip: add rk3288 edp-phy node
ARM: dts: rockchip: add rk3288 displayport controller node
ARM: dts: rockchip: move edp-hpd pin definition into common location
ARM: dts: rockchip: add startup delay to rk3288-veyron
panel-regulators
ARM: dts: rockchip: add core rk3288-veyron backlight and panel nodes
ARM: dts: rockchip: add rk3288-veyron-minnie backlight and panel
settings
ARM: dts: rockchip: override edp hpd handling on veyron-pinky and
speedy
ARM: dts: rockchip: simple panel and backlight supplies on veyron
boards
ARM: dts: rockchip: enable the eDP on rk3288 veyron devices

 arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 100 ++++++++++++++++++++++++
 arch/arm/boot/dts/rk3288-veyron-jaq.dts         |  49 ++++++++++--
 arch/arm/boot/dts/rk3288-veyron-jerry.dts       |   9 +++
 arch/arm/boot/dts/rk3288-veyron-minnie.dts      |  44 +++++++++++
 arch/arm/boot/dts/rk3288-veyron-pinky.dts       |   7 ++
 arch/arm/boot/dts/rk3288-veyron-speedy.dts      |  16 ++++
 arch/arm/boot/dts/rk3288.dtsi                   |  59 ++++++++++++++
 7 files changed, 278 insertions(+), 6 deletions(-)
Signature · 1 line
2.6.4
author maintainer
#1 lore raw

PATCH 1/10 ARM: dts: rockchip: add rk3288 edp-phy node

Add the core device node of the edp-phy on rk3288 socs.

Signed-off-by Heiko Stuebner <[email protected]>
---
 arch/arm/boot/dts/rk3288.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm/boot/dts/rk3288.dtsi +9 -0
index 0934b6a..d6af337 100644
@@ -201,6 +201,15 @@
 		#clock-cells = <0>;
 	};
 
+	edp_phy: edp-phy {
+		compatible = "rockchip,rk3288-dp-phy";
+		clocks = <&cru SCLK_EDP_24M>;
+		clock-names = "24m";
+		rockchip,grf = <&grf>;
+		#phy-cells = <0>;
+		status = "disabled";
+	};
+
 	timer {
 		compatible = "arm,armv7-timer";
 		arm,cpu-registers-not-fw-configured;
Signature · 1 line
2.6.4
author maintainer
#2 lore raw

PATCH 2/10 ARM: dts: rockchip: add rk3288 displayport controller node

In reply to Heiko Stuebner

Add the rk3288 edp node and its hooks into the display-subsystem.

Signed-off-by Heiko Stuebner <[email protected]>
---
 arch/arm/boot/dts/rk3288.dtsi | 44 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)
arch/arm/boot/dts/rk3288.dtsi +44 -0
index d6af337..26cdcee 100644
@@ -830,6 +830,12 @@
 				reg = <0>;
 				remote-endpoint = <&hdmi_in_vopb>;
 			};
+
+			vopb_out_edp: endpoint at 1 {
+				reg = <1>;
+				remote-endpoint = <&edp_in_vopb>;
+			};
+
 			vopb_out_mipi: endpoint at 2 {
 				reg = <2>;
 				remote-endpoint = <&mipi_in_vopb>;

@@ -867,6 +873,12 @@
 				reg = <0>;
 				remote-endpoint = <&hdmi_in_vopl>;
 			};
+
+			vopl_out_edp: endpoint at 1 {
+				reg = <1>;
+				remote-endpoint = <&edp_in_vopl>;
+			};
+
 			vopl_out_mipi: endpoint at 2 {
 				reg = <2>;
 				remote-endpoint = <&mipi_in_vopl>;

@@ -915,6 +927,38 @@
 		};
 	};
 
+	edp: dp at ff970000 {
+		compatible = "rockchip,rk3288-dp";
+		reg = <0xff970000 0x4000>;
+		interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&cru SCLK_EDP>, <&cru PCLK_EDP_CTRL>;
+		clock-names = "dp", "pclk";
+		phys = <&edp_phy>;
+		phy-names = "dp";
+		resets = <&cru SRST_EDP>;
+		reset-names = "dp";
+		rockchip,grf = <&grf>;
+		status = "disabled";
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			edp_in: port at 0 {
+				reg = <0>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+				edp_in_vopb: endpoint at 0 {
+					reg = <0>;
+					remote-endpoint = <&vopb_out_edp>;
+				};
+				edp_in_vopl: endpoint at 1 {
+					reg = <1>;
+					remote-endpoint = <&vopl_out_edp>;
+				};
+			};
+		};
+	};
+
 	hdmi: hdmi at ff980000 {
 		compatible = "rockchip,rk3288-dw-hdmi";
 		reg = <0xff980000 0x20000>;
Signature · 1 line
2.6.4
author maintainer
#3 lore raw

PATCH 3/10 ARM: dts: rockchip: move edp-hpd pin definition into common location

In reply to Heiko Stuebner

The edp hotplug pin is fixed on the soc side, anybody wanting to use it will need the same definition anyway, so move it to a common location.

Signed-off-by Heiko Stuebner <[email protected]>
---
 arch/arm/boot/dts/rk3288-veyron-jaq.dts | 6 ------
 arch/arm/boot/dts/rk3288.dtsi           | 6 ++++++
 2 files changed, 6 insertions(+), 6 deletions(-)
arch/arm/boot/dts/rk3288-veyron-jaq.dts +0 -6
index c2f52cf..5c97e31 100644
@@ -142,12 +142,6 @@
 		};
 	};
 
-	edp {
-		edp_hpd: edp_hpd {
-			rockchip,pins = <7 11 RK_FUNC_2 &pcfg_pull_down>;
-		};
-	};
-
 	hdmi {
 		vcc50_hdmi_en: vcc50-hdmi-en {
 			rockchip,pins = <5 19 RK_FUNC_GPIO &pcfg_pull_none>;
arch/arm/boot/dts/rk3288.dtsi +6 -0
index 26cdcee..f11a28f 100644
@@ -1211,6 +1211,12 @@
 			};
 		};
 
+		edp {
+			edp_hpd: edp-hpd {
+				rockchip,pins = <7 11 RK_FUNC_2 &pcfg_pull_down>;
+			};
+		};
+
 		i2c0 {
 			i2c0_xfer: i2c0-xfer {
 				rockchip,pins = <0 15 RK_FUNC_1 &pcfg_pull_none>,
Signature · 1 line
2.6.4
author maintainer
#4 lore raw

PATCH 4/10 ARM: dts: rockchip: add startup delay to rk3288-veyron panel-regulators

In reply to Heiko Stuebner

The panels need a bit of time to actually turn on. If this isn't observed, this results in problems when trying talk to the panels and thus produces detection errors. 100ms seem to be a safe value for the time being.

Signed-off-by Heiko Stuebner <[email protected]>
---
 arch/arm/boot/dts/rk3288-veyron-jaq.dts    | 1 +
 arch/arm/boot/dts/rk3288-veyron-jerry.dts  | 1 +
 arch/arm/boot/dts/rk3288-veyron-minnie.dts | 1 +
 arch/arm/boot/dts/rk3288-veyron-speedy.dts | 1 +
 4 files changed, 4 insertions(+)
arch/arm/boot/dts/rk3288-veyron-jaq.dts +1 -0
index 5c97e31..2123ac2 100644
@@ -61,6 +61,7 @@
 		pinctrl-names = "default";
 		pinctrl-0 = <&lcd_enable_h>;
 		regulator-name = "panel_regulator";
+		startup-delay-us = <100000>;
 		vin-supply = <&vcc33_sys>;
 	};
arch/arm/boot/dts/rk3288-veyron-jerry.dts +1 -0
index 60bd6e9..1a9bef1 100644
@@ -60,6 +60,7 @@
 		pinctrl-names = "default";
 		pinctrl-0 = <&lcd_enable_h>;
 		regulator-name = "panel_regulator";
+		startup-delay-us = <100000>;
 		vin-supply = <&vcc33_sys>;
 	};
arch/arm/boot/dts/rk3288-veyron-minnie.dts +1 -0
index 699beb0..8b16f37 100644
@@ -70,6 +70,7 @@
 		pinctrl-names = "default";
 		pinctrl-0 = <&lcd_enable_h>;
 		regulator-name = "panel_regulator";
+		startup-delay-us = <100000>;
 		vin-supply = <&vcc33_sys>;
 	};
arch/arm/boot/dts/rk3288-veyron-speedy.dts +1 -0
index b34a7b5..e62cdee 100644
@@ -61,6 +61,7 @@
 		pinctrl-names = "default";
 		pinctrl-0 = <&lcd_enable_h>;
 		regulator-name = "panel_regulator";
+		startup-delay-us = <100000>;
 		vin-supply = <&vcc33_sys>;
 	};
Signature · 1 line
2.6.4
#5 lore raw

Re: [PATCH 04/10] ARM: dts: rockchip: add startup delay to rk3288-veyron panel-regulators

Hi,

Quoted 6 lines · On Wed, Fri, 18 Mar 2016 Heiko Stuebner <[email protected]> wrote:

The panels need a bit of time to actually turn on. If this isn't observed, this results in problems when trying talk to the panels and thus produces detection errors. 100ms seem to be a safe value for the time being.

Quoted 7 lines
Signed-off-by Heiko Stuebner <[email protected]>
---
 arch/arm/boot/dts/rk3288-veyron-jaq.dts    | 1 +
 arch/arm/boot/dts/rk3288-veyron-jerry.dts  | 1 +
 arch/arm/boot/dts/rk3288-veyron-minnie.dts | 1 +
 arch/arm/boot/dts/rk3288-veyron-speedy.dts | 1 +
 4 files changed, 4 insertions(+)

I know it was 3 years ago, but any idea how to reproduce the problems you were seeing without this patch? I believe the downstream kernel never had any delay like this and I'm not aware of any issues.

I wonder if the need for this extra 100 ms delay is no longer there now that we have:

3157694d8c7f pwm-backlight: Add support for PWM delays proprieties. 5fb5caee92ba pwm-backlight: Enable/disable the PWM before/after LCD enable toggle.
6d5922dd0d60 ARM: dts: rockchip: set PWM delay backlight settings for Veyron

author maintainer
#6 lore raw

Re: [PATCH 04/10] ARM: dts: rockchip: add startup delay to rk3288-veyron panel-regulators

Hi Doug,

Am Donnerstag, 20. Juni 2019, 03:27:55 CEST schrieb Doug Anderson:

Quoted 19 lines · On Wed, Fri, 18 Mar 2016 Heiko Stuebner <[email protected]> wrote:
Quoted 6 lines

The panels need a bit of time to actually turn on. If this isn't observed, this results in problems when trying talk to the panels and thus produces detection errors. 100ms seem to be a safe value for the time being.

Quoted 7 lines
Signed-off-by Heiko Stuebner <[email protected]>
---
 arch/arm/boot/dts/rk3288-veyron-jaq.dts    | 1 +
 arch/arm/boot/dts/rk3288-veyron-jerry.dts  | 1 +
 arch/arm/boot/dts/rk3288-veyron-minnie.dts | 1 +
 arch/arm/boot/dts/rk3288-veyron-speedy.dts | 1 +
 4 files changed, 4 insertions(+)

I know it was 3 years ago, but any idea how to reproduce the problems you were seeing without this patch? I believe the downstream kernel never had any delay like this and I'm not aware of any issues.

Quoted 7 lines

I wonder if the need for this extra 100 ms delay is no longer there now that we have:

3157694d8c7f pwm-backlight: Add support for PWM delays proprieties. 5fb5caee92ba pwm-backlight: Enable/disable the PWM before/after LCD enable toggle.
6d5922dd0d60 ARM: dts: rockchip: set PWM delay backlight settings for Veyron

I just did a non-scientific test on my jerry+minnie and yes, simply reverting that patch does not seem to affect display bringup and I still get a prompt.

So I guess we could just revert that patch in light of the changes. [patches welcome ;-) ]

Heiko

author maintainer
#7 lore raw

PATCH 5/10 ARM: dts: rockchip: add core rk3288-veyron backlight and panel nodes

In reply to Heiko Stuebner

Many Veyron chromebooks share the same panel type, so define the core settings for all of them and allow the few runaways to override it later.

Signed-off-by Heiko Stuebner <[email protected]>
---
 arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 57 +++++++++++++++++++++++++
 1 file changed, 57 insertions(+)
arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi +57 -0
index 610769d..7563d3d 100644
@@ -54,6 +54,50 @@
 		i2c20 = &i2c_tunnel;
 	};
 
+	backlight: backlight {
+		compatible = "pwm-backlight";
+		brightness-levels = <
+			  0   1   2   3   4   5   6   7
+			  8   9  10  11  12  13  14  15
+			 16  17  18  19  20  21  22  23
+			 24  25  26  27  28  29  30  31
+			 32  33  34  35  36  37  38  39
+			 40  41  42  43  44  45  46  47
+			 48  49  50  51  52  53  54  55
+			 56  57  58  59  60  61  62  63
+			 64  65  66  67  68  69  70  71
+			 72  73  74  75  76  77  78  79
+			 80  81  82  83  84  85  86  87
+			 88  89  90  91  92  93  94  95
+			 96  97  98  99 100 101 102 103
+			104 105 106 107 108 109 110 111
+			112 113 114 115 116 117 118 119
+			120 121 122 123 124 125 126 127
+			128 129 130 131 132 133 134 135
+			136 137 138 139 140 141 142 143
+			144 145 146 147 148 149 150 151
+			152 153 154 155 156 157 158 159
+			160 161 162 163 164 165 166 167
+			168 169 170 171 172 173 174 175
+			176 177 178 179 180 181 182 183
+			184 185 186 187 188 189 190 191
+			192 193 194 195 196 197 198 199
+			200 201 202 203 204 205 206 207
+			208 209 210 211 212 213 214 215
+			216 217 218 219 220 221 222 223
+			224 225 226 227 228 229 230 231
+			232 233 234 235 236 237 238 239
+			240 241 242 243 244 245 246 247
+			248 249 250 251 252 253 254 255>;
+		default-brightness-level = <128>;
+		enable-gpios = <&gpio7 2 GPIO_ACTIVE_HIGH>;
+		backlight-boot-off;
+		pinctrl-names = "default";
+		pinctrl-0 = <&bl_en>;
+		pwms = <&pwm0 0 1000000 0>;
+		pwm-delay-us = <10000>;
+	};
+
 	gpio-charger {
 		compatible = "gpio-charger";
 		charger-type = "mains";

@@ -62,6 +106,13 @@
 		pinctrl-0 = <&ac_present_ap>;
 	};
 
+	panel: panel {
+		compatible ="innolux,n116bge", "simple-panel";
+		status = "okay";
+		power-supply = <&vcc33_lcd>;
+		backlight = <&backlight>;
+	};
+
 	/* A non-regulated voltage from power supply or battery */
 	vccsys: vccsys {
 		compatible = "regulator-fixed";

@@ -184,6 +235,12 @@
 		&suspend_l_sleep
 	>;
 
+	backlight {
+		bl_en: bl-en {
+			rockchip,pins = <7 2 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+
 	buttons {
 		ap_lid_int_l: ap-lid-int-l {
 			rockchip,pins = <0 6 RK_FUNC_GPIO &pcfg_pull_up>;
Signature · 1 line
2.6.4
author maintainer
#8 lore raw

PATCH 6/10 ARM: dts: rockchip: add rk3288-veyron-jaq backlight and panel overrides

In reply to Heiko Stuebner

From: Caesar Wang <[email protected]>

The panel which jaq uses requires the pwm duty cycle larger than 3%, when the backlight status from power off to power on, otherwise the backlight will flush, so we modify the second brightness-level to 8, and when the backlight from power off to power on the pwm duty cycle will larger than 3%.

Signed-off-by Caesar Wang <[email protected]>
Signed-off-by Heiko Stuebner <[email protected]>
---
 arch/arm/boot/dts/rk3288-veyron-jaq.dts | 42 +++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)
arch/arm/boot/dts/rk3288-veyron-jaq.dts +42 -0
index 2123ac2..3748abf 100644
@@ -89,6 +89,48 @@
 	};
 };
 
+&backlight {
+	/* Jaq panel PWM must be >= 3%, so start non-zero brightness at 8 */
+	brightness-levels = <
+		  0
+		  8   9  10  11  12  13  14  15
+		 16  17  18  19  20  21  22  23
+		 24  25  26  27  28  29  30  31
+		 32  33  34  35  36  37  38  39
+		 40  41  42  43  44  45  46  47
+		 48  49  50  51  52  53  54  55
+		 56  57  58  59  60  61  62  63
+		 64  65  66  67  68  69  70  71
+		 72  73  74  75  76  77  78  79
+		 80  81  82  83  84  85  86  87
+		 88  89  90  91  92  93  94  95
+		 96  97  98  99 100 101 102 103
+		104 105 106 107 108 109 110 111
+		112 113 114 115 116 117 118 119
+		120 121 122 123 124 125 126 127
+		128 129 130 131 132 133 134 135
+		136 137 138 139 140 141 142 143
+		144 145 146 147 148 149 150 151
+		152 153 154 155 156 157 158 159
+		160 161 162 163 164 165 166 167
+		168 169 170 171 172 173 174 175
+		176 177 178 179 180 181 182 183
+		184 185 186 187 188 189 190 191
+		192 193 194 195 196 197 198 199
+		200 201 202 203 204 205 206 207
+		208 209 210 211 212 213 214 215
+		216 217 218 219 220 221 222 223
+		224 225 226 227 228 229 230 231
+		232 233 234 235 236 237 238 239
+		240 241 242 243 244 245 246 247
+		248 249 250 251 252 253 254 255>;
+	power-supply = <&backlight_regulator>;
+};
+
+&panel {
+	power-supply = <&panel_regulator>;
+};
+
 &rk808 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pmic_int_l &dvs_1 &dvs_2>;
Signature · 1 line
2.6.4
author maintainer
#9 lore raw

PATCH 7/10 ARM: dts: rockchip: add rk3288-veyron-minnie backlight and panel settings

In reply to Heiko Stuebner

The pwm for Minnie's backlight needs to be above 1%, so adapt the start of non-zero brightness accordingly. Minnie is also using a different panel, so re-set the compatible property.

Signed-off-by Heiko Stuebner <[email protected]>
---
 arch/arm/boot/dts/rk3288-veyron-minnie.dts | 43 ++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)
arch/arm/boot/dts/rk3288-veyron-minnie.dts +43 -0
index 8b16f37..f72d616 100644
@@ -87,6 +87,44 @@
 	};
 };
 
+&backlight {
+	/* Minnie panel PWM must be >= 1%, so start non-zero brightness at 3 */
+	brightness-levels = <
+			  0   3   4   5   6   7
+			  8   9  10  11  12  13  14  15
+			 16  17  18  19  20  21  22  23
+			 24  25  26  27  28  29  30  31
+			 32  33  34  35  36  37  38  39
+			 40  41  42  43  44  45  46  47
+			 48  49  50  51  52  53  54  55
+			 56  57  58  59  60  61  62  63
+			 64  65  66  67  68  69  70  71
+			 72  73  74  75  76  77  78  79
+			 80  81  82  83  84  85  86  87
+			 88  89  90  91  92  93  94  95
+			 96  97  98  99 100 101 102 103
+			104 105 106 107 108 109 110 111
+			112 113 114 115 116 117 118 119
+			120 121 122 123 124 125 126 127
+			128 129 130 131 132 133 134 135
+			136 137 138 139 140 141 142 143
+			144 145 146 147 148 149 150 151
+			152 153 154 155 156 157 158 159
+			160 161 162 163 164 165 166 167
+			168 169 170 171 172 173 174 175
+			176 177 178 179 180 181 182 183
+			184 185 186 187 188 189 190 191
+			192 193 194 195 196 197 198 199
+			200 201 202 203 204 205 206 207
+			208 209 210 211 212 213 214 215
+			216 217 218 219 220 221 222 223
+			224 225 226 227 228 229 230 231
+			232 233 234 235 236 237 238 239
+			240 241 242 243 244 245 246 247
+			248 249 250 251 252 253 254 255>;
+	power-supply = <&backlight_regulator>;
+};
+
 &emmc {
 	/delete-property/mmc-hs200-1_8v;
 };

@@ -136,6 +174,11 @@
 	};
 };
 
+&panel {
+	compatible = "auo,b101ean01", "simple-panel";
+	power-supply= <&panel_regulator>;
+};
+
 &rk808 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pmic_int_l &dvs_1 &dvs_2>;
Signature · 1 line
2.6.4
author maintainer
#10 lore raw

PATCH 8/10 ARM: dts: rockchip: override edp hpd handling on veyron-pinky and speedy

In reply to Heiko Stuebner

Pinky boards don't have the hotplug pin connected. So remove the hotplug pinctrl setting and enable the force-hpd option, to allow them to find the display too.

While on speedy boards, the hotplug pin is connected, judging by comments in a chromeos change it seems the "panels HPD voltage is too low to be detected", so it also needs the forced hotplug, as we of course also know that a display is connected.

Signed-off-by Heiko Stuebner <[email protected]>
---
 arch/arm/boot/dts/rk3288-veyron-pinky.dts  | 7 +++++++
 arch/arm/boot/dts/rk3288-veyron-speedy.dts | 7 +++++++
 2 files changed, 14 insertions(+)
arch/arm/boot/dts/rk3288-veyron-pinky.dts +7 -0
index 94b56e3..d44351e 100644
@@ -65,6 +65,13 @@
 	pinctrl-0 = <&emmc_clk &emmc_cmd &emmc_bus8 &emmc_reset>;
 };
 
+&edp {
+	/delete-property/pinctrl-names;
+	/delete-property/pinctrl-0;
+
+	force-hpd;
+};
+
 &gpio_keys {
 	pinctrl-0 = <&pwr_key_h &ap_lid_int_l>;
arch/arm/boot/dts/rk3288-veyron-speedy.dts +7 -0
index e62cdee..90aa145 100644
@@ -97,6 +97,13 @@
 	temperature = <70000>;
 };
 
+&edp {
+	/delete-property/pinctrl-names;
+	/delete-property/pinctrl-0;
+
+	force-hpd;
+};
+
 &rk808 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pmic_int_l>;
Signature · 1 line
2.6.4
author maintainer
#11 lore raw

PATCH 9/10 ARM: dts: rockchip: simple panel and backlight supplies on veyron boards

In reply to Heiko Stuebner

Jerry and Speedy don't need any special handling wrt the backlight or panel, so only need their backlight and panel-regulators hooked up.

Signed-off-by Heiko Stuebner <[email protected]>
---
 arch/arm/boot/dts/rk3288-veyron-jerry.dts  | 8 ++++++++
 arch/arm/boot/dts/rk3288-veyron-speedy.dts | 8 ++++++++
 2 files changed, 16 insertions(+)
arch/arm/boot/dts/rk3288-veyron-jerry.dts +8 -0
index 1a9bef1..f6b2eaa 100644
@@ -88,6 +88,14 @@
 	};
 };
 
+&backlight {
+	power-supply = <&backlight_regulator>;
+};
+
+&panel {
+	power-supply= <&panel_regulator>;
+};
+
 &rk808 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pmic_int_l>;
arch/arm/boot/dts/rk3288-veyron-speedy.dts +8 -0
index 90aa145..a0d033f 100644
@@ -89,6 +89,10 @@
 	};
 };
 
+&backlight {
+	power-supply = <&backlight_regulator>;
+};
+
 &cpu_alert0 {
 	temperature = <65000>;
 };

@@ -104,6 +108,10 @@
 	force-hpd;
 };
 
+&panel {
+	power-supply= <&panel_regulator>;
+};
+
 &rk808 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pmic_int_l>;
Signature · 1 line
2.6.4
author maintainer
#12 lore raw

PATCH 10/10 ARM: dts: rockchip: enable the eDP on rk3288 veyron devices

In reply to Heiko Stuebner

After hooking up panel and backlight informations, enable the edp on veyron chromebooks now.

Signed-off-by Heiko Stuebner <[email protected]>
---
 arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 43 +++++++++++++++++++++++++
 1 file changed, 43 insertions(+)
arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi +43 -0
index 7563d3d..2958c36 100644
@@ -111,6 +111,14 @@
 		status = "okay";
 		power-supply = <&vcc33_lcd>;
 		backlight = <&backlight>;
+
+		ports {
+			panel_in: port {
+				panel_in_edp: endpoint {
+					remote-endpoint = <&edp_out_panel>;
+				};
+			};
+		};
 	};
 
 	/* A non-regulated voltage from power supply or battery */

@@ -154,6 +162,29 @@
 	};
 };
 
+&edp {
+	status = "okay";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&edp_hpd>;
+
+	ports {
+		edp_out: port at 1 {
+			reg = <1>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			edp_out_panel: endpoint {
+				reg = <0>;
+				remote-endpoint = <&panel_in_edp>;
+			};
+		};
+	};
+};
+
+&edp_phy {
+	status = "okay";
+};
+
 &gpio_keys {
 	pinctrl-0 = <&pwr_key_l &ap_lid_int_l>;
 	lid {

@@ -166,6 +197,10 @@
 	};
 };
 
+&pwm0 {
+	status = "okay";
+};
+
 &rk808 {
 	vcc11-supply = <&vcc_5v>;
 

@@ -219,6 +254,14 @@
 	};
 };
 
+&vopl {
+	status = "okay";
+};
+
+&vopl_mmu {
+	status = "okay";
+};
+
 &pinctrl {
 	pinctrl-0 = <
 		/* Common for sleep and wake, but no owners */
Signature · 1 line
2.6.4
#13 lore raw

cover ARM: dts: rockchip: enable edp functionality

In reply to Heiko Stuebner

Hi Heiko,

Quoted 8 lines · Heiko Stuebner

This is the companion series to Yakir's rework of the analogix-dp driver used both by Exynos and Rockchip.

These patches have been sitting in my tree for some time, and already got tested (and thus refined) by a number of people.

So I'll post them now, to get applied after the driver-side gets accepted hopefully soonish.

Thanks very much about this cool work ;)

- Yakir

Quoted 29 lines

Caesar Wang (1):
ARM: dts: rockchip: add rk3288-veyron-jaq backlight and panel
overrides

Heiko Stuebner (9):
ARM: dts: rockchip: add rk3288 edp-phy node
ARM: dts: rockchip: add rk3288 displayport controller node
ARM: dts: rockchip: move edp-hpd pin definition into common location
ARM: dts: rockchip: add startup delay to rk3288-veyron
panel-regulators
ARM: dts: rockchip: add core rk3288-veyron backlight and panel nodes
ARM: dts: rockchip: add rk3288-veyron-minnie backlight and panel
settings
ARM: dts: rockchip: override edp hpd handling on veyron-pinky and
speedy
ARM: dts: rockchip: simple panel and backlight supplies on veyron
boards
ARM: dts: rockchip: enable the eDP on rk3288 veyron devices

  arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 100 ++++++++++++++++++++++++
  arch/arm/boot/dts/rk3288-veyron-jaq.dts         |  49 ++++++++++--
  arch/arm/boot/dts/rk3288-veyron-jerry.dts       |   9 +++
  arch/arm/boot/dts/rk3288-veyron-minnie.dts      |  44 +++++++++++
  arch/arm/boot/dts/rk3288-veyron-pinky.dts       |   7 ++
  arch/arm/boot/dts/rk3288-veyron-speedy.dts      |  16 ++++
  arch/arm/boot/dts/rk3288.dtsi                   |  59 ++++++++++++++
  7 files changed, 278 insertions(+), 6 deletions(-)
#14 lore raw

cover ARM: dts: rockchip: enable edp functionality

In reply to Heiko Stuebner

Heiko,

Quoted 29 lines · Heiko Stuebner

This is the companion series to Yakir's rework of the analogix-dp driver used both by Exynos and Rockchip.

These patches have been sitting in my tree for some time, and already got tested (and thus refined) by a number of people.

So I'll post them now, to get applied after the driver-side gets accepted hopefully soonish.

Caesar Wang (1):
ARM: dts: rockchip: add rk3288-veyron-jaq backlight and panel
overrides

Heiko Stuebner (9):
ARM: dts: rockchip: add rk3288 edp-phy node
ARM: dts: rockchip: add rk3288 displayport controller node
ARM: dts: rockchip: move edp-hpd pin definition into common location
ARM: dts: rockchip: add startup delay to rk3288-veyron
panel-regulators
ARM: dts: rockchip: add core rk3288-veyron backlight and panel nodes
ARM: dts: rockchip: add rk3288-veyron-minnie backlight and panel
settings
ARM: dts: rockchip: override edp hpd handling on veyron-pinky and
speedy
ARM: dts: rockchip: simple panel and backlight supplies on veyron
boards
ARM: dts: rockchip: enable the eDP on rk3288 veyron devices

Quoted 8 lines
 arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 100 ++++++++++++++++++++++++
 arch/arm/boot/dts/rk3288-veyron-jaq.dts         |  49 ++++++++++--
 arch/arm/boot/dts/rk3288-veyron-jerry.dts       |   9 +++
 arch/arm/boot/dts/rk3288-veyron-minnie.dts      |  44 +++++++++++
 arch/arm/boot/dts/rk3288-veyron-pinky.dts       |   7 ++
 arch/arm/boot/dts/rk3288-veyron-speedy.dts      |  16 ++++
 arch/arm/boot/dts/rk3288.dtsi                   |  59 ++++++++++++++
 7 files changed, 278 insertions(+), 6 deletions(-)

Awesome! I picked this along with the eDP series and I was able to use the builtin panel on my veyron-jerry. :) I was testing on a 4.4-based tree with backports.

Tested-by Douglas Anderson <[email protected]>
author maintainer
#15 lore raw

cover ARM: dts: rockchip: enable edp functionality

In reply to Heiko Stuebner

Am Freitag, 18. M?rz 2016, 02:39:56 schrieb Heiko Stuebner:

Quoted 8 lines

This is the companion series to Yakir's rework of the analogix-dp driver used both by Exynos and Rockchip.

These patches have been sitting in my tree for some time, and already got tested (and thus refined) by a number of people.

So I'll post them now, to get applied after the driver-side gets accepted hopefully soonish.

with the edp driver entering the drm tree for 4.7, I've now applied the dt- side for 4.7 as well.

Heiko