Skip to contentSkip to conversation

ARM: shmobile: porter: add SDHI0/2 DT support

PATCH New Sergei Shtylyov 2 participants 8 messages Oct 6, 2015 – Oct 8, 2015

Subsystems (2)
Device tree bindings SuperH
lore
Share & tools
lore

Sergei Shtylyov

author
#0 lore raw

PATCH 1/1 ARM: shmobile: porter: add SDHI0/2 DT support

Define the Porter board dependent part of the SDHI0/2 device nodes along with the necessary voltage regulators (note that the Vcc regulators are dummy -- they are required but don't actually exist on the board). Also, GPIOs have to be used for the CD and WP signals due to the SDHI driver constraints...

This patch is analogous to the commit 1299df03d719 (ARM: shmobile: henninger:
add SDHI0/2 DT support) as there are no differences between those boards in this respect.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20151006-v4.3-rc4' tag of Simon Horman's 'renesas.git' repo.

 arch/arm/boot/dts/r8a7791-porter.dts |   76 +++++++++++++++++++++++++++++++++++
 1 file changed, 76 insertions(+)
arch/arm/boot/dts/r8a7791-porter.dts +76 -0
Index: renesas/arch/arm/boot/dts/r8a7791-porter.dts
===================================================================
@@ -10,6 +10,7 @@
 
 /dts-v1/;
 #include "r8a7791.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	model = "Porter";

@@ -33,6 +34,50 @@
 		device_type = "memory";
 		reg = <2 0x00000000 0 0x40000000>;
 	};
+
+	vcc_sdhi0: regulator at 0 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "SDHI0 Vcc";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-always-on;
+	};
+
+	vccq_sdhi0: regulator at 1 {
+		compatible = "regulator-gpio";
+
+		regulator-name = "SDHI0 VccQ";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpios = <&gpio2 12 GPIO_ACTIVE_HIGH>;
+		gpios-states = <1>;
+		states = <3300000 1
+			  1800000 0>;
+	};
+
+	vcc_sdhi2: regulator at 2 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "SDHI2 Vcc";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-always-on;
+	};
+
+	vccq_sdhi2: regulator at 3 {
+		compatible = "regulator-gpio";
+
+		regulator-name = "SDHI2 VccQ";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>;
+		gpios-states = <1>;
+		states = <3300000 1
+			  1800000 0>;
+	};
 };
 
 &extal_clk {

@@ -54,6 +99,16 @@
 		renesas,groups = "intc_irq0";
 		renesas,function = "intc";
 	};
+
+	sdhi0_pins: sd0 {
+		renesas,groups = "sdhi0_data4", "sdhi0_ctrl";
+		renesas,function = "sdhi0";
+	};
+
+	sdhi2_pins: sd2 {
+		renesas,groups = "sdhi2_data4", "sdhi2_ctrl";
+		renesas,function = "sdhi2";
+	};
 };
 
 &scif0 {

@@ -78,3 +133,24 @@
 		micrel,led-mode = <1>;
 	};
 };
+
+&sdhi0 {
+	pinctrl-0 = <&sdhi0_pins>;
+	pinctrl-names = "default";
+
+	vmmc-supply = <&vcc_sdhi0>;
+	vqmmc-supply = <&vccq_sdhi0>;
+	cd-gpios = <&gpio6 6 GPIO_ACTIVE_LOW>;
+	wp-gpios = <&gpio6 7 GPIO_ACTIVE_HIGH>;
+	status = "okay";
+};
+
+&sdhi2 {
+	pinctrl-0 = <&sdhi2_pins>;
+	pinctrl-names = "default";
+
+	vmmc-supply = <&vcc_sdhi2>;
+	vqmmc-supply = <&vccq_sdhi2>;
+	cd-gpios = <&gpio6 22 GPIO_ACTIVE_LOW>;
+	status = "okay";
+};
#1 lore raw

PATCH 1/1 ARM: shmobile: porter: add SDHI0/2 DT support

Quoted 9 lines · Sergei Shtylyov

Define the Porter board dependent part of the SDHI0/2 device nodes along with the necessary voltage regulators (note that the Vcc regulators are dummy -- they are required but don't actually exist on the board). Also, GPIOs have to be used for the CD and WP signals due to the SDHI driver constraints...

This patch is analogous to the commit 1299df03d719 (ARM: shmobile: henninger:
add SDHI0/2 DT support) as there are no differences between those boards in this respect.

Quoted 5 lines
Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20151006-v4.3-rc4' tag of Simon Horman's 'renesas.git' repo.

Thanks I have queued this up after addressing some issues in the changelog that checkpatch complained about:

* text > 75 characters wide
* Missing '"' around name of patch referred to

Its looking like there is already quite a log shared between r8a7791-porter.dts and r8a7791-henninger.dts. Do you have any thoughts on consolidating or sharing common elements between them somehow?

author
#2 lore raw

PATCH 1/1 ARM: shmobile: porter: add SDHI0/2 DT support

Hello.

Quoted 15 lines · Simon Horman
Quoted 9 lines

Define the Porter board dependent part of the SDHI0/2 device nodes along with the necessary voltage regulators (note that the Vcc regulators are dummy -- they are required but don't actually exist on the board). Also, GPIOs have to be used for the CD and WP signals due to the SDHI driver constraints...

This patch is analogous to the commit 1299df03d719 (ARM: shmobile: henninger:
add SDHI0/2 DT support) as there are no differences between those boards in this respect.

Quoted 5 lines
Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20151006-v4.3-rc4' tag of Simon Horman's 'renesas.git' repo.

Quoted 7 lines

Thanks I have queued this up after addressing some issues in the changelog that checkpatch complained about:

* text > 75 characters wide
* Missing '"' around name of patch referred to

Its looking like there is already quite a log shared between

Lot?

Quoted 3 lines

r8a7791-porter.dts and r8a7791-henninger.dts. Do you have any thoughts on consolidating or sharing common elements between them somehow?

I'm still planning to remove the Henninger's .dts for good. It was never
sold and so had no users outside Renesas (and Cogent Embedded), I was told.

MBR, Sergei

#3 lore raw

PATCH 1/1 ARM: shmobile: porter: add SDHI0/2 DT support

Quoted 27 lines · Sergei Shtylyov

Hello.

Quoted 15 lines · Simon Horman
Quoted 9 lines

Define the Porter board dependent part of the SDHI0/2 device nodes along with the necessary voltage regulators (note that the Vcc regulators are dummy -- they are required but don't actually exist on the board). Also, GPIOs have to be used for the CD and WP signals due to the SDHI driver constraints...

This patch is analogous to the commit 1299df03d719 (ARM: shmobile: henninger:
add SDHI0/2 DT support) as there are no differences between those boards in this respect.

Quoted 5 lines
Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20151006-v4.3-rc4' tag of Simon Horman's 'renesas.git' repo.

Quoted 7 lines

Thanks I have queued this up after addressing some issues in the changelog that checkpatch complained about:

* text > 75 characters wide
* Missing '"' around name of patch referred to

Its looking like there is already quite a log shared between

Quoted 8 lines

Lot?

Quoted 3 lines

r8a7791-porter.dts and r8a7791-henninger.dts. Do you have any thoughts on consolidating or sharing common elements between them somehow?

I'm still planning to remove the Henninger's .dts for good. It was never
sold and so had no users outside Renesas (and Cogent Embedded), I was told.

Thanks, that sounds like a good plan to me.
Do you have any thoughts on when?

author
#4 lore raw

PATCH 1/1 ARM: shmobile: porter: add SDHI0/2 DT support

Hello.

Quoted 29 lines · Simon Horman
Quoted 29 lines
Quoted 15 lines
Quoted 9 lines

Define the Porter board dependent part of the SDHI0/2 device nodes along with the necessary voltage regulators (note that the Vcc regulators are dummy -- they are required but don't actually exist on the board). Also, GPIOs have to be used for the CD and WP signals due to the SDHI driver constraints...

This patch is analogous to the commit 1299df03d719 (ARM: shmobile: henninger:
add SDHI0/2 DT support) as there are no differences between those boards in this respect.

Quoted 5 lines
Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20151006-v4.3-rc4' tag of Simon Horman's 'renesas.git' repo.

Quoted 7 lines

Thanks I have queued this up after addressing some issues in the changelog that checkpatch complained about:

* text > 75 characters wide
* Missing '"' around name of patch referred to

Its looking like there is already quite a log shared between

Lot?

Quoted 3 lines

r8a7791-porter.dts and r8a7791-henninger.dts. Do you have any thoughts on consolidating or sharing common elements between them somehow?

Quoted 5 lines
Quoted 2 lines

I'm still planning to remove the Henninger's .dts for good. It was never
sold and so had no users outside Renesas (and Cogent Embedded), I was told.

Thanks, that sounds like a good plan to me.
Do you have any thoughts on when?

Well, I was going to reach the feature parity between these 2 boards, i.e.
to support all devices on Porter that are supported on Henninger...

MBR, Sergei

#5 lore raw

PATCH 1/1 ARM: shmobile: porter: add SDHI0/2 DT support

Quoted 33 lines · Sergei Shtylyov

Hello.

Quoted 29 lines · Simon Horman
Quoted 29 lines
Quoted 15 lines
Quoted 9 lines

Define the Porter board dependent part of the SDHI0/2 device nodes along with the necessary voltage regulators (note that the Vcc regulators are dummy -- they are required but don't actually exist on the board). Also, GPIOs have to be used for the CD and WP signals due to the SDHI driver constraints...

This patch is analogous to the commit 1299df03d719 (ARM: shmobile: henninger:
add SDHI0/2 DT support) as there are no differences between those boards in this respect.

Quoted 5 lines
Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20151006-v4.3-rc4' tag of Simon Horman's 'renesas.git' repo.

Quoted 7 lines

Thanks I have queued this up after addressing some issues in the changelog that checkpatch complained about:

* text > 75 characters wide
* Missing '"' around name of patch referred to

Its looking like there is already quite a log shared between

Lot?

Quoted 3 lines

r8a7791-porter.dts and r8a7791-henninger.dts. Do you have any thoughts on consolidating or sharing common elements between them somehow?

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

I'm still planning to remove the Henninger's .dts for good. It was never
sold and so had no users outside Renesas (and Cogent Embedded), I was told.

Thanks, that sounds like a good plan to me.
Do you have any thoughts on when?

Well, I was going to reach the feature parity between these 2 boards,
i.e. to support all devices on Porter that are supported on Henninger...

THanks, that sounds like an entirely reasonable plan to me.

author
#6 lore raw

PATCH 1/1 ARM: shmobile: porter: add SDHI0/2 DT support

In reply to Simon Horman
Quoted 15 lines · Simon Horman
Quoted 9 lines

Define the Porter board dependent part of the SDHI0/2 device nodes along with the necessary voltage regulators (note that the Vcc regulators are dummy -- they are required but don't actually exist on the board). Also, GPIOs have to be used for the CD and WP signals due to the SDHI driver constraints...

This patch is analogous to the commit 1299df03d719 (ARM: shmobile: henninger:
add SDHI0/2 DT support) as there are no differences between those boards in this respect.

Quoted 5 lines
Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20151006-v4.3-rc4' tag of Simon Horman's 'renesas.git' repo.

Quoted 5 lines

Thanks I have queued this up after addressing some issues in the changelog that checkpatch complained about:

* text > 75 characters wide
* Missing '"' around name of patch referred to

Sorry about that, forgot to run thru checkpatch.pl (as usual :-).

MBR, Sergei

#7 lore raw

PATCH 1/1 ARM: shmobile: porter: add SDHI0/2 DT support

Quoted 17 lines · Sergei Shtylyov
Quoted 15 lines · Simon Horman
Quoted 14 lines

Define the Porter board dependent part of the SDHI0/2 device nodes along with the necessary voltage regulators (note that the Vcc regulators are dummy -- they are required but don't actually exist on the board). Also, GPIOs have to be used for the CD and WP signals due to the SDHI driver constraints...

This patch is analogous to the commit 1299df03d719 (ARM: shmobile: henninger:
add SDHI0/2 DT support) as there are no differences between those boards in this respect.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20151006-v4.3-rc4' tag of Simon Horman's 'renesas.git' repo.

Quoted 7 lines
Quoted 5 lines

Thanks I have queued this up after addressing some issues in the changelog that checkpatch complained about:

* text > 75 characters wide
* Missing '"' around name of patch referred to

Sorry about that, forgot to run thru checkpatch.pl (as usual :-).

No harm done.