Skip to contentSkip to conversation

ARM: s3c24xx: fix build error

PATCH New Linus Walleij 2 participants 2 messages Jan 7, 2014

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Linus Walleij

author
#0 lore raw

PATCH 1/1 ARM: s3c24xx: fix build error

When enabling device tree on the S3C an additional build bug appears in the Osiris DVS board file:

CC arch/arm/mach-s3c24xx/mach-osiris-dvs.o archh/arm/mach-s3c24xx/mach-osiris-dvs.c:
In function ?osiris_dvs_notify?:
arch/arm/mach-s3c24xx/mach-osiris-dvs.c:77:4:
error: implicit declaration of function ?S3C2410_GPB? [-Werror=implicit-function-declaration]

    gpio_set_value(OSIRIS_GPIO_DVS, 1);
    ^

Fix this by explicitly including
<linux/platform_data/gpio-samsung-s3c24xx.h>

Reported-by Arnd Bergmann <[email protected]>
Cc Kukjin Kim <[email protected]>
Cc Heiko Stuebner <[email protected]>
Cc Tomasz Figa <[email protected]>
Cc Sylwester Nawrocki <[email protected]>
Cc Ben Dooks <[email protected]>
Cc linux-samsung-soc at vger.kernel.org
Signed-off-by Linus Walleij <[email protected]>

---
I have tentatively applied this to the GPIO tree so I don't cause build regressions, ACKs are still appreciated from the S3C maintainers.

---
 arch/arm/mach-s3c24xx/mach-osiris-dvs.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-s3c24xx/mach-osiris-dvs.c +1 -0
index 45e74363aaa9..5b8af46c0d6b 100644
@@ -16,6 +16,7 @@
 #include <linux/platform_device.h>
 #include <linux/cpufreq.h>
 #include <linux/gpio.h>
+#include <linux/platform_data/gpio-samsung-s3c24xx.h>
 
 #include <linux/i2c/tps65010.h>
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 1/1 ARM: s3c24xx: fix build error

Am Dienstag, 7. Januar 2014, 19:27:25 schrieb Linus Walleij:

Quoted 23 lines

When enabling device tree on the S3C an additional build bug appears in the Osiris DVS board file:

CC arch/arm/mach-s3c24xx/mach-osiris-dvs.o archh/arm/mach-s3c24xx/mach-osiris-dvs.c:
In function ?osiris_dvs_notify?:
arch/arm/mach-s3c24xx/mach-osiris-dvs.c:77:4:
error: implicit declaration of function ?S3C2410_GPB? [-Werror=implicit-function-declaration]

    gpio_set_value(OSIRIS_GPIO_DVS, 1);
    ^

Fix this by explicitly including
<linux/platform_data/gpio-samsung-s3c24xx.h>

Reported-by Arnd Bergmann <[email protected]>
Cc Kukjin Kim <[email protected]>
Cc Heiko Stuebner <[email protected]>
Cc Tomasz Figa <[email protected]>
Cc Sylwester Nawrocki <[email protected]>
Cc Ben Dooks <[email protected]>
Cc linux-samsung-soc at vger.kernel.org
Signed-off-by Linus Walleij <[email protected]>
Quoted 4 lines

---
I have tentatively applied this to the GPIO tree so I don't cause build regressions, ACKs are still appreciated from the S3C maintainers.

Acked-by Heiko Stuebner <[email protected]>