Skip to contentSkip to conversation

net: emaclite: include linux/of_irq.h

PATCH In review Arnd Bergmann 2 participants 4 messages Jun 3, 2013 – Jun 4, 2013

Subsystems (3)
Networking Network drivers Arm/Zynq architecture
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 net: emaclite: include linux/of_irq.h

The emaclite driver now calls of_irq_to_resource, which is declared in linux/of_irq.h. Without this patch, I get a build error on ARM.

Signed-off-by Arnd Bergmann <[email protected]>
Cc Michal Simek <[email protected]>
drivers/net/ethernet/xilinx/xilinx_emaclite.c +1 -0
index aa14d8a..9559a3d 100644
@@ -22,6 +22,7 @@
 #include <linux/slab.h>
 #include <linux/of_address.h>
 #include <linux/of_device.h>
+#include <linux/of_irq.h>
 #include <linux/of_platform.h>
 #include <linux/of_mdio.h>
 #include <linux/of_net.h>
#1 lore raw
Quoted 3 lines · Arnd Bergmann

The emaclite driver now calls of_irq_to_resource, which is declared in linux/of_irq.h. Without this patch, I get a build error on ARM.

What about to just change it to use platform_get_resource()? I will test it.

Thanks,
Michal

Signature · 5 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
author
#2 lore raw
Quoted 7 lines · On Tuesday 04 June 2013 10:21:01 Michal Simek wrote:
Quoted 3 lines · Arnd Bergmann

The emaclite driver now calls of_irq_to_resource, which is declared in linux/of_irq.h. Without this patch, I get a build error on ARM.

What about to just change it to use platform_get_resource()? I will test it.

Yes, that would work too. It seems the driver predates the automatic generation of resources for IRQs and MMIO registers.

If you change the IRQ resource to platform_get_resource, you should change the other one as well.

Arnd

#3 lore raw
Quoted 6 lines · Arnd Bergmann
Quoted 5 lines · On Tuesday 04 June 2013 10:21:01 Michal Simek wrote:
Quoted 3 lines · Arnd Bergmann

The emaclite driver now calls of_irq_to_resource, which is declared in linux/of_irq.h. Without this patch, I get a build error on ARM.

Quoted 8 lines
Quoted 2 lines

What about to just change it to use platform_get_resource()? I will test it.

Yes, that would work too. It seems the driver predates the automatic generation of resources for IRQs and MMIO registers.

If you change the IRQ resource to platform_get_resource, you should change the other one as well.

Yep. I have done that changes. Let me test them on real hw and I will send them soon.

Thanks,
Michal

Signature · 5 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform