Skip to contentSkip to conversation

eal/ppc: add missing header inclusion

PATCH In review David Marchand 3 participants 5 messages Apr 17, 2020 – Apr 19, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eal/ppc: add missing header inclusion

Compilation is broken on ppc:

CC otx2_rx.o
In file included from .../drivers/net/octeontx2/otx2_rx.c:5:0:
.../builds/ppc_64-power8-linux-gcc/include/rte_vect.h:29:17:
error: expected declaration specifiers or ‘...’ before numeric constant

 } __rte_aligned(16) rte_xmm_t;
                 ^~

compilation terminated due to -Wfatal-errors.

Fixes f35e5b3e07b2 ("replace alignment attributes")
---
 lib/librte_eal/ppc/include/rte_vect.h | 2 ++
 1 file changed, 2 insertions(+)
lib/librte_eal/ppc/include/rte_vect.h +2 -0
index a0dabf02eb..1d6c29be02 100644
@@ -7,7 +7,9 @@
 #define _RTE_VECT_PPC_64_H_
 
 #include <altivec.h>
+
 #include "generic/rte_vect.h"
+#include "rte_common.h"
 
 #ifdef __cplusplus
 extern "C" {
Signature · 1 line
2.23.0
Tested-by on v1 1/1
#1 lore raw

17/04/2020 17:25, David Marchand:

Quoted 6 lines

Compilation is broken on ppc:

CC otx2_rx.o
In file included from .../drivers/net/octeontx2/otx2_rx.c:5:0:
.../builds/ppc_64-power8-linux-gcc/include/rte_vect.h:29:17:
error: expected declaration specifiers or ‘...’ before numeric constant

Quoted 7 lines
 } __rte_aligned(16) rte_xmm_t;
                 ^~

compilation terminated due to -Wfatal-errors.

Fixes f35e5b3e07b2 ("replace alignment attributes")

Sorry for not having tested PPC.

About the title:
eal/ppc: fix missing include
or
eal/ppc: fix build
?

author Applied
#2 lore raw
Quoted 18 lines · Thomas Monjalon

17/04/2020 17:25, David Marchand:

Quoted 6 lines

Compilation is broken on ppc:

CC otx2_rx.o
In file included from .../drivers/net/octeontx2/otx2_rx.c:5:0:
.../builds/ppc_64-power8-linux-gcc/include/rte_vect.h:29:17:
error: expected declaration specifiers or ‘...’ before numeric constant

Quoted 7 lines
 } __rte_aligned(16) rte_xmm_t;
                 ^~

compilation terminated due to -Wfatal-errors.

Fixes f35e5b3e07b2 ("replace alignment attributes")

Sorry for not having tested PPC.

Quoted 7 lines

About the title:
eal/ppc: fix missing include
or
eal/ppc: fix build
?

Applied.

Signature · 1 line
David Marchand
#4 lore raw
Quoted 4 lines · David Christensen
Quoted 2 lines

Compilation is broken on ppc:

What commit ID were you testing that failed to build? This must be a recent change as I'm not seeing it on my system.

The failure was seen at b11ecebc0.

Signature · 1 line
David Marchand