Skip to contentSkip to conversation

staging: iio: select IRQ_WORK for IIO_DUMMY_EVGEN

PATCH Applied Arnd Bergmann 3 participants 3 messages Oct 16, 2015 – Oct 25, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: iio: select IRQ_WORK for IIO_DUMMY_EVGEN

The iio dummy code was recently changed to use irq_work_queue, but that code is compiled into the kernel only if IRQ_WORK is set, so we can get a link error here:

drivers/built-in.o: In function `iio_evgen_poke':
(.text+0x208a04): undefined reference to `irq_work_queue'

This changes the Kconfig file to match what other drivers do.

Fixes fd2bb310ca3d ("Staging: iio: Move evgen interrupt generation to irq_work")

---
Found on ARM randconfig tests

drivers/staging/iio/Kconfig +2 -1
index 6d5b38d69578..9d7f0004d2d7 100644
@@ -18,7 +18,8 @@ source "drivers/staging/iio/resolver/Kconfig"
 source "drivers/staging/iio/trigger/Kconfig"
 
 config IIO_DUMMY_EVGEN
-       tristate
+	tristate
+	select IRQ_WORK
 
 config IIO_SIMPLE_DUMMY
        tristate "An example driver with no hardware requirements"
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Arnd Bergmann

The iio dummy code was recently changed to use irq_work_queue, but that code is compiled into the kernel only if IRQ_WORK is set, so we can get a link error here:

drivers/built-in.o: In function `iio_evgen_poke':
(.text+0x208a04): undefined reference to `irq_work_queue'

This changes the Kconfig file to match what other drivers do.

Fixes fd2bb310ca3d ("Staging: iio: Move evgen interrupt generation to irq_work")
Quoted 19 lines

---
Found on ARM randconfig tests

drivers/staging/iio/Kconfig +2 -2
index 6d5b38d69578..9d7f0004d2d7 100644
@@ -18,7 +18,8 @@ source "drivers/staging/iio/resolver/Kconfig"
 source "drivers/staging/iio/trigger/Kconfig"
 
 config IIO_DUMMY_EVGEN
-       tristate
+       tristate
+       select IRQ_WORK
 
 config IIO_SIMPLE_DUMMY
        tristate "An example driver with no hardware requirements"
 
--
maintainer Applied
#2 lore raw
Quoted 8 lines · Daniel Baluta
Quoted 7 lines · Arnd Bergmann

The iio dummy code was recently changed to use irq_work_queue, but that code is compiled into the kernel only if IRQ_WORK is set, so we can get a link error here:

drivers/built-in.o: In function `iio_evgen_poke':
(.text+0x208a04): undefined reference to `irq_work_queue'

Quoted 6 lines
Quoted 4 lines

This changes the Kconfig file to match what other drivers do.

Fixes fd2bb310ca3d ("Staging: iio: Move evgen interrupt generation to irq_work")

Applied to the fixes-togreg branch of iio.git. I fear this won't get to Linus until just after the release occurs. Unfortunate timing.

Jonathan

Quoted 25 lines
Quoted 10 lines

---
Found on ARM randconfig tests

drivers/staging/iio/Kconfig +0 -0
index 6d5b38d69578..9d7f0004d2d7 100644
@@ -18,7 +18,8 @@ source "drivers/staging/iio/resolver/Kconfig"
 source "drivers/staging/iio/trigger/Kconfig"

drivers/staging/iio/Kconfig source "drivers/staging/iio/resolver/Kconfig"

Quoted 10 lines
drivers/staging/iio/Kconfig +2 -2
 
 config IIO_DUMMY_EVGEN
-       tristate
+       tristate
+       select IRQ_WORK
 
 config IIO_SIMPLE_DUMMY
        tristate "An example driver with no hardware requirements"
 
--

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html