test/bbdev: fix build issues with optional build flag
v3 cover test/bbdev: fix build issues with optional build flag
v3: add more Fixes tag for missing error check commit
v2: add check in offload test function for error during allocation suggested by Maxime.
Fixing compilation errors in bbdev-test application on rc4 when the optional flag RTE_BBDEV_OFFLOAD_COST is set manually. This was raised by Vipin.
Nicolas Chautru (3):
test/bbdev: fix build issue with optional build flag test/bbdev: fix build issue with optional build flag test/bbdev: explicit check for allocation failure
app/test-bbdev/test_bbdev_perf.c | 93 ++++++++++++++++++++++++++++++-- 1 file changed, 89 insertions(+), 4 deletions(-)
Signature · 1 line
2.37.1
PATCH v3 1/3 test/bbdev: fix build issue with optional build flag
Incorrect bbdev member name used in test code under RTE_BBDEV_OFFLOAD_COST build flag.
--- app/test-bbdev/test_bbdev_perf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
app/test-bbdev/test_bbdev_perf.c +2 -2
@@ -4933,8 +4933,8 @@ get_bbdev_queue_stats(uint16_t dev_id, uint16_t queue_id, stats->dequeued_count = q_stats->dequeued_count; stats->enqueue_err_count = q_stats->enqueue_err_count; stats->dequeue_err_count = q_stats->dequeue_err_count; - stats->enqueue_warning_count = q_stats->enqueue_warning_count; - stats->dequeue_warning_count = q_stats->dequeue_warning_count; + stats->enqueue_warn_count = q_stats->enqueue_warn_count; + stats->dequeue_warn_count = q_stats->dequeue_warn_count; stats->acc_offload_cycles = q_stats->acc_offload_cycles;return 0 ;
Signature · 1 line
2.37.1
Re: [PATCH v3 1/3] test/bbdev: fix build issue with optional build flag
Hi Nicolas,
Quoted 7 lines · Nicolas Chautru
Incorrect bbdev member name used in test code under
RTE_BBDEV_OFFLOAD_COSTbuild flag.Fixes 4f08028c5e24 ("bbdev: expose queue related warning and status")Signed-off-by Nicolas Chautru <[email protected]>
Next time, please amend the R-by from previous revision when no (significant) changes are done to the patch.
Thanks,
Maxime
Quoted 19 lines
--- app/test-bbdev/test_bbdev_perf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)app/test-bbdev/test_bbdev_perf.c +2
-2@@ -4933,8 +4933,8 @@ get_bbdev_queue_stats(uint16_t dev_id, uint16_t queue_id, stats->dequeued_count = q_stats->dequeued_count; stats->enqueue_err_count = q_stats->enqueue_err_count; stats->dequeue_err_count = q_stats->dequeue_err_count; - stats->enqueue_warning_count = q_stats->enqueue_warning_count; - stats->dequeue_warning_count = q_stats->dequeue_warning_count; + stats->enqueue_warn_count = q_stats->enqueue_warn_count; + stats->dequeue_warn_count = q_stats->dequeue_warn_count; stats->acc_offload_cycles = q_stats->acc_offload_cycles;return 0 ;
PATCH v3 2/3 test/bbdev: fix build issue with optional build flag
In reply to Nicolas ChautruMissing implementation for offload test with FFT. Only build when the optional build flag RTE_BBDEV_OFFLOAD_COST is set.
--- app/test-bbdev/test_bbdev_perf.c | 82 ++++++++++++++++++++++++++++++++ 1 file changed, 82 insertions(+)
app/test-bbdev/test_bbdev_perf.c +82 -0
@@ -4940,6 +4940,88 @@ get_bbdev_queue_stats(uint16_t dev_id, uint16_t queue_id,return 0 ; } +static int +offload_latency_test_fft (struct rte_mempool *mempool,struct test_buffers *bufs, +struct rte_bbdev_fft_op *ref_op,uint16_t dev_id, +uint16_t queue_id,const uint16_t num_to_process, +uint16_t burst_sz,struct test_time_stats *time_st) +{ +int i, dequeued, ret; +struct rte_bbdev_fft_op *ops_enq[MAX_BURST ], *ops_deq[MAX_BURST ]; +uint64_t enq_start_time, deq_start_time; +uint64_t enq_sw_last_time, deq_last_time; +struct rte_bbdev_stats stats; + +for (i =0 , dequeued =0 ; dequeued < num_to_process; ++i) { +uint16_t enq =0 , deq =0 ; + +if (unlikely (num_to_process - dequeued < burst_sz)) + burst_sz = num_to_process - dequeued; + +rte_bbdev_fft_op_alloc_bulk (mempool, ops_enq, burst_sz); +if (test_vector.op_type !=RTE_BBDEV_OP_NONE ) +copy_reference_fft_op (ops_enq, burst_sz, dequeued, + bufs->inputs, + bufs->hard_outputs, bufs->soft_outputs, + ref_op); + +/* Start time meas for enqueue function offload latency */ + enq_start_time =rte_rdtsc_precise (); +do { + enq +=rte_bbdev_enqueue_fft_ops (dev_id, queue_id, + &ops_enq[enq], burst_sz - enq); + }while (unlikely (burst_sz != enq)); + + ret =get_bbdev_queue_stats (dev_id, queue_id, &stats); +TEST_ASSERT_SUCCESS (ret, +"Failed to get stats for queue (%u) of device (%u)" , + queue_id, dev_id); + + enq_sw_last_time =rte_rdtsc_precise () - enq_start_time - + stats.acc_offload_cycles; + time_st->enq_sw_max_time =RTE_MAX (time_st->enq_sw_max_time, + enq_sw_last_time); + time_st->enq_sw_min_time =RTE_MIN (time_st->enq_sw_min_time, + enq_sw_last_time); + time_st->enq_sw_total_time += enq_sw_last_time; + + time_st->enq_acc_max_time =RTE_MAX (time_st->enq_acc_max_time, + stats.acc_offload_cycles); + time_st->enq_acc_min_time =RTE_MIN (time_st->enq_acc_min_time, + stats.acc_offload_cycles); + time_st->enq_acc_total_time += stats.acc_offload_cycles; + +/* give time for device to process ops */ +rte_delay_us (WAIT_OFFLOAD_US ); + +/* Start time meas for dequeue function offload latency */ + deq_start_time =rte_rdtsc_precise (); +/* Dequeue one operation */ +do { + deq +=rte_bbdev_dequeue_fft_ops (dev_id, queue_id, + &ops_deq[deq], enq); + }while (unlikely (deq ==0 )); + + deq_last_time =rte_rdtsc_precise () - deq_start_time; + time_st->deq_max_time =RTE_MAX (time_st->deq_max_time, + deq_last_time); + time_st->deq_min_time =RTE_MIN (time_st->deq_min_time, + deq_last_time); + time_st->deq_total_time += deq_last_time; + +/* Dequeue remaining operations if needed*/ +while (burst_sz != deq) + deq +=rte_bbdev_dequeue_fft_ops (dev_id, queue_id, + &ops_deq[deq], burst_sz - deq); + +rte_bbdev_fft_op_free_bulk (ops_enq, deq); + dequeued += deq; + } + +return i; +} + + static int offload_latency_test_dec(struct rte_mempool *mempool, struct test_buffers *bufs, struct rte_bbdev_dec_op *ref_op, uint16_t dev_id,
Signature · 1 line
2.37.1
Re: [PATCH v3 2/3] test/bbdev: fix build issue with optional build flag
Quoted 4 lines · Nicolas Chautru
Missing implementation for offload test with FFT. Only build when the optional build flag
RTE_BBDEV_OFFLOAD_COSTis set.
Quoted 8 lines
Fixes 0acdb9866756 ("test/bbdev: add FFT operations cases")Signed-off-by Nicolas Chautru <[email protected]>--- app/test-bbdev/test_bbdev_perf.c | 82 ++++++++++++++++++++++++++++++++ 1 file changed, 82 insertions(+)
Thanks,
Maxime
PATCH v3 3/3 test/bbdev: explicit check for allocation failure
In reply to Nicolas ChautruAdding check for error on return of the
rte_bbdev_*_op_alloc_bulk calls in bbdev-test.
--- app/test-bbdev/test_bbdev_perf.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
app/test-bbdev/test_bbdev_perf.c +6 -3
@@ -4958,7 +4958,8 @@ offload_latency_test_fft(struct rte_mempool *mempool, struct test_buffers *bufs,if (unlikely (num_to_process - dequeued < burst_sz)) burst_sz = num_to_process - dequeued; -rte_bbdev_fft_op_alloc_bulk (mempool, ops_enq, burst_sz); + ret =rte_bbdev_fft_op_alloc_bulk (mempool, ops_enq, burst_sz); +TEST_ASSERT_SUCCESS (ret,"Allocation failed for %d ops" , ops_enq);if (test_vector.op_type !=RTE_BBDEV_OP_NONE ) copy_reference_fft_op(ops_enq, burst_sz, dequeued, bufs->inputs,
@@ -5040,7 +5041,8 @@ offload_latency_test_dec(struct rte_mempool *mempool, struct test_buffers *bufs,if (unlikely (num_to_process - dequeued < burst_sz)) burst_sz = num_to_process - dequeued; -rte_bbdev_dec_op_alloc_bulk (mempool, ops_enq, burst_sz); + ret =rte_bbdev_dec_op_alloc_bulk (mempool, ops_enq, burst_sz); +TEST_ASSERT_SUCCESS (ret,"Allocation failed for %d ops" , ops_enq);if (test_vector.op_type !=RTE_BBDEV_OP_NONE ) copy_reference_dec_op(ops_enq, burst_sz, dequeued, bufs->inputs,
@@ -5125,7 +5127,8 @@ offload_latency_test_ldpc_dec(struct rte_mempool *mempool,if (unlikely (num_to_process - dequeued < burst_sz)) burst_sz = num_to_process - dequeued; -rte_bbdev_dec_op_alloc_bulk (mempool, ops_enq, burst_sz); + ret =rte_bbdev_dec_op_alloc_bulk (mempool, ops_enq, burst_sz); +TEST_ASSERT_SUCCESS (ret,"Allocation failed for %d ops" , ops_enq);if (test_vector.op_type !=RTE_BBDEV_OP_NONE ) copy_reference_ldpc_dec_op(ops_enq, burst_sz, dequeued, bufs->inputs,
Signature · 1 line
2.37.1
Re: [PATCH v3 3/3] test/bbdev: explicit check for allocation failure
Quoted 11 lines · Nicolas Chautru
Adding check for error on return of the
rte_bbdev_*_op_alloc_bulk calls in bbdev-test.Fixes f714a18885a6 ("app/testbbdev: add test application for bbdev")Signed-off-by Nicolas Chautru <[email protected]>--- app/test-bbdev/test_bbdev_perf.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
Thanks,
Maxime
Maxime Coquelin
AppliedQuoted 7 lines · Nicolas Chautru
v3: add more Fixes tag for missing error check commit
v2: add check in offload test function for error during allocation suggested by Maxime.
Fixing compilation errors in bbdev-test application on rc4 when the optional flagRTE_BBDEV_OFFLOAD_COSTis set manually. This was raised by Vipin.
Quoted 8 lines
Nicolas Chautru (3):
test/bbdev: fix build issue with optional build flag test/bbdev: fix build issue with optional build flag test/bbdev: explicit check for allocation failureapp/test-bbdev/test_bbdev_perf.c | 93 ++++++++++++++++++++++++++++++-- 1 file changed, 89 insertions(+), 4 deletions(-)
Applied to dpdk-next-baseband/for-main.
Thanks,
Maxime