xen/balloon: Fix mapping PG_offline pages to user space
Subsystems (2)
PATCH 1/1 xen/balloon: Fix mapping PG_offline pages to user space
The XEN balloon driver - in contrast to other balloon drivers - allows to map some inflated pages to user space. Such pages are allocated via alloc_xenballooned_pages() and freed via free_xenballooned_pages(). The pfn space of these allocated pages is used to map other things by the hypervisor using hypercalls.
Pages marked with PG_offline must never be mapped to user space (as this page type uses the mapcount field of struct pages).
So what we can do is, clear/set PG_offline when allocating/freeing an inflated pages. This way, most inflated pages can be excluded by dumping tools and the "reused for other purpose" balloon pages are correctly not marked as PG_offline.
--- drivers/xen/balloon.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/xen/balloon.c +2 -0
@@ -604,6 +604,7 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages)while (pgno < nr_pages) { page =balloon_retrieve (true);if (page) { +__ClearPageOffline (page); pages[pgno++] = page;#ifdef CONFIG_XEN_HAVE_PVMMU /*
@@ -646,6 +647,7 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)for (i =0 ; i < nr_pages; i++) {if (pages[i]) +__SetPageOffline (pages[i]);balloon_append (pages[i]); }
Signature · 1 line
2.17.2
drivers/xen/balloon.c void free_xenballooned_pages(int nr_pages, struct page **pages) · line 651
Quoted 6 lines · David Hildenbrand
drivers/xen/balloon.c +1
-0@@ -646,6 +647,7 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)for (i =0 ; i < nr_pages; i++) {if (pages[i]) +__SetPageOffline (pages[i]);balloon_append (pages[i]);
didn't you forget {} there? ;-)
Quoted 5 lines
(quoted diff) +0
-0}Signature · 1 line
2.17.2
Signature · 2 lines
Oscar Salvador SUSE L3
Quoted 10 lines · Oscar Salvador
drivers/xen/balloon.c void free_xenballooned_pages(int nr_pages, struct page **pages) · line 651
Quoted 6 lines · David Hildenbrand
drivers/xen/balloon.c +1
-0@@ -646,6 +647,7 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)for (i =0 ; i < nr_pages; i++) {if (pages[i]) +__SetPageOffline (pages[i]);balloon_append (pages[i]);didn't you forget {} there? ;-)
That's what happens when you stashed the original patch and try to recreate it quickly from a mail ;)
Thanks!
Signature · 8 lines
Thanks, David / dhildenb _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 10 lines · Oscar Salvador
drivers/xen/balloon.c void free_xenballooned_pages(int nr_pages, struct page **pages) · line 651
Quoted 6 lines · David Hildenbrand
drivers/xen/balloon.c +1
-0@@ -646,6 +647,7 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)for (i =0 ; i < nr_pages; i++) {if (pages[i]) +__SetPageOffline (pages[i]);balloon_append (pages[i]);didn't you forget {} there? ;-)
That's what happens when you stashed the original patch and try to recreate it quickly from a mail ;)
Thanks!
Signature · 3 lines
Thanks, David / dhildenb
drivers/xen/balloon.c void free_xenballooned_pages(int nr_pages, struct page **pages) · line 651
Quoted 6 lines · David Hildenbrand
drivers/xen/balloon.c +1
-0@@ -646,6 +647,7 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)for (i =0 ; i < nr_pages; i++) {if (pages[i]) +__SetPageOffline (pages[i]);balloon_append (pages[i]);
didn't you forget {} there? ;-)
Quoted 5 lines
(quoted diff) +0
-0}Signature · 1 line
2.17.2
Signature · 7 lines
Oscar Salvador SUSE L3 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
drivers/xen/balloon.c int alloc_xenballooned_pages(int nr_pages, struct page **pages) · line 608
Quoted 9 lines
Quoted 1 line
Quoted 1 line · On 14.03.19 at 16:40, <[email protected]> wrote:
drivers/xen/balloon.c +1
-0@@ -604,6 +604,7 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages)while (pgno < nr_pages) { page =balloon_retrieve (true);if (page) { +__ClearPageOffline (page); pages[pgno++] = page;
While this one's fine, ...
drivers/xen/balloon.c void free_xenballooned_pages(int nr_pages, struct page **pages) · line 652
Quoted 7 lines
drivers/xen/balloon.c +1
-0@@ -646,6 +647,7 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)for (i =0 ; i < nr_pages; i++) {if (pages[i]) +__SetPageOffline (pages[i]);balloon_append (pages[i]); }
... I think you want to add a pair of braces here.
Jan
Quoted 22 lines · Jan Beulich
drivers/xen/balloon.c int alloc_xenballooned_pages(int nr_pages, struct page **pages) · line 608
Quoted 9 lines
Quoted 1 line
Quoted 1 line · On 14.03.19 at 16:40, <[email protected]> wrote:
drivers/xen/balloon.c +1
-0@@ -604,6 +604,7 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages)while (pgno < nr_pages) { page =balloon_retrieve (true);if (page) { +__ClearPageOffline (page); pages[pgno++] = page;While this one's fine, ...
drivers/xen/balloon.c void free_xenballooned_pages(int nr_pages, struct page **pages) · line 652
Quoted 7 lines
drivers/xen/balloon.c +1
-0@@ -646,6 +647,7 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)for (i =0 ; i < nr_pages; i++) {if (pages[i]) +__SetPageOffline (pages[i]);balloon_append (pages[i]); }... I think you want to add a pair of braces here.
Quoted 3 lines
Jan
Indeed, dropped by accident. Will resend in a minute. Thanks!
Signature · 8 lines
Thanks, David / dhildenb _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 22 lines · Jan Beulich
drivers/xen/balloon.c int alloc_xenballooned_pages(int nr_pages, struct page **pages) · line 608
Quoted 9 lines
Quoted 1 line
Quoted 1 line · On 14.03.19 at 16:40, <[email protected]> wrote:
drivers/xen/balloon.c +1
-0@@ -604,6 +604,7 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages)while (pgno < nr_pages) { page =balloon_retrieve (true);if (page) { +__ClearPageOffline (page); pages[pgno++] = page;While this one's fine, ...
drivers/xen/balloon.c void free_xenballooned_pages(int nr_pages, struct page **pages) · line 652
Quoted 7 lines
drivers/xen/balloon.c +1
-0@@ -646,6 +647,7 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)for (i =0 ; i < nr_pages; i++) {if (pages[i]) +__SetPageOffline (pages[i]);balloon_append (pages[i]); }... I think you want to add a pair of braces here.
Quoted 3 lines
Jan
Indeed, dropped by accident. Will resend in a minute. Thanks!
Signature · 3 lines
Thanks, David / dhildenb
drivers/xen/balloon.c int alloc_xenballooned_pages(int nr_pages, struct page **pages) · line 608
Quoted 9 lines
Quoted 1 line
Quoted 1 line · On 14.03.19 at 16:40, <[email protected]> wrote:
drivers/xen/balloon.c +1
-0@@ -604,6 +604,7 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages)while (pgno < nr_pages) { page =balloon_retrieve (true);if (page) { +__ClearPageOffline (page); pages[pgno++] = page;
While this one's fine, ...
drivers/xen/balloon.c void free_xenballooned_pages(int nr_pages, struct page **pages) · line 652
Quoted 7 lines
drivers/xen/balloon.c +1
-0@@ -646,6 +647,7 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)for (i =0 ; i < nr_pages; i++) {if (pages[i]) +__SetPageOffline (pages[i]);balloon_append (pages[i]); }
... I think you want to add a pair of braces here.
Jan
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel