Skip to contentSkip to conversation

devtool: warn user about multiple layer having the same base name

PATCH Peter Kjellerstedt 2 participants 2 messages Jun 28, 2019 – Jun 30, 2019

lore
Share & tools
lore
#0 lore raw

I had not realized the layer name in the devtool finish command supports abbreviations/patterns (whichever it is). My expectation from running devtool finish foo meta would be to update the foo recipe in the meta layer, not that it should go looking for every layer called meta-something.

How useful is that support compared to be able to specify the exact layer name? Normally in this situation, I would typically expect to use an extra option, e.g., --abbrev or --regexp, to enable support for using loose matching.

//Peter

#1 lore raw

Hi Peter,

Quoted 4 lines · NZST Peter Kjellerstedt

I had not realized the layer name in the devtool finish command supports abbreviations/patterns (whichever it is). My expectation from running devtool finish foo meta would be to update the foo recipe in the meta layer, not that it should go looking for every layer called meta-something.

That's not how it works. The logic is here:

https://git.openembedded.org/openembedded-core/tree/scripts/lib/devtool/standard.py#n1866

We only have the subdirectory the layer is in to use to determine what the name of the layer is, if you only specify the name. The only shortcuts in this function are "oe-core" and "openembedded-core" map to "meta". The case this patch is attempting to handle is where you have more than one layer in your configuration where the subdirectory in which the layer appears is called "meta". (People should generally avoid this and put the layer in a subdirectory whose name matches the name of the layer, but of course people can do whatever they want.)

Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre