Skip to contentSkip to conversation

mm: Fix two spelling mistakes in highmem.h

PATCH Applied Fabio M. De Francesco 2 participants 3 messages Jan 5, 2023 – Jan 9, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: Fix two spelling mistakes in highmem.h

Substitute two occurrencies of "higmem" with "highmem" in highmem.h.

---
 include/linux/highmem.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/highmem.h +2 -2
index 7b0085a61e67..ae1670ccdf45 100644
@@ -86,7 +86,7 @@ static inline void kmap_flush_unused(void);
  * virtual address of the direct mapping. Only real highmem pages are
  * temporarily mapped.
  *
- * While it is significantly faster than kmap() for the higmem case it
+ * While it is significantly faster than kmap() for the highmem case it
  * comes with restrictions about the pointer validity.
  *
  * On HIGHMEM enabled systems mapping a highmem page has the side effect of
@@ -119,7 +119,7 @@ static inline void *kmap_local_page(struct page *page);
  * virtual address of the direct mapping. Only real highmem pages are
  * temporarily mapped.
  *
- * While it is significantly faster than kmap() for the higmem case it
+ * While it is significantly faster than kmap() for the highmem case it
  * comes with restrictions about the pointer validity.
  *
  * On HIGHMEM enabled systems mapping a highmem page has the side effect of
Signature · 1 line
2.39.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line · Fabio M. De Francesco

Substitute two occurrencies of "higmem" with "highmem" in highmem.h.

The change looks fine but for Andrew's benefit I believe this patch is based on the other one you submitted to fix kmap_local_folio()?[1] Is that correct?

[1] https://lore.kernel.org/all/[email protected]/

With that note:

Quoted 33 lines
---
 include/linux/highmem.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/highmem.h +2 -2
index 7b0085a61e67..ae1670ccdf45 100644
@@ -86,7 +86,7 @@ static inline void kmap_flush_unused(void);
  * virtual address of the direct mapping. Only real highmem pages are
  * temporarily mapped.
  *
- * While it is significantly faster than kmap() for the higmem case it
+ * While it is significantly faster than kmap() for the highmem case it
  * comes with restrictions about the pointer validity.
  *
  * On HIGHMEM enabled systems mapping a highmem page has the side effect of
@@ -119,7 +119,7 @@ static inline void *kmap_local_page(struct page *page);
  * virtual address of the direct mapping. Only real highmem pages are
  * temporarily mapped.
  *
- * While it is significantly faster than kmap() for the higmem case it
+ * While it is significantly faster than kmap() for the highmem case it
  * comes with restrictions about the pointer validity.
  *
  * On HIGHMEM enabled systems mapping a highmem page has the side effect of
Signature · 1 line
2.39.0
#2 lore raw
Quoted 6 lines · On giovedì 5 gennaio 2023 18:02:30 CET Ira Weiny wrote:
Quoted 1 line · Fabio M. De Francesco

Substitute two occurrences of "higmem" with "highmem" in highmem.h.

The change looks fine but for Andrew's benefit I believe this patch is based on the other one you submitted to fix kmap_local_folio()?[1] Is that correct?

Yes, it is.
I had completely forgotten that previous patch. Thanks for noticing it and for providing its link to Andrew.

Fabio

Quoted 25 lines

[1]
https://lore.kernel.org/all/[email protected]/

With that note:

Quoted 17 lines

---

 include/linux/highmem.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/highmem.h +0 -0
index 7b0085a61e67..ae1670ccdf45 100644
@@ -86,7 +86,7 @@ static inline void kmap_flush_unused(void);
 
  * virtual address of the direct mapping. Only real highmem pages are
  * temporarily mapped.
  *
 
Quoted 6 lines
Quoted 6 lines
include/linux/highmem.h +1 -1
- * While it is significantly faster than kmap() for the higmem case it
+ * While it is significantly faster than kmap() for the highmem case it
 

* comes with restrictions about the pointer validity.
*
* On HIGHMEM enabled systems mapping a highmem page has the side effect

of

Quoted 2 lines

include/linux/highmem.h static inline void *kmap_local_page(struct page

Quoted 2 lines
include/linux/highmem.h +0 -0
@@ -119,7 +119,7 @@ static inline void *kmap_local_page(struct page 

*page);

Quoted 11 lines
Quoted 11 lines
include/linux/highmem.h +1 -1
  * virtual address of the direct mapping. Only real highmem pages are
  * temporarily mapped.
  *
 
- * While it is significantly faster than kmap() for the higmem case it
+ * While it is significantly faster than kmap() for the highmem case it
 
  * comes with restrictions about the pointer validity.

*
* On HIGHMEM enabled systems mapping a highmem page has the side effect

of

Quoted 3 lines
Quoted 3 lines

--
2.39.0