mm: huge_memory: Replace obsolete memalign() with posix_memalign()
Subsystems (4)
PATCH 1/1 mm: huge_memory: Replace obsolete memalign() with posix_memalign()
memalign() is obsolete according to its manpage.
Replace memalign() with posix_memalign()
As a pointer is passed into posix_memalign(), initialize *one_page to NULL to silence a warning about the function's return value being used as uninitialized (which is not valid anyway because the error is properly checked before one_page is returned).
--- tools/testing/selftests/mm/split_huge_page_test.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
tools/testing/selftests/mm/split_huge_page_test.c +3 -3
@@ -96,10 +96,10 @@ void split_pmd_thp(void)char *one_page;size_t len =4 * pmd_pagesize;size_t i; +int ret; - one_page =memalign (pmd_pagesize, len); - -if (!one_page) { + ret =posix_memalign ((void **)&one_page, pmd_pagesize, len); +if (ret <0 ) {printf ("Fail to allocate memory\n" );exit (EXIT_FAILURE ); }
Signature · 1 line
2.27.0
Quoted 8 lines · Deming Wang
memalign()is obsolete according to its manpage.Replace
memalign()withposix_memalign()As a pointer is passed into
posix_memalign(), initialize*one_pageto NULL to silence a warning about the function's return value being used as uninitialized (which is not valid anyway because the error is properly checked beforeone_pageis returned).
^ I'm getting tired of pointing out the same thing.
Please collect similar patches and send them as a series; and stop copy-pasting the same thing into all of the similar patches you send.
Last but not least, tag you patches accordingly: "selftests/mm: split_huge_page_test: ..."
Quoted 24 lines
Signed-off-by Deming Wang <[email protected]>--- tools/testing/selftests/mm/split_huge_page_test.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)tools/testing/selftests/mm/split_huge_page_test.c +3
-3@@ -96,10 +96,10 @@ void split_pmd_thp(void)char *one_page;size_t len =4 * pmd_pagesize;size_t i; +int ret; - one_page =memalign (pmd_pagesize, len); - -if (!one_page) { + ret =posix_memalign ((void **)&one_page, pmd_pagesize, len); +if (ret <0 ) {printf ("Fail to allocate memory\n" );exit (EXIT_FAILURE ); }
Signature · 3 lines
Thanks, David / dhildenb