Skip to contentSkip to conversation

sixaxis: Differing device name between usb and bluetooth connection

RFC PATCH In review Nicolas Werner 3 participants 4 messages Feb 4, 2017 – Aug 23, 2017 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 sixaxis: Differing device name between usb and bluetooth connection

BlueZ sets the device name of Dual Shock 3 controller to "PLAYSTATION(R)3 Controller". When you connect the same controller via USB it is set to "Sony PLAYSTATION(R)3 Controller".

It seems that at least some games fail to recognize the controller as a Dual Shock 3/sixaxis controller and don't load the default mapping for PlayStation controllers, if the name doesn't contain the Sony part. Also I don't see a reason to use a different name, when connecting via Bluetooth.

I noticed this with "The Binding of Isaac: Rebirth" and it seems, that Steam also recognizes the controller better after the patch, although I'm not confident, if I can parse the controller configuration dialog correctly. I don't know, if this breaks anything, because it depends on the current name.

The attached patch changes the device name set when pairing to match the device name, when connected via USB.

Nicolas Werner

plugins/sixaxis.c +1 -1
@@ -56,7 +56,7 @@
        uint16_t version;
 } devices[] = {
        {
-               .name = "PLAYSTATION(R)3 Controller",
+               .name = "Sony PLAYSTATION(R)3 Controller",
                .source = 0x0002,
                .vid = 0x054c,
                .pid = 0x0268,
#1 lore raw

Am Samstag, 4. Februar 2017, 19:16:28 CEST schrieben Sie:

Quoted 23 lines

BlueZ sets the device name of Dual Shock 3 controller to "PLAYSTATION(R)3 Controller". When you connect the same controller via USB it is set to "Sony PLAYSTATION(R)3 Controller".

It seems that at least some games fail to recognize the controller as a Dual Shock 3/sixaxis controller and don't load the default mapping for PlayStation controllers, if the name doesn't contain the Sony part. Also I don't see a reason to use a different name, when connecting via Bluetooth.

I noticed this with "The Binding of Isaac: Rebirth" and it seems, that Steam also recognizes the controller better after the patch, although I'm not confident, if I can parse the controller configuration dialog correctly. I don't know, if this breaks anything, because it depends on the current name.

The attached patch changes the device name set when pairing to match the device name, when connected via USB.

Nicolas Werner

plugins/sixaxis.c line 62

Quoted 8 lines
plugins/sixaxis.c +1 -1
@@ -56,7 +56,7 @@
        uint16_t version;
 } devices[] = {
        {
-               .name = "PLAYSTATION(R)3 Controller",
+               .name = "Sony PLAYSTATION(R)3 Controller",
                .source = 0x0002,
                .vid = 0x054c,
                .pid = 0x0268,

It seems I'm not the only one with this issue as I recently found this issue
(https://bugzilla.kernel.org/show_bug.cgi?id=195225) in the kernel bug tracker. It looks like dual shock 4 controllers have a similar issue.

I asked on IRC and someone recommended to ping this message. Again, I would appreciate some comments on this issue and it would be great if this issue could be fixed.

Regards
Nicolas Werner

#2 lore raw

Hi Nicolas,

Quoted 37 lines · Nicolas Werner

Am Samstag, 4. Februar 2017, 19:16:28 CEST schrieben Sie:

Quoted 23 lines

BlueZ sets the device name of Dual Shock 3 controller to "PLAYSTATION(R)3 Controller". When you connect the same controller via USB it is set to "Sony PLAYSTATION(R)3 Controller".

It seems that at least some games fail to recognize the controller as a Dual Shock 3/sixaxis controller and don't load the default mapping for PlayStation controllers, if the name doesn't contain the Sony part. Also I don't see a reason to use a different name, when connecting via Bluetooth.

I noticed this with "The Binding of Isaac: Rebirth" and it seems, that Steam also recognizes the controller better after the patch, although I'm not confident, if I can parse the controller configuration dialog correctly. I don't know, if this breaks anything, because it depends on the current name.

The attached patch changes the device name set when pairing to match the device name, when connected via USB.

Nicolas Werner

plugins/sixaxis.c line 62

Quoted 8 lines
plugins/sixaxis.c +1 -1
@@ -56,7 +56,7 @@
        uint16_t version;
 } devices[] = {
        {
-               .name = "PLAYSTATION(R)3 Controller",
+               .name = "Sony PLAYSTATION(R)3 Controller",
                .source = 0x0002,
                .vid = 0x054c,
                .pid = 0x0268,

It seems I'm not the only one with this issue as I recently found this issue
(https://bugzilla.kernel.org/show_bug.cgi?id=195225) in the kernel bug tracker. It looks like dual shock 4 controllers have a similar issue.

Quoted 3 lines

I asked on IRC and someone recommended to ping this message. Again, I would appreciate some comments on this issue and it would be great if this issue could be fixed.

I'm not sure where I took original name from (probably this is how DS3 presents itself over BT).
Anyway, if this fix the problem I'm fine with changing the name (and patch looks OK). Could you send a proper patch created with 'git format-patch'?

As for DS4 this is a bit more trickier since that name is the name device use over BT and we would probably have to spoof it...

Signature · 2 lines
pozdrawiam
Szymon K. Janc
#3 lore raw
Quoted 60 lines · Szymon Janc

Hi Nicolas,

Quoted 50 lines · Nicolas Werner

Am Samstag, 4. Februar 2017, 19:16:28 CEST schrieben Sie:

Quoted 33 lines

BlueZ sets the device name of Dual Shock 3 controller to "PLAYSTATION(R)3
Controller". When you connect the same controller via USB it is set to "Sony
PLAYSTATION(R)3 Controller".

It seems that at least some games fail to recognize the controller as a Dual
Shock 3/sixaxis controller and don't load the default mapping for PlayStation controllers, if the name doesn't contain the Sony part. Also I
don't see a reason to use a different name, when connecting via Bluetooth.

I noticed this with "The Binding of Isaac: Rebirth" and it seems, that Steam
also recognizes the controller better after the patch, although I'm not
confident, if I can parse the controller configuration dialog correctly. I
don't know, if this breaks anything, because it depends on the current
name.

The attached patch changes the device name set when pairing to match the
device name, when connected via USB.

Nicolas Werner

plugins/sixaxis.c line 62

Quoted 8 lines
plugins/sixaxis.c +1 -1
@@ -56,7 +56,7 @@
        uint16_t version;
 } devices[] = {
        {
-               .name = "PLAYSTATION(R)3 Controller",
+               .name = "Sony PLAYSTATION(R)3 Controller",
                .source = 0x0002,
                .vid = 0x054c,
                .pid = 0x0268,

It seems I'm not the only one with this issue as I recently found this issue
(https://bugzilla.kernel.org/show_bug.cgi?id=195225) in the kernel bug
tracker. It looks like dual shock 4 controllers have a similar issue.

Quoted 5 lines

I asked on IRC and someone recommended to ping this message. Again, I would
appreciate some comments on this issue and it would be great if this issue
could be fixed.

Quoted 3 lines

I'm not sure where I took original name from (probably this is how DS3
presents itself over BT).

You took it from commit 7d3d42ac10a6482057101667afd603ce1e79b866

As far as I remember, that was the name used by the device when connecting via Bluetooth and doing reverse SDP.

Quoted 3 lines

Anyway, if this fix the problem I'm fine with changing the name (and patch looks OK). Could you send a proper patch created with 'git format-patch'?

Changing the name is fine, as it won't be visible when doing scans anyway, it'll only appear when the device is already paired.

Quoted 2 lines

As for DS4 this is a bit more trickier since that name is the name device use over BT and we would probably have to spoof it...

There's a thread about adding cable-pairing for those. Look for "Add new DS4 controller PID into special case handler".

Trying the PS button+Share button trick to make it visible over Bluetooth fails on my system, I'm pretty sure it's a trick to re-pair if one of the sides gets out of sync.

I'll probably try to clean that up tomorrow so we can merge it, and send my old "cable pairing" agent code again.

Cheers