Skip to contentSkip to conversation

drm/radeon: ERROR: "foo* bar" should be "foo *bar"

PATCH In review [email protected] 2 participants 2 messages Jul 14, 2023 – Jul 15, 2023 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 drm/radeon: ERROR: "foo* bar" should be "foo *bar"

Fix five occurrences of the checkpatch.pl error:
ERROR: "foo* bar" should be "foo *bar"
ERROR: that open brace { should be on the previous line

---
 drivers/gpu/drm/radeon/radeon_audio.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/gpu/drm/radeon/radeon_audio.c +0 -0
index d6ccaf24ee0c..a010bc2c155c 100644
@@ -35,15 +35,14 @@
 
 void dce6_audio_enable(struct radeon_device *rdev, struct 

r600_audio_pin *pin,

         u8 enable_mask);

-struct r600_audio_pin* r600_audio_get_pin(struct radeon_device *rdev); -struct r600_audio_pin* dce6_audio_get_pin(struct radeon_device *rdev); +struct r600_audio_pin *r600_audio_get_pin(struct radeon_device *rdev); +struct r600_audio_pin *dce6_audio_get_pin(struct radeon_device *rdev);
static void radeon_audio_hdmi_mode_set(struct drm_encoder *encoder,

     struct drm_display_mode *mode);
 static void radeon_audio_dp_mode_set(struct drm_encoder *encoder,
     struct drm_display_mode *mode);

-static const u32 pin_offsets[7] =
-{

+static const u32 pin_offsets[7] = {
     (0x5e00 - 0x5e00),
     (0x5e18 - 0x5e00),
     (0x5e30 - 0x5e00),
@@ -359,7 +358,7 @@ static void radeon_audio_write_latency_fields(struct drm_encoder *encoder,
         radeon_encoder->audio->write_latency_fields(encoder, connector, 

mode);
}

-struct r600_audio_pin* radeon_audio_get_pin(struct drm_encoder *encoder) +struct r600_audio_pin *radeon_audio_get_pin(struct drm_encoder *encoder)

 {
     struct radeon_device *rdev = encoder->dev->dev_private;
     struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
@@ -526,7 +525,7 @@ static void radeon_audio_calc_cts(unsigned int clock, int *CTS, int *N, int freq
         *N, *CTS, freq);

}

-static const struct radeon_hdmi_acr* radeon_audio_acr(unsigned int clock) +static const struct radeon_hdmi_acr *radeon_audio_acr(unsigned int clock)

 {
     static struct radeon_hdmi_acr res;
     u8 i;
Reviewed-by on v1 1/1
#2 lore raw

[Public]

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of [email protected]
Sent: Friday, July 14, 2023 1:36 PM
To: Deucher, Alexander <[email protected]>; Pan, Xinhui <[email protected]>; [email protected]; [email protected]
Cc: [email protected]; [email protected]; [email protected]
Subject: [PATCH] drm/radeon: ERROR: "foo* bar" should be "foo *bar"

Fix five occurrences of the checkpatch.pl error:
ERROR: "foo* bar" should be "foo *bar"
ERROR: that open brace { should be on the previous line

---
  drivers/gpu/drm/radeon/radeon_audio.c | 11 +++++------
  1 file changed, 5 insertions(+), 6 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/radeon/radeon_audio.c
index d6ccaf24ee0c..a010bc2c155c 100644

drivers/gpu/drm/radeon/radeon_audio.c +3 -3
@@ -35,15 +35,14 @@
 
  void dce6_audio_enable(struct radeon_device *rdev, struct r600_audio_pin *pin,
          u8 enable_mask);
-struct r600_audio_pin* r600_audio_get_pin(struct radeon_device *rdev); -struct r600_audio_pin* dce6_audio_get_pin(struct radeon_device *rdev);
+struct r600_audio_pin *r600_audio_get_pin(struct radeon_device *rdev);
+struct r600_audio_pin *dce6_audio_get_pin(struct radeon_device *rdev);
  static void radeon_audio_hdmi_mode_set(struct drm_encoder *encoder,
      struct drm_display_mode *mode);
  static void radeon_audio_dp_mode_set(struct drm_encoder *encoder,
      struct drm_display_mode *mode);
 
-static const u32 pin_offsets[7] =
-{
+static const u32 pin_offsets[7] = {
      (0x5e00 - 0x5e00),
      (0x5e18 - 0x5e00),
      (0x5e30 - 0x5e00),
@@ -359,7 +358,7 @@ static void radeon_audio_write_latency_fields(struct

drm_encoder *encoder,

          radeon_encoder->audio->write_latency_fields(encoder, connector, mode);

}

-struct r600_audio_pin* radeon_audio_get_pin(struct drm_encoder *encoder)
+struct r600_audio_pin *radeon_audio_get_pin(struct drm_encoder *encoder)

  {
      struct radeon_device *rdev = encoder->dev->dev_private;
      struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder); @@ -526,7 +525,7 @@ static void radeon_audio_calc_cts(unsigned int clock, int *CTS, int *N, int freq
          *N, *CTS, freq);

}

-static const struct radeon_hdmi_acr* radeon_audio_acr(unsigned int clock)
+static const struct radeon_hdmi_acr *radeon_audio_acr(unsigned int clock)

  {
      static struct radeon_hdmi_acr res;
      u8 i;