media: docs: vidioc-g-ext-ctrls.rst: Document p_s32 and p_s64 fields
PATCH 1/1 media: docs: vidioc-g-ext-ctrls.rst: Document p_s32 and p_s64 fields
p_s32 and p_s64 were added to the v4l2_ext_control struct, so these should have documentation as well.
--- .../userspace-api/media/v4l/vidioc-g-ext-ctrls.rst | 10 ++++++++++ 1 file changed, 10 insertions(+)
Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst +10 -0
@@ -185,6 +185,16 @@ still cause this situation. - ``p_u32`` - A pointer to a matrix control of unsigned 32-bit values. Valid if this control is of type ``V4L2_CTRL_TYPE_U32``. + * - __u32 * + - ``p_s32`` + - A pointer to a matrix control of signed 32-bit values. Valid if + this control is of type ``V4L2_CTRL_TYPE_INTEGER`` and + ``V4L2_CTRL_FLAG_HAS_PAYLOAD`` is set. + * - __u32 * + - ``p_s64`` + - A pointer to a matrix control of signed 64-bit values. Valid if + this control is of type ``V4L2_CTRL_TYPE_INTEGER64`` and + ``V4L2_CTRL_FLAG_HAS_PAYLOAD`` is set. * - struct :c:type:`v4l2_area` * - ``p_area`` - A pointer to a struct :c:type:`v4l2_area`. Valid if this control is
Signature · 1 line
2.38.4
Hi Daniel,
Quoted 2 lines · Daniel Lundberg Pedersen
p_s32andp_s64were added to thev4l2_ext_controlstruct, so these should have documentation as well.
This patch is missing your Signed-off-by line!
Either repost or reply to this with your Signed-off-by.
It's a nice change, I'd like to merge this!
Regards,
Hans
Quoted 25 lines
--- .../userspace-api/media/v4l/vidioc-g-ext-ctrls.rst | 10 ++++++++++ 1 file changed, 10 insertions(+)Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst +10
-0@@ -185,6 +185,16 @@ still cause this situation. - ``p_u32`` - A pointer to a matrix control of unsigned 32-bit values. Valid if this control is of type ``V4L2_CTRL_TYPE_U32``. + * - __u32 * + - ``p_s32`` + - A pointer to a matrix control of signed 32-bit values. Valid if + this control is of type ``V4L2_CTRL_TYPE_INTEGER`` and + ``V4L2_CTRL_FLAG_HAS_PAYLOAD`` is set. + * - __u32 * + - ``p_s64`` + - A pointer to a matrix control of signed 64-bit values. Valid if + this control is of type ``V4L2_CTRL_TYPE_INTEGER64`` and + ``V4L2_CTRL_FLAG_HAS_PAYLOAD`` is set. * - struct :c:type:`v4l2_area` * - ``p_area`` - A pointer to a struct :c:type:`v4l2_area`. Valid if this control is
Quoted 9 lines · Hans Verkuil
Hi Daniel,
Quoted 2 lines · Daniel Lundberg Pedersen
p_s32andp_s64were added to thev4l2_ext_controlstruct, so these should have documentation as well.This patch is missing your Signed-off-by line!
Either repost or reply to this with your Signed-off-by.
Sorry about that. Hope this is good enough.
Regards Daniel
Quoted 33 lines
It's a nice change, I'd like to merge this!
Regards,
Hans
Quoted 25 lines
--- .../userspace-api/media/v4l/vidioc-g-ext-ctrls.rst | 10 ++++++++++ 1 file changed, 10 insertions(+)Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst +10
-0@@ -185,6 +185,16 @@ still cause this situation. - ``p_u32`` - A pointer to a matrix control of unsigned 32-bit values. Valid if this control is of type ``V4L2_CTRL_TYPE_U32``. + * - __u32 * + - ``p_s32`` + - A pointer to a matrix control of signed 32-bit values. Valid if + this control is of type ``V4L2_CTRL_TYPE_INTEGER`` and + ``V4L2_CTRL_FLAG_HAS_PAYLOAD`` is set. + * - __u32 * + - ``p_s64`` + - A pointer to a matrix control of signed 64-bit values. Valid if + this control is of type ``V4L2_CTRL_TYPE_INTEGER64`` and + ``V4L2_CTRL_FLAG_HAS_PAYLOAD`` is set. * - struct :c:type:`v4l2_area` * - ``p_area`` - A pointer to a struct :c:type:`v4l2_area`. Valid if this control is